[PATCH] scsi: pm8001: Initialize devices in pm8001_alloc_dev()

[PATCH] scsi: pm8001: Initialize devices in pm8001_alloc_dev()

[TJ Adams]

From: Igor Pylypiv <ipylypiv@google.com>

Devices can be allocated and freed at runtime. For example during
a soft reset all devices are freed and reallocated upon discovery.

Currently driver fully initializes devices once in pm8001_alloc().
This commit allows initialization steps to happen during runtime,
avoiding any leftover states from the device being freed.

Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
Signed-off-by: Terrence Adams <tadamsjr@google.com>
---
 drivers/scsi/pm8001/pm8001_init.c |  3 ---
 drivers/scsi/pm8001/pm8001_sas.c  | 17 ++++++++++++-----
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 33e1eba62ca1..ab961ab3224a 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -447,9 +447,6 @@ static int pm8001_alloc(struct pm8001_hba_info *pm8001_ha,
 	}
 	for (i = 0; i < PM8001_MAX_DEVICES; i++) {
 		pm8001_ha->devices[i].dev_type = SAS_PHY_UNUSED;
-		pm8001_ha->devices[i].id = i;
-		pm8001_ha->devices[i].device_id = PM8001_MAX_DEVICES;
-		atomic_set(&pm8001_ha->devices[i].running_req, 0);
 	}
 	pm8001_ha->flags = PM8001F_INIT_TIME;
 	return 0;
diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
index ee2da8e49d4c..d80cffd25a6e 100644
--- a/drivers/scsi/pm8001/pm8001_sas.c
+++ b/drivers/scsi/pm8001/pm8001_sas.c
@@ -572,6 +572,13 @@ void pm8001_ccb_task_free(struct pm8001_hba_info *pm8001_ha,
 	pm8001_ccb_free(pm8001_ha, ccb);
 }
 
+static void pm8001_init_dev(struct pm8001_device *pm8001_dev, int id)
+{
+	pm8001_dev->id = id;
+	pm8001_dev->device_id = PM8001_MAX_DEVICES;
+	atomic_set(&pm8001_dev->running_req, 0);
+}
+
 /**
  * pm8001_alloc_dev - find a empty pm8001_device
  * @pm8001_ha: our hba card information
@@ -580,9 +587,11 @@ static struct pm8001_device *pm8001_alloc_dev(struct pm8001_hba_info *pm8001_ha)
 {
 	u32 dev;
 	for (dev = 0; dev < PM8001_MAX_DEVICES; dev++) {
-		if (pm8001_ha->devices[dev].dev_type == SAS_PHY_UNUSED) {
-			pm8001_ha->devices[dev].id = dev;
-			return &pm8001_ha->devices[dev];
+		struct pm8001_device *pm8001_dev = &pm8001_ha->devices[dev];
+
+		if (pm8001_dev->dev_type == SAS_PHY_UNUSED) {
+			pm8001_init_dev(pm8001_dev, dev);
+			return pm8001_dev;
 		}
 	}
 	if (dev == PM8001_MAX_DEVICES) {
@@ -613,9 +622,7 @@ struct pm8001_device *pm8001_find_dev(struct pm8001_hba_info *pm8001_ha,
 
 void pm8001_free_dev(struct pm8001_device *pm8001_dev)
 {
-	u32 id = pm8001_dev->id;
 	memset(pm8001_dev, 0, sizeof(*pm8001_dev));
-	pm8001_dev->id = id;
 	pm8001_dev->dev_type = SAS_PHY_UNUSED;
 	pm8001_dev->device_id = PM8001_MAX_DEVICES;
 	pm8001_dev->sas_device = NULL;
-- 
2.47.0.105.g07ac214952-goog

Re: [PATCH] scsi: pm8001: Initialize devices in pm8001_alloc_dev()

[Martin K. Petersen]

TJ,

> Devices can be allocated and freed at runtime. For example during a
> soft reset all devices are freed and reallocated upon discovery.
>
> Currently driver fully initializes devices once in pm8001_alloc().
> This commit allows initialization steps to happen during runtime,
> avoiding any leftover states from the device being freed.

Applied to 6.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: pm8001: Initialize devices in pm8001_alloc_dev()

[Martin K. Petersen]

On Mon, 21 Oct 2024 13:18:28 -0700, TJ Adams wrote:

> Devices can be allocated and freed at runtime. For example during
> a soft reset all devices are freed and reallocated upon discovery.
> 
> Currently driver fully initializes devices once in pm8001_alloc().
> This commit allows initialization steps to happen during runtime,
> avoiding any leftover states from the device being freed.
> 
> [...]

Applied to 6.13/scsi-queue, thanks!

[1/1] scsi: pm8001: Initialize devices in pm8001_alloc_dev()
      https://git.kernel.org/mkp/scsi/c/4501ea5f0a5c

-- 
Martin K. Petersen	Oracle Linux Engineering