* [PATCH] scsi: lpfc: silence an incorrect device output
@ 2023-04-10 2:37 Jun Chen
2023-04-11 21:31 ` Justin Tee
2023-04-12 1:23 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jun Chen @ 2023-04-10 2:37 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E.J. Bottomley, Martin K. Petersen
Cc: Jun Chen, Dongliang Mu, linux-scsi, linux-kernel
In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have a
break statement, resulting in an incorrect device output.
Fix this by adding a break statement before the default option.
Signed-off-by: Jun Chen <jun_c@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
drivers/scsi/lpfc/lpfc_init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index d062220d3232..da3a45441639 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -12105,6 +12105,7 @@ lpfc_sli4_pci_mem_unset(struct lpfc_hba *phba)
iounmap(phba->sli4_hba.dpp_regs_memmap_p);
break;
case LPFC_SLI_INTF_IF_TYPE_1:
+ break;
default:
dev_printk(KERN_ERR, &phba->pcidev->dev,
"FATAL - unsupported SLI4 interface type - %d\n",
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: lpfc: silence an incorrect device output
2023-04-10 2:37 [PATCH] scsi: lpfc: silence an incorrect device output Jun Chen
@ 2023-04-11 21:31 ` Justin Tee
2023-04-12 1:23 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Justin Tee @ 2023-04-11 21:31 UTC (permalink / raw)
To: Jun Chen
Cc: James Smart, Dick Kennedy, Justin Tee, James E.J. Bottomley,
Martin K. Petersen, Dongliang Mu, linux-scsi, linux-kernel
Hi Jun,
Broadcom no longer supports LPFC_SLI_INTF_IF_TYPE_1 adapters, but the
patch looks fine.
Reviewed-by: Justin Tee <justin.tee@broadcom.com>
Thanks,
Justin
On Sun, Apr 9, 2023 at 8:14 PM Jun Chen <jun_c@hust.edu.cn> wrote:
>
> In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have a
> break statement, resulting in an incorrect device output.
>
> Fix this by adding a break statement before the default option.
>
> Signed-off-by: Jun Chen <jun_c@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index d062220d3232..da3a45441639 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -12105,6 +12105,7 @@ lpfc_sli4_pci_mem_unset(struct lpfc_hba *phba)
> iounmap(phba->sli4_hba.dpp_regs_memmap_p);
> break;
> case LPFC_SLI_INTF_IF_TYPE_1:
> + break;
> default:
> dev_printk(KERN_ERR, &phba->pcidev->dev,
> "FATAL - unsupported SLI4 interface type - %d\n",
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: lpfc: silence an incorrect device output
2023-04-10 2:37 [PATCH] scsi: lpfc: silence an incorrect device output Jun Chen
2023-04-11 21:31 ` Justin Tee
@ 2023-04-12 1:23 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-04-12 1:23 UTC (permalink / raw)
To: Jun Chen
Cc: James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, Dongliang Mu, linux-scsi, linux-kernel
Jun,
> In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have
> a break statement, resulting in an incorrect device output.
Applied to 6.4/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 1:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-10 2:37 [PATCH] scsi: lpfc: silence an incorrect device output Jun Chen
2023-04-11 21:31 ` Justin Tee
2023-04-12 1:23 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®