* [PATCH] scsi: elx: efct: Remove redundant memset statement
@ 2022-05-05 14:36 Harshit Mogalapalli
2022-05-17 2:13 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Harshit Mogalapalli @ 2022-05-05 14:36 UTC (permalink / raw)
Cc: harshit.m.mogalapalli, dan.carpenter, James Smart, Ram Vegesna,
James E.J. Bottomley, Martin K. Petersen, Daniel Wagner,
Hannes Reinecke, Nathan Chancellor, Wei Yongjun, linux-scsi,
target-devel, linux-kernel
As memset of 'bmbx' is immediately followed by a memcpy where 'bmbx'
is the destination, memset is redundant.
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
drivers/scsi/elx/efct/efct_hw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/elx/efct/efct_hw.c b/drivers/scsi/elx/efct/efct_hw.c
index d4bb37960a3c..5a5525054d71 100644
--- a/drivers/scsi/elx/efct/efct_hw.c
+++ b/drivers/scsi/elx/efct/efct_hw.c
@@ -1402,7 +1402,6 @@ efct_hw_command(struct efct_hw *hw, u8 *cmd, u32 opts, void *cb, void *arg)
mutex_lock(&hw->bmbx_lock);
bmbx = hw->sli.bmbx.virt;
- memset(bmbx, 0, SLI4_BMBX_SIZE);
memcpy(bmbx, cmd, SLI4_BMBX_SIZE);
if (sli_bmbx_command(&hw->sli) == 0) {
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: elx: efct: Remove redundant memset statement
2022-05-05 14:36 [PATCH] scsi: elx: efct: Remove redundant memset statement Harshit Mogalapalli
@ 2022-05-17 2:13 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-05-17 2:13 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: dan.carpenter, James Smart, Ram Vegesna, James E.J. Bottomley,
Martin K. Petersen, Daniel Wagner, Hannes Reinecke,
Nathan Chancellor, Wei Yongjun, linux-scsi, target-devel,
linux-kernel
Harshit,
> As memset of 'bmbx' is immediately followed by a memcpy where 'bmbx'
> is the destination, memset is redundant.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: elx: efct: Remove redundant memset statement
2022-05-05 14:36 [PATCH] scsi: elx: efct: Remove redundant memset statement Harshit Mogalapalli
2022-05-17 2:13 ` Martin K. Petersen
@ 2022-05-20 1:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-05-20 1:09 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: Martin K . Petersen, linux-scsi, Daniel Wagner,
James E.J. Bottomley, linux-kernel, Ram Vegesna, James Smart,
Hannes Reinecke, Nathan Chancellor, Wei Yongjun, target-devel,
dan.carpenter
On Thu, 5 May 2022 07:36:57 -0700, Harshit Mogalapalli wrote:
> As memset of 'bmbx' is immediately followed by a memcpy where 'bmbx'
> is the destination, memset is redundant.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: elx: efct: Remove redundant memset statement
https://git.kernel.org/mkp/scsi/c/e79aaa9cc02d
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-20 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 14:36 [PATCH] scsi: elx: efct: Remove redundant memset statement Harshit Mogalapalli
2022-05-17 2:13 ` Martin K. Petersen
2022-05-20 1:09 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®