* [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081
@ 2015-01-06 11:54 Sreekanth Reddy
2015-01-07 0:07 ` Martin K. Petersen
0 siblings, 1 reply; 7+ messages in thread
From: Sreekanth Reddy @ 2015-01-06 11:54 UTC (permalink / raw)
To: jejb, hch
Cc: martin.petersen, linux-scsi, JBottomley, Sathya.Prakash,
Nagalakshmi.Nandigama, linux-kernel, Sreekanth Reddy
For any SCSI command, if the driver receives IOC status = SCSI_IOC_TERMINATED and log info = 0x32010081
then that command will be completed with DID_RESET host status.
The definition of this log info value is "Virtual IO has failed and has to be retried".
Firmware will provide this log info value with IOC Status
"SCSI_IOC_TERMINATED", whenever a drive (with is a part of a volume)
is pulled and pushed back within some minimal delay. With this log info
value, firmware informs the driver to retry the failed IO command
infinite times, so to provide some time for the firmware to discover
the reinserted drive successfully instated of just retrying failed
command for five times( doesn't giving enough time for firmware to
complete the drive discovery) and failing the IO permanently even
though drive came back successfully.
Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
---
drivers/scsi/mpt2sas/mpt2sas_scsih.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
index 38acb91..c6bb136 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
@@ -4574,6 +4574,10 @@ _scsih_io_done(struct MPT2SAS_ADAPTER *ioc, u16 smid, u8 msix_index, u32 reply)
scmd->result = DID_TRANSPORT_DISRUPTED << 16;
goto out;
}
+ if (log_info == 0x32010081) {
+ scmd->result = DID_RESET << 16;
+ break;
+ }
scmd->result = DID_SOFT_ERROR << 16;
break;
case MPI2_IOCSTATUS_SCSI_TASK_TERMINATED:
--
2.0.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 00/22] mpt2sas, mpt3sas: SAS2 Phase 19,20 and SAS3 Phase 4,5 patches
@ 2014-11-20 7:05 Sreekanth Reddy
2014-11-20 7:05 ` [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081 Sreekanth Reddy
0 siblings, 1 reply; 7+ messages in thread
From: Sreekanth Reddy @ 2014-11-20 7:05 UTC (permalink / raw)
To: jejb, hch
Cc: martin.petersen, linux-scsi, JBottomley, Sathya.Prakash,
Nagalakshmi.Nandigama, linux-kernel, Sreekanth Reddy
Please consider this Patch set for next kernel release.
Highlights of this patch set:
- 96 MSIX vector support for SAS3 HBA's,
- Log Temperature threshold exceeds message for any temperature sensor,
- Updating the copy right information,
- Provide physical location of target drives by printing Enclosure level,
Enclosure address, Slot number etc,
- Displaying OEM's HBA branding String,
- MPI file's update,
- Some driver fixes.
Sreekanth Reddy (22):
[SCSI] mpt2sas: MPI2 Rev AA (2.00.19) specifications
[SCSI] mpt2sas, mpt3sas: Added support to log message when Temperature
Threshold exceeds for any Sensor
mpt2sas, mpt3sas: Fail the host reset initiated due to discovery
related I/O timeouts at driver load time
[SCSI] mpt2sas: Bump driver version to 19.100.00.00
[SCSI] mpt2sas: MPI2 Rev BB (2.00.20) specification and 2.00.35 header
files
[SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the
module parameter max_sgl_entries
[SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for
log_info value 0x0x32010081
[SCSI] mpt2sas, mpt3sas: Update Attribution Language to Avago
[SCSI] mpt2sas, mpt3sas: Added a support to set cpu affinity for each
MSIX vector enabled by the HBA
[SCSI] mpt2sas: Bump driver version to 20.100.00.00
[SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96
MSIX vector support
mpt3sas: Get IOC_FACTS information using handshake protocol only after
HBA card gets into READY or Operational state.
[SCSI] mpt3sas: Added module parameter 'unblock_io' to unblock IO's
during disk addition
[SCSI] mpt2sas, mpt3sas: Remove redundancy code while freeing the
controller resources.
[SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.
[SCSI] mpt3sas: Provides the physical location of sas drives
[SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00
[SCSI] mpt3sas: Update MPI2 strings to MPI2.5
[SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header
files
[SCSI] mpt3sas: Add branding string support for OEM's HBA
mpt3sas: Add branding string support for OEM custom HBA
[SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00
drivers/scsi/mpt2sas/mpi/mpi2.h | 7 +-
drivers/scsi/mpt2sas/mpi/mpi2_cnfg.h | 51 ++++-
drivers/scsi/mpt2sas/mpi/mpi2_ioc.h | 4 +-
drivers/scsi/mpt2sas/mpi/mpi2_tool.h | 6 +-
drivers/scsi/mpt2sas/mpt2sas_base.c | 79 +++++--
drivers/scsi/mpt2sas/mpt2sas_base.h | 15 +-
drivers/scsi/mpt2sas/mpt2sas_config.c | 39 +++-
drivers/scsi/mpt2sas/mpt2sas_ctl.c | 3 +-
drivers/scsi/mpt2sas/mpt2sas_ctl.h | 3 +-
drivers/scsi/mpt2sas/mpt2sas_debug.h | 3 +-
drivers/scsi/mpt2sas/mpt2sas_scsih.c | 47 +++-
drivers/scsi/mpt2sas/mpt2sas_transport.c | 3 +-
drivers/scsi/mpt3sas/mpi/mpi2.h | 7 +-
drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 39 +++-
drivers/scsi/mpt3sas/mpi/mpi2_ioc.h | 4 +-
drivers/scsi/mpt3sas/mpi/mpi2_tool.h | 4 +-
drivers/scsi/mpt3sas/mpt3sas_base.c | 282 ++++++++++++++++++++---
drivers/scsi/mpt3sas/mpt3sas_base.h | 51 ++++-
drivers/scsi/mpt3sas/mpt3sas_config.c | 39 +++-
drivers/scsi/mpt3sas/mpt3sas_ctl.c | 3 +-
drivers/scsi/mpt3sas/mpt3sas_ctl.h | 3 +-
drivers/scsi/mpt3sas/mpt3sas_debug.h | 3 +-
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 343 ++++++++++++++++++++++++----
drivers/scsi/mpt3sas/mpt3sas_transport.c | 17 +-
drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c | 3 +-
drivers/scsi/mpt3sas/mpt3sas_trigger_diag.h | 3 +-
26 files changed, 913 insertions(+), 148 deletions(-)
--
2.0.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081
2014-11-20 7:05 [PATCH 00/22] mpt2sas, mpt3sas: SAS2 Phase 19,20 and SAS3 Phase 4,5 patches Sreekanth Reddy
@ 2014-11-20 7:05 ` Sreekanth Reddy
2014-12-04 3:06 ` Martin K. Petersen
0 siblings, 1 reply; 7+ messages in thread
From: Sreekanth Reddy @ 2014-11-20 7:05 UTC (permalink / raw)
To: jejb, hch
Cc: martin.petersen, linux-scsi, JBottomley, Sathya.Prakash,
Nagalakshmi.Nandigama, linux-kernel, Sreekanth Reddy
For any SCSI command, if the driver receives IOC status = SCSI_IOC_TERMINATED and log info = 0x32010081
then that command will be completed with DID_RESET host status.
Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
---
drivers/scsi/mpt2sas/mpt2sas_scsih.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
index 38acb91..c6bb136 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
@@ -4574,6 +4574,10 @@ _scsih_io_done(struct MPT2SAS_ADAPTER *ioc, u16 smid, u8 msix_index, u32 reply)
scmd->result = DID_TRANSPORT_DISRUPTED << 16;
goto out;
}
+ if (log_info == 0x32010081) {
+ scmd->result = DID_RESET << 16;
+ break;
+ }
scmd->result = DID_SOFT_ERROR << 16;
break;
case MPI2_IOCSTATUS_SCSI_TASK_TERMINATED:
--
2.0.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081
2014-11-20 7:05 ` [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081 Sreekanth Reddy
@ 2014-12-04 3:06 ` Martin K. Petersen
2014-12-09 12:08 ` Sreekanth Reddy
0 siblings, 1 reply; 7+ messages in thread
From: Martin K. Petersen @ 2014-12-04 3:06 UTC (permalink / raw)
To: Sreekanth Reddy
Cc: jejb, hch, martin.petersen, linux-scsi, JBottomley,
Sathya.Prakash, Nagalakshmi.Nandigama, linux-kernel
>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.reddy@avagotech.com> writes:
Sreekanth> For any SCSI command, if the driver receives IOC status =
Sreekanth> SCSI_IOC_TERMINATED and log info = 0x32010081 then that
Sreekanth> command will be completed with DID_RESET host status.
What does that log info value mean?
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081
2014-12-04 3:06 ` Martin K. Petersen
@ 2014-12-09 12:08 ` Sreekanth Reddy
2014-12-10 20:40 ` Martin K. Petersen
0 siblings, 1 reply; 7+ messages in thread
From: Sreekanth Reddy @ 2014-12-09 12:08 UTC (permalink / raw)
To: Martin K. Petersen
Cc: jejb, Christoph Hellwig, linux-scsi, James E.J. Bottomley,
Sathya Prakash, Nagalakshmi Nandigama, linux-kernel
On Thu, Dec 4, 2014 at 8:36 AM, Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.reddy@avagotech.com> writes:
>
> Sreekanth> For any SCSI command, if the driver receives IOC status =
> Sreekanth> SCSI_IOC_TERMINATED and log info = 0x32010081 then that
> Sreekanth> command will be completed with DID_RESET host status.
>
> What does that log info value mean?
The meaning of this log info value is "Virtual IO has failed and has
to be retried".
Firmware will provide this log info value with IOC Status
"SCSI_IOC_TERMINATED", whenever a drive (with is a part of a volume)
is pulled and pushed back with some minimal delay. With this log info
value, firmware informs the driver to retry the failed IO command
infinite times, so to provide some time for the firmware to discover
the reinserted drive successfully instated of just retrying failed
command for five times( doesn't giving enough time for firmware to
complete the drive discovery) and failing the IO permanently even
though drive came back successfully.
Regards,
Sreekanth.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081
2014-12-09 12:08 ` Sreekanth Reddy
@ 2014-12-10 20:40 ` Martin K. Petersen
2014-12-11 12:18 ` Sreekanth Reddy
0 siblings, 1 reply; 7+ messages in thread
From: Martin K. Petersen @ 2014-12-10 20:40 UTC (permalink / raw)
To: Sreekanth Reddy
Cc: Martin K. Petersen, jejb, Christoph Hellwig, linux-scsi,
James E.J. Bottomley, Sathya Prakash, Nagalakshmi Nandigama,
linux-kernel
>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.reddy@avagotech.com> writes:
Sreekanth> For any SCSI command, if the driver receives IOC status =
Sreekanth> SCSI_IOC_TERMINATED and log info = 0x32010081 then that
Sreekanth> command will be completed with DID_RESET host status.
>>
>> What does that log info value mean?
Sreekanth> The meaning of this log info value is "Virtual IO has failed
Sreekanth> and has to be retried".
OK, I'd prefer to see that documented in the patch.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081
2014-12-10 20:40 ` Martin K. Petersen
@ 2014-12-11 12:18 ` Sreekanth Reddy
0 siblings, 0 replies; 7+ messages in thread
From: Sreekanth Reddy @ 2014-12-11 12:18 UTC (permalink / raw)
To: Martin K. Petersen
Cc: jejb, Christoph Hellwig, linux-scsi, James E.J. Bottomley,
Sathya Prakash, Nagalakshmi Nandigama, linux-kernel
> Sreekanth> For any SCSI command, if the driver receives IOC status =
> Sreekanth> SCSI_IOC_TERMINATED and log info = 0x32010081 then that
> Sreekanth> command will be completed with DID_RESET host status.
>>>
>>> What does that log info value mean?
>
> Sreekanth> The meaning of this log info value is "Virtual IO has failed
> Sreekanth> and has to be retried".
>
> OK, I'd prefer to see that documented in the patch.
Ok sure Martin, I will add this description in the next version of
this patch once review completes on this patch set.
Thanks,
Sreekanth
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-07 0:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-06 11:54 [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081 Sreekanth Reddy
2015-01-07 0:07 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2014-11-20 7:05 [PATCH 00/22] mpt2sas, mpt3sas: SAS2 Phase 19,20 and SAS3 Phase 4,5 patches Sreekanth Reddy
2014-11-20 7:05 ` [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081 Sreekanth Reddy
2014-12-04 3:06 ` Martin K. Petersen
2014-12-09 12:08 ` Sreekanth Reddy
2014-12-10 20:40 ` Martin K. Petersen
2014-12-11 12:18 ` Sreekanth Reddy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®