* [PATCH] scsi: target: tcmu: add a missing newline when printing parameters
@ 2020-09-03 11:29 Xiongfeng Wang
2020-09-16 0:19 ` Martin K. Petersen
2020-09-22 3:56 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Xiongfeng Wang @ 2020-09-03 11:29 UTC (permalink / raw)
To: martin.petersen; +Cc: linux-scsi, target-devel, linux-kernel, wangxiongfeng2
When I cat module paramter 'global_max_data_area_mb' by sysfs, it
displays as follows. It's better to add a newline for easy reading.
root@(none):/# cat /sys/module/target_core_user/parameters/global_max_data_area_mb
2048noneroot@(none):/#
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
drivers/target/target_core_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 9b75923..9775670 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -242,7 +242,7 @@ static int tcmu_set_global_max_data_area(const char *str,
static int tcmu_get_global_max_data_area(char *buffer,
const struct kernel_param *kp)
{
- return sprintf(buffer, "%d", TCMU_BLOCKS_TO_MBS(tcmu_global_max_blocks));
+ return sprintf(buffer, "%d\n", TCMU_BLOCKS_TO_MBS(tcmu_global_max_blocks));
}
static const struct kernel_param_ops tcmu_global_max_data_area_op = {
--
1.7.12.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: target: tcmu: add a missing newline when printing parameters
2020-09-03 11:29 [PATCH] scsi: target: tcmu: add a missing newline when printing parameters Xiongfeng Wang
@ 2020-09-16 0:19 ` Martin K. Petersen
2020-09-22 3:56 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-16 0:19 UTC (permalink / raw)
To: Xiongfeng Wang; +Cc: martin.petersen, linux-scsi, target-devel, linux-kernel
Xiongfeng,
> When I cat module paramter 'global_max_data_area_mb' by sysfs, it
> displays as follows. It's better to add a newline for easy reading.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: target: tcmu: add a missing newline when printing parameters
2020-09-03 11:29 [PATCH] scsi: target: tcmu: add a missing newline when printing parameters Xiongfeng Wang
2020-09-16 0:19 ` Martin K. Petersen
@ 2020-09-22 3:56 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-22 3:56 UTC (permalink / raw)
To: Xiongfeng Wang
Cc: Martin K . Petersen, linux-scsi, target-devel, linux-kernel
On Thu, 3 Sep 2020 19:29:33 +0800, Xiongfeng Wang wrote:
> When I cat module paramter 'global_max_data_area_mb' by sysfs, it
> displays as follows. It's better to add a newline for easy reading.
>
> root@(none):/# cat /sys/module/target_core_user/parameters/global_max_data_area_mb
> 2048noneroot@(none):/#
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: target: tcmu: Add missing newline when printing parameters
https://git.kernel.org/mkp/scsi/c/6d70cb343484
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-22 3:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 11:29 [PATCH] scsi: target: tcmu: add a missing newline when printing parameters Xiongfeng Wang
2020-09-16 0:19 ` Martin K. Petersen
2020-09-22 3:56 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®