Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors

["Måns Rullgård" <mans@mansr.com>]

"Shevchenko, Andriy" <andriy.shevchenko@intel.com> writes:

> On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote:
>> On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
>> > This patch fixes whitespace errors reported by checkpatch to
>> > increase
>> > readability. Main focus is on missing spaces after commas in
>> > function headers and macros (like foo,bar edited to foo, bar).
>> > 
>> > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
>> > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
>> > CC: linux-kernel@i4.cs.fau.de
>> 
>> Cc: looks more standard.
>> 
>> > --- a/drivers/tty/serial/8250/8250_accent.c
>> > +++ b/drivers/tty/serial/8250/8250_accent.c
>> > @@ -10,7 +10,7 @@
>> >  #include <linux/init.h>
>> >  #include <linux/serial_8250.h>
>> >  
>> > -#define PORT(_base,_irq)				\
>> > +#define PORT(_base, _irq)				\
>> >  	{						\
>> >  		.iobase		= _base,		\
>> >  		.irq		= _irq,			
>> > \
>
> 8250_PORT()
>
>> > 
>> 
>> While those are okay, I would suggest to make a macro in
>> drivers/…/8250.h one for all, something like this:
>> 
>> #define 8250_PORT_FLAGS(_base, _irq, _flags)
>> …
>> 	.flags          = UPF_BOOT_AUTOCONF | (_flags) \
>> 
>> #define 8250_PORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq, 0)
>> 
>> And use it.
>
> #define 8250_FOURPORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq,
> UPF_FOURPORT)

Macro names can't start with a number.

-- 
Måns Rullgård