From: "Måns Rullgård" <mans@mansr.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Cyrille Pitchen <cyrille.pitchen@atmel.com>, "Yang\,
Wenyou" <Wenyou.Yang@atmel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice
Date: Mon, 11 Jan 2016 16:16:31 +0000 [thread overview]
Message-ID: <yw1xd1t8w0ps.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <20160111161333.GK6588@sirena.org.uk> (Mark Brown's message of "Mon, 11 Jan 2016 16:13:33 +0000")
Mark Brown <broonie@kernel.org> writes:
> On Mon, Jan 11, 2016 at 04:01:42PM +0000, Mans Rullgard wrote:
>> The driver currently chooses between internal chip-select or gpio
>> based on the existence of the cs-gpios DT property which fails on
>> non-DT systems and also enforces the same choice for all devices.
>
> Normally you shouldn't send incremental patches against patches that
> have already been applied.
Should or shouldn't?
> However in this case I'm going to drop your original patch anyway due
> to the issue that was found so it's OK.
Sorry, I hadn't noticed it was already applied. Too many trees to keep
track of.
--
Måns Rullgård
next prev parent reply other threads:[~2016-01-11 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 16:01 Mans Rullgard
2016-01-11 16:13 ` Mark Brown
2016-01-11 16:16 ` Måns Rullgård [this message]
2016-01-11 16:24 ` Mark Brown
2016-01-12 8:39 ` Cyrille Pitchen
2016-01-12 8:51 ` Måns Rullgård
2016-01-12 8:52 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xd1t8w0ps.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=Wenyou.Yang@atmel.com \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®