mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: martin.blumenstingl@googlemail.com (Martin Blumenstingl)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support
Date: Sun, 22 Jan 2017 19:10:26 +0100	[thread overview]
Message-ID: <20170122181028.5014-8-martin.blumenstingl@googlemail.com> (raw)
In-Reply-To: <20170122181028.5014-1-martin.blumenstingl@googlemail.com>

Amlogic's own .dts specifies that the P201 board uses a RMII PHY (with
the reset GPIO being GPIOZ_14).
However our P201 board .dts simply inherits the phy-mode setting from
from meson-gx.dtsi where it defaults to RGMII mode.
Remove all ethernet settings from meson-gxbb-p20x.dtsi as it only
specifies the RGMII pins which are only valid for the P200 board.
Instead we add the ethmac node to the meson-gxbb-p201.dts and configure
the pinctrl property and the phy-mode for an RMII PHY.

An MDIO node (which would also specify the PHY) is not added since we
don't know which PHY is being used (and thus which PHY address would
have to be used).

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts  | 11 +++++++++++
 arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi |  6 ------
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
index 39bb037a3e47..ae3194663d64 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dts
@@ -50,3 +50,14 @@
 	compatible = "amlogic,p201", "amlogic,meson-gxbb";
 	model = "Amlogic Meson GXBB P201 Development Board";
 };
+
+&ethmac {
+	status = "okay";
+	pinctrl-0 = <&eth_rmii_pins>;
+	pinctrl-names = "default";
+	phy-mode = "rmii";
+
+	snps,reset-gpio = <&gpio GPIOZ_14 0>;
+	snps,reset-delays-us = <0 10000 1000000>;
+	snps,reset-active-low;
+};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
index b6f9d051439c..f10e532557b1 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
@@ -143,12 +143,6 @@
 	};
 };
 
-&ethmac {
-	status = "okay";
-	pinctrl-0 = <&eth_rgmii_pins>;
-	pinctrl-names = "default";
-};
-
 &ir {
 	status = "okay";
 	pinctrl-0 = <&remote_input_ao_pins>;
-- 
2.11.0

  parent reply	other threads:[~2017-01-22 18:10 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 23:47 [PATCH 0/5] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 1/5] ARM64: dts: meson-gx: move the MDIO node to meson-gx Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 2/5] ARM64: dts: meson-gxbb-odroidc2: add reset for the ethernet PHY Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 3/5] ARM64: dts: meson-gxbb-p20x: " Martin Blumenstingl
2017-01-17 19:22   ` Jerome Brunet
2017-01-17 21:26     ` Martin Blumenstingl
2017-01-18 10:36       ` Jerome Brunet
2017-01-18 14:26         ` Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 4/5] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 5/5] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2016-12-17 20:36 ` [PATCH 0/5] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
2017-01-09 22:52   ` Kevin Hilman
2017-01-17 19:23 ` Jerome Brunet
2017-01-17 21:09   ` Martin Blumenstingl
2017-01-17 22:26     ` Jerome Brunet
2017-01-17 22:44       ` Martin Blumenstingl
2017-01-18 19:28 ` Kevin Hilman
2017-01-18 19:40   ` Martin Blumenstingl
2017-01-19  9:47     ` Jerome Brunet
2017-01-20 13:26 ` [PATCH v2 0/9] " Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 2/9] ARM64: dts: meson-gxbb-p201: " Martin Blumenstingl
2017-01-20 13:31     ` Neil Armstrong
2017-01-20 13:33       ` Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 7/9] ARM64: dts: meson-gxbb-p20x: remove the ethernet node Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2017-01-20 13:26   ` [PATCH v2 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-01-20 15:22   ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
2017-01-20 15:22     ` [PATCH v3 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-01-20 16:23       ` Neil Armstrong
2017-01-20 15:22     ` [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
2017-01-20 16:18       ` Andrew Lunn
2017-01-20 16:21       ` Andrew Lunn
2017-01-20 17:07         ` Martin Blumenstingl
2017-01-20 17:46           ` Andrew Lunn
2017-01-22 16:48             ` Martin Blumenstingl
2017-01-20 16:23       ` Neil Armstrong
2017-01-20 15:22     ` [PATCH v3 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2017-01-20 15:22     ` [PATCH v3 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
2017-01-20 16:23       ` Neil Armstrong
2017-01-20 15:22     ` [PATCH v3 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
2017-01-20 15:22     ` [PATCH v3 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
2017-01-20 16:23       ` Neil Armstrong
2017-01-20 15:22     ` [PATCH v3 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
2017-01-20 15:22     ` [PATCH v3 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2017-01-20 16:34       ` Neil Armstrong
2017-01-20 15:22     ` [PATCH v3 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-01-20 15:27     ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
2017-01-20 15:32     ` Martin Blumenstingl
2017-01-20 19:46       ` Kevin Hilman
2017-01-22 18:10     ` [PATCH v4 " Martin Blumenstingl
2017-01-22 18:10       ` [PATCH v4 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-01-22 18:10       ` [PATCH v4 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
2017-01-22 18:10       ` [PATCH v4 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2017-01-22 18:10       ` [PATCH v4 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
2017-01-22 18:10       ` [PATCH v4 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
2017-01-22 18:10       ` [PATCH v4 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
2017-01-22 18:10       ` Martin Blumenstingl [this message]
2017-01-22 18:10       ` [PATCH v4 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2017-01-22 18:10       ` [PATCH v4 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-01-23 18:55       ` [PATCH v4 0/9] meson-gx: reset RGMII PHYs and configure TX delay Kevin Hilman
2017-01-23 19:02         ` Martin Blumenstingl
2017-02-19 21:41       ` [PATCH v5 " Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2017-02-19 21:41         ` [PATCH v5 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-02-20  9:08         ` [PATCH v5 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
2017-03-02 17:02           ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170122181028.5014-8-martin.blumenstingl@googlemail.com \
    --to=martin.blumenstingl@googlemail.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®