mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Alexey Romanov <avromanov@salutedevices.com>
To: <narmstrong@baylibre.com>, <neil.armstrong@linaro.org>,
	<clabbe@baylibre.com>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<khilman@baylibre.com>, <jbrunet@baylibre.com>,
	<artin.blumenstingl@googlemail.com>
Cc: <linux-crypto@vger.kernel.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<kernel@salutedevices.com>,
	Jan Dakinevich <yvdakinevich@salutedevices.com>,
	Alexey Romanov <avromanov@salutedevices.com>
Subject: [PATCH v1 12/24] drivers: crypto: meson: add support for AES-CTR
Date: Wed, 10 Jan 2024 23:11:28 +0300	[thread overview]
Message-ID: <20240110201216.18016-13-avromanov@salutedevices.com> (raw)
In-Reply-To: <20240110201216.18016-1-avromanov@salutedevices.com>

From: Jan Dakinevich <yvdakinevich@salutedevices.com>

This patch adds support for AES-CTR algorithm.
Tested via tcrypt and custom tests.

Signed-off-by: Jan Dakinevich <yvdakinevich@salutedevices.com>
Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
 drivers/crypto/amlogic/amlogic-gxl-cipher.c | 41 +++++++++++++++++++--
 drivers/crypto/amlogic/amlogic-gxl.h        |  1 +
 2 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
index 6ff0e088939f..b60b65034b6e 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
@@ -154,7 +154,7 @@ static void meson_setup_keyiv_descs(struct cipher_ctx *ctx)
 	if (ctx->tloffset)
 		return;
 
-	if (blockmode == DESC_OPMODE_CBC) {
+	if (blockmode == DESC_OPMODE_CBC || blockmode == DESC_OPMODE_CTR) {
 		memcpy(op->keyiv + AES_MAX_KEY_SIZE, ctx->areq->iv, ivsize);
 		dma_sync_single_for_device(mc->dev, ctx->keyiv.addr,
 					   ctx->keyiv.len, DMA_TO_DEVICE);
@@ -186,6 +186,7 @@ static bool meson_setup_data_descs(struct cipher_ctx *ctx)
 	struct meson_desc *desc = &mc->chanlist[rctx->flow].tl[ctx->tloffset];
 	unsigned int blocksize = crypto_skcipher_blocksize(tfm);
 	unsigned int blockmode = algt->blockmode;
+	unsigned int ivsize = crypto_skcipher_ivsize(tfm);
 	unsigned int maxlen = rounddown(DESC_MAXLEN, blocksize);
 	unsigned int todo;
 	u32 v;
@@ -204,8 +205,15 @@ static bool meson_setup_data_descs(struct cipher_ctx *ctx)
 	ctx->src_offset += todo;
 	ctx->dst_offset += todo;
 
+	if (blockmode == DESC_OPMODE_CTR) {
+		unsigned int nblocks = todo / blocksize;
+
+		while (nblocks--)
+			crypto_inc(ctx->areq->iv, ivsize);
+	}
+
 	v = DESC_OWN | blockmode | op->keymode | todo;
-	if (rctx->op_dir == MESON_ENCRYPT)
+	if (rctx->op_dir == MESON_ENCRYPT || blockmode == DESC_OPMODE_CTR)
 		v |= DESC_ENCRYPTION;
 
 	if (!ctx->cryptlen || ctx->tloffset == MAXDESC)
@@ -322,7 +330,8 @@ static int meson_cipher(struct skcipher_request *areq)
 	if (ctx.keyiv.len == AES_KEYSIZE_192)
 		ctx.keyiv.len = AES_MAX_KEY_SIZE;
 
-	if (algt->blockmode == DESC_OPMODE_CBC) {
+	if (algt->blockmode == DESC_OPMODE_CBC ||
+		algt->blockmode == DESC_OPMODE_CTR) {
 		memcpy(op->keyiv + AES_MAX_KEY_SIZE, areq->iv, ivsize);
 		ctx.keyiv.len = AES_MAX_KEY_SIZE + ivsize;
 	}
@@ -534,6 +543,32 @@ static struct meson_alg_template algs[] = {
 		.decrypt	= meson_skdecrypt,
 	}
 },
+{
+	.type = CRYPTO_ALG_TYPE_SKCIPHER,
+	.blockmode = DESC_OPMODE_CTR,
+	.alg.skcipher = {
+		.base = {
+			.cra_name = "ctr(aes)",
+			.cra_driver_name = "ctr-aes-gxl",
+			.cra_priority = 400,
+			.cra_blocksize = AES_BLOCK_SIZE,
+			.cra_flags = CRYPTO_ALG_TYPE_SKCIPHER |
+				CRYPTO_ALG_ASYNC | CRYPTO_ALG_ALLOCATES_MEMORY |
+				CRYPTO_ALG_NEED_FALLBACK,
+			.cra_ctxsize = sizeof(struct meson_cipher_tfm_ctx),
+			.cra_module = THIS_MODULE,
+			.cra_alignmask = 0xf,
+			.cra_init = meson_cipher_init,
+			.cra_exit = meson_cipher_exit,
+		},
+		.min_keysize	= AES_MIN_KEY_SIZE,
+		.max_keysize	= AES_MAX_KEY_SIZE,
+		.ivsize		= AES_BLOCK_SIZE,
+		.setkey		= meson_aes_setkey,
+		.encrypt	= meson_skencrypt,
+		.decrypt	= meson_skdecrypt,
+	}
+},
 };
 
 int meson_cipher_register(struct meson_dev *mc)
diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/amlogic-gxl.h
index 5d80471f6a6a..d9336718d813 100644
--- a/drivers/crypto/amlogic/amlogic-gxl.h
+++ b/drivers/crypto/amlogic/amlogic-gxl.h
@@ -24,6 +24,7 @@
 
 #define DESC_OPMODE_ECB (0 << 26)
 #define DESC_OPMODE_CBC (1 << 26)
+#define DESC_OPMODE_CTR (2 << 26)
 #define DESC_OPMODE_SHA (0 << 26)
 
 #define DESC_MAXLEN ((1 << 17) - 1)
-- 
2.30.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  parent reply	other threads:[~2024-01-10 20:13 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 20:11 [PATCH v1 00/24] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 01/24] drivers: crypto: meson: don't hardcode IRQ count Alexey Romanov
2024-01-11  8:21   ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 02/24] drivers: crypto: meson: make CLK controller optional Alexey Romanov
2024-01-11  8:20   ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 03/24] drviers: crypto: meson: add platform data Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 04/24] drivers: crypto: meson: add MMIO helpers Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 05/24] drivers: crypto: meson: move get_engine_number() Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 06/24] drivers: crypto: meson: drop status field from meson_flow Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 07/24] drivers: crypto: meson: move algs definition and cipher API to cipher.c Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 08/24] drivers: crypto: meson: cleanup defines Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 09/24] drivers: crypto: meson: process more than MAXDESCS descriptors Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 10/24] drivers: crypto: meson: avoid kzalloc in engine thread Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 11/24] drivers: crypto: meson: introduce hasher Alexey Romanov
2024-01-10 20:11 ` Alexey Romanov [this message]
2024-01-10 20:11 ` [PATCH v1 13/24] drivers: crypto: meson: use fallback for 192-bit keys Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 14/24] drivers: crypto: meson: add support for G12-series Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 15/24] drivers: crypto: meson: add support for AXG-series Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 16/24] dt-bindings: crypto: meson: add new compatibles Alexey Romanov
2024-01-10 21:25   ` Rob Herring
2024-01-11  1:44   ` Rob Herring
2024-01-11  8:15   ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 17/24] arch: arm64: dts: meson: a1: add crypto node Alexey Romanov
2024-01-11  8:16   ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 18/24] arch: arm64: dts: meson: s4: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 19/24] arch: arm64: dts: meson: g12: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 20/24] arch: arm64: dts: meson: axg: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 21/24] arch: arm64: dts: meson: s4-s805x2-aq222: enable " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 22/24] arch: arm64: dts: meson: a1-ad401: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 23/24] arch: arm64: dts: meson: axg-s400: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 24/24] arch: arm64: dts: meson: g12a-u200: " Alexey Romanov
2024-01-10 21:08 ` [PATCH v1 00/24] Support more Amlogic SoC families in crypto driver Corentin Labbe
2024-01-11  9:18   ` Alexey Romanov
2024-01-11  9:29     ` Krzysztof Kozlowski
2024-01-11  9:31       ` Krzysztof Kozlowski
2024-01-11  8:19 ` neil.armstrong
2024-01-11  9:33   ` Alexey Romanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110201216.18016-13-avromanov@salutedevices.com \
    --to=avromanov@salutedevices.com \
    --cc=artin.blumenstingl@googlemail.com \
    --cc=clabbe@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@salutedevices.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=yvdakinevich@salutedevices.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®