From: Alexey Romanov <avromanov@salutedevices.com>
To: <narmstrong@baylibre.com>, <neil.armstrong@linaro.org>,
<clabbe@baylibre.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<khilman@baylibre.com>, <jbrunet@baylibre.com>,
<artin.blumenstingl@googlemail.com>
Cc: <linux-crypto@vger.kernel.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<kernel@salutedevices.com>,
Alexey Romanov <avromanov@salutedevices.com>,
Jan Dakinevich <yvdakinevich@salutedevices.com>
Subject: [PATCH v1 03/24] drviers: crypto: meson: add platform data
Date: Wed, 10 Jan 2024 23:11:19 +0300 [thread overview]
Message-ID: <20240110201216.18016-4-avromanov@salutedevices.com> (raw)
In-Reply-To: <20240110201216.18016-1-avromanov@salutedevices.com>
To support other Amlogic SoC's we have to
use platform data: descriptors and status registers
offsets are individual for each SoC series.
Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
Signed-off-by: Jan Dakinevich <yvdakinevich@salutedevices.com>
---
drivers/crypto/amlogic/amlogic-gxl-cipher.c | 2 +-
drivers/crypto/amlogic/amlogic-gxl-core.c | 30 +++++++++++++++------
drivers/crypto/amlogic/amlogic-gxl.h | 11 ++++++++
3 files changed, 34 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
index e01ed6347c3d..58de925caae7 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
@@ -225,7 +225,7 @@ static int meson_cipher(struct skcipher_request *areq)
reinit_completion(&mc->chanlist[flow].complete);
mc->chanlist[flow].status = 0;
- writel(mc->chanlist[flow].t_phy | 2, mc->base + (flow << 2));
+ writel(mc->chanlist[flow].t_phy | 2, mc->base + ((mc->pdata->descs_reg + flow) << 2));
wait_for_completion_interruptible_timeout(&mc->chanlist[flow].complete,
msecs_to_jiffies(500));
if (mc->chanlist[flow].status == 0) {
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index e5f504fb477e..a83c00922b48 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -28,9 +28,10 @@ static irqreturn_t meson_irq_handler(int irq, void *data)
for (flow = 0; flow < mc->flow_cnt; flow++) {
if (mc->chanlist[flow].irq == irq) {
- p = readl(mc->base + ((0x04 + flow) << 2));
+ p = readl(mc->base + ((mc->pdata->status_reg + flow) << 2));
if (p) {
- writel_relaxed(0xF, mc->base + ((0x4 + flow) << 2));
+ writel_relaxed(0xF, mc->base +
+ ((mc->pdata->status_reg + flow) << 2));
mc->chanlist[flow].status = 1;
complete(&mc->chanlist[flow].complete);
return IRQ_HANDLED;
@@ -230,15 +231,34 @@ static void meson_unregister_algs(struct meson_dev *mc)
}
}
+static const struct meson_pdata meson_gxl_pdata = {
+ .descs_reg = 0x0,
+ .status_reg = 0x4,
+};
+
+static const struct of_device_id meson_crypto_of_match_table[] = {
+ {
+ .compatible = "amlogic,gxl-crypto",
+ .data = &meson_gxl_pdata,
+ },
+ {},
+};
+
static int meson_crypto_probe(struct platform_device *pdev)
{
+ const struct of_device_id *match;
struct meson_dev *mc;
int err;
+ match = of_match_device(meson_crypto_of_match_table, &pdev->dev);
+ if (!match)
+ return -EINVAL;
+
mc = devm_kzalloc(&pdev->dev, sizeof(*mc), GFP_KERNEL);
if (!mc)
return -ENOMEM;
+ mc->pdata = match->data;
mc->dev = &pdev->dev;
platform_set_drvdata(pdev, mc);
@@ -291,12 +311,6 @@ static int meson_crypto_remove(struct platform_device *pdev)
return 0;
}
-static const struct of_device_id meson_crypto_of_match_table[] = {
- { .compatible = "amlogic,gxl-crypto", },
- {}
-};
-MODULE_DEVICE_TABLE(of, meson_crypto_of_match_table);
-
static struct platform_driver meson_crypto_driver = {
.probe = meson_crypto_probe,
.remove = meson_crypto_remove,
diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/amlogic-gxl.h
index e5cc6e028fa8..c8ba726ccc8b 100644
--- a/drivers/crypto/amlogic/amlogic-gxl.h
+++ b/drivers/crypto/amlogic/amlogic-gxl.h
@@ -78,6 +78,16 @@ struct meson_flow {
#endif
};
+/*
+ * struct meson_pdata - SoC series dependent data.
+ * @reg_descs: offset to descriptors register
+ * @reg_status: offset to status register
+ */
+struct meson_pdata {
+ u32 descs_reg;
+ u32 status_reg;
+};
+
/*
* struct meson_dev - main container for all this driver information
* @base: base address of amlogic-crypto
@@ -93,6 +103,7 @@ struct meson_dev {
void __iomem *base;
struct clk *busclk;
struct device *dev;
+ const struct meson_pdata *pdata;
struct meson_flow *chanlist;
atomic_t flow;
int flow_cnt;
--
2.30.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-01-10 20:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 20:11 [PATCH v1 00/24] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 01/24] drivers: crypto: meson: don't hardcode IRQ count Alexey Romanov
2024-01-11 8:21 ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 02/24] drivers: crypto: meson: make CLK controller optional Alexey Romanov
2024-01-11 8:20 ` neil.armstrong
2024-01-10 20:11 ` Alexey Romanov [this message]
2024-01-10 20:11 ` [PATCH v1 04/24] drivers: crypto: meson: add MMIO helpers Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 05/24] drivers: crypto: meson: move get_engine_number() Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 06/24] drivers: crypto: meson: drop status field from meson_flow Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 07/24] drivers: crypto: meson: move algs definition and cipher API to cipher.c Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 08/24] drivers: crypto: meson: cleanup defines Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 09/24] drivers: crypto: meson: process more than MAXDESCS descriptors Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 10/24] drivers: crypto: meson: avoid kzalloc in engine thread Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 11/24] drivers: crypto: meson: introduce hasher Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 12/24] drivers: crypto: meson: add support for AES-CTR Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 13/24] drivers: crypto: meson: use fallback for 192-bit keys Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 14/24] drivers: crypto: meson: add support for G12-series Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 15/24] drivers: crypto: meson: add support for AXG-series Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 16/24] dt-bindings: crypto: meson: add new compatibles Alexey Romanov
2024-01-10 21:25 ` Rob Herring
2024-01-11 1:44 ` Rob Herring
2024-01-11 8:15 ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 17/24] arch: arm64: dts: meson: a1: add crypto node Alexey Romanov
2024-01-11 8:16 ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 18/24] arch: arm64: dts: meson: s4: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 19/24] arch: arm64: dts: meson: g12: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 20/24] arch: arm64: dts: meson: axg: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 21/24] arch: arm64: dts: meson: s4-s805x2-aq222: enable " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 22/24] arch: arm64: dts: meson: a1-ad401: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 23/24] arch: arm64: dts: meson: axg-s400: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 24/24] arch: arm64: dts: meson: g12a-u200: " Alexey Romanov
2024-01-10 21:08 ` [PATCH v1 00/24] Support more Amlogic SoC families in crypto driver Corentin Labbe
2024-01-11 9:18 ` Alexey Romanov
2024-01-11 9:29 ` Krzysztof Kozlowski
2024-01-11 9:31 ` Krzysztof Kozlowski
2024-01-11 8:19 ` neil.armstrong
2024-01-11 9:33 ` Alexey Romanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110201216.18016-4-avromanov@salutedevices.com \
--to=avromanov@salutedevices.com \
--cc=artin.blumenstingl@googlemail.com \
--cc=clabbe@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=yvdakinevich@salutedevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®