mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Alexey Romanov <avromanov@salutedevices.com>
To: <narmstrong@baylibre.com>, <neil.armstrong@linaro.org>,
	<clabbe@baylibre.com>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<khilman@baylibre.com>, <jbrunet@baylibre.com>,
	<artin.blumenstingl@googlemail.com>
Cc: <linux-crypto@vger.kernel.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<kernel@salutedevices.com>,
	Alexey Romanov <avromanov@salutedevices.com>
Subject: [PATCH v1 13/24] drivers: crypto: meson: use fallback for 192-bit keys
Date: Wed, 10 Jan 2024 23:11:29 +0300	[thread overview]
Message-ID: <20240110201216.18016-14-avromanov@salutedevices.com> (raw)
In-Reply-To: <20240110201216.18016-1-avromanov@salutedevices.com>

Unforunately, not all Amlogic SoC's have a 192-bit key
support for AES algo. In this case, use fallback.

Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
 drivers/crypto/amlogic/amlogic-gxl-cipher.c | 7 +++++++
 drivers/crypto/amlogic/amlogic-gxl-core.c   | 1 +
 drivers/crypto/amlogic/amlogic-gxl.h        | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
index b60b65034b6e..20ef3dfbaeb4 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
@@ -41,6 +41,13 @@ static bool meson_cipher_need_fallback_sg(struct skcipher_request *areq,
 
 static bool meson_cipher_need_fallback(struct skcipher_request *areq)
 {
+	struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(areq);
+	struct meson_cipher_tfm_ctx *op = crypto_skcipher_ctx(tfm);
+	struct meson_dev *mc = op->mc;
+
+	if (op->keymode == DESC_MODE_AES_192 && !mc->pdata->support_192bit_key)
+		return true;
+
 	if (areq->cryptlen == 0)
 		return true;
 
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index a2bc9299214a..202dd9f73e55 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -206,6 +206,7 @@ static const struct meson_pdata meson_gxl_pdata = {
 	.descs_reg = 0x0,
 	.status_reg = 0x4,
 	.setup_desc_cnt = 3,
+	.support_192bit_key = true,
 };
 
 static const struct of_device_id meson_crypto_of_match_table[] = {
diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/amlogic-gxl.h
index d9336718d813..d4b2468b7e92 100644
--- a/drivers/crypto/amlogic/amlogic-gxl.h
+++ b/drivers/crypto/amlogic/amlogic-gxl.h
@@ -97,11 +97,13 @@ struct meson_flow {
  * @reg_descs:	offset to descriptors register
  * @reg_status:	offset to status register
  * @setup_desc_cnt:	number of setup descriptor to configure.
+ * @support_192bit_key:	indicates whether platform support AES 192-bit key
  */
 struct meson_pdata {
 	u32 descs_reg;
 	u32 status_reg;
 	u32 setup_desc_cnt;
+	bool support_192bit_key;
 };
 
 /*
-- 
2.30.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  parent reply	other threads:[~2024-01-10 20:13 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 20:11 [PATCH v1 00/24] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 01/24] drivers: crypto: meson: don't hardcode IRQ count Alexey Romanov
2024-01-11  8:21   ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 02/24] drivers: crypto: meson: make CLK controller optional Alexey Romanov
2024-01-11  8:20   ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 03/24] drviers: crypto: meson: add platform data Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 04/24] drivers: crypto: meson: add MMIO helpers Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 05/24] drivers: crypto: meson: move get_engine_number() Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 06/24] drivers: crypto: meson: drop status field from meson_flow Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 07/24] drivers: crypto: meson: move algs definition and cipher API to cipher.c Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 08/24] drivers: crypto: meson: cleanup defines Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 09/24] drivers: crypto: meson: process more than MAXDESCS descriptors Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 10/24] drivers: crypto: meson: avoid kzalloc in engine thread Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 11/24] drivers: crypto: meson: introduce hasher Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 12/24] drivers: crypto: meson: add support for AES-CTR Alexey Romanov
2024-01-10 20:11 ` Alexey Romanov [this message]
2024-01-10 20:11 ` [PATCH v1 14/24] drivers: crypto: meson: add support for G12-series Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 15/24] drivers: crypto: meson: add support for AXG-series Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 16/24] dt-bindings: crypto: meson: add new compatibles Alexey Romanov
2024-01-10 21:25   ` Rob Herring
2024-01-11  1:44   ` Rob Herring
2024-01-11  8:15   ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 17/24] arch: arm64: dts: meson: a1: add crypto node Alexey Romanov
2024-01-11  8:16   ` neil.armstrong
2024-01-10 20:11 ` [PATCH v1 18/24] arch: arm64: dts: meson: s4: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 19/24] arch: arm64: dts: meson: g12: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 20/24] arch: arm64: dts: meson: axg: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 21/24] arch: arm64: dts: meson: s4-s805x2-aq222: enable " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 22/24] arch: arm64: dts: meson: a1-ad401: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 23/24] arch: arm64: dts: meson: axg-s400: " Alexey Romanov
2024-01-10 20:11 ` [PATCH v1 24/24] arch: arm64: dts: meson: g12a-u200: " Alexey Romanov
2024-01-10 21:08 ` [PATCH v1 00/24] Support more Amlogic SoC families in crypto driver Corentin Labbe
2024-01-11  9:18   ` Alexey Romanov
2024-01-11  9:29     ` Krzysztof Kozlowski
2024-01-11  9:31       ` Krzysztof Kozlowski
2024-01-11  8:19 ` neil.armstrong
2024-01-11  9:33   ` Alexey Romanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110201216.18016-14-avromanov@salutedevices.com \
    --to=avromanov@salutedevices.com \
    --cc=artin.blumenstingl@googlemail.com \
    --cc=clabbe@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@salutedevices.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®