* [PATCH 2/2] arm64: dts: meson: add GXLX/S905L/p271 support
2024-06-04 8:41 [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board Christian Hewitt
@ 2024-06-04 8:41 ` Christian Hewitt
2024-06-05 8:46 ` Neil Armstrong
2024-06-04 15:28 ` [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board Rob Herring (Arm)
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Christian Hewitt @ 2024-06-04 8:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Add a device-tree for the GXLX Amlogic P271 (S905L) reference design
board. This is a low-cost design similar to P281 (S905W) but with
silicon differences to omit VP9 and use Mali 450-MP2 (not MP3). The
SoC is marked with S905L and "2" (believed to denote MP2) resulting
in chip distributor stock lists and Android STB marketing sometimes
describing it as an S905L2 chip.
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
NOTE: This patch depends upon the following submitted patches for
VDEC [0] and SARADC [1] support:
[0] https://patchwork.kernel.org/project/linux-amlogic/list/?series=858514
[1] https://patchwork.kernel.org/project/linux-amlogic/list/?series=858525
CHECK_DTBS generates some warnings for pre-existing issues inherited
from common dtsi files. The patch does not add any new issues.
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../dts/amlogic/meson-gxlx-s905l-p271.dts | 51 +++++++++++++++++++
2 files changed, 52 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 0f29517da5ec..0746e01b5853 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -62,6 +62,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc-v2.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxlx-s905l-p271.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxm-gt1-ultimate.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxm-mecool-kiii-pro.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts b/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
new file mode 100644
index 000000000000..1221f4545130
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
@@ -0,0 +1,51 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2024 Christian Hewitt <christianshewitt@gmail.com>
+ */
+
+/dts-v1/;
+
+#include "meson-gxl-s905x.dtsi"
+#include "meson-gx-p23x-q20x.dtsi"
+
+/ {
+ compatible = "amlogic,p271", "amlogic,s905l", "amlogic,meson-gxlx";
+ model = "Amlogic Meson GXLX (S905L) P271 Development Board";
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x40000000>;
+ };
+
+ sound {
+ model = "P271";
+ };
+};
+
+&apb {
+ mali: gpu@c0000 {
+ /* Mali 450-MP2 */
+ interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "gp", "gpmmu", "pp", "pmu",
+ "pp0", "ppmmu0", "pp1", "ppmmu1";
+ };
+};
+
+&saradc {
+ compatible = "amlogic,meson-gxlx-saradc", "amlogic,meson-saradc";
+};
+
+&usb {
+ dr_mode = "host";
+};
+
+&vdec {
+ compatible = "amlogic,gxlx-vdec", "amlogic,gx-vdec";
+};
--
2.34.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] arm64: dts: meson: add GXLX/S905L/p271 support
2024-06-04 8:41 ` [PATCH 2/2] arm64: dts: meson: add GXLX/S905L/p271 support Christian Hewitt
@ 2024-06-05 8:46 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-06-05 8:46 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
On 04/06/2024 10:41, Christian Hewitt wrote:
> Add a device-tree for the GXLX Amlogic P271 (S905L) reference design
> board. This is a low-cost design similar to P281 (S905W) but with
> silicon differences to omit VP9 and use Mali 450-MP2 (not MP3). The
> SoC is marked with S905L and "2" (believed to denote MP2) resulting
> in chip distributor stock lists and Android STB marketing sometimes
> describing it as an S905L2 chip.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> NOTE: This patch depends upon the following submitted patches for
> VDEC [0] and SARADC [1] support:
>
> [0] https://patchwork.kernel.org/project/linux-amlogic/list/?series=858514
> [1] https://patchwork.kernel.org/project/linux-amlogic/list/?series=858525
>
> CHECK_DTBS generates some warnings for pre-existing issues inherited
> from common dtsi files. The patch does not add any new issues.
>
> arch/arm64/boot/dts/amlogic/Makefile | 1 +
> .../dts/amlogic/meson-gxlx-s905l-p271.dts | 51 +++++++++++++++++++
> 2 files changed, 52 insertions(+)
> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index 0f29517da5ec..0746e01b5853 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -62,6 +62,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc-v2.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxlx-s905l-p271.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-gt1-ultimate.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-mecool-kiii-pro.dtb
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts b/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
> new file mode 100644
> index 000000000000..1221f4545130
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
> @@ -0,0 +1,51 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2024 Christian Hewitt <christianshewitt@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "meson-gxl-s905x.dtsi"
> +#include "meson-gx-p23x-q20x.dtsi"
> +
> +/ {
> + compatible = "amlogic,p271", "amlogic,s905l", "amlogic,meson-gxlx";
> + model = "Amlogic Meson GXLX (S905L) P271 Development Board";
> +
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x0 0x0 0x40000000>;
> + };
> +
> + sound {
> + model = "P271";
> + };
> +};
> +
> +&apb {
> + mali: gpu@c0000 {
> + /* Mali 450-MP2 */
> + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "gp", "gpmmu", "pp", "pmu",
> + "pp0", "ppmmu0", "pp1", "ppmmu1";
> + };
> +};
> +
> +&saradc {
> + compatible = "amlogic,meson-gxlx-saradc", "amlogic,meson-saradc";
> +};
> +
> +&usb {
> + dr_mode = "host";
> +};
> +
> +&vdec {
> + compatible = "amlogic,gxlx-vdec", "amlogic,gx-vdec";
> +};
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board
2024-06-04 8:41 [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board Christian Hewitt
2024-06-04 8:41 ` [PATCH 2/2] arm64: dts: meson: add GXLX/S905L/p271 support Christian Hewitt
@ 2024-06-04 15:28 ` Rob Herring (Arm)
2024-06-04 15:30 ` Krzysztof Kozlowski
2024-06-06 9:13 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2024-06-04 15:28 UTC (permalink / raw)
To: Christian Hewitt
Cc: linux-arm-kernel, Jerome Brunet, Krzysztof Kozlowski,
Martin Blumenstingl, linux-kernel, devicetree, Neil Armstrong,
linux-amlogic, Conor Dooley, Rob Herring, Kevin Hilman
On Tue, 04 Jun 2024 08:41:33 +0000, Christian Hewitt wrote:
> Add support for an Amlogic GXLX based S905L SoC and P271 reference
> design board. The S905L is a low-cost design similar to the P281
> (S905W) and is similarly derived from P212 (S905X). However S905L
> omits support for the VP9 codec and uses Mali 450-MP2 (not MP3).
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y amlogic/meson-gxlx-s905l-p271.dtb' for 20240604084134.3315841-1-christianshewitt@gmail.com:
arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dtb: /soc/bus@c1100000/adc@8680: failed to match any schema with compatible: ['amlogic,meson-gxlx-saradc', 'amlogic,meson-saradc']
arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dtb: /soc/video-codec@c8820000: failed to match any schema with compatible: ['amlogic,gxlx-vdec', 'amlogic,gx-vdec']
arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dtb: sound: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
from schema $id: http://devicetree.org/schemas/sound/amlogic,gx-sound-card.yaml#
arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dtb: sound: 'anyOf' conditional failed, one must be fixed:
'clocks' is a required property
'#clock-cells' is a required property
from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board
2024-06-04 8:41 [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board Christian Hewitt
2024-06-04 8:41 ` [PATCH 2/2] arm64: dts: meson: add GXLX/S905L/p271 support Christian Hewitt
2024-06-04 15:28 ` [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board Rob Herring (Arm)
@ 2024-06-04 15:30 ` Krzysztof Kozlowski
2024-06-06 9:13 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-04 15:30 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
On 04/06/2024 10:41, Christian Hewitt wrote:
> Add support for an Amlogic GXLX based S905L SoC and P271 reference
> design board. The S905L is a low-cost design similar to the P281
> (S905W) and is similarly derived from P212 (S905X). However S905L
> omits support for the VP9 codec and uses Mali 450-MP2 (not MP3).
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board
2024-06-04 8:41 [PATCH 1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board Christian Hewitt
` (2 preceding siblings ...)
2024-06-04 15:30 ` Krzysztof Kozlowski
@ 2024-06-06 9:13 ` Neil Armstrong
3 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-06-06 9:13 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, devicetree, linux-arm-kernel,
linux-amlogic, linux-kernel, Christian Hewitt
Hi,
On Tue, 04 Jun 2024 08:41:33 +0000, Christian Hewitt wrote:
> Add support for an Amlogic GXLX based S905L SoC and P271 reference
> design board. The S905L is a low-cost design similar to the P281
> (S905W) and is similarly derived from P212 (S905X). However S905L
> omits support for the VP9 codec and uses Mali 450-MP2 (not MP3).
>
>
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.11/arm64-dt)
[1/2] dt-bindings: arm: amlogic: add GXLX/S905L/p271 reference board
https://git.kernel.org/amlogic/c/f36596adb56f0381c0c46c5fab23ffd201f7e646
[2/2] arm64: dts: meson: add GXLX/S905L/p271 support
https://git.kernel.org/amlogic/c/f6386b5afa81724164263c30c48de733e0aab74c
These changes has been applied on the intermediate git tree [1].
The v6.11/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.
In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].
The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.
If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
--
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread