* Re: [PATCH] pinctrl: meson: mark the GPIO controller as sleeping
2026-01-05 15:05 [PATCH] pinctrl: meson: mark the GPIO controller as sleeping Bartosz Golaszewski
@ 2026-01-05 15:07 ` Neil Armstrong
2026-01-05 17:28 ` Martin Blumenstingl
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2026-01-05 15:07 UTC (permalink / raw)
To: Bartosz Golaszewski, Linus Walleij, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, Bartosz Golaszewski
Cc: linux-gpio, linux-arm-kernel, linux-amlogic, linux-kernel,
stable, Marek Szyprowski
On 1/5/26 16:05, Bartosz Golaszewski wrote:
> The GPIO controller is configured as non-sleeping but it uses generic
> pinctrl helpers which use a mutex for synchronization.
>
> This can cause the following lockdep splat with shared GPIOs enabled on
> boards which have multiple devices using the same GPIO:
>
> BUG: sleeping function called from invalid context at
> kernel/locking/mutex.c:591
> in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 142, name:
> kworker/u25:3
> preempt_count: 1, expected: 0
> RCU nest depth: 0, expected: 0
> INFO: lockdep is turned off.
> irq event stamp: 46379
> hardirqs last enabled at (46379): [<ffff8000813acb24>]
> _raw_spin_unlock_irqrestore+0x74/0x78
> hardirqs last disabled at (46378): [<ffff8000813abf38>]
> _raw_spin_lock_irqsave+0x84/0x88
> softirqs last enabled at (46330): [<ffff8000800c71b4>]
> handle_softirqs+0x4c4/0x4dc
> softirqs last disabled at (46295): [<ffff800080010674>]
> __do_softirq+0x14/0x20
> CPU: 1 UID: 0 PID: 142 Comm: kworker/u25:3 Tainted: G C
> 6.19.0-rc4-next-20260105+ #11963 PREEMPT
> Tainted: [C]=CRAP
> Hardware name: Khadas VIM3 (DT)
> Workqueue: events_unbound deferred_probe_work_func
> Call trace:
> show_stack+0x18/0x24 (C)
> dump_stack_lvl+0x90/0xd0
> dump_stack+0x18/0x24
> __might_resched+0x144/0x248
> __might_sleep+0x48/0x98
> __mutex_lock+0x5c/0x894
> mutex_lock_nested+0x24/0x30
> pinctrl_get_device_gpio_range+0x44/0x128
> pinctrl_gpio_set_config+0x40/0xdc
> gpiochip_generic_config+0x28/0x3c
> gpio_do_set_config+0xa8/0x194
> gpiod_set_config+0x34/0xfc
> gpio_shared_proxy_set_config+0x6c/0xfc [gpio_shared_proxy]
> gpio_do_set_config+0xa8/0x194
> gpiod_set_transitory+0x4c/0xf0
> gpiod_configure_flags+0xa4/0x480
> gpiod_find_and_request+0x1a0/0x574
> gpiod_get_index+0x58/0x84
> devm_gpiod_get_index+0x20/0xb4
> devm_gpiod_get+0x18/0x24
> mmc_pwrseq_emmc_probe+0x40/0xb8
> platform_probe+0x5c/0xac
> really_probe+0xbc/0x298
> __driver_probe_device+0x78/0x12c
> driver_probe_device+0xdc/0x164
> __device_attach_driver+0xb8/0x138
> bus_for_each_drv+0x80/0xdc
> __device_attach+0xa8/0x1b0
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> Cc: stable@vger.kernel.org
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Closes: https://lore.kernel.org/all/00107523-7737-4b92-a785-14ce4e93b8cb@samsung.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
> index 18295b15ecd9..4507dc8b5563 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
> @@ -619,7 +619,7 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc)
> pc->chip.set = meson_gpio_set;
> pc->chip.base = -1;
> pc->chip.ngpio = pc->data->num_pins;
> - pc->chip.can_sleep = false;
> + pc->chip.can_sleep = true;
>
> ret = gpiochip_add_data(&pc->chip, pc);
> if (ret) {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] pinctrl: meson: mark the GPIO controller as sleeping
2026-01-05 15:05 [PATCH] pinctrl: meson: mark the GPIO controller as sleeping Bartosz Golaszewski
2026-01-05 15:07 ` Neil Armstrong
@ 2026-01-05 17:28 ` Martin Blumenstingl
2026-01-05 17:38 ` Bartosz Golaszewski
2026-01-06 8:57 ` Martin Blumenstingl
2026-01-09 9:30 ` Linus Walleij
3 siblings, 1 reply; 7+ messages in thread
From: Martin Blumenstingl @ 2026-01-05 17:28 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Bartosz Golaszewski, linux-gpio, linux-arm-kernel, linux-amlogic,
linux-kernel, stable, Marek Szyprowski
Hi Bartosz,
On Mon, Jan 5, 2026 at 4:05 PM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:
[...]
> mutex_lock_nested+0x24/0x30
> pinctrl_get_device_gpio_range+0x44/0x128
> pinctrl_gpio_set_config+0x40/0xdc
> gpiochip_generic_config+0x28/0x3c
> gpio_do_set_config+0xa8/0x194
$ git grep gpiochip_generic_config drivers/pinctrl/meson/
drivers/pinctrl/meson/pinctrl-amlogic-a4.c: .set_config
= gpiochip_generic_config,
drivers/pinctrl/meson/pinctrl-meson.c: pc->chip.set_config =
gpiochip_generic_config;
pinctrl-amlogic-a4.c still has:
.can_sleep = false,
Are there plans to send a separate fix for pinctrl-amlogic-a4.c - or
was the intention to fix "all" Amlogic pin controllers in this patch
(which would mean that the change to pinctrl-amlogic-a4.c is missing)?
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pinctrl: meson: mark the GPIO controller as sleeping
2026-01-05 17:28 ` Martin Blumenstingl
@ 2026-01-05 17:38 ` Bartosz Golaszewski
2026-01-05 17:50 ` Marek Szyprowski
0 siblings, 1 reply; 7+ messages in thread
From: Bartosz Golaszewski @ 2026-01-05 17:38 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Linus Walleij, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Bartosz Golaszewski, linux-gpio, linux-arm-kernel, linux-amlogic,
linux-kernel, stable, Marek Szyprowski, Bartosz Golaszewski
On Mon, 5 Jan 2026 18:28:23 +0100, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> said:
> Hi Bartosz,
>
> On Mon, Jan 5, 2026 at 4:05 PM Bartosz Golaszewski
> <bartosz.golaszewski@oss.qualcomm.com> wrote:
> [...]
>> mutex_lock_nested+0x24/0x30
>> pinctrl_get_device_gpio_range+0x44/0x128
>> pinctrl_gpio_set_config+0x40/0xdc
>> gpiochip_generic_config+0x28/0x3c
>> gpio_do_set_config+0xa8/0x194
> $ git grep gpiochip_generic_config drivers/pinctrl/meson/
> drivers/pinctrl/meson/pinctrl-amlogic-a4.c: .set_config
> = gpiochip_generic_config,
> drivers/pinctrl/meson/pinctrl-meson.c: pc->chip.set_config =
> gpiochip_generic_config;
>
> pinctrl-amlogic-a4.c still has:
> .can_sleep = false,
>
> Are there plans to send a separate fix for pinctrl-amlogic-a4.c - or
> was the intention to fix "all" Amlogic pin controllers in this patch
> (which would mean that the change to pinctrl-amlogic-a4.c is missing)?
>
>
Yeah, I missed it. I will send a follow-up tomorrow.
Bartosz
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pinctrl: meson: mark the GPIO controller as sleeping
2026-01-05 17:38 ` Bartosz Golaszewski
@ 2026-01-05 17:50 ` Marek Szyprowski
0 siblings, 0 replies; 7+ messages in thread
From: Marek Szyprowski @ 2026-01-05 17:50 UTC (permalink / raw)
To: Bartosz Golaszewski, Martin Blumenstingl
Cc: Linus Walleij, Neil Armstrong, Kevin Hilman, Jerome Brunet,
linux-gpio, linux-arm-kernel, linux-amlogic, linux-kernel,
stable, Bartosz Golaszewski
On 05.01.2026 18:38, Bartosz Golaszewski wrote:
> On Mon, 5 Jan 2026 18:28:23 +0100, Martin Blumenstingl
> <martin.blumenstingl@googlemail.com> said:
>> Hi Bartosz,
>>
>> On Mon, Jan 5, 2026 at 4:05 PM Bartosz Golaszewski
>> <bartosz.golaszewski@oss.qualcomm.com> wrote:
>> [...]
>>> mutex_lock_nested+0x24/0x30
>>> pinctrl_get_device_gpio_range+0x44/0x128
>>> pinctrl_gpio_set_config+0x40/0xdc
>>> gpiochip_generic_config+0x28/0x3c
>>> gpio_do_set_config+0xa8/0x194
>> $ git grep gpiochip_generic_config drivers/pinctrl/meson/
>> drivers/pinctrl/meson/pinctrl-amlogic-a4.c: .set_config
>> = gpiochip_generic_config,
>> drivers/pinctrl/meson/pinctrl-meson.c: pc->chip.set_config =
>> gpiochip_generic_config;
>>
>> pinctrl-amlogic-a4.c still has:
>> .can_sleep = false,
>>
>> Are there plans to send a separate fix for pinctrl-amlogic-a4.c - or
>> was the intention to fix "all" Amlogic pin controllers in this patch
>> (which would mean that the change to pinctrl-amlogic-a4.c is missing)?
>>
>>
> Yeah, I missed it. I will send a follow-up tomorrow.
I found that drivers/pinctrl/pinctrl-rockchip.c suffers for the same
issue, although I don't see where this ".can_sleep" flag has to be added:
BUG: sleeping function called from invalid context at
kernel/locking/mutex.c:591
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 12, name:
kworker/u16:0
preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
6 locks held by kworker/u16:0/12:
#0: ffff0001f0018d48 ((wq_completion)events_unbound#2){+.+.}-{0:0},
at: process_one_work+0x18c/0x604
#1: ffff8000842dbdf0 (deferred_probe_work){+.+.}-{0:0}, at:
process_one_work+0x1b4/0x604
#2: ffff0001f18498f8 (&dev->mutex){....}-{4:4}, at:
__device_attach+0x38/0x1b0
#3: ffff0001f75f1e90 (&gdev->srcu){.+.?}-{0:0}, at:
gpiod_direction_output_raw_commit+0x0/0x360
#4: ffff0001f46e3db8 (&shared_desc->spinlock){....}-{3:3}, at:
gpio_shared_proxy_direction_output+0xd0/0x144 [gpio_shared_proxy]
#5: ffff0001f180ee90 (&gdev->srcu){.+.?}-{0:0}, at:
gpiod_direction_output_raw_commit+0x0/0x360
irq event stamp: 81450
hardirqs last enabled at (81449): [<ffff8000813acba4>]
_raw_spin_unlock_irqrestore+0x74/0x78
hardirqs last disabled at (81450): [<ffff8000813abfb8>]
_raw_spin_lock_irqsave+0x84/0x88
softirqs last enabled at (79616): [<ffff8000811455fc>]
__alloc_skb+0x17c/0x1e8
softirqs last disabled at (79614): [<ffff8000811455fc>]
__alloc_skb+0x17c/0x1e8
CPU: 2 UID: 0 PID: 12 Comm: kworker/u16:0 Not tainted
6.19.0-rc4-next-20260105+ #11975 PREEMPT
Hardware name: Hardkernel ODROID-M1 (DT)
Workqueue: events_unbound deferred_probe_work_func
Call trace:
show_stack+0x18/0x24 (C)
dump_stack_lvl+0x90/0xd0
dump_stack+0x18/0x24
__might_resched+0x144/0x248
__might_sleep+0x48/0x98
__mutex_lock+0x5c/0x894
mutex_lock_nested+0x24/0x30
pinctrl_get_device_gpio_range+0x44/0x128
pinctrl_gpio_direction+0x3c/0xe0
pinctrl_gpio_direction_output+0x14/0x20
rockchip_gpio_direction_output+0xb8/0x19c
gpiochip_direction_output+0x38/0x94
gpiod_direction_output_raw_commit+0x1d8/0x360
gpiod_direction_output_nonotify+0x7c/0x230
gpiod_direction_output+0x34/0xf8
gpio_shared_proxy_direction_output+0xec/0x144 [gpio_shared_proxy]
gpiochip_direction_output+0x38/0x94
gpiod_direction_output_raw_commit+0x1d8/0x360
gpiod_direction_output_nonotify+0x7c/0x230
gpiod_configure_flags+0xbc/0x480
gpiod_find_and_request+0x1a0/0x574
gpiod_get_index+0x58/0x84
devm_gpiod_get_index+0x20/0xb4
devm_gpiod_get_optional+0x18/0x30
rockchip_pcie_probe+0x98/0x380
platform_probe+0x5c/0xac
really_probe+0xbc/0x298
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pinctrl: meson: mark the GPIO controller as sleeping
2026-01-05 15:05 [PATCH] pinctrl: meson: mark the GPIO controller as sleeping Bartosz Golaszewski
2026-01-05 15:07 ` Neil Armstrong
2026-01-05 17:28 ` Martin Blumenstingl
@ 2026-01-06 8:57 ` Martin Blumenstingl
2026-01-09 9:30 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Martin Blumenstingl @ 2026-01-06 8:57 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Bartosz Golaszewski, linux-gpio, linux-arm-kernel, linux-amlogic,
linux-kernel, stable, Marek Szyprowski
On Mon, Jan 5, 2026 at 4:05 PM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:
>
> The GPIO controller is configured as non-sleeping but it uses generic
> pinctrl helpers which use a mutex for synchronization.
>
> This can cause the following lockdep splat with shared GPIOs enabled on
> boards which have multiple devices using the same GPIO:
>
> BUG: sleeping function called from invalid context at
> kernel/locking/mutex.c:591
> in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 142, name:
> kworker/u25:3
> preempt_count: 1, expected: 0
> RCU nest depth: 0, expected: 0
> INFO: lockdep is turned off.
> irq event stamp: 46379
> hardirqs last enabled at (46379): [<ffff8000813acb24>]
> _raw_spin_unlock_irqrestore+0x74/0x78
> hardirqs last disabled at (46378): [<ffff8000813abf38>]
> _raw_spin_lock_irqsave+0x84/0x88
> softirqs last enabled at (46330): [<ffff8000800c71b4>]
> handle_softirqs+0x4c4/0x4dc
> softirqs last disabled at (46295): [<ffff800080010674>]
> __do_softirq+0x14/0x20
> CPU: 1 UID: 0 PID: 142 Comm: kworker/u25:3 Tainted: G C
> 6.19.0-rc4-next-20260105+ #11963 PREEMPT
> Tainted: [C]=CRAP
> Hardware name: Khadas VIM3 (DT)
> Workqueue: events_unbound deferred_probe_work_func
> Call trace:
> show_stack+0x18/0x24 (C)
> dump_stack_lvl+0x90/0xd0
> dump_stack+0x18/0x24
> __might_resched+0x144/0x248
> __might_sleep+0x48/0x98
> __mutex_lock+0x5c/0x894
> mutex_lock_nested+0x24/0x30
> pinctrl_get_device_gpio_range+0x44/0x128
> pinctrl_gpio_set_config+0x40/0xdc
> gpiochip_generic_config+0x28/0x3c
> gpio_do_set_config+0xa8/0x194
> gpiod_set_config+0x34/0xfc
> gpio_shared_proxy_set_config+0x6c/0xfc [gpio_shared_proxy]
> gpio_do_set_config+0xa8/0x194
> gpiod_set_transitory+0x4c/0xf0
> gpiod_configure_flags+0xa4/0x480
> gpiod_find_and_request+0x1a0/0x574
> gpiod_get_index+0x58/0x84
> devm_gpiod_get_index+0x20/0xb4
> devm_gpiod_get+0x18/0x24
> mmc_pwrseq_emmc_probe+0x40/0xb8
> platform_probe+0x5c/0xac
> really_probe+0xbc/0x298
> __driver_probe_device+0x78/0x12c
> driver_probe_device+0xdc/0x164
> __device_attach_driver+0xb8/0x138
> bus_for_each_drv+0x80/0xdc
> __device_attach+0xa8/0x1b0
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> Cc: stable@vger.kernel.org
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Closes: https://lore.kernel.org/all/00107523-7737-4b92-a785-14ce4e93b8cb@samsung.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] pinctrl: meson: mark the GPIO controller as sleeping
2026-01-05 15:05 [PATCH] pinctrl: meson: mark the GPIO controller as sleeping Bartosz Golaszewski
` (2 preceding siblings ...)
2026-01-06 8:57 ` Martin Blumenstingl
@ 2026-01-09 9:30 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2026-01-09 9:30 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Bartosz Golaszewski, linux-gpio, linux-arm-kernel, linux-amlogic,
linux-kernel, stable, Marek Szyprowski
On Mon, Jan 5, 2026 at 4:05 PM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:
> The GPIO controller is configured as non-sleeping but it uses generic
> pinctrl helpers which use a mutex for synchronization.
>
> This can cause the following lockdep splat with shared GPIOs enabled on
> boards which have multiple devices using the same GPIO:
>
> BUG: sleeping function called from invalid context at
> kernel/locking/mutex.c:591
> in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 142, name:
> kworker/u25:3
> preempt_count: 1, expected: 0
> RCU nest depth: 0, expected: 0
> INFO: lockdep is turned off.
> irq event stamp: 46379
> hardirqs last enabled at (46379): [<ffff8000813acb24>]
> _raw_spin_unlock_irqrestore+0x74/0x78
> hardirqs last disabled at (46378): [<ffff8000813abf38>]
> _raw_spin_lock_irqsave+0x84/0x88
> softirqs last enabled at (46330): [<ffff8000800c71b4>]
> handle_softirqs+0x4c4/0x4dc
> softirqs last disabled at (46295): [<ffff800080010674>]
> __do_softirq+0x14/0x20
> CPU: 1 UID: 0 PID: 142 Comm: kworker/u25:3 Tainted: G C
> 6.19.0-rc4-next-20260105+ #11963 PREEMPT
> Tainted: [C]=CRAP
> Hardware name: Khadas VIM3 (DT)
> Workqueue: events_unbound deferred_probe_work_func
> Call trace:
> show_stack+0x18/0x24 (C)
> dump_stack_lvl+0x90/0xd0
> dump_stack+0x18/0x24
> __might_resched+0x144/0x248
> __might_sleep+0x48/0x98
> __mutex_lock+0x5c/0x894
> mutex_lock_nested+0x24/0x30
> pinctrl_get_device_gpio_range+0x44/0x128
> pinctrl_gpio_set_config+0x40/0xdc
> gpiochip_generic_config+0x28/0x3c
> gpio_do_set_config+0xa8/0x194
> gpiod_set_config+0x34/0xfc
> gpio_shared_proxy_set_config+0x6c/0xfc [gpio_shared_proxy]
> gpio_do_set_config+0xa8/0x194
> gpiod_set_transitory+0x4c/0xf0
> gpiod_configure_flags+0xa4/0x480
> gpiod_find_and_request+0x1a0/0x574
> gpiod_get_index+0x58/0x84
> devm_gpiod_get_index+0x20/0xb4
> devm_gpiod_get+0x18/0x24
> mmc_pwrseq_emmc_probe+0x40/0xb8
> platform_probe+0x5c/0xac
> really_probe+0xbc/0x298
> __driver_probe_device+0x78/0x12c
> driver_probe_device+0xdc/0x164
> __device_attach_driver+0xb8/0x138
> bus_for_each_drv+0x80/0xdc
> __device_attach+0xa8/0x1b0
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> Cc: stable@vger.kernel.org
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Closes: https://lore.kernel.org/all/00107523-7737-4b92-a785-14ce4e93b8cb@samsung.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Patch applied for fixes!
Yours,
Linus Walleij
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread