[PATCH] ASoC: meson: axg-fifo: return a negative error code when no irq is found

[PATCH] ASoC: meson: axg-fifo: return a negative error code when no irq is found

[Haotian Zhang]

In axg_fifo_probe(), of_irq_get() returns 0 when irq_create_of_mapping()
fails to map the interrupt. The error path explicitly treats this as a
failure with "if (fifo->irq <= 0)" and logs "failed to get irq: 0", but
then returns fifo->irq as-is. probe() therefore succeeds with fifo->irq
set to 0, and the failure is only reported much later when
axg_fifo_pcm_open() calls request_threaded_irq() with irq 0.

Return -EINVAL instead of 0, keeping the real negative error codes
untouched.

Fixes: 6dc4fa179fb8 ("ASoC: meson: add axg fifo base driver")
Assisted-by: DeepSeek-V4.1-Flash
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
 sound/soc/meson/axg-fifo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c
index 75909196b769..fdbee44f5101 100644
--- a/sound/soc/meson/axg-fifo.c
+++ b/sound/soc/meson/axg-fifo.c
@@ -365,7 +365,7 @@ int axg_fifo_probe(struct platform_device *pdev)
 	fifo->irq = of_irq_get(dev->of_node, 0);
 	if (fifo->irq <= 0) {
 		dev_err(dev, "failed to get irq: %d\n", fifo->irq);
-		return fifo->irq;
+		return fifo->irq ?: -EINVAL;
 	}
 
 	fifo->field_threshold =
-- 
2.25.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] ASoC: meson: axg-fifo: return a negative error code when no irq is found

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] soc: meson: dev_err() causes log spam on EPROBE_DEFER in axg_fifo_probe()
--

commit 267006c95b3ed8ed3ac0f11cabf3a8125d79bc3b
Author: Haotian Zhang <vulab@iscas.ac.cn>

ASoC: meson: axg-fifo: return a negative error code when no irq is found

This commit updates axg_fifo_probe() to return -EINVAL when of_irq_get()
returns 0. Previously, it returned 0 which caused the probe to succeed
erroneously, leading to failures later during request_threaded_irq().

> diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c
> index 75909196b7698..fdbee44f5101c 100644
> --- a/sound/soc/meson/axg-fifo.c
> +++ b/sound/soc/meson/axg-fifo.c
> @@ -365,7 +365,7 @@ int axg_fifo_probe(struct platform_device *pdev)
>  	fifo->irq = of_irq_get(dev->of_node, 0);
>  	if (fifo->irq <= 0) {
>  		dev_err(dev, "failed to get irq: %d\n", fifo->irq);

[Severity: Low]
Does this unconditionally log an error even when of_irq_get() returns
-EPROBE_DEFER?

If of_irq_get() returns -EPROBE_DEFER (-517) because the IRQ controller is
not yet available during boot, the condition fifo->irq <= 0 is true and
dev_err() will generate log spam.

Since this error handling block is being updated, could this be changed to
use dev_err_probe() instead? This would correctly suppress deferral log
messages, as is done for other resources in axg_fifo_probe().

> -		return fifo->irq;
> +		return fifo->irq ?: -EINVAL;
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009051724.3134644-1-vulab@iscas.ac.cn?part=1

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] ASoC: meson: axg-fifo: return a negative error code when no irq is found

[Krzysztof Kozlowski]

On Fri, 09 Oct 2026 13:17:24 +0800, Haotian Zhang wrote:
> In axg_fifo_probe(), of_irq_get() returns 0 when irq_create_of_mapping()
> fails to map the interrupt. The error path explicitly treats this as a
> failure with "if (fifo->irq <= 0)" and logs "failed to get irq: 0", but
> then returns fifo->irq as-is. probe() therefore succeeds with fifo->irq
> set to 0, and the failure is only reported much later when
> axg_fifo_pcm_open() calls request_threaded_irq() with irq 0.
> 
> Return -EINVAL instead of 0, keeping the real negative error codes
> untouched.
> 
> Fixes: 6dc4fa179fb8 ("ASoC: meson: add axg fifo base driver")
> Assisted-by: DeepSeek-V4.1-Flash
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
>  sound/soc/meson/axg-fifo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 



Multiple things here:
1. Your team ignored completely previous feedback.

2. You use multiple identities with this email, thus I actually doubt we speak
   with actual person.

3. Finally, same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document usage of LLM and how what you should not do
if this was posted in a good faith.

Best regards,
Krzysztof





_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic