Re: [PATCH 09/10] arm64: dts: amlogic: meson-s4: add the AO CEC controller

From: Conor Dooley <conor@kernel.org>
To: christian.koever-draxl@student.uibk.ac.at
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	neil.armstrong@linaro.org, khilman@baylibre.com,
	jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	"Christian Stefan Kövér-Draxl" <ckoever@outlook.de>
Subject: Re: [PATCH 09/10] arm64: dts: amlogic: meson-s4: add the AO CEC controller
Date: Fri, 6 Nov 2026 17:19:46 +0000	[thread overview]
Message-ID: <20261106-walk-overload-3ffa489c0af1@spud> (raw)
In-Reply-To: <20261106104659.54656-10-christian.koever-draxl@student.uibk.ac.at>

[-- Attachment #1.1: Type: text/plain, Size: 1910 bytes --]

On Fri, Nov 06, 2026 at 11:46:58AM +0100, christian.koever-draxl@student.uibk.ac.at wrote:
> From: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
> 
> Add the AO_CEC_A controller and its pin group.
> 
> Signed-off-by: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
> ---
>  arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 24 +++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index 155997649dc3..dd51e786d29d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -747,6 +747,14 @@ mux {
>  					};
>  				};
>  
> +				ao_cec_a_pins: ao-cec-a {
> +					mux {
> +						groups = "ao_cec_a";
> +						function = "ao_cec_a";
> +						bias-disable;
> +					};
> +				};
> +
>  			};
>  
>  			gpio_intc: interrupt-controller@4080 {
> @@ -970,6 +978,22 @@ sec_ao: ao-secure@10220 {
>  				amlogic,has-chip-id;
>  			};
>  
> +			cec_a: cec@44000 {
> +				compatible = "amlogic,meson-gx-ao-cec";

This is an s4, not a gx, so you need a specific compatible.
pw-bot: changes-requested

Thanks,
Conor.

> +				reg = <0x0 0x44000 0x0 0x14>;
> +				interrupts = <GIC_SPI 179 IRQ_TYPE_EDGE_RISING>;
> +				clocks = <&clkc_periphs CLKID_CECA_32K_CLKOUT>;
> +				clock-names = "core";
> +				assigned-clocks = <&clkc_periphs CLKID_CECA_32K_DIV>,
> +						  <&clkc_periphs CLKID_CECA_32K_SEL_PRE>,
> +						  <&clkc_periphs CLKID_CECA_32K_SEL>;
> +				assigned-clock-parents = <0>,
> +							 <&clkc_periphs CLKID_CECA_32K_DIV>,
> +							 <&clkc_periphs CLKID_CECA_32K_SEL_PRE>;
> +				assigned-clock-rates = <32768>, <0>, <0>;
> +				status = "disabled";
> +			};
> +
>  			ir: ir@84040 {
>  				compatible = "amlogic,meson-s4-ir";
>  				reg = <0x0 0x84040 0x0 0x30>;
> -- 
> 2.56.0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic