Re: [PATCH 06/10] arm64: dts: amlogic: meson-s4: add the CPU thermal sensor and zone

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: amlogic: meson-s4: unmatched amlogic,s4-thermal
  compatible
--

commit a99d2d51a763291902046985186e9763a3fd5d38
Author: Christian Stefan Kövér-Draxl <ckoever@outlook.de>

arm64: dts: amlogic: meson-s4: add the CPU thermal sensor and zone

This commit adds the CPU temperature sensor node and the corresponding CPU
thermal zone with trip points and GPU cooling map to meson-s4.dtsi.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index 69105c8abf122..1e8b845b80c31 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
[ ... ]
> @@ -748,6 +749,17 @@ gpio_intc: interrupt-controller@4080 {
>  					<10 11 12 13 14 15 16 17 18 19 20 21>;
>  			};
>  
> +			cpu_temp: temperature-sensor@20000 {
> +				compatible = "amlogic,s4-thermal";
> +				reg = <0x0 0x20000 0x0 0x50>;
> +				interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clkc_periphs CLKID_TS_PLL>,
> +					 <&clkc_periphs CLKID_TS>;
> +				clock-names = "bus", "core";
> +				#thermal-sensor-cells = <0>;
> +				amlogic,secure-monitor = <&sm 1>;
> +			};

[Severity: High]
Does cpu_temp fail to bind to a driver and fail dtbs_check because
"amlogic,s4-thermal" is not matched or documented?

of_amlogic_thermal_match[] in drivers/thermal/amlogic_thermal.c only lists
"amlogic,g12a-ddr-thermal", "amlogic,g12a-cpu-thermal",
"amlogic,a1-cpu-thermal", and "amlogic,t7-thermal".  Without a matching
entry or a fallback compatible such as "amlogic,t7-thermal" (which
Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml also
requires when two clocks and clock-names are present), amlogic_thermal_probe()
never runs and the cpu-thermal zone remains inactive.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106104659.54656-1-christian.koever-draxl@student.uibk.ac.at?part=6

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic