Re: [PATCH 1/3] spi: dt-bindings: add doc for Amlogic A113L2 SFC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/08/2025 08:13, Xianwei Zhao wrote:
>>> +allOf:
>>> +  - $ref: /schemas/spi/spi-controller.yaml#
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: amlogic,a4-spifc
>>> +
>>> +  reg:
>>> +    items:
>>> +      - description: core registers
>>> +      - description: parent clk control registers
>>
>> Why are you poking to parent node or to clock registers? This looks like
>> mixing up device address spaces.
>>
> 
> The SPIFC bus clock multiplexes EMMC modules, so the corresponding 
> frequency division register is also in EMMC module. The SPIFC and the 
> EMMC modules cannot be used simultaneously.

Then obviously you cannot put here EMMC or parent registers.

It looks really like you miss proper hardware representation.

> 
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: core
>>> +      - const: pclk
>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: clock gate
>>
>> Are you sure this is separate clock input to this device?
>>
> 
> This clock is used by the APB interface to access the SPIFC registers.

So APB clock?



Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic