From: Hans Zhang <18255117159@163.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
heiko@sntech.de, thomas.petazzoni@bootlin.com,
manivannan.sadhasivam@linaro.org, yue.wang@Amlogic.com,
neil.armstrong@linaro.org, robh@kernel.org, jingoohan1@gmail.com,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 2/2] PCI: Remove redundant MPS configuration
Date: Sat, 26 Apr 2025 23:02:08 +0800 [thread overview]
Message-ID: <5e2844cc-8359-4b87-a8ce-eb5ebb85f8ff@163.com> (raw)
In-Reply-To: <20250425181345.bybgcht5tweyg43k@pali>
On 2025/4/26 02:13, Pali Rohár wrote:
> On Friday 25 April 2025 17:57:08 Hans Zhang wrote:
>> diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
>> index a29796cce420..d8852892994a 100644
>> --- a/drivers/pci/controller/pci-aardvark.c
>> +++ b/drivers/pci/controller/pci-aardvark.c
>> @@ -549,9 +549,7 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie)
>> reg = advk_readl(pcie, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL);
>> reg &= ~PCI_EXP_DEVCTL_RELAX_EN;
>> reg &= ~PCI_EXP_DEVCTL_NOSNOOP_EN;
>> - reg &= ~PCI_EXP_DEVCTL_PAYLOAD;
>> reg &= ~PCI_EXP_DEVCTL_READRQ;
>> - reg |= PCI_EXP_DEVCTL_PAYLOAD_512B;
>> reg |= PCI_EXP_DEVCTL_READRQ_512B;
>> advk_writel(pcie, reg, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL);
>>
>> --
>> 2.25.1
>>
>
> Please do not remove this code. It is required part of the
> initialization of the aardvark PCI controller at the specific phase,
> as defined in the Armada 3700 Functional Specification.
Hi Pali,
This series of patches is discussing the initialization of DevCtl.MPS by
the Root Port. Please look at the first patch I submitted. If there is a
reasonable method in the end, DevCtl.MPS will also be configured
successfully. The PCIe maintainer will give the review opinions. Please
rest assured that it will not affect the functions of the aardvark PCI
controller.
Rockchip's RK3588 also has the same problem.
https://patchwork.kernel.org/project/linux-pci/patch/20250416151926.140202-1-18255117159@163.com/
Best regards,
Hans
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-04-26 15:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 9:57 [PATCH v2 0/2] PCI: Configure max payload size on pci_host_probe Hans Zhang
2025-04-25 9:57 ` [PATCH v2 1/2] PCI: Configure root port MPS to hardware maximum during host probing Hans Zhang
2025-04-25 10:23 ` Niklas Cassel
2025-04-25 10:56 ` Hans Zhang
2025-04-25 13:47 ` Niklas Cassel
2025-04-25 14:17 ` Hans Zhang
2025-04-25 9:57 ` [PATCH v2 2/2] PCI: Remove redundant MPS configuration Hans Zhang
2025-04-25 10:17 ` Niklas Cassel
2025-04-25 10:26 ` Hans Zhang
2025-04-25 11:59 ` neil.armstrong
2025-04-25 14:20 ` Hans Zhang
2025-04-25 18:13 ` Pali Rohár
2025-04-26 15:02 ` Hans Zhang [this message]
2025-04-26 15:06 ` Pali Rohár
2025-04-26 15:20 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e2844cc-8359-4b87-a8ce-eb5ebb85f8ff@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jingoohan1@gmail.com \
--cc=khilman@baylibre.com \
--cc=kw@linux.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yue.wang@Amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®