* [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'
@ 2022-08-27 20:38 Fabio Estevam
2022-08-27 20:38 ` [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2022-08-27 20:38 UTC (permalink / raw)
To: martin.blumenstingl
Cc: linux-arm-kernel, khilman, linux-amlogic, Fabio Estevam
The 'enable-active-low' property is not a valid one.
Only 'enable-active-high' is valid, and when this property is absent
the gpio regulator will act as active low by default.
Remove the invalid 'enable-active-low' property.
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Changes since v1:
- Put linux-amlogic on Cc and added Martin's Reviewed-by tag.
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
index b4e86196e346..b2bb94981838 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
@@ -111,7 +111,6 @@ vcc_5v: regulator-vcc_5v {
vin-supply = <&dc_in>;
gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
- enable-active-low;
};
vddao_1v8: regulator-vddao_1v8 {
--
2.25.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: Remove 'enable-active-low'
2022-08-27 20:38 [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' Fabio Estevam
@ 2022-08-27 20:38 ` Fabio Estevam
2022-08-29 7:37 ` Neil Armstrong
2022-08-29 7:37 ` [PATCH v2 1/2] arm64: dts: meson-g12a: " Neil Armstrong
2022-08-29 7:49 ` Neil Armstrong
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2022-08-27 20:38 UTC (permalink / raw)
To: martin.blumenstingl
Cc: linux-arm-kernel, khilman, linux-amlogic, Fabio Estevam
The 'enable-active-low' property is not a valid one.
Only 'enable-active-high' is valid, and when this property is absent
the gpio regulator will act as active low by default.
Remove the invalid 'enable-active-low' property.
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Changes since v1:
- Put linux-amlogic on Cc and added Martin's Reviewed-by tag.
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 603337ca5608..9068a334ea57 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -171,7 +171,6 @@ vddao_3v3_t: regulator-vddao_3v3_t {
regulator-max-microvolt = <3300000>;
vin-supply = <&vddao_3v3>;
gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
- enable-active-low;
regulator-always-on;
};
--
2.25.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'
2022-08-27 20:38 [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' Fabio Estevam
2022-08-27 20:38 ` [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
@ 2022-08-29 7:37 ` Neil Armstrong
2022-08-29 7:49 ` Neil Armstrong
2 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2022-08-29 7:37 UTC (permalink / raw)
To: Fabio Estevam, martin.blumenstingl
Cc: linux-arm-kernel, khilman, linux-amlogic
On 27/08/2022 22:38, Fabio Estevam wrote:
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes since v1:
> - Put linux-amlogic on Cc and added Martin's Reviewed-by tag.
>
> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> index b4e86196e346..b2bb94981838 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> @@ -111,7 +111,6 @@ vcc_5v: regulator-vcc_5v {
> vin-supply = <&dc_in>;
>
> gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
> - enable-active-low;
> };
>
> vddao_1v8: regulator-vddao_1v8 {
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: Remove 'enable-active-low'
2022-08-27 20:38 ` [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
@ 2022-08-29 7:37 ` Neil Armstrong
0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2022-08-29 7:37 UTC (permalink / raw)
To: Fabio Estevam, martin.blumenstingl
Cc: linux-arm-kernel, khilman, linux-amlogic
On 27/08/2022 22:38, Fabio Estevam wrote:
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes since v1:
> - Put linux-amlogic on Cc and added Martin's Reviewed-by tag.
>
> arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> index 603337ca5608..9068a334ea57 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> @@ -171,7 +171,6 @@ vddao_3v3_t: regulator-vddao_3v3_t {
> regulator-max-microvolt = <3300000>;
> vin-supply = <&vddao_3v3>;
> gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
> - enable-active-low;
> regulator-always-on;
> };
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'
2022-08-27 20:38 [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' Fabio Estevam
2022-08-27 20:38 ` [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
2022-08-29 7:37 ` [PATCH v2 1/2] arm64: dts: meson-g12a: " Neil Armstrong
@ 2022-08-29 7:49 ` Neil Armstrong
2 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2022-08-29 7:49 UTC (permalink / raw)
To: Fabio Estevam, martin.blumenstingl
Cc: Neil Armstrong, khilman, linux-arm-kernel, linux-amlogic
Hi,
On Sat, 27 Aug 2022 17:38:12 -0300, Fabio Estevam wrote:
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> [...]
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.1/dt64)
[1/2] arm64: dts: meson-g12a: Remove 'enable-active-low'
https://git.kernel.org/amlogic/c/6b2592f087bb7e35fd0a6616bc92d87d9af63aab
[2/2] arm64: dts: meson-sm1-sei610: Remove 'enable-active-low'
https://git.kernel.org/amlogic/c/fdfaefa831728110f591764c1dc274fb3739e5c1
These changes has been applied on the intermediate git tree [1].
The v6.1/dt64 branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.
In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].
The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.
If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
--
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-29 7:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-27 20:38 [PATCH v2 1/2] arm64: dts: meson-g12a: Remove 'enable-active-low' Fabio Estevam
2022-08-27 20:38 ` [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
2022-08-29 7:37 ` Neil Armstrong
2022-08-29 7:37 ` [PATCH v2 1/2] arm64: dts: meson-g12a: " Neil Armstrong
2022-08-29 7:49 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®