* [PATCH] mfd: twl4030-madc: add __exit macro to remove
@ 2013-02-19 1:08 Jingoo Han
2013-02-20 10:46 ` Jingoo Han
2013-02-20 10:52 ` [PATCH v2] mfd: twl4030-madc: remove erroneous __exit_p() in twl4030_madc_driver Jingoo Han
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-02-19 1:08 UTC (permalink / raw)
To: 'Samuel Ortiz'; +Cc: linux-kernel, 'Jingoo Han'
Fixed build warning as below:
drivers/mfd/twl4030-madc.c:788:12: warning: 'twl4030_madc_remove' defined but not used [-Wunused-function]
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mfd/twl4030-madc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
index 88ff9dc..86ba920 100644
--- a/drivers/mfd/twl4030-madc.c
+++ b/drivers/mfd/twl4030-madc.c
@@ -785,7 +785,7 @@ err_power:
return ret;
}
-static int twl4030_madc_remove(struct platform_device *pdev)
+static int __exit twl4030_madc_remove(struct platform_device *pdev)
{
struct twl4030_madc_data *madc = platform_get_drvdata(pdev);
--
1.7.2.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: twl4030-madc: add __exit macro to remove
2013-02-19 1:08 [PATCH] mfd: twl4030-madc: add __exit macro to remove Jingoo Han
@ 2013-02-20 10:46 ` Jingoo Han
2013-02-20 10:52 ` [PATCH v2] mfd: twl4030-madc: remove erroneous __exit_p() in twl4030_madc_driver Jingoo Han
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-02-20 10:46 UTC (permalink / raw)
To: 'Jingoo Han', 'Samuel Ortiz'; +Cc: linux-kernel
On Tuesday, February 19, 2013 10:08 AM, Jingoo Han wrote:
>
> Fixed build warning as below:
>
> drivers/mfd/twl4030-madc.c:788:12: warning: 'twl4030_madc_remove' defined but not used [-Wunused-
> function]
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/twl4030-madc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
> index 88ff9dc..86ba920 100644
> --- a/drivers/mfd/twl4030-madc.c
> +++ b/drivers/mfd/twl4030-madc.c
> @@ -785,7 +785,7 @@ err_power:
> return ret;
> }
>
> -static int twl4030_madc_remove(struct platform_device *pdev)
> +static int __exit twl4030_madc_remove(struct platform_device *pdev)
> {
> struct twl4030_madc_data *madc = platform_get_drvdata(pdev);
Removing __exit_p() would be better.
I will send V2 patch.
>
> --
> 1.7.2.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] mfd: twl4030-madc: remove erroneous __exit_p() in twl4030_madc_driver
2013-02-19 1:08 [PATCH] mfd: twl4030-madc: add __exit macro to remove Jingoo Han
2013-02-20 10:46 ` Jingoo Han
@ 2013-02-20 10:52 ` Jingoo Han
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-02-20 10:52 UTC (permalink / raw)
To: 'Samuel Ortiz'; +Cc: linux-kernel, 'Jingoo Han'
This __exit_p() causes an build warning as below. Thus, it should
be removed.
drivers/mfd/twl4030-madc.c:788:12: warning: 'twl4030_madc_remove' defined but not used [-Wunused-function]
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mfd/twl4030-madc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
index 88ff9dc..942b666 100644
--- a/drivers/mfd/twl4030-madc.c
+++ b/drivers/mfd/twl4030-madc.c
@@ -800,7 +800,7 @@ static int twl4030_madc_remove(struct platform_device *pdev)
static struct platform_driver twl4030_madc_driver = {
.probe = twl4030_madc_probe,
- .remove = __exit_p(twl4030_madc_remove),
+ .remove = twl4030_madc_remove,
.driver = {
.name = "twl4030_madc",
.owner = THIS_MODULE,
--
1.7.2.5
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-20 10:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-19 1:08 [PATCH] mfd: twl4030-madc: add __exit macro to remove Jingoo Han
2013-02-20 10:46 ` Jingoo Han
2013-02-20 10:52 ` [PATCH v2] mfd: twl4030-madc: remove erroneous __exit_p() in twl4030_madc_driver Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®