mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/5] uio: uio_aec: remove unnecessary pci_set_drvdata()
@ 2013-09-12  6:37 Jingoo Han
  2013-09-12  6:38 ` [PATCH 2/5] uio: uio_cif: " Jingoo Han
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-12  6:37 UTC (permalink / raw)
  To: 'Greg Kroah-Hartman'
  Cc: linux-kernel, 'Hans J. Koch', 'Jingoo Han'

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/uio/uio_aec.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/uio/uio_aec.c b/drivers/uio/uio_aec.c
index f3611c2..1549fab 100644
--- a/drivers/uio/uio_aec.c
+++ b/drivers/uio/uio_aec.c
@@ -147,7 +147,6 @@ static void remove(struct pci_dev *pdev)
 	uio_unregister_device(info);
 	pci_release_regions(pdev);
 	pci_disable_device(pdev);
-	pci_set_drvdata(pdev, NULL);
 	iounmap(info->priv);
 
 	kfree(info);
-- 
1.7.10.4



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/5] uio: uio_cif: remove unnecessary pci_set_drvdata()
  2013-09-12  6:37 [PATCH 1/5] uio: uio_aec: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-09-12  6:38 ` Jingoo Han
  2013-09-12  6:39 ` [PATCH 3/5] uio: uio_mf624: " Jingoo Han
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-12  6:38 UTC (permalink / raw)
  To: 'Greg Kroah-Hartman'
  Cc: linux-kernel, 'Hans J. Koch', 'Jingoo Han'

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/uio/uio_cif.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/uio/uio_cif.c b/drivers/uio/uio_cif.c
index 22cdf38..30f533c 100644
--- a/drivers/uio/uio_cif.c
+++ b/drivers/uio/uio_cif.c
@@ -106,7 +106,6 @@ static void hilscher_pci_remove(struct pci_dev *dev)
 	uio_unregister_device(info);
 	pci_release_regions(dev);
 	pci_disable_device(dev);
-	pci_set_drvdata(dev, NULL);
 	iounmap(info->mem[0].internal_addr);
 
 	kfree (info);
-- 
1.7.10.4



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/5] uio: uio_mf624: remove unnecessary pci_set_drvdata()
  2013-09-12  6:37 [PATCH 1/5] uio: uio_aec: remove unnecessary pci_set_drvdata() Jingoo Han
  2013-09-12  6:38 ` [PATCH 2/5] uio: uio_cif: " Jingoo Han
@ 2013-09-12  6:39 ` Jingoo Han
  2013-09-12  6:39 ` [PATCH 4/5] uio: uio_netx: " Jingoo Han
  2013-09-12  6:39 ` [PATCH 5/5] uio: uio_sercos3: " Jingoo Han
  3 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-12  6:39 UTC (permalink / raw)
  To: 'Greg Kroah-Hartman'
  Cc: linux-kernel, 'Hans J. Koch', 'Jingoo Han'

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/uio/uio_mf624.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/uio/uio_mf624.c b/drivers/uio/uio_mf624.c
index a1768b2..832afa2 100644
--- a/drivers/uio/uio_mf624.c
+++ b/drivers/uio/uio_mf624.c
@@ -220,7 +220,6 @@ static void mf624_pci_remove(struct pci_dev *dev)
 	uio_unregister_device(info);
 	pci_release_regions(dev);
 	pci_disable_device(dev);
-	pci_set_drvdata(dev, NULL);
 
 	iounmap(info->mem[0].internal_addr);
 	iounmap(info->mem[1].internal_addr);
-- 
1.7.10.4



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 4/5] uio: uio_netx: remove unnecessary pci_set_drvdata()
  2013-09-12  6:37 [PATCH 1/5] uio: uio_aec: remove unnecessary pci_set_drvdata() Jingoo Han
  2013-09-12  6:38 ` [PATCH 2/5] uio: uio_cif: " Jingoo Han
  2013-09-12  6:39 ` [PATCH 3/5] uio: uio_mf624: " Jingoo Han
@ 2013-09-12  6:39 ` Jingoo Han
  2013-09-12  6:39 ` [PATCH 5/5] uio: uio_sercos3: " Jingoo Han
  3 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-12  6:39 UTC (permalink / raw)
  To: 'Greg Kroah-Hartman'
  Cc: linux-kernel, 'Hans J. Koch', 'Jingoo Han'

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/uio/uio_netx.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/uio/uio_netx.c b/drivers/uio/uio_netx.c
index 28a766b..4c345db 100644
--- a/drivers/uio/uio_netx.c
+++ b/drivers/uio/uio_netx.c
@@ -127,7 +127,6 @@ static void netx_pci_remove(struct pci_dev *dev)
 	uio_unregister_device(info);
 	pci_release_regions(dev);
 	pci_disable_device(dev);
-	pci_set_drvdata(dev, NULL);
 	iounmap(info->mem[0].internal_addr);
 
 	kfree(info);
-- 
1.7.10.4



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 5/5] uio: uio_sercos3: remove unnecessary pci_set_drvdata()
  2013-09-12  6:37 [PATCH 1/5] uio: uio_aec: remove unnecessary pci_set_drvdata() Jingoo Han
                   ` (2 preceding siblings ...)
  2013-09-12  6:39 ` [PATCH 4/5] uio: uio_netx: " Jingoo Han
@ 2013-09-12  6:39 ` Jingoo Han
  3 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-12  6:39 UTC (permalink / raw)
  To: 'Greg Kroah-Hartman'
  Cc: linux-kernel, 'Hans J. Koch', 'Jingoo Han'

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/uio/uio_sercos3.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/uio/uio_sercos3.c b/drivers/uio/uio_sercos3.c
index 5419832..9cfdfca 100644
--- a/drivers/uio/uio_sercos3.c
+++ b/drivers/uio/uio_sercos3.c
@@ -188,7 +188,6 @@ static void sercos3_pci_remove(struct pci_dev *dev)
 	uio_unregister_device(info);
 	pci_release_regions(dev);
 	pci_disable_device(dev);
-	pci_set_drvdata(dev, NULL);
 	for (i = 0; i < 5; i++) {
 		if (info->mem[i].internal_addr)
 			iounmap(info->mem[i].internal_addr);
-- 
1.7.10.4



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-09-12  6:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-12  6:37 [PATCH 1/5] uio: uio_aec: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-12  6:38 ` [PATCH 2/5] uio: uio_cif: " Jingoo Han
2013-09-12  6:39 ` [PATCH 3/5] uio: uio_mf624: " Jingoo Han
2013-09-12  6:39 ` [PATCH 4/5] uio: uio_netx: " Jingoo Han
2013-09-12  6:39 ` [PATCH 5/5] uio: uio_sercos3: " Jingoo Han

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®