* [PATCH 1/3] pcmcia: bfin_cf: remove unnecessary platform_set_drvdata()
@ 2013-08-22 2:16 Jingoo Han
2013-08-22 2:16 ` [PATCH 2/3] pcmcia: pxa2xx: " Jingoo Han
2013-08-22 2:17 ` [PATCH 3/3] pcmcia: sa1100: " Jingoo Han
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-08-22 2:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-pcmcia, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pcmcia/bfin_cf_pcmcia.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pcmcia/bfin_cf_pcmcia.c b/drivers/pcmcia/bfin_cf_pcmcia.c
index ed3b522..624d127 100644
--- a/drivers/pcmcia/bfin_cf_pcmcia.c
+++ b/drivers/pcmcia/bfin_cf_pcmcia.c
@@ -281,7 +281,6 @@ fail2:
fail0:
gpio_free(cf->cd_pfx);
kfree(cf);
- platform_set_drvdata(pdev, NULL);
return status;
}
@@ -296,7 +295,6 @@ static int bfin_cf_remove(struct platform_device *pdev)
del_timer_sync(&cf->timer);
iounmap((void __iomem *)cf->socket.io_offset);
release_mem_region(cf->phys_cf_io, SZ_8K);
- platform_set_drvdata(pdev, NULL);
kfree(cf);
return 0;
}
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/3] pcmcia: pxa2xx: remove unnecessary platform_set_drvdata()
2013-08-22 2:16 [PATCH 1/3] pcmcia: bfin_cf: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-08-22 2:16 ` Jingoo Han
2013-08-22 2:17 ` [PATCH 3/3] pcmcia: sa1100: " Jingoo Han
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-08-22 2:16 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, linux-pcmcia, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pcmcia/pxa2xx_base.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pcmcia/pxa2xx_base.c b/drivers/pcmcia/pxa2xx_base.c
index cfec9dd..480c61a 100644
--- a/drivers/pcmcia/pxa2xx_base.c
+++ b/drivers/pcmcia/pxa2xx_base.c
@@ -343,8 +343,6 @@ static int pxa2xx_drv_pcmcia_remove(struct platform_device *dev)
struct skt_dev_info *sinfo = platform_get_drvdata(dev);
int i;
- platform_set_drvdata(dev, NULL);
-
for (i = 0; i < sinfo->nskt; i++)
soc_pcmcia_remove_one(&sinfo->skt[i]);
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/3] pcmcia: sa1100: remove unnecessary platform_set_drvdata()
2013-08-22 2:16 [PATCH 1/3] pcmcia: bfin_cf: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 2:16 ` [PATCH 2/3] pcmcia: pxa2xx: " Jingoo Han
@ 2013-08-22 2:17 ` Jingoo Han
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-08-22 2:17 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, linux-pcmcia, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pcmcia/sa1100_generic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pcmcia/sa1100_generic.c b/drivers/pcmcia/sa1100_generic.c
index ff8a027..fed68e6 100644
--- a/drivers/pcmcia/sa1100_generic.c
+++ b/drivers/pcmcia/sa1100_generic.c
@@ -88,8 +88,6 @@ static int sa11x0_drv_pcmcia_remove(struct platform_device *dev)
struct skt_dev_info *sinfo = platform_get_drvdata(dev);
int i;
- platform_set_drvdata(dev, NULL);
-
for (i = 0; i < sinfo->nskt; i++)
soc_pcmcia_remove_one(&sinfo->skt[i]);
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-22 2:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-22 2:16 [PATCH 1/3] pcmcia: bfin_cf: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 2:16 ` [PATCH 2/3] pcmcia: pxa2xx: " Jingoo Han
2013-08-22 2:17 ` [PATCH 3/3] pcmcia: sa1100: " Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®