* [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree
@ 2013-03-13 17:18 Doug Anderson
2013-03-14 6:22 ` Vivek Gautam
2013-03-15 1:37 ` Jingoo Han
0 siblings, 2 replies; 6+ messages in thread
From: Doug Anderson @ 2013-03-13 17:18 UTC (permalink / raw)
To: Kukjin Kim, Olof Johansson
Cc: Thomas Abraham, Vivek Gautam, Doug Anderson, Russell King,
Padmavathi Venna, Jingoo Han, Mark Brown, linux-arm-kernel,
linux-kernel
This is a fixup to two device tree nodes that have already landed but
without clock nodes since the transition to common clock happened at
the same time.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 24c52e6..59be603 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -402,12 +402,18 @@
compatible = "samsung,exynos4210-ehci";
reg = <0x12110000 0x100>;
interrupts = <0 71 0>;
+
+ clocks = <&clock 285>;
+ clock-names = "usbhost";
};
usb@12120000 {
compatible = "samsung,exynos4210-ohci";
reg = <0x12120000 0x100>;
interrupts = <0 71 0>;
+
+ clocks = <&clock 285>;
+ clock-names = "usbhost";
};
amba {
--
1.8.1.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree
2013-03-13 17:18 [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree Doug Anderson
@ 2013-03-14 6:22 ` Vivek Gautam
2013-03-14 23:01 ` Doug Anderson
2013-03-15 1:37 ` Jingoo Han
1 sibling, 1 reply; 6+ messages in thread
From: Vivek Gautam @ 2013-03-14 6:22 UTC (permalink / raw)
To: Doug Anderson
Cc: Kukjin Kim, Olof Johansson, Thomas Abraham, Vivek Gautam,
Russell King, Padmavathi Venna, Jingoo Han, Mark Brown,
linux-arm-kernel, linux-kernel
Hi Doug,
On Wed, Mar 13, 2013 at 10:48 PM, Doug Anderson <dianders@chromium.org> wrote:
> This is a fixup to two device tree nodes that have already landed but
> without clock nodes since the transition to common clock happened at
> the same time.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 24c52e6..59be603 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -402,12 +402,18 @@
> compatible = "samsung,exynos4210-ehci";
> reg = <0x12110000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
>
> usb@12120000 {
> compatible = "samsung,exynos4210-ohci";
> reg = <0x12120000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
It will be nice if you can please update relevant information
alongwith this, in the bindings doc for "exynos-usb".
> };
>
> amba {
> --
> 1.8.1.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree
2013-03-14 6:22 ` Vivek Gautam
@ 2013-03-14 23:01 ` Doug Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2013-03-14 23:01 UTC (permalink / raw)
To: Vivek Gautam
Cc: Kukjin Kim, Olof Johansson, Thomas Abraham, Vivek Gautam,
Russell King, Padmavathi Venna, Jingoo Han, Mark Brown,
linux-arm-kernel, linux-kernel
Vivek,
On Wed, Mar 13, 2013 at 11:22 PM, Vivek Gautam
<gautamvivek1987@gmail.com> wrote:
> It will be nice if you can please update relevant information
> alongwith this, in the bindings doc for "exynos-usb".
Sure. It always feels like device tree additions ought to be separate
patches from bindings patches, so I'll just send something separately.
Here it is: <https://patchwork.kernel.org/patch/2274331/>
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree
2013-03-13 17:18 [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree Doug Anderson
2013-03-14 6:22 ` Vivek Gautam
@ 2013-03-15 1:37 ` Jingoo Han
2013-03-18 13:41 ` Vivek Gautam
1 sibling, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2013-03-15 1:37 UTC (permalink / raw)
To: 'Doug Anderson', 'Kukjin Kim', 'Olof Johansson'
Cc: 'Thomas Abraham', 'Vivek Gautam',
'Russell King', 'Padmavathi Venna',
'Mark Brown',
linux-arm-kernel, linux-kernel, 'Jingoo Han'
On Thursday, March 14, 2013 2:18 AM, Doug Anderson wrote:
>
> This is a fixup to two device tree nodes that have already landed but
> without clock nodes since the transition to common clock happened at
> the same time.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
The clock number and name are right.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 24c52e6..59be603 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -402,12 +402,18 @@
> compatible = "samsung,exynos4210-ehci";
> reg = <0x12110000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
>
> usb@12120000 {
> compatible = "samsung,exynos4210-ohci";
> reg = <0x12120000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
>
> amba {
> --
> 1.8.1.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree
2013-03-15 1:37 ` Jingoo Han
@ 2013-03-18 13:41 ` Vivek Gautam
2013-04-03 1:46 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Vivek Gautam @ 2013-03-18 13:41 UTC (permalink / raw)
To: Doug Anderson
Cc: Kukjin Kim, Olof Johansson, Thomas Abraham, Vivek Gautam,
Russell King, Padmavathi Venna, Mark Brown, linux-arm-kernel,
linux-kernel, Jingoo Han
Hi,
On Fri, Mar 15, 2013 at 7:07 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>
> On Thursday, March 14, 2013 2:18 AM, Doug Anderson wrote:
>>
>> This is a fixup to two device tree nodes that have already landed but
>> without clock nodes since the transition to common clock happened at
>> the same time.
>>
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>
> The clock number and name are right.
>
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
>
>
> Best regards,
> Jingoo Han
>
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>> index 24c52e6..59be603 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -402,12 +402,18 @@
>> compatible = "samsung,exynos4210-ehci";
>> reg = <0x12110000 0x100>;
>> interrupts = <0 71 0>;
>> +
>> + clocks = <&clock 285>;
>> + clock-names = "usbhost";
>> };
>>
>> usb@12120000 {
>> compatible = "samsung,exynos4210-ohci";
>> reg = <0x12120000 0x100>;
>> interrupts = <0 71 0>;
>> +
>> + clocks = <&clock 285>;
>> + clock-names = "usbhost";
tested this patch with smdk5250 h/w.
Tested-by: Vivek Gautam <gautam.vivek@samsung.com>
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree
2013-03-18 13:41 ` Vivek Gautam
@ 2013-04-03 1:46 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-04-03 1:46 UTC (permalink / raw)
To: 'Vivek Gautam', 'Doug Anderson'
Cc: 'Olof Johansson', 'Thomas Abraham',
'Vivek Gautam', 'Russell King',
'Padmavathi Venna', 'Mark Brown',
linux-arm-kernel, linux-kernel, 'Jingoo Han'
Vivek Gautam wrote:
>
> Hi,
>
>
> On Fri, Mar 15, 2013 at 7:07 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> >
> > On Thursday, March 14, 2013 2:18 AM, Doug Anderson wrote:
> >>
> >> This is a fixup to two device tree nodes that have already landed but
> >> without clock nodes since the transition to common clock happened at
> >> the same time.
> >>
> >> Signed-off-by: Doug Anderson <dianders@chromium.org>
> >
> > The clock number and name are right.
> >
> > Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> >
> >
> > Best regards,
> > Jingoo Han
> >
> >> ---
> >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> >> index 24c52e6..59be603 100644
> >> --- a/arch/arm/boot/dts/exynos5250.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> >> @@ -402,12 +402,18 @@
> >> compatible = "samsung,exynos4210-ehci";
> >> reg = <0x12110000 0x100>;
> >> interrupts = <0 71 0>;
> >> +
> >> + clocks = <&clock 285>;
> >> + clock-names = "usbhost";
> >> };
> >>
> >> usb@12120000 {
> >> compatible = "samsung,exynos4210-ohci";
> >> reg = <0x12120000 0x100>;
> >> interrupts = <0 71 0>;
> >> +
> >> + clocks = <&clock 285>;
> >> + clock-names = "usbhost";
>
> tested this patch with smdk5250 h/w.
>
> Tested-by: Vivek Gautam <gautam.vivek@samsung.com>
>
Vivek and Jingoo,
Thanks for your review and test.
Looks good to me and I applied in my local.
Just note that this should be seen in my public tree tomorrow night(KST).
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-03 1:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-13 17:18 [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree Doug Anderson
2013-03-14 6:22 ` Vivek Gautam
2013-03-14 23:01 ` Doug Anderson
2013-03-15 1:37 ` Jingoo Han
2013-03-18 13:41 ` Vivek Gautam
2013-04-03 1:46 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome