From: Aleksey Makarov <amakarov.linux@gmail.com>
To: "Jayachandran C." <c.jayachandran@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Aleksey Makarov <aleksey.makarov@linaro.org>,
linux-serial@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>,
Jiri Slaby <jslaby@suse.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"
Date: Thu, 16 Mar 2017 12:31:53 +0300 [thread overview]
Message-ID: <008d062d-1095-5a65-3a69-33bee1f648d7@gmail.com> (raw)
In-Reply-To: <CA+7sy7C6zp3giR+ypFXqbsNY_C3ggUgegS1zEWOAybkRBtCn4w@mail.gmail.com>
On 03/16/2017 10:11 AM, Jayachandran C. wrote:
> Hi Greg,
>
> On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>>
>> On 01/03/17 15:23, Aleksey Makarov wrote:
>>> The original patch makes the condition always true, so it is wrong.
>>>
>>> It masks (but not fixes) the bug described in the commit message
>>> but introduces a regression (no console is selected by SPCR)
>>> in regular (no 'console=ttyAMA') case.
>>>
>>> s/||/&&/ would not fix the problem as the root cause was identified
>>> incorrectly.
>>>
>>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
>>>
>>
>> Sorry for that, I will test your patches and respond to that. For this
>> patch:
>>
>> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>>
>
> This fixes a regression I see in v4.11-rc2
>
> Tested-by: Jayachandran C <jnair@caviumnetworks.com>
>
> I don't see it in the tty/serial tree yet
It's commit 713b93f1b849 from tty-next branch of
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
So it looks like it is scheduled for 4.12
Greg, this is a fix for regression. Can it be applied to 4.11-rcX?
Thank you
Aleksey Makarov
>
> JC.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-03-16 9:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 12:26 [PATCH] " Aleksey Makarov
2017-03-01 12:50 ` [PATCH v2] " Aleksey Makarov
2017-03-01 12:59 ` [PATCH] " Robin Murphy
2017-03-01 13:01 ` Aleksey Makarov
2017-03-01 13:55 ` Robin Murphy
2017-03-01 15:23 ` [PATCH v3] " Aleksey Makarov
2017-03-14 16:14 ` Sudeep Holla
2017-03-16 7:11 ` Jayachandran C.
2017-03-16 9:31 ` Aleksey Makarov [this message]
2017-03-17 5:04 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=008d062d-1095-5a65-3a69-33bee1f648d7@gmail.com \
--to=amakarov.linux@gmail.com \
--cc=aleksey.makarov@linaro.org \
--cc=c.jayachandran@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter@hurleysoftware.com \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome