From: Sudeep Holla <sudeep.holla@arm.com>
To: Aleksey Makarov <aleksey.makarov@linaro.org>,
linux-serial@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Hurley <peter@hurleysoftware.com>,
Russell King <linux@armlinux.org.uk>,
Jiri Slaby <jslaby@suse.com>, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"
Date: Tue, 14 Mar 2017 16:14:04 +0000 [thread overview]
Message-ID: <d1e067f1-e82f-7692-bcc2-e3549887be63@arm.com> (raw)
In-Reply-To: <20170301152304.29635-1-aleksey.makarov@linaro.org>
On 01/03/17 15:23, Aleksey Makarov wrote:
> The original patch makes the condition always true, so it is wrong.
>
> It masks (but not fixes) the bug described in the commit message
> but introduces a regression (no console is selected by SPCR)
> in regular (no 'console=ttyAMA') case.
>
> s/||/&&/ would not fix the problem as the root cause was identified
> incorrectly.
>
> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
>
Sorry for that, I will test your patches and respond to that. For this
patch:
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2017-03-14 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 12:26 [PATCH] " Aleksey Makarov
2017-03-01 12:50 ` [PATCH v2] " Aleksey Makarov
2017-03-01 12:59 ` [PATCH] " Robin Murphy
2017-03-01 13:01 ` Aleksey Makarov
2017-03-01 13:55 ` Robin Murphy
2017-03-01 15:23 ` [PATCH v3] " Aleksey Makarov
2017-03-14 16:14 ` Sudeep Holla [this message]
2017-03-16 7:11 ` Jayachandran C.
2017-03-16 9:31 ` Aleksey Makarov
2017-03-17 5:04 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1e067f1-e82f-7692-bcc2-e3549887be63@arm.com \
--to=sudeep.holla@arm.com \
--cc=aleksey.makarov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter@hurleysoftware.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome