From: Robin Murphy <robin.murphy@arm.com>
To: Aleksey Makarov <aleksey.makarov@linaro.org>,
linux-serial@vger.kernel.org
Cc: Peter Hurley <peter@hurleysoftware.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"
Date: Wed, 1 Mar 2017 12:59:41 +0000 [thread overview]
Message-ID: <af761742-1362-a120-3f54-4cbe92ddbbbb@arm.com> (raw)
In-Reply-To: <20170301122602.30025-1-aleksey.makarov@linaro.org>
On 01/03/17 12:26, Aleksey Makarov wrote:
> The original patch makes condition always true, so it is wrong.
>
> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
It seems fairly clear that the intent of the code merely warrants
s/||/&&/ - wouldn't it be more straightforward to just fix that?
Robin.
> ---
> drivers/tty/serial/amba-pl011.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> index 8789ea423ccf..56f92d7348bf 100644
> --- a/drivers/tty/serial/amba-pl011.c
> +++ b/drivers/tty/serial/amba-pl011.c
> @@ -2373,7 +2373,7 @@ static int __init pl011_console_match(struct console *co, char *name, int idx,
> if (strcmp(name, "qdf2400_e44") == 0) {
> pr_info_once("UART: Working around QDF2400 SoC erratum 44");
> qdf2400_e44_present = true;
> - } else if (strcmp(name, "pl011") != 0 || strcmp(name, "ttyAMA") != 0) {
> + } else if (strcmp(name, "pl011") != 0) {
> return -ENODEV;
> }
>
>
next prev parent reply other threads:[~2017-03-01 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 12:26 Aleksey Makarov
2017-03-01 12:50 ` [PATCH v2] " Aleksey Makarov
2017-03-01 12:59 ` Robin Murphy [this message]
2017-03-01 13:01 ` [PATCH] " Aleksey Makarov
2017-03-01 13:55 ` Robin Murphy
2017-03-01 15:23 ` [PATCH v3] " Aleksey Makarov
2017-03-14 16:14 ` Sudeep Holla
2017-03-16 7:11 ` Jayachandran C.
2017-03-16 9:31 ` Aleksey Makarov
2017-03-17 5:04 ` Greg Kroah-Hartman
2017-03-16 16:51 [PATCH] " Mark Salter
2017-03-16 17:28 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af761742-1362-a120-3f54-4cbe92ddbbbb@arm.com \
--to=robin.murphy@arm.com \
--cc=aleksey.makarov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter@hurleysoftware.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®