From: Daniel Phillips <phillips@bonn-fries.net>
To: Alexander Viro <viro@math.psu.edu>,
Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH] parser for mount options
Date: Tue, 7 Aug 2001 20:06:54 +0200 [thread overview]
Message-ID: <0108072006540A.02365@starship> (raw)
In-Reply-To: <Pine.GSO.4.21.0108071227080.18565-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0108071227080.18565-100000@weyl.math.psu.edu>
On Tuesday 07 August 2001 19:02, Alexander Viro wrote:
> OK, folks - here's an implementation of parser for mount options.
> Patch contains parser itself (lib/parser.c, include/linux/parser.h)
> and switches parse_options() in several filesystems to using it
> instead of the current ad-hackery.
> [...]
> It works surprisingly well - syntax is immediately visible in
> the table, code is not crapped with tons of global variables and
> parser itself is not large.
It's a big improvement.
> Patch applies clean at least to -pre4 and -pre5. Comments,
> suggestions and flames are welcome.
Can't think of anything to flame about, so how about a comment: strtok
is evil. Even strtok_r sucks somewhat for destroying the input string
but strtok is far worse for keeping internal static state. This would
be a good opportunity to add strtok_r to the library and use it.
--
Daniel
next prev parent reply other threads:[~2001-08-07 18:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-07 17:02 Alexander Viro
2001-08-07 18:06 ` Daniel Phillips [this message]
2001-08-07 18:12 ` Christoph Hellwig
2001-08-07 21:54 ` Pavel Machek
2001-08-07 22:48 ` Alexander Viro
2001-08-09 6:20 ` Albert D. Cahalan
2001-08-07 21:51 Andries.Brouwer
2001-08-07 22:02 ` Andreas Dilger
2001-08-07 22:40 ` Alexander Viro
2001-08-07 23:52 Andries.Brouwer
2001-08-08 1:14 ` Alexander Viro
2001-08-08 11:38 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0108072006540A.02365@starship \
--to=phillips@bonn-fries.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®