Re: [RFC][PATCH] parser for mount options

[Pavel Machek <pavel@suse.cz>]

Hi!

> 	Patch applies clean at least to -pre4 and -pre5.  Comments,
> suggestions and flames are welcome.  I hope that it got enough
> filesystems converted to be representative - adfs, autofs, devpts,
> ext2, fat and isofs.

fat and isofs have pretty ugly set of options:

nodots and dotsOK=no are same thing (oops, you've bug there). It would
be nice to have just one name for each function. No need to do
second-guessing in kernel.

> +static match_table_t FAT_tokens = {
> +	{Opt_check_r, "check=relaxed"},
> +	{Opt_check_s, "check=strict"},
> +	{Opt_check_n, "check=normal"},
> +	{Opt_check_r, "check=r"},
> +	{Opt_check_s, "check=s"},
> +	{Opt_check_n, "check=n"},
> +	{Opt_conv_b, "conv=binary"},
> +	{Opt_conv_t, "conv=text"},
> +	{Opt_conv_a, "conv=auto"},
> +	{Opt_conv_b, "conv=b"},
> +	{Opt_conv_t, "conv=t"},
> +	{Opt_conv_a, "conv=a"},
> +	{Opt_dots, "dots"},
> +	{Opt_dots, "dotsOK=yes"},
> +	{Opt_nodots, "nodots"},
> +	{Opt_dots, "dotsOK=no"},
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

here's bug, btw.

								Pavel
-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org