mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@turbolinux.com>
To: Andries.Brouwer@cwi.nl
Cc: torvalds@transmeta.com, viro@math.psu.edu,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] parser for mount options
Date: Tue, 7 Aug 2001 16:02:44 -0600 (MDT)	[thread overview]
Message-ID: <200108072202.f77M2ikt017668@webber.adilger.int> (raw)
In-Reply-To: <200108072151.VAA25091@vlet.cwi.nl> "from Andries.Brouwer@cwi.nl at Aug 7, 2001 09:51:06 pm"

Andreis writes:
> I did the same for 1.3.61 long ago. A fragment:
> with call for each filesystem
> 
> 	parse_mount_options((char *) data, SIZE(opts), opts);
> 
> I am not sure which of the two versions I prefer.
> For example, the above setup shows very clearly what the defaults are.

What else is nice about this variant is that you don't need to change
the prototype for parse_options() each time you add a new parameter,
you only pass the "opts" struct around.

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert


  reply	other threads:[~2001-08-07 22:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-07 21:51 Andries.Brouwer
2001-08-07 22:02 ` Andreas Dilger [this message]
2001-08-07 22:40 ` Alexander Viro
  -- strict thread matches above, loose matches on Subject: below --
2001-08-08 11:38 Andries.Brouwer
2001-08-07 23:52 Andries.Brouwer
2001-08-08  1:14 ` Alexander Viro
2001-08-07 17:02 Alexander Viro
2001-08-07 18:06 ` Daniel Phillips
2001-08-07 18:12   ` Christoph Hellwig
2001-08-07 21:54 ` Pavel Machek
2001-08-07 22:48   ` Alexander Viro
2001-08-09  6:20 ` Albert D. Cahalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200108072202.f77M2ikt017668@webber.adilger.int \
    --to=adilger@turbolinux.com \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®