From: "Songwei.Chai" <songwei.chai@oss.qualcomm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
andersson@kernel.org, alexander.shishkin@linux.intel.com,
mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com,
james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
songchai@qti.qualcomm.com
Subject: Re: [PATCH v17 02/10] coresight: Move CS_LOCK/CS_UNLOCK to linux/coresight.h
Date: Mon, 16 Nov 2026 14:52:56 +0800 [thread overview]
Message-ID: <01333b29-8739-4791-9339-45a66811fc51@oss.qualcomm.com> (raw)
In-Reply-To: <2246263b-a872-4a65-803d-ef1e031522f9@arm.com>
On 11/13/2026 6:25 PM, Suzuki K Poulose wrote:
> On 13/11/2026 02:49, Songwei Chai wrote:
>> CORESIGHT_LAR and the CS_LOCK()/CS_UNLOCK() helpers implement the
>> generic ARM CoreSight Software Lock Access Register sequence, which
>> is also present on non-CoreSight-labelled components that follow the
>> same architecture (e.g. the Qualcomm TGU). Keeping them private to
>> coresight-priv.h forces such drivers to duplicate the exact same
>> definitions instead of reusing them.
>>
>> Move CORESIGHT_LAR, CS_LOCK() and CS_UNLOCK() into the public
>> include/linux/coresight.h so they can be shared outside of
>> drivers/hwtracing/coresight/ as well.
>>
>> Suggested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>> Signed-off-by: Songwei Chai <songwei.chai@oss.qualcomm.com>
>> ---
>> drivers/hwtracing/coresight/coresight-priv.h | 19 -------------------
>> include/linux/coresight.h | 19 +++++++++++++++++++
>> 2 files changed, 19 insertions(+), 19 deletions(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-priv.h
>> b/drivers/hwtracing/coresight/coresight-priv.h
>> index dddac946659f..0d3f6229b282 100644
>> --- a/drivers/hwtracing/coresight/coresight-priv.h
>> +++ b/drivers/hwtracing/coresight/coresight-priv.h
>> @@ -23,7 +23,6 @@ extern const struct device_type coresight_dev_type[];
>> #define CORESIGHT_ITCTRL 0xf00
>> #define CORESIGHT_CLAIMSET 0xfa0
>> #define CORESIGHT_CLAIMCLR 0xfa4
>> -#define CORESIGHT_LAR 0xfb0
>> #define CORESIGHT_LSR 0xfb4
>> #define CORESIGHT_DEVARCH 0xfbc
>> #define CORESIGHT_AUTHSTATUS 0xfb8
>
> Move all of these register defs above to linux/coresight.h. We can keep
> them in a central place, in linux/coresight.h and drop patch 3
Confirmed.
>
> Suzuki
next prev parent reply other threads:[~2026-11-16 6:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 2:49 [PATCH v17 00/10] Provide support for Trigger Generation Unit Songwei Chai
2026-11-13 2:49 ` [PATCH v17 01/10] dt-bindings: arm: Add support for Qualcomm TGU trace Songwei Chai
2026-11-13 2:49 ` [PATCH v17 02/10] coresight: Move CS_LOCK/CS_UNLOCK to linux/coresight.h Songwei Chai
2026-11-13 10:25 ` Suzuki K Poulose
2026-11-16 6:52 ` Songwei.Chai [this message]
2026-11-13 2:49 ` [PATCH v17 03/10] qcom-tgu: Add TGU driver Songwei Chai
2026-11-13 10:34 ` Suzuki K Poulose
2026-11-16 6:53 ` Songwei.Chai
2026-11-13 2:49 ` [PATCH v17 04/10] coresight: Move CORESIGHT_DEVID to linux/coresight.h Songwei Chai
2026-11-13 2:49 ` [PATCH v17 05/10] qcom-tgu: Add signal priority support Songwei Chai
2026-11-13 2:49 ` [PATCH v17 06/10] qcom-tgu: Add TGU decode support Songwei Chai
2026-11-13 2:49 ` [PATCH v17 07/10] qcom-tgu: Add support to configure next action Songwei Chai
2026-11-13 2:49 ` [PATCH v17 08/10] coresight: Add CORESIGHT_DEVID2 to linux/coresight.h Songwei Chai
2026-11-13 10:27 ` Suzuki K Poulose
2026-11-16 6:54 ` Songwei.Chai
2026-11-13 2:49 ` [PATCH v17 09/10] qcom-tgu: Add timer/counter functionality for TGU Songwei Chai
2026-11-13 2:49 ` [PATCH v17 10/10] qcom-tgu: Add reset node to initialize Songwei Chai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01333b29-8739-4791-9339-45a66811fc51@oss.qualcomm.com \
--to=songwei.chai@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@arm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=songchai@qti.qualcomm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®