From: "Songwei.Chai" <songwei.chai@oss.qualcomm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
andersson@kernel.org, alexander.shishkin@linux.intel.com,
mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com,
james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
songchai@qti.qualcomm.com
Subject: Re: [PATCH v17 08/10] coresight: Add CORESIGHT_DEVID2 to linux/coresight.h
Date: Mon, 16 Nov 2026 14:54:59 +0800 [thread overview]
Message-ID: <c3da00ab-913b-48ee-8af1-eaef26548b4e@oss.qualcomm.com> (raw)
In-Reply-To: <9a479160-5bab-42f8-bf50-7b92c40b39c0@arm.com>
On 11/13/2026 6:27 PM, Suzuki K Poulose wrote:
> On 13/11/2026 02:49, Songwei Chai wrote:
>> CORESIGHT_DEVID2 lives at a fixed, architecturally-defined offset
>> (0xfc0) within the generic CoreSight management register block,
>> immediately preceding CORESIGHT_DEVID (0xfc8). Components outside
>> drivers/hwtracing/coresight/ that follow the same register convention
>> (e.g. the Qualcomm TGU, which uses it to detect its timer/counter
>> capabilities) need to read it too.
>>
>> Add it to the public include/linux/coresight.h so it can be shared
>> outside of drivers/hwtracing/coresight/, matching CORESIGHT_LAR and
>> CORESIGHT_DEVID already moved there.
>>
>> Signed-off-by: Songwei Chai <songwei.chai@oss.qualcomm.com>
>> ---
>> include/linux/coresight.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
>> index 5286b3606581..7ce0366c7c70 100644
>> --- a/include/linux/coresight.h
>> +++ b/include/linux/coresight.h
>> @@ -37,6 +37,7 @@
>> #define CORESIGHT_UNLOCK 0xc5acce55
>> #define CORESIGHT_LAR 0xfb0
>> #define CORESIGHT_DEVID 0xfc8
>> +#define CORESIGHT_DEVID2 0xfc0
>> static inline void CS_LOCK(void __iomem *addr)
>> {
>
>
> Merge it with Patch 1 please.
Moved Patch04 & Patch08 to Patch02
>
> Suzuki
next prev parent reply other threads:[~2026-11-16 6:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 2:49 [PATCH v17 00/10] Provide support for Trigger Generation Unit Songwei Chai
2026-11-13 2:49 ` [PATCH v17 01/10] dt-bindings: arm: Add support for Qualcomm TGU trace Songwei Chai
2026-11-13 2:49 ` [PATCH v17 02/10] coresight: Move CS_LOCK/CS_UNLOCK to linux/coresight.h Songwei Chai
2026-11-13 10:25 ` Suzuki K Poulose
2026-11-16 6:52 ` Songwei.Chai
2026-11-13 2:49 ` [PATCH v17 03/10] qcom-tgu: Add TGU driver Songwei Chai
2026-11-13 10:34 ` Suzuki K Poulose
2026-11-16 6:53 ` Songwei.Chai
2026-11-13 2:49 ` [PATCH v17 04/10] coresight: Move CORESIGHT_DEVID to linux/coresight.h Songwei Chai
2026-11-13 2:49 ` [PATCH v17 05/10] qcom-tgu: Add signal priority support Songwei Chai
2026-11-13 2:49 ` [PATCH v17 06/10] qcom-tgu: Add TGU decode support Songwei Chai
2026-11-13 2:49 ` [PATCH v17 07/10] qcom-tgu: Add support to configure next action Songwei Chai
2026-11-13 2:49 ` [PATCH v17 08/10] coresight: Add CORESIGHT_DEVID2 to linux/coresight.h Songwei Chai
2026-11-13 10:27 ` Suzuki K Poulose
2026-11-16 6:54 ` Songwei.Chai [this message]
2026-11-13 2:49 ` [PATCH v17 09/10] qcom-tgu: Add timer/counter functionality for TGU Songwei Chai
2026-11-13 2:49 ` [PATCH v17 10/10] qcom-tgu: Add reset node to initialize Songwei Chai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3da00ab-913b-48ee-8af1-eaef26548b4e@oss.qualcomm.com \
--to=songwei.chai@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@arm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=songchai@qti.qualcomm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®