From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
Abel Vesa <abelvesa@kernel.org>,
Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Joonhoe Kim <26rote@gmail.com>
Subject: Re: [PATCH v5 1/3] dt-bindings: display: msm: Add INT2 GDSC to Kaanapali DPU
Date: Thu, 12 Nov 2026 15:13:21 +0800 [thread overview]
Message-ID: <01f33d97-ce2f-4cf9-8672-63effc90fbe5@oss.qualcomm.com> (raw)
In-Reply-To: <20261109-mammoth-of-delightful-potency-b1ede2@quoll>
On 11/9/2026 8:25 PM, Krzysztof Kozlowski wrote:
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: qcom,kaanapali-dpu
>> + required:
>> + - compatible
> Droo required
>
Got it. Will drop it.
>> + then:
>> + properties:
>> + power-domains:
>> + minItems: 2
>> +
>> + power-domain-names:
>> + minItems: 2
> How did you resolve my previous comment?
>
Will drop in next version.
>> + power-domain-names:
>> + minItems: 2
I moved the items: list to the top level in v5. Only the minItems: was
left, which is pointless anyway since items: already fixes the length,
so it's gone in v6.
>> +
>> + required:
>> + - power-domain-names
> Why adding this?
items: only checks the value if the property is present, it doesn't make
it mandatory. The driver looks the domains up by name, so a Kaanapali DT
without the names would pass the schema but fail to probe.
next prev parent reply other threads:[~2026-11-12 7:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 8:36 [PATCH v5 0/3] drm/msm/dpu: Add INT2 GDSC power domain support for Kaanapali Yongxing Mou
2026-11-09 8:36 ` [PATCH v5 1/3] dt-bindings: display: msm: Add INT2 GDSC to Kaanapali DPU Yongxing Mou
2026-11-09 12:25 ` Krzysztof Kozlowski
2026-11-12 3:01 ` Yongxing Mou
2026-11-12 7:13 ` Yongxing Mou [this message]
2026-11-09 8:36 ` [PATCH v5 2/3] drm/msm/dpu: Attach CORE and INT2 power domains on Kaanapali Yongxing Mou
2026-11-09 12:26 ` Krzysztof Kozlowski
2026-11-12 3:02 ` Yongxing Mou
2026-11-09 8:36 ` [PATCH v5 3/3] arm64: dts: qcom: Add INT2 GDSC to Kaanapali DPU Yongxing Mou
2026-11-11 15:42 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f33d97-ce2f-4cf9-8672-63effc90fbe5@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=26rote@gmail.com \
--cc=abelvesa@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_mkrishn@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=yuanjie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®