From: "Gilad Benjamini" <gilad@altornetworks.com>
To: "'Davide Libenzi'" <davidel@xmailserver.org>
Cc: "'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>
Subject: RE: epoll and closed file descriptors
Date: Wed, 16 Sep 2009 17:40:49 -0700 [thread overview]
Message-ID: <024701ca372f$81412040$83c360c0$@com> (raw)
In-Reply-To: <alpine.DEB.2.00.0909161726090.3124@makko.or.mcafeemobile.com>
Davide wrote:
> On Wed, 16 Sep 2009, Gilad Benjamini wrote:
>
> > I would, but epoll is preventing me from doing so.
> > Early in sys_epoll_ctl there are these lines
> >
> > file = fget(epfd);
> > if (!file)
> > goto error_return;
> >
> > Leaving me in a kind of dead lock
>
> The 'epfd' in there, is the _epoll fd_, which, if fget() fails, means
> you
> close it.
> You see likely failing the 'tfile = fget(fd)' (of course, you closed
> it),
> so if someone else keeps the socket open and you have no chance in
> telling
> it to drop it (really?), you need to remove the socket from the set
> before
> closing it.
>
>
>
> - Davide
My bad. I meant to quote the line that you mentioned.
I agree that the right thing to do is to remove the fd from epoll before
closing it.
However, due to the way curl works, I cannot do that. Changing the curl code
doesn't seem trivial.
Regardless, I still don't see how the kernel got into this situation, and if
this situation is valid, why it doesn't bail out of it.
next prev parent reply other threads:[~2009-09-17 0:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 23:22 Gilad Benjamini
2009-09-17 0:07 ` Davide Libenzi
2009-09-17 0:23 ` Gilad Benjamini
2009-09-17 0:28 ` Bryan Donlan
2009-09-17 0:30 ` Davide Libenzi
2009-09-17 0:40 ` Gilad Benjamini [this message]
2009-09-17 0:45 ` Bryan Donlan
2009-09-17 0:53 ` Gilad Benjamini
2009-09-17 0:57 ` Bryan Donlan
2009-09-17 0:55 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='024701ca372f$81412040$83c360c0$@com' \
--to=gilad@altornetworks.com \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®