* Re: [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry
2026-09-02 5:06 [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry Aboorva Devarajan
@ 2026-09-02 5:31 ` Mukesh Kumar Chaurasiya
2026-09-02 17:45 ` Aboorva Devarajan
2026-09-02 5:36 ` Christophe Leroy (CS GROUP)
2026-09-02 7:07 ` Shrikanth Hegde
2 siblings, 1 reply; 8+ messages in thread
From: Mukesh Kumar Chaurasiya @ 2026-09-02 5:31 UTC (permalink / raw)
To: Aboorva Devarajan
Cc: Madhavan Srinivasan, linuxppc-dev, Mukesh Kumar Chaurasiya,
Christophe Leroy, Shrikanth Hegde, linux-kernel, Ritesh Harjani
On Wed, Sep 02, 2026 at 10:36:28AM +0530, Aboorva Devarajan wrote:
> Since the switch to generic entry, an interrupt taken from user mode
> accounts user time twice: once in arch_interrupt_enter_prepare() and
> again in arch_enter_from_user_mode(), which irqentry_enter() invokes
> for the same interrupt:
>
> arch_interrupt_enter_prepare()
> account_cpu_user_entry()
> irqentry_enter()
> arch_enter_from_user_mode()
> account_cpu_user_entry()
>
> account_cpu_user_entry() accumulates the time spent in user mode
> since the last return to user space, so the second call charges the
> same interval again.
>
> With CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y this roughly doubles the
> reported user time of any workload that takes interrupts. On a
> pseries LPAR, ps/top show ~200% CPU for a single-threaded CPU-bound
> loop, and time(1) reports user time about twice the elapsed time.
>
> Remove the accounting from arch_interrupt_enter_prepare() and rely on
> arch_enter_from_user_mode(), which runs for both syscalls and
> interrupts. The duplicate account_stolen_time() call is removed the
> same way.
>
> Fixes: bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature")
> Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> ---
> Verified on a pseries LPAR (CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y),
> 7.3.0-rc1, single-threaded CPU-bound loop:
>
> Before:
>
> $ python3 -c 'while True: pass' &
> $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> PID ELAPSED TIME %CPU
> 4980 00:03 00:00:06 210
>
> After:
>
> $ python3 -c 'while True: pass' &
> $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> PID ELAPSED TIME %CPU
> 4951 00:03 00:00:03 105
>
> arch/powerpc/include/asm/entry-common.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/entry-common.h b/arch/powerpc/include/asm/entry-common.h
> index c5adb5006361..984294e62568 100644
> --- a/arch/powerpc/include/asm/entry-common.h
> +++ b/arch/powerpc/include/asm/entry-common.h
> @@ -222,8 +222,6 @@ static inline void arch_interrupt_enter_prepare(struct pt_regs *regs)
>
> if (user_mode(regs)) {
> kuap_lock();
> - account_cpu_user_entry();
> - account_stolen_time();
Yeah, that's dual accounting the time.
Thanks for the fix.
> } else {
> kuap_save_and_lock(regs);
> /*
> @@ -426,6 +424,10 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs)
> #endif
> kuap_assert_locked();
> booke_restore_dbcr0();
> + /*
> + * User and stolen time is accounted here for every entry from
> + * user mode. The interrupt prepare hooks must not account again.
> + */
I think this comment is very specific to the current problem. We already
have a commit history to explain this, I guess we can remove this
comment.
With that,
Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
Thanks,
Mukesh
> account_cpu_user_entry();
> account_stolen_time();
>
>
> base-commit: fb442a6673ff1046bf67754957d95880fdb394b5
> --
> 2.54.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry
2026-09-02 5:31 ` Mukesh Kumar Chaurasiya
@ 2026-09-02 17:45 ` Aboorva Devarajan
0 siblings, 0 replies; 8+ messages in thread
From: Aboorva Devarajan @ 2026-09-02 17:45 UTC (permalink / raw)
To: Mukesh Kumar Chaurasiya
Cc: Madhavan Srinivasan, linuxppc-dev, Mukesh Kumar Chaurasiya,
Christophe Leroy, Shrikanth Hegde, linux-kernel, Ritesh Harjani
On Wed, 2026-09-02 at 11:01 +0530, Mukesh Kumar Chaurasiya wrote:
Hi Mukesh,
> On Wed, Sep 02, 2026 at 10:36:28AM +0530, Aboorva Devarajan wrote:
> > Since the switch to generic entry, an interrupt taken from user mode
> > accounts user time twice: once in arch_interrupt_enter_prepare() and
> > again in arch_enter_from_user_mode(), which irqentry_enter() invokes
> > for the same interrupt:
> >
> > arch_interrupt_enter_prepare()
> > account_cpu_user_entry()
> > irqentry_enter()
> > arch_enter_from_user_mode()
> > account_cpu_user_entry()
> >
> > account_cpu_user_entry() accumulates the time spent in user mode
> > since the last return to user space, so the second call charges the
> > same interval again.
> >
> > With CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y this roughly doubles the
> > reported user time of any workload that takes interrupts. On a
> > pseries LPAR, ps/top show ~200% CPU for a single-threaded CPU-bound
> > loop, and time(1) reports user time about twice the elapsed time.
> >
> > Remove the accounting from arch_interrupt_enter_prepare() and rely on
> > arch_enter_from_user_mode(), which runs for both syscalls and
> > interrupts. The duplicate account_stolen_time() call is removed the
> > same way.
> >
> > Fixes: bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature")
> > Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> > ---
> > Verified on a pseries LPAR (CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y),
> > 7.3.0-rc1, single-threaded CPU-bound loop:
> >
> > Before:
> >
> > $ python3 -c 'while True: pass' &
> > $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> > PID ELAPSED TIME %CPU
> > 4980 00:03 00:00:06 210
> >
> > After:
> >
> > $ python3 -c 'while True: pass' &
> > $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> > PID ELAPSED TIME %CPU
> > 4951 00:03 00:00:03 105
> >
> > arch/powerpc/include/asm/entry-common.h | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/include/asm/entry-common.h b/arch/powerpc/include/asm/entry-common.h
> > index c5adb5006361..984294e62568 100644
> > --- a/arch/powerpc/include/asm/entry-common.h
> > +++ b/arch/powerpc/include/asm/entry-common.h
> > @@ -222,8 +222,6 @@ static inline void arch_interrupt_enter_prepare(struct pt_regs *regs)
> >
> > if (user_mode(regs)) {
> > kuap_lock();
> > - account_cpu_user_entry();
> > - account_stolen_time();
> Yeah, that's dual accounting the time.
>
> Thanks for the fix.
> > } else {
> > kuap_save_and_lock(regs);
> > /*
> > @@ -426,6 +424,10 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs)
> > #endif
> > kuap_assert_locked();
> > booke_restore_dbcr0();
> > + /*
> > + * User and stolen time is accounted here for every entry from
> > + * user mode. The interrupt prepare hooks must not account again.
> > + */
> I think this comment is very specific to the current problem. We already
> have a commit history to explain this, I guess we can remove this
> comment.
Agreed, I will drop it in v2.
>
> With that,
>
> Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
Thanks.
>
> Thanks,
> Mukesh
> > account_cpu_user_entry();
> > account_stolen_time();
> >
> >
> > base-commit: fb442a6673ff1046bf67754957d95880fdb394b5
> > --
> > 2.54.0
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry
2026-09-02 5:06 [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry Aboorva Devarajan
2026-09-02 5:31 ` Mukesh Kumar Chaurasiya
@ 2026-09-02 5:36 ` Christophe Leroy (CS GROUP)
2026-09-02 19:44 ` Aboorva Devarajan
2026-09-02 7:07 ` Shrikanth Hegde
2 siblings, 1 reply; 8+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-09-02 5:36 UTC (permalink / raw)
To: Aboorva Devarajan, Madhavan Srinivasan, linuxppc-dev,
Mukesh Kumar Chaurasiya
Cc: Shrikanth Hegde, linux-kernel, Ritesh Harjani
Le 02/09/2026 à 07:06, Aboorva Devarajan a écrit :
> Since the switch to generic entry, an interrupt taken from user mode
> accounts user time twice: once in arch_interrupt_enter_prepare() and
> again in arch_enter_from_user_mode(), which irqentry_enter() invokes
> for the same interrupt:
>
> arch_interrupt_enter_prepare()
> account_cpu_user_entry()
> irqentry_enter()
> arch_enter_from_user_mode()
> account_cpu_user_entry()
>
> account_cpu_user_entry() accumulates the time spent in user mode
> since the last return to user space, so the second call charges the
> same interval again.
One of them was added by commit 09a9d3a8499d ("powerpc: introduce
arch_enter_from_user_mode"), the other one by commit 893082ac769b
("powerpc: Prepare for IRQ entry exit"). Would be good to mention it and
explain how it went wrong.
>
> With CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y this roughly doubles the
> reported user time of any workload that takes interrupts. On a
> pseries LPAR, ps/top show ~200% CPU for a single-threaded CPU-bound
> loop, and time(1) reports user time about twice the elapsed time.
>
> Remove the accounting from arch_interrupt_enter_prepare() and rely on
> arch_enter_from_user_mode(), which runs for both syscalls and
> interrupts. The duplicate account_stolen_time() call is removed the
> same way.
>
> Fixes: bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature")
Not sure it is the correct commit. Should probably be one of the ones
that introduced the wrong call.
> Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> ---
> Verified on a pseries LPAR (CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y),
> 7.3.0-rc1, single-threaded CPU-bound loop:
>
> Before:
>
> $ python3 -c 'while True: pass' &
> $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> PID ELAPSED TIME %CPU
> 4980 00:03 00:00:06 210
>
> After:
>
> $ python3 -c 'while True: pass' &
> $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> PID ELAPSED TIME %CPU
> 4951 00:03 00:00:03 105
>
> arch/powerpc/include/asm/entry-common.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/entry-common.h b/arch/powerpc/include/asm/entry-common.h
> index c5adb5006361..984294e62568 100644
> --- a/arch/powerpc/include/asm/entry-common.h
> +++ b/arch/powerpc/include/asm/entry-common.h
> @@ -222,8 +222,6 @@ static inline void arch_interrupt_enter_prepare(struct pt_regs *regs)
>
> if (user_mode(regs)) {
> kuap_lock();
> - account_cpu_user_entry();
> - account_stolen_time();
> } else {
> kuap_save_and_lock(regs);
> /*
> @@ -426,6 +424,10 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs)
> #endif
> kuap_assert_locked();
> booke_restore_dbcr0();
> + /*
> + * User and stolen time is accounted here for every entry from
> + * user mode. The interrupt prepare hooks must not account again.
> + */
Don't polute the code with such a comment. This is to be explained in
the commit message. First a comment shall tell what code does, not what
it doesn't do. And the comment has no added value, when you see
account_cpu_user_entry() is called you already know that.
Here you feel the need to add such comment, but if you had implemented
this function yourself and done it right at the first time, would you
have felt the need for this comment ?
Have a look at https://docs.kernel.org/process/coding-style.html#commenting
> account_cpu_user_entry();
> account_stolen_time();
>
>
> base-commit: fb442a6673ff1046bf67754957d95880fdb394b5
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry
2026-09-02 5:36 ` Christophe Leroy (CS GROUP)
@ 2026-09-02 19:44 ` Aboorva Devarajan
2026-09-03 4:51 ` Christophe Leroy (CS GROUP)
0 siblings, 1 reply; 8+ messages in thread
From: Aboorva Devarajan @ 2026-09-02 19:44 UTC (permalink / raw)
To: Christophe Leroy (CS GROUP), Mukesh Kumar Chaurasiya
Cc: Shrikanth Hegde, linux-kernel, Ritesh Harjani, aboorvad,
Madhavan Srinivasan, linuxppc-dev
On Wed, 2026-09-02 at 07:36 +0200, Christophe Leroy (CS GROUP) wrote:
>
>
Hi Christophe,
Thanks for reviewing the patch.
> Le 02/09/2026 à 07:06, Aboorva Devarajan a écrit :
> > Since the switch to generic entry, an interrupt taken from user mode
> > accounts user time twice: once in arch_interrupt_enter_prepare() and
> > again in arch_enter_from_user_mode(), which irqentry_enter() invokes
> > for the same interrupt:
> >
> > arch_interrupt_enter_prepare()
> > account_cpu_user_entry()
> > irqentry_enter()
> > arch_enter_from_user_mode()
> > account_cpu_user_entry()
> >
> > account_cpu_user_entry() accumulates the time spent in user mode
> > since the last return to user space, so the second call charges the
> > same interval again.
>
> One of them was added by commit 09a9d3a8499d ("powerpc: introduce
> arch_enter_from_user_mode"), the other one by commit 893082ac769b
> ("powerpc: Prepare for IRQ entry exit").
>
> Would be good to mention it and explain how it went wrong.
>
Sure, I'll explain this in the commit message.
>
> >
> > With CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y this roughly doubles the
> > reported user time of any workload that takes interrupts. On a
> > pseries LPAR, ps/top show ~200% CPU for a single-threaded CPU-bound
> > loop, and time(1) reports user time about twice the elapsed time.
> >
> > Remove the accounting from arch_interrupt_enter_prepare() and rely on
> > arch_enter_from_user_mode(), which runs for both syscalls and
> > interrupts. The duplicate account_stolen_time() call is removed the
> > same way.
> >
> > Fixes: bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature")
>
> Not sure it is the correct commit. Should probably be one of the ones
> that introduced the wrong call.
The history is as follows:
Commit 09a9d3a8499d ("powerpc: introduce arch_enter_from_user_mode")
introduced the arch_enter_from_user_mode() function with the accounting,
but the function was not called at that point. Commit 893082ac769b
("powerpc: Prepare for IRQ entry exit") introduced arch_interrupt_enter_prepare()
and copied the accounting from interrupt_enter_prepare() into it, but the
new helper was not used either. Both changes were preparatory and did not
change the accounting behavior.
Commit bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature") made both paths
active. The syscall path removed its open-coded account_cpu_user_entry() and
started accounting through arch_enter_from_user_mode(). But the interrupt path
started using arch_interrupt_enter_prepare() followed by irqentry_enter(),
which also invokes arch_enter_from_user_mode(), while the accounting in
arch_interrupt_enter_prepare() remained. This resulted in the same user-time
interval being accounted twice for interrupts taken from user mode.
I used bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature") as the Fixes
tag because 893082ac769b only introduced the accounting call while
arch_interrupt_enter_prepare() was unused. bee25f97ad24 is where the duplicate
accounting actually became functional.
Would it be ok to keep bee25f97ad24 as the Fixes tag? Please let me know if
you think 893082ac769b would be more appropriate.
>
> > Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> > ---
> > Verified on a pseries LPAR (CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y),
> > 7.3.0-rc1, single-threaded CPU-bound loop:
> >
> > Before:
> >
> > $ python3 -c 'while True: pass' &
> > $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> > PID ELAPSED TIME %CPU
> > 4980 00:03 00:00:06 210
> >
> > After:
> >
> > $ python3 -c 'while True: pass' &
> > $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> > PID ELAPSED TIME %CPU
> > 4951 00:03 00:00:03 105
> >
> > arch/powerpc/include/asm/entry-common.h | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/include/asm/entry-common.h b/arch/powerpc/include/asm/entry-common.h
> > index c5adb5006361..984294e62568 100644
> > --- a/arch/powerpc/include/asm/entry-common.h
> > +++ b/arch/powerpc/include/asm/entry-common.h
> > @@ -222,8 +222,6 @@ static inline void arch_interrupt_enter_prepare(struct pt_regs *regs)
> >
> > if (user_mode(regs)) {
> > kuap_lock();
> > - account_cpu_user_entry();
> > - account_stolen_time();
> > } else {
> > kuap_save_and_lock(regs);
> > /*
> > @@ -426,6 +424,10 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs)
> > #endif
> > kuap_assert_locked();
> > booke_restore_dbcr0();
> > + /*
> > + * User and stolen time is accounted here for every entry from
> > + * user mode. The interrupt prepare hooks must not account again.
> > + */
>
> Don't polute the code with such a comment. This is to be explained in
> the commit message. First a comment shall tell what code does, not what
> it doesn't do. And the comment has no added value, when you see
> account_cpu_user_entry() is called you already know that.
>
> Here you feel the need to add such comment, but if you had implemented
> this function yourself and done it right at the first time, would you
> have felt the need for this comment ?
>
> Have a look at https://docs.kernel.org/process/coding-style.html#commenting
Agreed, thanks for pointing this out. I'll drop the comment in v2.
> > account_cpu_user_entry();
> > account_stolen_time();
> >
> >
> > base-commit: fb442a6673ff1046bf67754957d95880fdb394b5
Regards,
Aboorva
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry
2026-09-02 19:44 ` Aboorva Devarajan
@ 2026-09-03 4:51 ` Christophe Leroy (CS GROUP)
0 siblings, 0 replies; 8+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-09-03 4:51 UTC (permalink / raw)
To: Aboorva Devarajan, Mukesh Kumar Chaurasiya
Cc: Shrikanth Hegde, linux-kernel, Ritesh Harjani,
Madhavan Srinivasan, linuxppc-dev
Hi Aboorva,
Le 02/09/2026 à 21:44, Aboorva Devarajan a écrit :
>
> The history is as follows:
>
> Commit 09a9d3a8499d ("powerpc: introduce arch_enter_from_user_mode")
> introduced the arch_enter_from_user_mode() function with the accounting,
> but the function was not called at that point. Commit 893082ac769b
> ("powerpc: Prepare for IRQ entry exit") introduced arch_interrupt_enter_prepare()
> and copied the accounting from interrupt_enter_prepare() into it, but the
> new helper was not used either. Both changes were preparatory and did not
> change the accounting behavior.
>
> Commit bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature") made both paths
> active. The syscall path removed its open-coded account_cpu_user_entry() and
> started accounting through arch_enter_from_user_mode(). But the interrupt path
> started using arch_interrupt_enter_prepare() followed by irqentry_enter(),
> which also invokes arch_enter_from_user_mode(), while the accounting in
> arch_interrupt_enter_prepare() remained. This resulted in the same user-time
> interval being accounted twice for interrupts taken from user mode.
>
> I used bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature") as the Fixes
> tag because 893082ac769b only introduced the accounting call while
> arch_interrupt_enter_prepare() was unused. bee25f97ad24 is where the duplicate
> accounting actually became functional.
>
> Would it be ok to keep bee25f97ad24 as the Fixes tag? Please let me know if
> you think 893082ac769b would be more appropriate.
Ok, lets keep bee25f97ad24, I guess a bisect would land here. Anyway
they all appear for the first time in v7.2
Christophe
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry
2026-09-02 5:06 [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry Aboorva Devarajan
2026-09-02 5:31 ` Mukesh Kumar Chaurasiya
2026-09-02 5:36 ` Christophe Leroy (CS GROUP)
@ 2026-09-02 7:07 ` Shrikanth Hegde
2026-09-02 20:14 ` Aboorva Devarajan
2 siblings, 1 reply; 8+ messages in thread
From: Shrikanth Hegde @ 2026-09-02 7:07 UTC (permalink / raw)
To: Aboorva Devarajan
Cc: Christophe Leroy, linux-kernel, Ritesh Harjani,
Madhavan Srinivasan, linuxppc-dev, Mukesh Kumar Chaurasiya
Hi Aboorva.
On 9/2/26 10:36 AM, Aboorva Devarajan wrote:
> Since the switch to generic entry, an interrupt taken from user mode
> accounts user time twice: once in arch_interrupt_enter_prepare() and
> again in arch_enter_from_user_mode(), which irqentry_enter() invokes
> for the same interrupt:
>
> arch_interrupt_enter_prepare()
> account_cpu_user_entry()
> irqentry_enter()
> arch_enter_from_user_mode()
> account_cpu_user_entry()
>
> account_cpu_user_entry() accumulates the time spent in user mode
> since the last return to user space, so the second call charges the
> same interval again.
>
> With CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y this roughly doubles the
> reported user time of any workload that takes interrupts. On a
> pseries LPAR, ps/top show ~200% CPU for a single-threaded CPU-bound
> loop, and time(1) reports user time about twice the elapsed time.
>
Could you please run mpstat with 50% or less loading workload like stress-ng
and document the difference in changelog.
> Remove the accounting from arch_interrupt_enter_prepare() and rely on
> arch_enter_from_user_mode(), which runs for both syscalls and
> interrupts. The duplicate account_stolen_time() call is removed the
> same way.
>
> Fixes: bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature")
> Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> ---
> Verified on a pseries LPAR (CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y),
Usual default is VIRT_CPU_ACCOUNTING_GEN, selected by NO_HZ_FULL.
Most distros usually enable NO_HZ_FULL=y.
At hindsight, I don't see the issue dependency on it. But better to be sure.
> 7.3.0-rc1, single-threaded CPU-bound loop:
>
> Before:
>
> $ python3 -c 'while True: pass' &
> $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> PID ELAPSED TIME %CPU
> 4980 00:03 00:00:06 210
>
> After:
>
> $ python3 -c 'while True: pass' &
> $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> PID ELAPSED TIME %CPU
> 4951 00:03 00:00:03 105
>
> arch/powerpc/include/asm/entry-common.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/entry-common.h b/arch/powerpc/include/asm/entry-common.h
> index c5adb5006361..984294e62568 100644
> --- a/arch/powerpc/include/asm/entry-common.h
> +++ b/arch/powerpc/include/asm/entry-common.h
> @@ -222,8 +222,6 @@ static inline void arch_interrupt_enter_prepare(struct pt_regs *regs)
>
> if (user_mode(regs)) {
> kuap_lock();
> - account_cpu_user_entry();
> - account_stolen_time();
> } else {
> kuap_save_and_lock(regs);
> /*
> @@ -426,6 +424,10 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs)
> #endif
> kuap_assert_locked();
> booke_restore_dbcr0();
> + /*
> + * User and stolen time is accounted here for every entry from
> + * user mode. The interrupt prepare hooks must not account again.
> + */
> account_cpu_user_entry();
> account_stolen_time();
>
>
> base-commit: fb442a6673ff1046bf67754957d95880fdb394b5
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] powerpc/entry: Fix double accounting of user time on interrupt entry
2026-09-02 7:07 ` Shrikanth Hegde
@ 2026-09-02 20:14 ` Aboorva Devarajan
0 siblings, 0 replies; 8+ messages in thread
From: Aboorva Devarajan @ 2026-09-02 20:14 UTC (permalink / raw)
To: Shrikanth Hegde
Cc: Christophe Leroy, linux-kernel, Ritesh Harjani,
Madhavan Srinivasan, linuxppc-dev, Mukesh Kumar Chaurasiya
On Wed, 2026-09-02 at 12:37 +0530, Shrikanth Hegde wrote:
Hi Shrikanth,
> Hi Aboorva.
>
> On 9/2/26 10:36 AM, Aboorva Devarajan wrote:
> > Since the switch to generic entry, an interrupt taken from user mode
> > accounts user time twice: once in arch_interrupt_enter_prepare() and
> > again in arch_enter_from_user_mode(), which irqentry_enter() invokes
> > for the same interrupt:
> >
> > arch_interrupt_enter_prepare()
> > account_cpu_user_entry()
> > irqentry_enter()
> > arch_enter_from_user_mode()
> > account_cpu_user_entry()
> >
> > account_cpu_user_entry() accumulates the time spent in user mode
> > since the last return to user space, so the second call charges the
> > same interval again.
> >
> > With CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y this roughly doubles the
> > reported user time of any workload that takes interrupts. On a
> > pseries LPAR, ps/top show ~200% CPU for a single-threaded CPU-bound
> > loop, and time(1) reports user time about twice the elapsed time.
> >
>
> Could you please run mpstat with 50% or less loading workload like stress-ng
> and document the difference in changelog.
Sure, will add it in v2.
1. On the same pseries LPAR, taskset -c 6 stress-ng --cpu 1 --cpu-load 50:
Without the patch, the reported %usr is inflated, while with the patch
it is close to the expected 50%.
Without Patch:
06:43:09 AM CPU %usr** %nice %sys %iowait %irq %soft %steal %guest %gnice %idle
06:43:10 AM 6 69.74 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 30.26
With Patch:
06:29:33 AM CPU %usr** %nice %sys %iowait %irq %soft %steal %guest %gnice %idle
06:29:34 AM 6 48.51 0.00 0.00 0.00 0.99 0.00 0.00 0.00 0.00 50.50
2. Single-threaded CPU-bound workload:
taskset -c 100 python3 -c 'while True: pass' (executed for ~3 seconds)
Without patch:
TIME ELAPSED %CPU
00:00:06 00:02 209
With patch:
TIME ELAPSED %CPU
00:00:03 00:03 104
>
> > Remove the accounting from arch_interrupt_enter_prepare() and rely on
> > arch_enter_from_user_mode(), which runs for both syscalls and
> > interrupts. The duplicate account_stolen_time() call is removed the
> > same way.
> >
> > Fixes: bee25f97ad24 ("powerpc: Enable GENERIC_ENTRY feature")
> > Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> > ---
> > Verified on a pseries LPAR (CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y),
>
> Usual default is VIRT_CPU_ACCOUNTING_GEN, selected by NO_HZ_FULL.
> Most distros usually enable NO_HZ_FULL=y.
>
> At hindsight, I don't see the issue dependency on it. But better to be sure.
It is only observed with CONFIG_VIRT_CPU_ACCOUNTING_NATIVE.
account_cpu_user_entry() updates utime only with NATIVE accounting.
With CONFIG_VIRT_CPU_ACCOUNTING_GEN or tick-based accounting, it is
an empty stub and therefore a no-op.
So kernels using CONFIG_VIRT_CPU_ACCOUNTING_GEN or tick-based accounting
are not affected.
> > 7.3.0-rc1, single-threaded CPU-bound loop:
> >
> > Before:
> >
> > $ python3 -c 'while True: pass' &
> > $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> > PID ELAPSED TIME %CPU
> > 4980 00:03 00:00:06 210
> >
> > After:
> >
> > $ python3 -c 'while True: pass' &
> > $ sleep 3; ps -p $! -o pid,etime,time,pcpu
> > PID ELAPSED TIME %CPU
> > 4951 00:03 00:00:03 105
> >
> > arch/powerpc/include/asm/entry-common.h | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/include/asm/entry-common.h b/arch/powerpc/include/asm/entry-common.h
> > index c5adb5006361..984294e62568 100644
> > --- a/arch/powerpc/include/asm/entry-common.h
> > +++ b/arch/powerpc/include/asm/entry-common.h
> > @@ -222,8 +222,6 @@ static inline void arch_interrupt_enter_prepare(struct pt_regs *regs)
> >
> > if (user_mode(regs)) {
> > kuap_lock();
> > - account_cpu_user_entry();
> > - account_stolen_time();
> > } else {
> > kuap_save_and_lock(regs);
> > /*
> > @@ -426,6 +424,10 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs)
> > #endif
> > kuap_assert_locked();
> > booke_restore_dbcr0();
> > + /*
> > + * User and stolen time is accounted here for every entry from
> > + * user mode. The interrupt prepare hooks must not account again.
> > + */
> > account_cpu_user_entry();
> > account_stolen_time();
> >
> >
> > base-commit: fb442a6673ff1046bf67754957d95880fdb394b5
Thanks,
Aboorva
^ permalink raw reply [flat|nested] 8+ messages in thread