From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
To: Howard Chiu <howard_chiu@aspeedtech.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine
Date: Thu, 24 Mar 2022 06:48:57 -0700 [thread overview]
Message-ID: <0419edf0-89ba-7db8-7f8f-7682d2af3e7c@quicinc.com> (raw)
In-Reply-To: <SG2PR06MB2315C9F4348D39DA1A448852E6199@SG2PR06MB2315.apcprd06.prod.outlook.com>
Hi Howard,
On 3/24/2022 12:27 AM, Howard Chiu wrote:
> The ast2600 SoC has an embedded video engine
>
> Signed-off-by: Howard Chiu <howard_chiu@aspeedtech.com>
> ---
> arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index c32e87fad4dc..41d5087f7d92 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -389,6 +389,17 @@ sbc: secure-boot-controller@1e6f2000 {
> reg = <0x1e6f2000 0x1000>;
> };
>
> + video: video@1e700000 {
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x1000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
> + <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&syscon ASPEED_RESET_VIDEO>;
Video engine reset is handled by clk-ast2600.c so you don't need to add
'resets'.
> + status = "disabled";
> + };
> +
This node was already added back by this change.
https://lore.kernel.org/all/CACPK8XfPPLoS=mhwbAHY4EfVad=1_dnhB+gaHBjPj1wWbWE4gg@mail.gmail.com/
Cheers,
-Jae
> gpio0: gpio@1e780000 {
> #gpio-cells = <2>;
> gpio-controller;
next prev parent reply other threads:[~2022-03-24 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 7:27 Howard Chiu
2022-03-24 13:48 ` Jae Hyun Yoo [this message]
2022-03-25 1:56 ` Howard Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0419edf0-89ba-7db8-7f8f-7682d2af3e7c@quicinc.com \
--to=quic_jaehyoo@quicinc.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=howard_chiu@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®