* [PATCH v1 1/3] ARM: dts: aspeed: Add video engine
@ 2022-03-24 7:27 Howard Chiu
2022-03-24 13:48 ` Jae Hyun Yoo
0 siblings, 1 reply; 3+ messages in thread
From: Howard Chiu @ 2022-03-24 7:27 UTC (permalink / raw)
To: robh+dt, Joel Stanley, andrew, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
Cc: Troy Lee
The ast2600 SoC has an embedded video engine
Signed-off-by: Howard Chiu <howard_chiu@aspeedtech.com>
---
arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index c32e87fad4dc..41d5087f7d92 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -389,6 +389,17 @@ sbc: secure-boot-controller@1e6f2000 {
reg = <0x1e6f2000 0x1000>;
};
+ video: video@1e700000 {
+ compatible = "aspeed,ast2600-video-engine";
+ reg = <0x1e700000 0x1000>;
+ clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
+ <&syscon ASPEED_CLK_GATE_ECLK>;
+ clock-names = "vclk", "eclk";
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&syscon ASPEED_RESET_VIDEO>;
+ status = "disabled";
+ };
+
gpio0: gpio@1e780000 {
#gpio-cells = <2>;
gpio-controller;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine
2022-03-24 7:27 [PATCH v1 1/3] ARM: dts: aspeed: Add video engine Howard Chiu
@ 2022-03-24 13:48 ` Jae Hyun Yoo
2022-03-25 1:56 ` Howard Chiu
0 siblings, 1 reply; 3+ messages in thread
From: Jae Hyun Yoo @ 2022-03-24 13:48 UTC (permalink / raw)
To: Howard Chiu, robh+dt, Joel Stanley, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel
Hi Howard,
On 3/24/2022 12:27 AM, Howard Chiu wrote:
> The ast2600 SoC has an embedded video engine
>
> Signed-off-by: Howard Chiu <howard_chiu@aspeedtech.com>
> ---
> arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index c32e87fad4dc..41d5087f7d92 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -389,6 +389,17 @@ sbc: secure-boot-controller@1e6f2000 {
> reg = <0x1e6f2000 0x1000>;
> };
>
> + video: video@1e700000 {
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x1000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
> + <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&syscon ASPEED_RESET_VIDEO>;
Video engine reset is handled by clk-ast2600.c so you don't need to add
'resets'.
> + status = "disabled";
> + };
> +
This node was already added back by this change.
https://lore.kernel.org/all/CACPK8XfPPLoS=mhwbAHY4EfVad=1_dnhB+gaHBjPj1wWbWE4gg@mail.gmail.com/
Cheers,
-Jae
> gpio0: gpio@1e780000 {
> #gpio-cells = <2>;
> gpio-controller;
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine
2022-03-24 13:48 ` Jae Hyun Yoo
@ 2022-03-25 1:56 ` Howard Chiu
0 siblings, 0 replies; 3+ messages in thread
From: Howard Chiu @ 2022-03-25 1:56 UTC (permalink / raw)
To: Jae Hyun Yoo, robh+dt, Joel Stanley, andrew, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel
Hi Jae
> -----Original Message-----
> From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
> Sent: Thursday, March 24, 2022 9:49 PM
> To: Howard Chiu <howard_chiu@aspeedtech.com>; robh+dt@kernel.org; Joel
> Stanley <joel@jms.id.au>; andrew@aj.id.au; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine
>
> Hi Howard,
>
> On 3/24/2022 12:27 AM, Howard Chiu wrote:
> > The ast2600 SoC has an embedded video engine
> >
> > Signed-off-by: Howard Chiu <howard_chiu@aspeedtech.com>
> > ---
> > arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi
> > b/arch/arm/boot/dts/aspeed-g6.dtsi
> > index c32e87fad4dc..41d5087f7d92 100644
> > --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> > @@ -389,6 +389,17 @@ sbc: secure-boot-controller@1e6f2000 {
> > reg = <0x1e6f2000 0x1000>;
> > };
> >
> > + video: video@1e700000 {
> > + compatible = "aspeed,ast2600-video-engine";
> > + reg = <0x1e700000 0x1000>;
> > + clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
> > + <&syscon ASPEED_CLK_GATE_ECLK>;
> > + clock-names = "vclk", "eclk";
> > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > + resets = <&syscon ASPEED_RESET_VIDEO>;
>
> Video engine reset is handled by clk-ast2600.c so you don't need to add
> 'resets'.
>
> > + status = "disabled";
> > + };
> > +
>
> This node was already added back by this change.
> https://lore.kernel.org/all/CACPK8XfPPLoS=mhwbAHY4EfVad=1_dnhB+gaHBjPj
> 1wWbWE4gg@mail.gmail.com/
>
Thanks for info, the next patchset won't include this.
> Cheers,
>
> -Jae
>
> > gpio0: gpio@1e780000 {
> > #gpio-cells = <2>;
> > gpio-controller;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-25 1:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 7:27 [PATCH v1 1/3] ARM: dts: aspeed: Add video engine Howard Chiu
2022-03-24 13:48 ` Jae Hyun Yoo
2022-03-25 1:56 ` Howard Chiu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®