Re: [PATCH] EDAC/i3200: drop the PCI device reference on module exit

Re: [PATCH] EDAC/i3200: drop the PCI device reference on module exit

[Borislav Petkov]

On Wed, Nov 04, 2026 at 03:38:33AM +0000, Wentao Liang wrote:
> i3200_init_one() takes an extra reference on the memory controller with
> pci_dev_get() and stores it in the global mci_pdev pointer.  When the
> driver probed a device, i3200_registered stays set and i3200_exit()
> calls pci_dev_put() only in the !i3200_registered branch, so the
> reference is never dropped and the PCI device can not be released.
> 
> Move the put out of the conditional.  i3200_remove_one() still has to be
> called by hand only for the i3200_init() fallback that probed the device
> outside the PCI driver core.
> 
> Fixes: dd8ef1db87a4 ("edac: i3200 memory controller driver")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex

Grep the kernel tree for Assisted-by guidance.

> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/edac/i3200_edac.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

$ ./scripts/get_maintainer.pl -f drivers/edac/i3200_edac.c
Borislav Petkov <bp@alien8.de> (maintainer:EDAC-CORE)
Tony Luck <tony.luck@intel.com> (maintainer:EDAC-CORE)
linux-edac@vger.kernel.org (open list:EDAC-I3200)
linux-kernel@vger.kernel.org (open list)
EDAC-I3200 status: Orphan
		   ^^^^^^^

All your patches touching orphaned EDAC drivers are going to be ignored - you
don't want to spend any effort or burn AI energy on them.

I already told you that the last time you sent patches. It looks like probably
no human even read my responses.

Quickly grepping through lore.kernel.org it looks like this effort you're
doing is some AI gunk mindlessly sending kernel patches.

So you will be ignored too.

Just remember that if you don't listen to maintainers and ignore their
feedback, all your effort and wasted energy will be for nothing.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/i3200: drop the PCI device reference on module exit

[Wentao Liang]

Hi Boris,

Sorry for the late reply, and for the mess it caused.

Thank you for telling me that the EDAC i3200 driver is orphaned. I will stop
working on this driver and will not send patches for orphaned EDAC drivers
again.

In particular, thank you for pointing out the Assisted-by guidance and the
problem with my submission process. This is an important lesson for me. I
will go through all previous feedback manually, one by one, and reply in a
timely manner from now on. I will also not send patches in large batches
going forward, so that I do not accumulate more feedback than I can respond
to in time.

Thank you for your patience.

Best regards,
Wentao Liang

Re: [PATCH] EDAC/i3200: drop the PCI device reference on module exit

[Krzysztof Kozlowski]

On 06/11/2026 04:28, Wentao Liang wrote:
> Hi Boris,
> 
> Sorry for the late reply, and for the mess it caused.
> 
> Thank you for telling me that the EDAC i3200 driver is orphaned. I will stop
> working on this driver and will not send patches for orphaned EDAC drivers
> again.
> 
> In particular, thank you for pointing out the Assisted-by guidance and the
> problem with my submission process. This is an important lesson for me. I

And 30 minutes later you send the same crap?

https://lore.kernel.org/all/179393727482.2060666.9057920361892304525@iscas.ac.cn/

So how was it an important lesson? What did you learn? You just ignored
everything, just like you did week and weeks ago.

Best regards,
Krzysztof