From: Andrew Lunn <andrew@lunn.ch>
To: Dawid Glazik <dawid.glazik@linux.intel.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
maciej.lawniczak@intel.com
Subject: Re: [PATCH 3/4] ARM: dts: aspeed: add Intel AVCRP BMC
Date: Sun, 4 Oct 2026 23:20:01 +0200 [thread overview]
Message-ID: <04355d4a-e1db-4681-bca2-43806216a7fd@lunn.ch> (raw)
In-Reply-To: <9dadaaf04cae28e13057fa5d65023789f74483fb.1790344811.git.dawid.glazik@linux.intel.com>
> +&mdio1 {
> + status = "okay";
> +
> + ethphy1: ethernet-phy@0 {
> + compatible = "ethernet-phy-id001c.c916";
> + reg = <0>;
> + reset-gpios = <&gpio0 ASPEED_GPIO(C, 1) GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + reset-deassert-us = <50000>;
> + };
> +};
> +
> +&mac1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii2_default>;
> + clocks = <&syscon ASPEED_CLK_GATE_MAC2CLK>,
> + <&syscon ASPEED_CLK_MAC2RCLK>;
> + clock-names = "MACCLK", "RCLK";
> + phy-mode = "rgmii-id";
> + phy-handle = <ðphy1>;
> +};
Oh, wow. Somebody actually got RGMII delays correct on the first try
for an aspeed board.
For these two nodes only:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2026-10-04 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 16:32 [PATCH 0/4] arm: dts: aspeed: add Intel AVCRP and JNCRP BMC platforms Dawid Glazik
2026-10-02 16:32 ` [PATCH 1/4] dt-bindings: arm: aspeed: Add Intel AVCRP board Dawid Glazik
2026-10-03 14:40 ` Krzysztof Kozlowski
2026-10-02 16:32 ` [PATCH 2/4] dt-bindings: arm: aspeed: Add Intel JNCRP board Dawid Glazik
2026-10-03 14:41 ` Krzysztof Kozlowski
2026-10-02 16:32 ` [PATCH 3/4] ARM: dts: aspeed: add Intel AVCRP BMC Dawid Glazik
2026-10-03 14:42 ` Krzysztof Kozlowski
2026-10-04 21:20 ` Andrew Lunn [this message]
2026-10-02 16:32 ` [PATCH 4/4] ARM: dts: aspeed: add Intel JNCRP BMC Dawid Glazik
2026-10-04 21:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04355d4a-e1db-4681-bca2-43806216a7fd@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=dawid.glazik@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.lawniczak@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®