Re: [PATCH v3 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Wi-Fi device

[Arend van Spriel <arend.vanspriel@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

On 6/30/2024 9:36 AM, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.

you can add my....

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
>   .../bindings/net/wireless/brcm,bcm4329-fmac.yaml          | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 2c2093c77ec9a..f542b60e44dc4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -122,6 +122,14 @@ properties:
>         NVRAM. This would normally be filled in by the bootloader from platform
>         configuration data.
>   
> +  clocks:
> +    items:
> +      - description: Wi-Fi RTC clock

Having a few problems with the description. There is only one LPO clock 
input on the 43752 chipset. From the AMPAK AP6275P datasheet:

| 31 | LPO_IN | I | External Low Power Clock input (32.768KHz) |

I would suggest to use the description from the datasheet or something 
similar.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]