From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacobe Zang <jacobe.zang@wesion.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"heiko@sntech.de" <heiko@sntech.de>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "efectn@protonmail.com" <efectn@protonmail.com>,
"dsimic@manjaro.org" <dsimic@manjaro.org>,
"jagan@edgeble.ai" <jagan@edgeble.ai>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arend@broadcom.com" <arend@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"megi@xff.cz" <megi@xff.cz>,
"duoming@zju.edu.cn" <duoming@zju.edu.cn>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"minipli@grsecurity.net" <minipli@grsecurity.net>,
"brcm80211@lists.linux.dev" <brcm80211@lists.linux.dev>,
"brcm80211-dev-list.pdl@broadcom.com"
<brcm80211-dev-list.pdl@broadcom.com>, Nick Xie <nick@khadas.com>
Subject: Re: [PATCH v3 3/5] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2
Date: Mon, 1 Jul 2024 13:16:26 +0200 [thread overview]
Message-ID: <c2febca9-59e4-4505-bbec-6e61f7d8b944@kernel.org> (raw)
In-Reply-To: <TYZPR03MB7001FFD5180C6248F14EE48E80D32@TYZPR03MB7001.apcprd03.prod.outlook.com>
On 01/07/2024 12:38, Jacobe Zang wrote:
>>> + pcie@0,0 {
>>> + reg = <0x400000 0 0 0 0>;
>>> + #address-cells = <3>;
>>> + #size-cells = <2>;
>>> + ranges;
>>> + device_type = "pci";
>>> + bus-range = <0x40 0x4f>;
>>> +
>>> + wifi: wifi@0,0 {
>> Where is the compatible (again!)? Test your code - you will see your
>> binding is a no-op.
>
> I tried to build kernel with CHECK_DTBS=1. And didn't get any message
> like 'compatible' is a required property in wifi node. But when I check
> the bindings that do required the compatible... So I will add it next time.
Yep, use different clock name and then test. You should see errors,
right? But there are not, because schema is not applied to this node at all.
Look how Apple is doing this.
I have doubts that your code works at all in the first place. If there
is no compatible, how your platform device gets of_node?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-01 11:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 7:36 [PATCH v3 0/5] Add AP6275P wireless support Jacobe Zang
2024-06-30 7:36 ` [PATCH v3 1/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d Jacobe Zang
2024-07-02 18:56 ` Arend van Spriel
2024-06-30 7:36 ` [PATCH v3 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Wi-Fi device Jacobe Zang
2024-06-30 8:26 ` Stefan Wahren
2024-07-01 8:58 ` Krzysztof Kozlowski
2024-07-02 19:05 ` Arend van Spriel
2024-06-30 7:36 ` [PATCH v3 3/5] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 Jacobe Zang
2024-07-01 8:46 ` Krzysztof Kozlowski
2024-07-01 10:38 ` Jacobe Zang
2024-07-01 11:16 ` Krzysztof Kozlowski [this message]
2024-07-01 11:31 ` Jacobe Zang
2024-07-01 13:04 ` Krzysztof Kozlowski
2024-06-30 7:36 ` [PATCH v3 4/5] wifi: brcmfmac: Add optional lpo clock enable support Jacobe Zang
2024-06-30 8:43 ` Stefan Wahren
2024-06-30 9:09 ` Jacobe Zang
2024-06-30 9:15 ` Chen-Yu Tsai
2024-06-30 9:54 ` Stefan Wahren
2024-06-30 10:51 ` Arend Van Spriel
2024-07-01 10:57 ` Jacobe Zang
2024-06-30 11:01 ` Arend Van Spriel
2024-07-01 12:03 ` kernel test robot
2024-07-01 13:48 ` kernel test robot
2024-07-02 19:20 ` Arend van Spriel
2024-06-30 7:36 ` [PATCH v3 5/5] wifi: brcmfmac: Add support for AP6275P Jacobe Zang
2024-06-30 8:34 ` Stefan Wahren
2024-06-30 8:36 ` Ondřej Jirman
2024-06-30 8:37 ` Stefan Wahren
2024-06-30 11:17 ` Arend Van Spriel
2024-07-08 10:09 ` Jacobe Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2febca9-59e4-4505-bbec-6e61f7d8b944@kernel.org \
--to=krzk@kernel.org \
--cc=arend@broadcom.com \
--cc=bhelgaas@google.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=efectn@protonmail.com \
--cc=heiko@sntech.de \
--cc=jacobe.zang@wesion.com \
--cc=jagan@edgeble.ai \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=minipli@grsecurity.net \
--cc=netdev@vger.kernel.org \
--cc=nick@khadas.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®