From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacobe Zang <jacobe.zang@wesion.com>,
robh@kernel.org, krzk+dt@kernel.org, heiko@sntech.de,
kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, conor+dt@kernel.org
Cc: efectn@protonmail.com, dsimic@manjaro.org, jagan@edgeble.ai,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
arend@broadcom.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, megi@xff.cz, duoming@zju.edu.cn,
bhelgaas@google.com, minipli@grsecurity.net,
brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
nick@khadas.com
Subject: Re: [PATCH v3 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Wi-Fi device
Date: Mon, 1 Jul 2024 10:58:18 +0200 [thread overview]
Message-ID: <831bad74-5519-48a1-b13c-a358e634598c@kernel.org> (raw)
In-Reply-To: <20240630073605.2164346-3-jacobe.zang@wesion.com>
On 30/06/2024 09:36, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.
>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
> .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 2c2093c77ec9a..f542b60e44dc4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -122,6 +122,14 @@ properties:
> NVRAM. This would normally be filled in by the bootloader from platform
> configuration data.
>
> + clocks:
> + items:
> + - description: Wi-Fi RTC clock
> +
> + clock-names:
> + items:
> + - const: lpo
This does not match your DTS. DTS is different, e.g. does not have
compatible. There are required properties here, some of which are required.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-01 8:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 7:36 [PATCH v3 0/5] Add AP6275P wireless support Jacobe Zang
2024-06-30 7:36 ` [PATCH v3 1/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d Jacobe Zang
2024-07-02 18:56 ` Arend van Spriel
2024-06-30 7:36 ` [PATCH v3 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Wi-Fi device Jacobe Zang
2024-06-30 8:26 ` Stefan Wahren
2024-07-01 8:58 ` Krzysztof Kozlowski [this message]
2024-07-02 19:05 ` Arend van Spriel
2024-06-30 7:36 ` [PATCH v3 3/5] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 Jacobe Zang
2024-07-01 8:46 ` Krzysztof Kozlowski
2024-07-01 10:38 ` Jacobe Zang
2024-07-01 11:16 ` Krzysztof Kozlowski
2024-07-01 11:31 ` Jacobe Zang
2024-07-01 13:04 ` Krzysztof Kozlowski
2024-06-30 7:36 ` [PATCH v3 4/5] wifi: brcmfmac: Add optional lpo clock enable support Jacobe Zang
2024-06-30 8:43 ` Stefan Wahren
2024-06-30 9:09 ` Jacobe Zang
2024-06-30 9:15 ` Chen-Yu Tsai
2024-06-30 9:54 ` Stefan Wahren
2024-06-30 10:51 ` Arend Van Spriel
2024-07-01 10:57 ` Jacobe Zang
2024-06-30 11:01 ` Arend Van Spriel
2024-07-01 12:03 ` kernel test robot
2024-07-01 13:48 ` kernel test robot
2024-07-02 19:20 ` Arend van Spriel
2024-06-30 7:36 ` [PATCH v3 5/5] wifi: brcmfmac: Add support for AP6275P Jacobe Zang
2024-06-30 8:34 ` Stefan Wahren
2024-06-30 8:36 ` Ondřej Jirman
2024-06-30 8:37 ` Stefan Wahren
2024-06-30 11:17 ` Arend Van Spriel
2024-07-08 10:09 ` Jacobe Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831bad74-5519-48a1-b13c-a358e634598c@kernel.org \
--to=krzk@kernel.org \
--cc=arend@broadcom.com \
--cc=bhelgaas@google.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=efectn@protonmail.com \
--cc=heiko@sntech.de \
--cc=jacobe.zang@wesion.com \
--cc=jagan@edgeble.ai \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=minipli@grsecurity.net \
--cc=netdev@vger.kernel.org \
--cc=nick@khadas.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®