[PATCH] reset: scmi: Set the device for the reset controller

[PATCH] reset: scmi: Set the device for the reset controller

[Kunihiko Hayashi]

SCMI reset driver does not set rcdev.dev when registering its reset
controller.

If rcdev.of_node is not available, the reset core tries to obtain
the firmware node from rcdev.dev. However, rcdev.dev is also NULL,
causing a NULL pointer dereference.

Set rcdev.dev to the SCMI device.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 drivers/reset/reset-scmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c
index 8be5743cc8fd..1523245f83ef 100644
--- a/drivers/reset/reset-scmi.c
+++ b/drivers/reset/reset-scmi.c
@@ -107,6 +107,7 @@ static int scmi_reset_probe(struct scmi_device *sdev)
 
 	data->rcdev.ops = &scmi_reset_ops;
 	data->rcdev.owner = THIS_MODULE;
+	data->rcdev.dev = dev;
 	data->rcdev.of_node = np;
 	data->rcdev.nr_resets = reset_ops->num_domains_get(ph);
 	data->ph = ph;
-- 
2.34.1

Re: [PATCH] reset: scmi: Set the device for the reset controller

[Sudeep Holla]

On Fri, Oct 02, 2026 at 05:41:42PM +0900, Kunihiko Hayashi wrote:
> SCMI reset driver does not set rcdev.dev when registering its reset
> controller.
> 
> If rcdev.of_node is not available, the reset core tries to obtain
> the firmware node from rcdev.dev. However, rcdev.dev is also NULL,
> causing a NULL pointer dereference.
> 
> Set rcdev.dev to the SCMI device.
> 

Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>

Worth adding fixes tag IMO

Fixes: c8ae9c2da1cc ("reset: Add support for resets provided by SCMI")

Hi Philipp,

Can you please take this in your next round of fixes and/or updates ?

-- 
Regards,
Sudeep

Re: [PATCH] reset: scmi: Set the device for the reset controller

[Philipp Zabel]

On Fr, 2026-10-02 at 17:41 +0900, Kunihiko Hayashi wrote:
> SCMI reset driver does not set rcdev.dev when registering its reset
> controller.
> 
> If rcdev.of_node is not available, the reset core tries to obtain
> the firmware node from rcdev.dev. However, rcdev.dev is also NULL,
> causing a NULL pointer dereference.
> 
> [...]

Applied to reset/fixes, thanks!

[1/1] reset: scmi: Set the device for the reset controller
      https://git.kernel.org/pub/scm/linux/kernel/git/pza/linux.git/commit/?id=e3e068a457ce

regards
Philipp