* [PATCH] tty: serial: jsm: remove redundant pointer ts
@ 2017-11-07 11:41 Colin King
2017-11-07 12:53 ` Guilherme G. Piccoli
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-07 11:41 UTC (permalink / raw)
To: Guilherme G . Piccoli, Greg Kroah-Hartman, Jiri Slaby, linux-serial
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer ts is assigned a value that is never read, ts is therefore
redundant and can be removed. Cleans up clang warning:
drivers/tty/serial/jsm/jsm_tty.c:285:2: warning: Value stored to 'ts'
is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/tty/serial/jsm/jsm_tty.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index e69227cc3827..5ecd878669b8 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -275,14 +275,12 @@ static int jsm_tty_open(struct uart_port *port)
static void jsm_tty_close(struct uart_port *port)
{
struct jsm_board *bd;
- struct ktermios *ts;
struct jsm_channel *channel =
container_of(port, struct jsm_channel, uart_port);
jsm_dbg(CLOSE, &channel->ch_bd->pci_dev, "start\n");
bd = channel->ch_bd;
- ts = &port->state->port.tty->termios;
channel->ch_flags &= ~(CH_STOPI);
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: serial: jsm: remove redundant pointer ts
2017-11-07 11:41 [PATCH] tty: serial: jsm: remove redundant pointer ts Colin King
@ 2017-11-07 12:53 ` Guilherme G. Piccoli
0 siblings, 0 replies; 2+ messages in thread
From: Guilherme G. Piccoli @ 2017-11-07 12:53 UTC (permalink / raw)
To: Colin King
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, kernel-janitors,
linux-kernel
On 11/07/2017 09:41 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer ts is assigned a value that is never read, ts is therefore
> redundant and can be removed. Cleans up clang warning:
>
> drivers/tty/serial/jsm/jsm_tty.c:285:2: warning: Value stored to 'ts'
> is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin!
Acked-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
> ---
> drivers/tty/serial/jsm/jsm_tty.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
> index e69227cc3827..5ecd878669b8 100644
> --- a/drivers/tty/serial/jsm/jsm_tty.c
> +++ b/drivers/tty/serial/jsm/jsm_tty.c
> @@ -275,14 +275,12 @@ static int jsm_tty_open(struct uart_port *port)
> static void jsm_tty_close(struct uart_port *port)
> {
> struct jsm_board *bd;
> - struct ktermios *ts;
> struct jsm_channel *channel =
> container_of(port, struct jsm_channel, uart_port);
>
> jsm_dbg(CLOSE, &channel->ch_bd->pci_dev, "start\n");
>
> bd = channel->ch_bd;
> - ts = &port->state->port.tty->termios;
>
> channel->ch_flags &= ~(CH_STOPI);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-07 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 11:41 [PATCH] tty: serial: jsm: remove redundant pointer ts Colin King
2017-11-07 12:53 ` Guilherme G. Piccoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®