* [PATCH] media: iris: Add missing platform data entries for SM8750
@ 2025-12-18 6:54 Dikshita Agarwal
2025-12-18 11:17 ` Konrad Dybcio
2025-12-24 8:57 ` Vikash Garodia
0 siblings, 2 replies; 3+ messages in thread
From: Dikshita Agarwal @ 2025-12-18 6:54 UTC (permalink / raw)
To: Vikash Garodia, Abhinav Kumar, Bryan O'Donoghue,
Mauro Carvalho Chehab, Neil Armstrong, Hans Verkuil
Cc: linux-media, linux-arm-msm, linux-kernel, stable, Dikshita Agarwal
Two platform-data fields for SM8750 were missed:
- get_vpu_buffer_size = iris_vpu33_buf_size
Without this, the driver fails to allocate the required internal
buffers, leading to basic decode/encode failures during session
bring-up.
- max_core_mbps = ((7680 * 4320) / 256) * 60
Without this capability exposed, capability checks are incomplete and
v4l2-compliance for encoder fails.
Fixes: a5925a2ce077 ("media: iris: add VPU33 specific encoding buffer calculation")
Fixes: a6882431a138 ("media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder")
Cc: stable@vger.kernel.org
Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
---
drivers/media/platform/qcom/iris/iris_platform_gen2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
index c1989240c248601c34b84f508f1b72d72f81260a..00d1d55463179429f2ae7554546dcbe4fb1431cc 100644
--- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
+++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
@@ -915,6 +915,7 @@ const struct iris_platform_data sm8750_data = {
.get_instance = iris_hfi_gen2_get_instance,
.init_hfi_command_ops = iris_hfi_gen2_command_ops_init,
.init_hfi_response_ops = iris_hfi_gen2_response_ops_init,
+ .get_vpu_buffer_size = iris_vpu33_buf_size,
.vpu_ops = &iris_vpu35_ops,
.set_preset_registers = iris_set_sm8550_preset_registers,
.icc_tbl = sm8550_icc_table,
@@ -945,6 +946,7 @@ const struct iris_platform_data sm8750_data = {
.num_vpp_pipe = 4,
.max_session_count = 16,
.max_core_mbpf = NUM_MBS_8K * 2,
+ .max_core_mbps = ((7680 * 4320) / 256) * 60,
.dec_input_config_params_default =
sm8550_vdec_input_config_params_default,
.dec_input_config_params_default_size =
---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251217-iris-sm8750-fix-2d42a133058d
Best regards,
--
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: iris: Add missing platform data entries for SM8750
2025-12-18 6:54 [PATCH] media: iris: Add missing platform data entries for SM8750 Dikshita Agarwal
@ 2025-12-18 11:17 ` Konrad Dybcio
2025-12-24 8:57 ` Vikash Garodia
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-12-18 11:17 UTC (permalink / raw)
To: Dikshita Agarwal, Vikash Garodia, Abhinav Kumar,
Bryan O'Donoghue, Mauro Carvalho Chehab, Neil Armstrong,
Hans Verkuil
Cc: linux-media, linux-arm-msm, linux-kernel, stable
On 12/18/25 7:54 AM, Dikshita Agarwal wrote:
> Two platform-data fields for SM8750 were missed:
>
> - get_vpu_buffer_size = iris_vpu33_buf_size
> Without this, the driver fails to allocate the required internal
> buffers, leading to basic decode/encode failures during session
> bring-up.
>
> - max_core_mbps = ((7680 * 4320) / 256) * 60
> Without this capability exposed, capability checks are incomplete and
> v4l2-compliance for encoder fails.
>
> Fixes: a5925a2ce077 ("media: iris: add VPU33 specific encoding buffer calculation")
> Fixes: a6882431a138 ("media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder")
> Cc: stable@vger.kernel.org
> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: iris: Add missing platform data entries for SM8750
2025-12-18 6:54 [PATCH] media: iris: Add missing platform data entries for SM8750 Dikshita Agarwal
2025-12-18 11:17 ` Konrad Dybcio
@ 2025-12-24 8:57 ` Vikash Garodia
1 sibling, 0 replies; 3+ messages in thread
From: Vikash Garodia @ 2025-12-24 8:57 UTC (permalink / raw)
To: Dikshita Agarwal, Abhinav Kumar, Bryan O'Donoghue,
Mauro Carvalho Chehab, Neil Armstrong, Hans Verkuil
Cc: linux-media, linux-arm-msm, linux-kernel, stable
On 12/18/2025 12:24 PM, Dikshita Agarwal wrote:
> Two platform-data fields for SM8750 were missed:
>
> - get_vpu_buffer_size = iris_vpu33_buf_size
> Without this, the driver fails to allocate the required internal
> buffers, leading to basic decode/encode failures during session
> bring-up.
>
> - max_core_mbps = ((7680 * 4320) / 256) * 60
> Without this capability exposed, capability checks are incomplete and
> v4l2-compliance for encoder fails.
>
> Fixes: a5925a2ce077 ("media: iris: add VPU33 specific encoding buffer calculation")
> Fixes: a6882431a138 ("media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder")
> Cc: stable@vger.kernel.org
> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> index c1989240c248601c34b84f508f1b72d72f81260a..00d1d55463179429f2ae7554546dcbe4fb1431cc 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> @@ -915,6 +915,7 @@ const struct iris_platform_data sm8750_data = {
> .get_instance = iris_hfi_gen2_get_instance,
> .init_hfi_command_ops = iris_hfi_gen2_command_ops_init,
> .init_hfi_response_ops = iris_hfi_gen2_response_ops_init,
> + .get_vpu_buffer_size = iris_vpu33_buf_size,
> .vpu_ops = &iris_vpu35_ops,
> .set_preset_registers = iris_set_sm8550_preset_registers,
> .icc_tbl = sm8550_icc_table,
> @@ -945,6 +946,7 @@ const struct iris_platform_data sm8750_data = {
> .num_vpp_pipe = 4,
> .max_session_count = 16,
> .max_core_mbpf = NUM_MBS_8K * 2,
> + .max_core_mbps = ((7680 * 4320) / 256) * 60,
> .dec_input_config_params_default =
> sm8550_vdec_input_config_params_default,
> .dec_input_config_params_default_size =
>
Reviewed-by: Vikash Garodia<vikash.garodia@oss.qualcomm.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-24 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-18 6:54 [PATCH] media: iris: Add missing platform data entries for SM8750 Dikshita Agarwal
2025-12-18 11:17 ` Konrad Dybcio
2025-12-24 8:57 ` Vikash Garodia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®