mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lizhi Hou <lizhi.hou@amd.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>, <ogabbay@kernel.org>,
	<dri-devel@lists.freedesktop.org>
Cc: <linux-kernel@vger.kernel.org>, <min.ma@amd.com>,
	<max.zhen@amd.com>, <sonal.santan@amd.com>, <king.tam@amd.com>
Subject: Re: [PATCH V3 11/11] accel/amdxdna: Add firmware debug buffer support
Date: Wed, 9 Oct 2024 09:22:38 -0700	[thread overview]
Message-ID: <08835e82-f9e4-52e5-5d03-fa31ecf63314@amd.com> (raw)
In-Reply-To: <1a2bb8fc-0242-d86b-1de0-cc9eec1c61c0@quicinc.com>


On 10/4/24 11:33, Jeffrey Hugo wrote:
> On 9/11/2024 12:06 PM, Lizhi Hou wrote:
>> User application may allocate a debug buffer and attach it to an NPU
>> context through the driver. Then the NPU firmware prints its debug
>> information to this buffer for debugging.
>
> I feel like I must be missing something. It looks like this patch 
> accepts a buffer from the user, and stores it. However I don't see how 
> the NPU firmware ever learns that this special buffer exists to then 
> use it.

The debug function is incomplete while I was creating the patch. Thus, I 
put a line in TODO "Improve debug bo support".

We made progress on this feature. Should I add the code to V4 patch? Or 
I can add it within future patches.


Thanks,

Lizhi


  reply	other threads:[~2024-10-09 16:22 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11 18:05 [PATCH V3 00/11] AMD XDNA driver Lizhi Hou
2024-09-11 18:05 ` [PATCH V3 01/11] accel/amdxdna: Add documentation for AMD NPU accelerator driver Lizhi Hou
2024-10-04 17:06   ` Jeffrey Hugo
2024-10-05  0:27     ` Lizhi Hou
2024-09-11 18:05 ` [PATCH V3 02/11] accel/amdxdna: Add a new driver for AMD AI Engine Lizhi Hou
2024-10-04 17:21   ` Jeffrey Hugo
2024-10-07  4:01     ` Lizhi Hou
2024-09-11 18:05 ` [PATCH V3 03/11] accel/amdxdna: Support hardware mailbox Lizhi Hou
2024-10-04 17:34   ` Jeffrey Hugo
2024-10-07  4:15     ` Lizhi Hou
2024-10-07 15:34       ` Jeffrey Hugo
2024-09-11 18:05 ` [PATCH V3 04/11] accel/amdxdna: Add hardware resource solver Lizhi Hou
2024-10-04 17:36   ` Jeffrey Hugo
2024-09-11 18:05 ` [PATCH V3 05/11] accel/amdxdna: Add hardware context Lizhi Hou
2024-10-04 17:50   ` Jeffrey Hugo
2024-10-07  5:02     ` Lizhi Hou
2024-10-07 15:37       ` Jeffrey Hugo
2024-09-11 18:05 ` [PATCH V3 06/11] accel/amdxdna: Add GEM buffer object management Lizhi Hou
2024-09-14 14:07   ` kernel test robot
2024-10-04 17:56   ` Jeffrey Hugo
2024-10-07 22:35     ` Lizhi Hou
2024-09-11 18:06 ` [PATCH V3 07/11] accel/amdxdna: Add command execution Lizhi Hou
2024-10-04 18:01   ` Jeffrey Hugo
2024-10-07 22:51     ` Lizhi Hou
2024-09-11 18:06 ` [PATCH V3 08/11] accel/amdxdna: Add suspend and resume Lizhi Hou
2024-10-04 18:08   ` Jeffrey Hugo
2024-10-08  5:52     ` Lizhi Hou
2024-09-11 18:06 ` [PATCH V3 09/11] accel/amdxdna: Add error handling Lizhi Hou
2024-10-04 18:20   ` Jeffrey Hugo
2024-09-11 18:06 ` [PATCH V3 10/11] accel/amdxdna: Add query functions Lizhi Hou
2024-10-04 18:23   ` Jeffrey Hugo
2024-10-09 16:19     ` Lizhi Hou
2024-09-11 18:06 ` [PATCH V3 11/11] accel/amdxdna: Add firmware debug buffer support Lizhi Hou
2024-10-04 18:33   ` Jeffrey Hugo
2024-10-09 16:22     ` Lizhi Hou [this message]
2024-10-09 23:51       ` Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08835e82-f9e4-52e5-5d03-fa31ecf63314@amd.com \
    --to=lizhi.hou@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=king.tam@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.zhen@amd.com \
    --cc=min.ma@amd.com \
    --cc=ogabbay@kernel.org \
    --cc=quic_jhugo@quicinc.com \
    --cc=sonal.santan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®