mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Joan-Na-adi <joan.na.devcode@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Joan Na <joan.na@analog.com>
Subject: Re: [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator binding
Date: Tue, 14 Oct 2025 14:11:47 +0100	[thread overview]
Message-ID: <08b4c0a0-cc59-4640-94ff-2d243c558a67@sirena.org.uk> (raw)
In-Reply-To: <512ffe3d-5ab3-4e87-afd2-46f0005a8d17@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

On Tue, Oct 14, 2025 at 10:14:15AM +0200, Krzysztof Kozlowski wrote:
> On 14/10/2025 07:31, Joan-Na-adi wrote:

> > +  maxim,en-mode:
> > +    description: |
> > +      Enable mode configuration.
> > +      "push-button"  - Push button
> > +      "slide-switch" - Slide switch
> > +      "logic" - Logic mode

> You just repeat the name in the description. Say something useful.

Do you have concrete suggestions there?  I can see dropping the
descriptions entirely but otherwise I'm not sure there's much to
usefully add.

> > +  maxim,latency-mode:
> > +    description: |
> > +      Latency mode for voltage transition:
> > +      "high" - High latency (100μs)
> > +      "low"  - Low latency (10μs)

> So use values 100 or 10, and proper type (-us)

Without knowing the device specifics at all I rather suspect those
numbers are more ballparks than specifics.

> > +  maxim,dvs-slew-rate-mv-per-us:

> ... like here.

> > +    description: |
> > +      Dynamic rising slew rate for output voltage transitions, in mV/μs.

> Except you said mv/us, not us. Confusing.

That's what I'd expect for a slew rate?  It's the speed with which the
device ramps between voltages during voltage transitions, mV/us is a
perfectly normal unit for that.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-10-14 13:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  5:31 [PATCH v3 0/3] MAX77675 regulator driver: Add support for MAX77675 device Joan-Na-adi
2025-10-14  5:31 ` [PATCH v3 1/3] dt-bindings: regulator: Add MAX77675 binding header Joan-Na-adi
2025-10-14  8:09   ` Krzysztof Kozlowski
2025-10-20 10:12   ` Krzysztof Kozlowski
2025-10-14  5:31 ` [PATCH v3 2/3] regulator: max77675: Add MAX77675 regulator driver Joan-Na-adi
2025-10-14  8:17   ` Krzysztof Kozlowski
2025-10-14  5:31 ` [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator binding Joan-Na-adi
2025-10-14  8:14   ` Krzysztof Kozlowski
2025-10-14 13:11     ` Mark Brown [this message]
2025-10-14 21:54       ` Krzysztof Kozlowski
2025-10-14 22:08         ` Mark Brown
2025-11-06  5:29     ` Joan Na
2025-11-06  7:08       ` Krzysztof Kozlowski
2025-11-07  9:03         ` Joan Na
2025-10-14 16:35   ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08b4c0a0-cc59-4640-94ff-2d243c558a67@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joan.na.devcode@gmail.com \
    --cc=joan.na@analog.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®