Re: [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator binding

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1654 bytes --]

On Tue, Oct 14, 2025 at 11:54:41PM +0200, Krzysztof Kozlowski wrote:
> On 14/10/2025 15:11, Mark Brown wrote:
> > On Tue, Oct 14, 2025 at 10:14:15AM +0200, Krzysztof Kozlowski wrote:
> >> On 14/10/2025 07:31, Joan-Na-adi wrote:

> >>> +  maxim,en-mode:
> >>> +    description: |
> >>> +      Enable mode configuration.
> >>> +      "push-button"  - Push button
> >>> +      "slide-switch" - Slide switch
> >>> +      "logic" - Logic mode

> >> You just repeat the name in the description. Say something useful.

> > Do you have concrete suggestions there?  I can see dropping the
> > descriptions entirely but otherwise I'm not sure there's much to
> > usefully add.

> Then just drop descriptions. I could imagine datasheet has something
> more, but if not, then really no point to copy paste.

I suspect someone said descriptions were needed...  TBH I think just
the enumerated names are clear enough.

> >>> +  maxim,dvs-slew-rate-mv-per-us:

> >> Except you said mv/us, not us. Confusing.

> > That's what I'd expect for a slew rate?  It's the speed with which the
> > device ramps between voltages during voltage transitions, mV/us is a
> > perfectly normal unit for that.

> Yeah, but the property unit suffix "-us" says that unit is us, so not
> mv/us. I think we did not have that case so far, unless I missed such,
> so either we ignore description mismatch from property-units or we
> change it to something, like "-mvperus".
> https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

Right, and the above does say "mv-per-us" which is how I'd have expected
those units to be formatted rather than "mvperus".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]