mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Joan-Na-adi <joan.na.devcode@gmail.com>
Cc: Joan Na <joan.na@analog.com>, Mark Brown <broonie@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	 Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator binding
Date: Tue, 14 Oct 2025 11:35:16 -0500	[thread overview]
Message-ID: <176045970397.4162063.2449885497355673633.robh@kernel.org> (raw)
In-Reply-To: <20251014053142.15835-4-joan.na@analog.com>


On Tue, 14 Oct 2025 14:31:42 +0900, Joan-Na-adi wrote:
> From: Joan Na <joan.na@analog.com>
> 
> Add device tree binding YAML schema for the Maxim MAX77675 PMIC regulator.
> This defines the node properties and supported regulator names for use
> in device tree sources.
> 
> Fixed:
> - Missing explanation of `maxim,fps-slot` default value
> - Updated DT binding enums to use string values (e.g., "low", "high") instead of integers
> - Converted several binary properties to boolean type
> - Renamed time-based properties to use standard unit suffixes (e.g., "-sec", "-us")
> - Added default values for properties
> 
> Signed-off-by: Joan Na <joan.na@analog.com>
> ---
>  .../bindings/regulator/maxim,max77675.yaml    | 205 ++++++++++++++++++
>  1 file changed, 205 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77675.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:36:12: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:36:27: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:36:43: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:37:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:45:12: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:45:20: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:46:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:58:12: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:58:19: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:58:27: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:58:34: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:59:14: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:25: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:34: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:43: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/regulator/maxim,max77675.yaml:126:52: [error] string value is redundantly quoted with any quotes (quoted-strings)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251014053142.15835-4-joan.na@analog.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      parent reply	other threads:[~2025-10-14 16:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  5:31 [PATCH v3 0/3] MAX77675 regulator driver: Add support for MAX77675 device Joan-Na-adi
2025-10-14  5:31 ` [PATCH v3 1/3] dt-bindings: regulator: Add MAX77675 binding header Joan-Na-adi
2025-10-14  8:09   ` Krzysztof Kozlowski
2025-10-20 10:12   ` Krzysztof Kozlowski
2025-10-14  5:31 ` [PATCH v3 2/3] regulator: max77675: Add MAX77675 regulator driver Joan-Na-adi
2025-10-14  8:17   ` Krzysztof Kozlowski
2025-10-14  5:31 ` [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator binding Joan-Na-adi
2025-10-14  8:14   ` Krzysztof Kozlowski
2025-10-14 13:11     ` Mark Brown
2025-10-14 21:54       ` Krzysztof Kozlowski
2025-10-14 22:08         ` Mark Brown
2025-11-06  5:29     ` Joan Na
2025-11-06  7:08       ` Krzysztof Kozlowski
2025-11-07  9:03         ` Joan Na
2025-10-14 16:35   ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176045970397.4162063.2449885497355673633.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joan.na.devcode@gmail.com \
    --cc=joan.na@analog.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®