[PATCH v5 00/10] media: Add support for Broadcom/RPi BCM2835 ISP

[PATCH v5 00/10] media: Add support for Broadcom/RPi BCM2835 ISP

[Jai Luthra]

Hi,

This series adds initial support for Broadcom/Raspberry Pi BCM2835 ISP
present on older Raspberry Pi boards.

The underlying hardware for the ISP is accessed through the VideoCore
VPU, via the VCHIQ/MMAL interface that was recently destaged under
platform/raspberrypi. The ISP driver, and thus this series, depends on
VCSM CMA driver for shared memory support (for lens shading buffers):

https://lore.kernel.org/all/20260916-b4-vc-sm-cma-v4-0-476d1142b5df@ideasonboard.com

The baseline driver was taken from the one present in the downstream
raspberrypi 6.12 tree (which was posted as v1 with minor cleanups).

Since then the driver has been significantly modified, switching away
from custom V4L2 controls to parameter buffers for ISP configuration,
and many other fixes.

This series along with dependencies is available for ease of testing in
this linux branch:
https://github.com/jailuthra/linux/tree/b4/rpi-isp

You can test this series with libcamera, using the following libcamera
branch:
https://github.com/jailuthra/libcamera/tree/pi4-upstream

This series (v4 onwards) depends on the latest raspberry pi firmware
that is in process of being published. I'll reply with a link to this
cover letter when it's available.

Thanks,
Jai

Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
Changes in v5:
- Add missing note in cover letter about dependency on latest firmware
- Update documentation of return type of vb2_core_expbuf_dmabuf() to only
  ERR_PTR and not NULL
- Fix warnings reported by media-ci (coccinelle, smatch etc.)
  - Use struct_group() around the fields we want to memcpy from UAPI param
    struct to the anonymous structs inside mmal_parameter_isp_parameters
  - Don't use complicated pointer arithmetic and instead write
    mmal_param->_mmal_substruct.update = 1 explicitly
  - Only check for IS_ERR and not IS_ERR_OR_NULL for output of
    vb2_core_expbuf_dmabuf()
  - Check node->id against array bounds
- Link to v4: https://lore.kernel.org/r/20260916-b4-vchiq-isp-v4-0-f668c2017b74@ideasonboard.com

Changes in v4:
- Rebase on v7.3-rc1
- Set ISP_NUM_INSTANCES to 1 until we have proper support for
  multiplexing ISP instances (Laurent)
- Add a new struct mmal_parameter_isp_parameters {} in mmal-parameters.h
  to send combined updates the firmware (Dave)
- Rework bcm2835-isp-params.c to use the above and save expensive
  messages over IPC boundary (Dave)
- Test if the firmware supports the single struct, and fail with an
  error message asking the user to update their firmware if not (Dave)
- Check for retval of isp_set_param() and print error messages if it
  fails
- Various cleanups and suggestions (Paul)
- Add "media: videobuf2-core: Move type check out of vb2_core_expbuf()"
  on Laurent's suggestion
- Drop comment about FourCC values being copied from V4L2
- Drop old paragraph in Kconfig that got copied from previous revision
- Link to v3: https://lore.kernel.org/r/20260717-b4-vchiq-isp-v3-0-fb8235e15c68@ideasonboard.com

Changes in v3:
- Rebase on v7.2-rc1
- Split PATCH 1 to add missing incles before moving the headers
- Update commit messages with Laurent's suggestions
- Drop redundant buffer list and locks for params as we send them
  immediately to the firmware in .buf_queue
- Drop the now empty .stop_streaming() for params node
- Minor cleanups
- Link to v2: https://lore.kernel.org/r/20260210-b4-vchiq-isp-v2-0-4403944152fe@ideasonboard.com

Changes in v2:
- Replace custom V4L2 controls (V4L2_CID_USER_BCM2835_ISP_*) with the
  V4L2 extensible parameters framework via a dedicated metadata output
  node (bcm2835-isp-params). Split params handling into new file
  bcm2835-isp-params.c.
- Add AWB gains and digital gain as extensible parameter block types
  instead of standard V4L2 integer controls.
- Use MEDIA_ENT_F_PROC_VIDEO_ISP instead of MEDIA_ENT_F_PROC_VIDEO_SCALER
  for the media entity function.
- Rework media controller registration: let video device nodes handle
  their own entity registration, removing the manual entity/interface
  creation in media_controller_register_node().
- Propagate colorspace, ycbcr_enc, xfer_func, and quantization properly
  through g_fmt/s_fmt.
- Fold the stats/params FourCC additions (previously a separate commit)
  into this patch.
- Drop the custom CID base commit (no longer needed).
- Update documentation.
- Link to v1: https://lore.kernel.org/r/20260113-b4-vchiq-isp-v1-0-ea0b300bffc8@ideasonboard.com

---
Dave Stevenson (1):
      media: videobuf2: Allow exporting of a struct dmabuf

Jai Luthra (7):
      media: videobuf2-core: Move type check out of vb2_core_expbuf()
      platform/raspberrypi: vchiq-mmal: Include missing headers
      platform/raspberrypi: vchiq-mmal: Move headers to include/linux
      platform/raspberrypi: vchiq-mmal: Support ISP parameters and stats
      platform/raspberrypi: vchiq-mmal: Support bayer and gray formats
      platform/raspberrypi: vchiq: Add helpers for vchiq driver data
      media: platform: broadcom: Move unicam driver to subdir

Naushir Patuck (2):
      media: platform: broadcom: Add bcm2835-isp driver
      platform/raspberrypi: vchiq: Load bcm2835_isp driver from vchiq

 Documentation/admin-guide/media/bcm2835-isp.dot    |   14 +
 Documentation/admin-guide/media/bcm2835-isp.rst    |   78 +
 Documentation/admin-guide/media/v4l-drivers.rst    |    1 +
 .../userspace-api/media/v4l/meta-formats.rst       |    1 +
 .../media/v4l/metafmt-bcm2835-isp.rst              |  101 ++
 MAINTAINERS                                        |   12 +-
 drivers/media/common/videobuf2/videobuf2-core.c    |   50 +-
 drivers/media/common/videobuf2/videobuf2-v4l2.c    |    8 +-
 drivers/media/dvb-core/dvb_vb2.c                   |    3 +-
 drivers/media/platform/broadcom/Kconfig            |   18 +-
 drivers/media/platform/broadcom/Makefile           |    3 +-
 .../media/platform/broadcom/bcm2835-isp/Kconfig    |   15 +
 .../media/platform/broadcom/bcm2835-isp/Makefile   |    4 +
 .../broadcom/bcm2835-isp/bcm2835-isp-common.h      |   50 +
 .../broadcom/bcm2835-isp/bcm2835-isp-fmts.h        |  558 +++++++
 .../broadcom/bcm2835-isp/bcm2835-isp-params.c      |  510 +++++++
 .../broadcom/bcm2835-isp/bcm2835-v4l2-isp.c        | 1516 ++++++++++++++++++++
 .../media/platform/broadcom/bcm2835-unicam/Kconfig |   18 +
 .../platform/broadcom/bcm2835-unicam/Makefile      |    3 +
 .../{ => bcm2835-unicam}/bcm2835-unicam-regs.h     |    0
 .../broadcom/{ => bcm2835-unicam}/bcm2835-unicam.c |    0
 drivers/media/v4l2-core/v4l2-ioctl.c               |    2 +
 .../raspberrypi/vchiq-interface/vchiq_arm.c        |    2 +
 .../platform/raspberrypi/vchiq-mmal/mmal-vchiq.c   |    9 +-
 .../linux/raspberrypi}/mmal-common.h               |    4 +
 .../linux/raspberrypi}/mmal-encodings.h            |   67 +
 .../linux/raspberrypi}/mmal-msg-common.h           |    0
 .../linux/raspberrypi}/mmal-msg-format.h           |    0
 .../linux/raspberrypi}/mmal-msg-port.h             |    0
 .../linux/raspberrypi}/mmal-msg.h                  |    0
 .../linux/raspberrypi}/mmal-parameters.h           |  217 +++
 .../linux/raspberrypi}/mmal-vchiq.h                |    0
 include/linux/raspberrypi/vchiq_arm.h              |    1 +
 include/linux/raspberrypi/vchiq_bus.h              |   10 +
 include/media/videobuf2-core.h                     |   21 +-
 include/uapi/linux/bcm2835-isp.h                   |  530 +++++++
 include/uapi/linux/videodev2.h                     |    2 +
 37 files changed, 3778 insertions(+), 50 deletions(-)
---
base-commit: e5e04726cdd043e309677071ab1b65a4b18f422b
change-id: 20250923-b4-vchiq-isp-7e8c22c2860c
prerequisite-change-id: 20251030-b4-vc-sm-cma-f6727c39cd25:v4
prerequisite-patch-id: 4fc8cb49edcbe9c8e699b4ab9f6863ac040a070b
prerequisite-patch-id: 0a5fdf8fe23298fac2c6d188e1686dd292901efc
prerequisite-patch-id: d6d9ee5b60f97112dcf1aea01212c724d9151505
prerequisite-patch-id: 3855700b608f20e2a6857a9702838d1e54fc31cb
prerequisite-patch-id: e2b1e84a1e94e7095b964da693129d36dda78bb0
prerequisite-patch-id: 07e50207cc947f44e1d626b31d0ace7e12a8f3a1
prerequisite-patch-id: 3d82a2605799686668729fdc2677c3f6b7c2aa0d
prerequisite-patch-id: 7795536d875736f74fb4b2e77ca106b127bedbc0
prerequisite-patch-id: ad833b78f90ce3081e470caf70e601fc573bb52d
prerequisite-patch-id: 1898d91213e9bd75be3109180527fb0caf6d7174
prerequisite-patch-id: d0cfc49c673c8c4a4c13d44a547104c24f57cb49

Best regards,
-- 
Jai Luthra <jai.luthra@ideasonboard.com>

[PATCH v5 01/10] media: videobuf2-core: Move type check out of vb2_core_expbuf()

[Jai Luthra]

vb2_core_expbuf() takes the type of the exportbuffer as an argument and
checks if it matches the type of the vb2 queue. Move that check to the
caller (vb2_expbuf).

There is only one other user of this, which is dvb-core, where the check
was anyway redundant as it passed the vb2 queue type instead. So update
it too.

Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/all/20260910150454.GP1892234%40killaraus.ideasonboard.com
---
Changes in v4:
- New patch in v4
---
 drivers/media/common/videobuf2/videobuf2-core.c | 9 ++-------
 drivers/media/common/videobuf2/videobuf2-v4l2.c | 8 ++++++--
 drivers/media/dvb-core/dvb_vb2.c                | 3 +--
 include/media/videobuf2-core.h                  | 5 ++---
 4 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
index b0a6084f1757..5e318165659f 100644
--- a/drivers/media/common/videobuf2/videobuf2-core.c
+++ b/drivers/media/common/videobuf2/videobuf2-core.c
@@ -2419,8 +2419,8 @@ static int __find_plane_by_offset(struct vb2_queue *q, unsigned long offset,
 	return 0;
 }
 
-int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
-		    struct vb2_buffer *vb, unsigned int plane, unsigned int flags)
+int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
+		    unsigned int plane, unsigned int flags)
 {
 	struct vb2_plane *vb_plane;
 	int ret;
@@ -2441,11 +2441,6 @@ int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
 		return -EINVAL;
 	}
 
-	if (type != q->type) {
-		dprintk(q, 1, "invalid buffer type\n");
-		return -EINVAL;
-	}
-
 	if (plane >= vb->num_planes) {
 		dprintk(q, 1, "buffer plane out of range\n");
 		return -EINVAL;
diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
index 5a1ee5eb9c0f..aee1a9244a7b 100644
--- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
+++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
@@ -877,14 +877,18 @@ int vb2_expbuf(struct vb2_queue *q, struct v4l2_exportbuffer *eb)
 {
 	struct vb2_buffer *vb;
 
+	if (eb->type != q->type) {
+		dprintk(q, 1, "invalid buffer type\n");
+		return -EINVAL;
+	}
+
 	vb = vb2_get_buffer(q, eb->index);
 	if (!vb) {
 		dprintk(q, 1, "can't find the requested buffer %u\n", eb->index);
 		return -EINVAL;
 	}
 
-	return vb2_core_expbuf(q, &eb->fd, eb->type, vb,
-				eb->plane, eb->flags);
+	return vb2_core_expbuf(q, &eb->fd, vb, eb->plane, eb->flags);
 }
 EXPORT_SYMBOL_GPL(vb2_expbuf);
 
diff --git a/drivers/media/dvb-core/dvb_vb2.c b/drivers/media/dvb-core/dvb_vb2.c
index 672b0efdca21..fe7a6554b30e 100644
--- a/drivers/media/dvb-core/dvb_vb2.c
+++ b/drivers/media/dvb-core/dvb_vb2.c
@@ -357,8 +357,7 @@ int dvb_vb2_expbuf(struct dvb_vb2_ctx *ctx, struct dmx_exportbuffer *exp)
 		return -EINVAL;
 	}
 
-	ret = vb2_core_expbuf(&ctx->vb_q, &exp->fd, q->type, vb2,
-			      0, exp->flags);
+	ret = vb2_core_expbuf(&ctx->vb_q, &exp->fd, vb2, 0, exp->flags);
 	if (ret) {
 		dprintk(1, "[%s] index=%d errno=%d\n", ctx->name,
 			exp->index, ret);
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index 4b4f4c15c53a..feda638d0064 100644
--- a/include/media/videobuf2-core.h
+++ b/include/media/videobuf2-core.h
@@ -959,7 +959,6 @@ int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
  * @q:		pointer to &struct vb2_queue with videobuf2 queue.
  * @fd:		pointer to the file descriptor associated with DMABUF
  *		(set by driver).
- * @type:	buffer type.
  * @vb:		pointer to struct &vb2_buffer.
  * @plane:	index of the plane to be exported, 0 for single plane queues
  * @flags:	file flags for newly created file, as defined at
@@ -973,8 +972,8 @@ int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
  *
  * Return: returns zero on success; an error code otherwise.
  */
-int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
-		    struct vb2_buffer *vb, unsigned int plane, unsigned int flags);
+int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
+		    unsigned int plane, unsigned int flags);
 
 /**
  * vb2_core_queue_init() - initialize a videobuf2 queue

-- 
2.55.0

Re: [PATCH v5 01/10] media: videobuf2-core: Move type check out of vb2_core_expbuf()

[Paul Elder]

Quoting Jai Luthra (2026-09-17 17:23:07)
> vb2_core_expbuf() takes the type of the exportbuffer as an argument and
> checks if it matches the type of the vb2 queue. Move that check to the
> caller (vb2_expbuf).
> 
> There is only one other user of this, which is dvb-core, where the check
> was anyway redundant as it passed the vb2 queue type instead. So update
> it too.
> 
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> Link: https://lore.kernel.org/all/20260910150454.GP1892234%40killaraus.ideasonboard.com
> ---
> Changes in v4:
> - New patch in v4
> ---
>  drivers/media/common/videobuf2/videobuf2-core.c | 9 ++-------
>  drivers/media/common/videobuf2/videobuf2-v4l2.c | 8 ++++++--
>  drivers/media/dvb-core/dvb_vb2.c                | 3 +--
>  include/media/videobuf2-core.h                  | 5 ++---
>  4 files changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index b0a6084f1757..5e318165659f 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -2419,8 +2419,8 @@ static int __find_plane_by_offset(struct vb2_queue *q, unsigned long offset,
>         return 0;
>  }
>  
> -int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
> -                   struct vb2_buffer *vb, unsigned int plane, unsigned int flags)
> +int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
> +                   unsigned int plane, unsigned int flags)
>  {
>         struct vb2_plane *vb_plane;
>         int ret;
> @@ -2441,11 +2441,6 @@ int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
>                 return -EINVAL;
>         }
>  
> -       if (type != q->type) {
> -               dprintk(q, 1, "invalid buffer type\n");
> -               return -EINVAL;
> -       }
> -
>         if (plane >= vb->num_planes) {
>                 dprintk(q, 1, "buffer plane out of range\n");
>                 return -EINVAL;
> diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> index 5a1ee5eb9c0f..aee1a9244a7b 100644
> --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
> +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> @@ -877,14 +877,18 @@ int vb2_expbuf(struct vb2_queue *q, struct v4l2_exportbuffer *eb)
>  {
>         struct vb2_buffer *vb;
>  
> +       if (eb->type != q->type) {
> +               dprintk(q, 1, "invalid buffer type\n");
> +               return -EINVAL;
> +       }
> +
>         vb = vb2_get_buffer(q, eb->index);
>         if (!vb) {
>                 dprintk(q, 1, "can't find the requested buffer %u\n", eb->index);
>                 return -EINVAL;
>         }
>  
> -       return vb2_core_expbuf(q, &eb->fd, eb->type, vb,
> -                               eb->plane, eb->flags);
> +       return vb2_core_expbuf(q, &eb->fd, vb, eb->plane, eb->flags);
>  }
>  EXPORT_SYMBOL_GPL(vb2_expbuf);
>  
> diff --git a/drivers/media/dvb-core/dvb_vb2.c b/drivers/media/dvb-core/dvb_vb2.c
> index 672b0efdca21..fe7a6554b30e 100644
> --- a/drivers/media/dvb-core/dvb_vb2.c
> +++ b/drivers/media/dvb-core/dvb_vb2.c
> @@ -357,8 +357,7 @@ int dvb_vb2_expbuf(struct dvb_vb2_ctx *ctx, struct dmx_exportbuffer *exp)
>                 return -EINVAL;
>         }
>  
> -       ret = vb2_core_expbuf(&ctx->vb_q, &exp->fd, q->type, vb2,
> -                             0, exp->flags);
> +       ret = vb2_core_expbuf(&ctx->vb_q, &exp->fd, vb2, 0, exp->flags);
>         if (ret) {
>                 dprintk(1, "[%s] index=%d errno=%d\n", ctx->name,
>                         exp->index, ret);
> diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
> index 4b4f4c15c53a..feda638d0064 100644
> --- a/include/media/videobuf2-core.h
> +++ b/include/media/videobuf2-core.h
> @@ -959,7 +959,6 @@ int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
>   * @q:         pointer to &struct vb2_queue with videobuf2 queue.
>   * @fd:                pointer to the file descriptor associated with DMABUF
>   *             (set by driver).
> - * @type:      buffer type.
>   * @vb:                pointer to struct &vb2_buffer.
>   * @plane:     index of the plane to be exported, 0 for single plane queues
>   * @flags:     file flags for newly created file, as defined at
> @@ -973,8 +972,8 @@ int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
>   *
>   * Return: returns zero on success; an error code otherwise.
>   */
> -int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
> -                   struct vb2_buffer *vb, unsigned int plane, unsigned int flags);
> +int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
> +                   unsigned int plane, unsigned int flags);
>  
>  /**
>   * vb2_core_queue_init() - initialize a videobuf2 queue
> 
> -- 
> 2.55.0
>

Re: [PATCH v5 01/10] media: videobuf2-core: Move type check out of vb2_core_expbuf()

[Jai Luthra]

Hi Tomasz, Hans,

Quoting Jai Luthra (2026-09-17 13:53:07)
> vb2_core_expbuf() takes the type of the exportbuffer as an argument and
> checks if it matches the type of the vb2 queue. Move that check to the
> caller (vb2_expbuf).
> 
> There is only one other user of this, which is dvb-core, where the check
> was anyway redundant as it passed the vb2 queue type instead. So update
> it too.
> 

Are you okay with this change?

I see that rest of this series is more-or-less reviewed. I was planning to
rebase and post a v6 this week.

Thanks,
    Jai

> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Link: https://lore.kernel.org/all/20260910150454.GP1892234%40killaraus.ideasonboard.com
> ---
> Changes in v4:
> - New patch in v4
> ---
>  drivers/media/common/videobuf2/videobuf2-core.c | 9 ++-------
>  drivers/media/common/videobuf2/videobuf2-v4l2.c | 8 ++++++--
>  drivers/media/dvb-core/dvb_vb2.c                | 3 +--
>  include/media/videobuf2-core.h                  | 5 ++---
>  4 files changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index b0a6084f1757..5e318165659f 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -2419,8 +2419,8 @@ static int __find_plane_by_offset(struct vb2_queue *q, unsigned long offset,
>         return 0;
>  }
>  
> -int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
> -                   struct vb2_buffer *vb, unsigned int plane, unsigned int flags)
> +int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
> +                   unsigned int plane, unsigned int flags)
>  {
>         struct vb2_plane *vb_plane;
>         int ret;
> @@ -2441,11 +2441,6 @@ int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
>                 return -EINVAL;
>         }
>  
> -       if (type != q->type) {
> -               dprintk(q, 1, "invalid buffer type\n");
> -               return -EINVAL;
> -       }
> -
>         if (plane >= vb->num_planes) {
>                 dprintk(q, 1, "buffer plane out of range\n");
>                 return -EINVAL;
> diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> index 5a1ee5eb9c0f..aee1a9244a7b 100644
> --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
> +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> @@ -877,14 +877,18 @@ int vb2_expbuf(struct vb2_queue *q, struct v4l2_exportbuffer *eb)
>  {
>         struct vb2_buffer *vb;
>  
> +       if (eb->type != q->type) {
> +               dprintk(q, 1, "invalid buffer type\n");
> +               return -EINVAL;
> +       }
> +
>         vb = vb2_get_buffer(q, eb->index);
>         if (!vb) {
>                 dprintk(q, 1, "can't find the requested buffer %u\n", eb->index);
>                 return -EINVAL;
>         }
>  
> -       return vb2_core_expbuf(q, &eb->fd, eb->type, vb,
> -                               eb->plane, eb->flags);
> +       return vb2_core_expbuf(q, &eb->fd, vb, eb->plane, eb->flags);
>  }
>  EXPORT_SYMBOL_GPL(vb2_expbuf);
>  
> diff --git a/drivers/media/dvb-core/dvb_vb2.c b/drivers/media/dvb-core/dvb_vb2.c
> index 672b0efdca21..fe7a6554b30e 100644
> --- a/drivers/media/dvb-core/dvb_vb2.c
> +++ b/drivers/media/dvb-core/dvb_vb2.c
> @@ -357,8 +357,7 @@ int dvb_vb2_expbuf(struct dvb_vb2_ctx *ctx, struct dmx_exportbuffer *exp)
>                 return -EINVAL;
>         }
>  
> -       ret = vb2_core_expbuf(&ctx->vb_q, &exp->fd, q->type, vb2,
> -                             0, exp->flags);
> +       ret = vb2_core_expbuf(&ctx->vb_q, &exp->fd, vb2, 0, exp->flags);
>         if (ret) {
>                 dprintk(1, "[%s] index=%d errno=%d\n", ctx->name,
>                         exp->index, ret);
> diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
> index 4b4f4c15c53a..feda638d0064 100644
> --- a/include/media/videobuf2-core.h
> +++ b/include/media/videobuf2-core.h
> @@ -959,7 +959,6 @@ int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
>   * @q:         pointer to &struct vb2_queue with videobuf2 queue.
>   * @fd:                pointer to the file descriptor associated with DMABUF
>   *             (set by driver).
> - * @type:      buffer type.
>   * @vb:                pointer to struct &vb2_buffer.
>   * @plane:     index of the plane to be exported, 0 for single plane queues
>   * @flags:     file flags for newly created file, as defined at
> @@ -973,8 +972,8 @@ int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
>   *
>   * Return: returns zero on success; an error code otherwise.
>   */
> -int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
> -                   struct vb2_buffer *vb, unsigned int plane, unsigned int flags);
> +int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
> +                   unsigned int plane, unsigned int flags);
>  
>  /**
>   * vb2_core_queue_init() - initialize a videobuf2 queue
> 
> -- 
> 2.55.0
>

Re: [PATCH v5 01/10] media: videobuf2-core: Move type check out of vb2_core_expbuf()

[Hans Verkuil]

On 9/17/26 10:23, Jai Luthra wrote:
> vb2_core_expbuf() takes the type of the exportbuffer as an argument and
> checks if it matches the type of the vb2 queue. Move that check to the
> caller (vb2_expbuf).
> 
> There is only one other user of this, which is dvb-core, where the check
> was anyway redundant as it passed the vb2 queue type instead. So update
> it too.
> 
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Link: https://lore.kernel.org/all/20260910150454.GP1892234%40killaraus.ideasonboard.com


Reviewed-by: Hans Verkuil <hverkuil+cisco@kernel.org>

Regards,

	Hans

> ---
> Changes in v4:
> - New patch in v4
> ---
>  drivers/media/common/videobuf2/videobuf2-core.c | 9 ++-------
>  drivers/media/common/videobuf2/videobuf2-v4l2.c | 8 ++++++--
>  drivers/media/dvb-core/dvb_vb2.c                | 3 +--
>  include/media/videobuf2-core.h                  | 5 ++---
>  4 files changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index b0a6084f1757..5e318165659f 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -2419,8 +2419,8 @@ static int __find_plane_by_offset(struct vb2_queue *q, unsigned long offset,
>  	return 0;
>  }
>  
> -int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
> -		    struct vb2_buffer *vb, unsigned int plane, unsigned int flags)
> +int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
> +		    unsigned int plane, unsigned int flags)
>  {
>  	struct vb2_plane *vb_plane;
>  	int ret;
> @@ -2441,11 +2441,6 @@ int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
>  		return -EINVAL;
>  	}
>  
> -	if (type != q->type) {
> -		dprintk(q, 1, "invalid buffer type\n");
> -		return -EINVAL;
> -	}
> -
>  	if (plane >= vb->num_planes) {
>  		dprintk(q, 1, "buffer plane out of range\n");
>  		return -EINVAL;
> diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> index 5a1ee5eb9c0f..aee1a9244a7b 100644
> --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
> +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> @@ -877,14 +877,18 @@ int vb2_expbuf(struct vb2_queue *q, struct v4l2_exportbuffer *eb)
>  {
>  	struct vb2_buffer *vb;
>  
> +	if (eb->type != q->type) {
> +		dprintk(q, 1, "invalid buffer type\n");
> +		return -EINVAL;
> +	}
> +
>  	vb = vb2_get_buffer(q, eb->index);
>  	if (!vb) {
>  		dprintk(q, 1, "can't find the requested buffer %u\n", eb->index);
>  		return -EINVAL;
>  	}
>  
> -	return vb2_core_expbuf(q, &eb->fd, eb->type, vb,
> -				eb->plane, eb->flags);
> +	return vb2_core_expbuf(q, &eb->fd, vb, eb->plane, eb->flags);
>  }
>  EXPORT_SYMBOL_GPL(vb2_expbuf);
>  
> diff --git a/drivers/media/dvb-core/dvb_vb2.c b/drivers/media/dvb-core/dvb_vb2.c
> index 672b0efdca21..fe7a6554b30e 100644
> --- a/drivers/media/dvb-core/dvb_vb2.c
> +++ b/drivers/media/dvb-core/dvb_vb2.c
> @@ -357,8 +357,7 @@ int dvb_vb2_expbuf(struct dvb_vb2_ctx *ctx, struct dmx_exportbuffer *exp)
>  		return -EINVAL;
>  	}
>  
> -	ret = vb2_core_expbuf(&ctx->vb_q, &exp->fd, q->type, vb2,
> -			      0, exp->flags);
> +	ret = vb2_core_expbuf(&ctx->vb_q, &exp->fd, vb2, 0, exp->flags);
>  	if (ret) {
>  		dprintk(1, "[%s] index=%d errno=%d\n", ctx->name,
>  			exp->index, ret);
> diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
> index 4b4f4c15c53a..feda638d0064 100644
> --- a/include/media/videobuf2-core.h
> +++ b/include/media/videobuf2-core.h
> @@ -959,7 +959,6 @@ int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
>   * @q:		pointer to &struct vb2_queue with videobuf2 queue.
>   * @fd:		pointer to the file descriptor associated with DMABUF
>   *		(set by driver).
> - * @type:	buffer type.
>   * @vb:		pointer to struct &vb2_buffer.
>   * @plane:	index of the plane to be exported, 0 for single plane queues
>   * @flags:	file flags for newly created file, as defined at
> @@ -973,8 +972,8 @@ int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
>   *
>   * Return: returns zero on success; an error code otherwise.
>   */
> -int vb2_core_expbuf(struct vb2_queue *q, int *fd, unsigned int type,
> -		    struct vb2_buffer *vb, unsigned int plane, unsigned int flags);
> +int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
> +		    unsigned int plane, unsigned int flags);
>  
>  /**
>   * vb2_core_queue_init() - initialize a videobuf2 queue
> 

[PATCH v5 02/10] platform/raspberrypi: vchiq-mmal: Include missing headers

[Jai Luthra]

The structures defined in mmal-common.h use types related to lists and
videobuf2 framework, but are missing the explicit includes for them.
Include those.

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h b/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h
index 6c5092a68b99..c9976bdd7490 100644
--- a/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h
+++ b/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h
@@ -16,6 +16,10 @@
 #ifndef MMAL_COMMON_H
 #define MMAL_COMMON_H
 
+#include <linux/list.h>
+#include <linux/types.h>
+#include <media/videobuf2-v4l2.h>
+
 #define MMAL_FOURCC(a, b, c, d) ((a) | (b << 8) | (c << 16) | (d << 24))
 #define MMAL_MAGIC MMAL_FOURCC('m', 'm', 'a', 'l')
 

-- 
2.55.0

[PATCH v5 03/10] platform/raspberrypi: vchiq-mmal: Move headers to include/linux

[Jai Luthra]

Now that VCHIQ interface is destaged, different drivers (like ISP or
codec) no longer live under the same tree as VCHIQ-MMAL, but in their
relevant trees like media or audio.

Enable access to the MMAL headers for such drivers by moving them under
include/linux/raspberrypi with other VCHIQ headers.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
Changes in v4:
- None
Changes in v3:
- Split missing includes patch
- Update commit message
---
 MAINTAINERS                                                      | 1 +
 drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c             | 9 ++++-----
 .../vchiq-mmal => include/linux/raspberrypi}/mmal-common.h       | 0
 .../vchiq-mmal => include/linux/raspberrypi}/mmal-encodings.h    | 0
 .../vchiq-mmal => include/linux/raspberrypi}/mmal-msg-common.h   | 0
 .../vchiq-mmal => include/linux/raspberrypi}/mmal-msg-format.h   | 0
 .../vchiq-mmal => include/linux/raspberrypi}/mmal-msg-port.h     | 0
 .../vchiq-mmal => include/linux/raspberrypi}/mmal-msg.h          | 0
 .../vchiq-mmal => include/linux/raspberrypi}/mmal-parameters.h   | 0
 .../vchiq-mmal => include/linux/raspberrypi}/mmal-vchiq.h        | 0
 10 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index b887ac593088..0ac9a9d7b215 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5160,6 +5160,7 @@ F:	Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
 F:	drivers/pci/controller/pcie-brcmstb.c
 F:	drivers/platform/raspberrypi/vchiq-*
 F:	drivers/staging/vc04_services
+F:	include/linux/raspberrypi/mmal*
 F:	include/linux/raspberrypi/vchiq*
 N:	bcm2711
 N:	bcm2712
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c b/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
index ccd8910c315f..80406e1f4bdc 100644
--- a/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
+++ b/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
@@ -22,17 +22,16 @@
 #include <linux/mm.h>
 #include <linux/slab.h>
 #include <linux/completion.h>
+#include <linux/raspberrypi/mmal-common.h>
+#include <linux/raspberrypi/mmal-parameters.h>
+#include <linux/raspberrypi/mmal-vchiq.h>
+#include <linux/raspberrypi/mmal-msg.h>
 #include <linux/raspberrypi/vchiq.h>
 #include <linux/raspberrypi/vchiq_arm.h>
 #include <linux/raspberrypi/vc_sm_knl.h>
 #include <linux/vmalloc.h>
 #include <media/videobuf2-vmalloc.h>
 
-#include "mmal-common.h"
-#include "mmal-parameters.h"
-#include "mmal-vchiq.h"
-#include "mmal-msg.h"
-
 /*
  * maximum number of components supported.
  * This matches the maximum permitted by default on the VPU
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h b/include/linux/raspberrypi/mmal-common.h
similarity index 100%
rename from drivers/platform/raspberrypi/vchiq-mmal/mmal-common.h
rename to include/linux/raspberrypi/mmal-common.h
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-encodings.h b/include/linux/raspberrypi/mmal-encodings.h
similarity index 100%
rename from drivers/platform/raspberrypi/vchiq-mmal/mmal-encodings.h
rename to include/linux/raspberrypi/mmal-encodings.h
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-msg-common.h b/include/linux/raspberrypi/mmal-msg-common.h
similarity index 100%
rename from drivers/platform/raspberrypi/vchiq-mmal/mmal-msg-common.h
rename to include/linux/raspberrypi/mmal-msg-common.h
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-msg-format.h b/include/linux/raspberrypi/mmal-msg-format.h
similarity index 100%
rename from drivers/platform/raspberrypi/vchiq-mmal/mmal-msg-format.h
rename to include/linux/raspberrypi/mmal-msg-format.h
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-msg-port.h b/include/linux/raspberrypi/mmal-msg-port.h
similarity index 100%
rename from drivers/platform/raspberrypi/vchiq-mmal/mmal-msg-port.h
rename to include/linux/raspberrypi/mmal-msg-port.h
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-msg.h b/include/linux/raspberrypi/mmal-msg.h
similarity index 100%
rename from drivers/platform/raspberrypi/vchiq-mmal/mmal-msg.h
rename to include/linux/raspberrypi/mmal-msg.h
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-parameters.h b/include/linux/raspberrypi/mmal-parameters.h
similarity index 100%
rename from drivers/platform/raspberrypi/vchiq-mmal/mmal-parameters.h
rename to include/linux/raspberrypi/mmal-parameters.h
diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.h b/include/linux/raspberrypi/mmal-vchiq.h
similarity index 100%
rename from drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.h
rename to include/linux/raspberrypi/mmal-vchiq.h

-- 
2.55.0

[PATCH v5 04/10] platform/raspberrypi: vchiq-mmal: Support ISP parameters and stats

[Jai Luthra]

The ISP used on BCM2835 and derivative platforms is behind the VCHIQ
bus, where some parameters and statistics are accessed through the MMAL
layer.

So add the relevant structures, macros and enum values.

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 include/linux/raspberrypi/mmal-encodings.h  |  4 ++
 include/linux/raspberrypi/mmal-parameters.h | 86 +++++++++++++++++++++++++++++
 2 files changed, 90 insertions(+)

diff --git a/include/linux/raspberrypi/mmal-encodings.h b/include/linux/raspberrypi/mmal-encodings.h
index e15ae7b24f73..eadf2e981408 100644
--- a/include/linux/raspberrypi/mmal-encodings.h
+++ b/include/linux/raspberrypi/mmal-encodings.h
@@ -73,6 +73,10 @@
  */
 #define MMAL_ENCODING_EGL_IMAGE        MMAL_FOURCC('E', 'G', 'L', 'I')
 
+/** ISP image statistics format
+ */
+#define MMAL_ENCODING_BRCM_STATS       MMAL_FOURCC('S', 'T', 'A', 'T')
+
 /* }@ */
 
 /** \name Pre-defined audio encodings */
diff --git a/include/linux/raspberrypi/mmal-parameters.h b/include/linux/raspberrypi/mmal-parameters.h
index a0cdd28101f2..6ae5a7a1932c 100644
--- a/include/linux/raspberrypi/mmal-parameters.h
+++ b/include/linux/raspberrypi/mmal-parameters.h
@@ -223,6 +223,64 @@ enum mmal_parameter_camera_type {
 	MMAL_PARAMETER_SHUTTER_SPEED,
 		/**< Takes a @ref MMAL_PARAMETER_AWB_GAINS_T */
 	MMAL_PARAMETER_CUSTOM_AWB_GAINS,
+		/**< Takes a @ref MMAL_PARAMETER_CAMERA_SETTINGS_T */
+	MMAL_PARAMETER_CAMERA_SETTINGS,
+		/**< Takes a @ref MMAL_PARAMETER_PRIVACY_INDICATOR_T */
+	MMAL_PARAMETER_PRIVACY_INDICATOR,
+		/**< Takes a @ref MMAL_PARAMETER_BOOLEAN_T */
+	MMAL_PARAMETER_VIDEO_DENOISE,
+		/**< Takes a @ref MMAL_PARAMETER_BOOLEAN_T */
+	MMAL_PARAMETER_STILLS_DENOISE,
+		/**< Takes a @ref MMAL_PARAMETER_CAMERA_ANNOTATE_T */
+	MMAL_PARAMETER_ANNOTATE,
+		/**< Takes a @ref MMAL_PARAMETER_STEREOSCOPIC_MODE_T */
+	MMAL_PARAMETER_STEREOSCOPIC_MODE,
+		/**< Takes a @ref MMAL_PARAMETER_CAMERA_INTERFACE_T */
+	MMAL_PARAMETER_CAMERA_INTERFACE,
+		/**< Takes a @ref MMAL_PARAMETER_CAMERA_CLOCKING_MODE_T */
+	MMAL_PARAMETER_CAMERA_CLOCKING_MODE,
+		/**< Takes a @ref MMAL_PARAMETER_CAMERA_RX_CONFIG_T */
+	MMAL_PARAMETER_CAMERA_RX_CONFIG,
+		/**< Takes a @ref MMAL_PARAMETER_CAMERA_RX_TIMING_T */
+	MMAL_PARAMETER_CAMERA_RX_TIMING,
+		/**< Takes a @ref MMAL_PARAMETER_UINT32_T */
+	MMAL_PARAMETER_DPF_CONFIG,
+
+	/* 0x50 */
+		/**< Takes a @ref MMAL_PARAMETER_UINT32_T */
+	MMAL_PARAMETER_JPEG_RESTART_INTERVAL,
+		/**< Takes a @ref MMAL_PARAMETER_UINT32_T */
+	MMAL_PARAMETER_CAMERA_ISP_BLOCK_OVERRIDE,
+		/**< Takes a @ref MMAL_PARAMETER_LENS_SHADING_T */
+	MMAL_PARAMETER_LENS_SHADING_OVERRIDE,
+		/**< Takes a @ref MMAL_PARAMETER_UINT32_T */
+	MMAL_PARAMETER_BLACK_LEVEL,
+		/**< Takes a @ref MMAL_PARAMETER_RESIZE_T */
+	MMAL_PARAMETER_RESIZE_PARAMS,
+		/**< Takes a @ref MMAL_PARAMETER_CROP_T */
+	MMAL_PARAMETER_CROP,
+		/**< Takes a @ref MMAL_PARAMETER_INT32_T */
+	MMAL_PARAMETER_OUTPUT_SHIFT,
+		/**< Takes a @ref MMAL_PARAMETER_INT32_T */
+	MMAL_PARAMETER_CCM_SHIFT,
+		/**< Takes a @ref MMAL_PARAMETER_CUSTOM_CCM_T */
+	MMAL_PARAMETER_CUSTOM_CCM,
+		/**< Takes a @ref MMAL_PARAMETER_RATIONAL_T */
+	MMAL_PARAMETER_ANALOG_GAIN,
+		/**< Takes a @ref MMAL_PARAMETER_RATIONAL_T */
+	MMAL_PARAMETER_DIGITAL_GAIN,
+		/**< Takes a @ref MMAL_PARAMETER_DENOISE_T */
+	MMAL_PARAMETER_DENOISE,
+		/**< Takes a @ref MMAL_PARAMETER_SHARPEN_T */
+	MMAL_PARAMETER_SHARPEN,
+		/**< Takes a @ref MMAL_PARAMETER_GEQ_T */
+	MMAL_PARAMETER_GEQ,
+		/**< Tales a @ref MMAP_PARAMETER_DPC_T */
+	MMAL_PARAMETER_DPC,
+		/**< Tales a @ref MMAP_PARAMETER_GAMMA_T */
+	MMAL_PARAMETER_GAMMA,
+		/**< Takes a @ref MMAL_PARAMETER_CDN_T */
+	MMAL_PARAMETER_CDN,
 };
 
 enum mmal_parameter_camera_config_timestamp_mode {
@@ -749,4 +807,32 @@ struct mmal_parameter_camera_info {
 				flashes[MMAL_PARAMETER_CAMERA_INFO_MAX_FLASHES];
 };
 
+enum mmal_parameter_ls_gain_format_type {
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_U0P8_1 = 0,
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_U1P7_0 = 1,
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_U1P7_1 = 2,
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_U2P6_0 = 3,
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_U2P6_1 = 4,
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_U3P5_0 = 5,
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_U3P5_1 = 6,
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_U4P10  = 7,
+	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_DUMMY  = 0x7FFFFFFF
+};
+
+struct mmal_parameter_lens_shading_v2 {
+	u32 enabled;
+	u32 grid_cell_size;
+	u32 grid_width;
+	u32 grid_stride;
+	u32 grid_height;
+	u32 mem_handle_table;
+	u32 ref_transform;
+	u32 corner_sampled;
+	enum mmal_parameter_ls_gain_format_type gain_format;
+};
+
+struct mmal_parameter_crop {
+	struct vchiq_mmal_rect rect;
+};
+
 #endif

-- 
2.55.0

[PATCH v5 05/10] platform/raspberrypi: vchiq-mmal: Support bayer and gray formats

[Jai Luthra]

Raw camera sensors often send data as packed or unpacked bayer and gray
formats, which needs to be processed by the ISP.

Add macros to support bayer and gray format FOURCCs in the MMAL layer.

Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
Changes in v4:
- Drop comment about FourCC values being copied from V4L2
---
 include/linux/raspberrypi/mmal-encodings.h | 63 ++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/include/linux/raspberrypi/mmal-encodings.h b/include/linux/raspberrypi/mmal-encodings.h
index eadf2e981408..fd9cd840cb7b 100644
--- a/include/linux/raspberrypi/mmal-encodings.h
+++ b/include/linux/raspberrypi/mmal-encodings.h
@@ -69,6 +69,69 @@
  */
 #define MMAL_ENCODING_OPAQUE           MMAL_FOURCC('O', 'P', 'Q', 'V')
 
+/**
+ * Bayer formats
+ */
+/* 8 bit per pixel Bayer formats. */
+#define MMAL_ENCODING_BAYER_SBGGR8     MMAL_FOURCC('B', 'A', '8', '1')
+#define MMAL_ENCODING_BAYER_SGBRG8     MMAL_FOURCC('G', 'B', 'R', 'G')
+#define MMAL_ENCODING_BAYER_SGRBG8     MMAL_FOURCC('G', 'R', 'B', 'G')
+#define MMAL_ENCODING_BAYER_SRGGB8     MMAL_FOURCC('R', 'G', 'G', 'B')
+
+/* 10 bit per pixel packed Bayer formats. */
+#define MMAL_ENCODING_BAYER_SBGGR10P   MMAL_FOURCC('p', 'B', 'A', 'A')
+#define MMAL_ENCODING_BAYER_SGRBG10P   MMAL_FOURCC('p', 'g', 'A', 'A')
+#define MMAL_ENCODING_BAYER_SGBRG10P   MMAL_FOURCC('p', 'G', 'A', 'A')
+#define MMAL_ENCODING_BAYER_SRGGB10P   MMAL_FOURCC('p', 'R', 'A', 'A')
+
+/* 12 bit per pixel packed Bayer formats. */
+#define MMAL_ENCODING_BAYER_SBGGR12P   MMAL_FOURCC('p', 'B', '1', '2')
+#define MMAL_ENCODING_BAYER_SGRBG12P   MMAL_FOURCC('p', 'g', '1', '2')
+#define MMAL_ENCODING_BAYER_SGBRG12P   MMAL_FOURCC('p', 'G', '1', '2')
+#define MMAL_ENCODING_BAYER_SRGGB12P   MMAL_FOURCC('p', 'R', '1', '2')
+
+/* 14 bit per pixel packed Bayer formats. */
+#define MMAL_ENCODING_BAYER_SBGGR14P   MMAL_FOURCC('p', 'B', 'E', 'E')
+#define MMAL_ENCODING_BAYER_SGBRG14P   MMAL_FOURCC('p', 'G', 'E', 'E')
+#define MMAL_ENCODING_BAYER_SGRBG14P   MMAL_FOURCC('p', 'g', 'E', 'E')
+#define MMAL_ENCODING_BAYER_SRGGB14P   MMAL_FOURCC('p', 'R', 'E', 'E')
+
+/* 16 bit per pixel Bayer formats. */
+#define MMAL_ENCODING_BAYER_SBGGR16    MMAL_FOURCC('B', 'G', '1', '6')
+#define MMAL_ENCODING_BAYER_SGBRG16    MMAL_FOURCC('G', 'B', '1', '6')
+#define MMAL_ENCODING_BAYER_SGRBG16    MMAL_FOURCC('G', 'R', '1', '6')
+#define MMAL_ENCODING_BAYER_SRGGB16    MMAL_FOURCC('R', 'G', '1', '6')
+
+/* 10 bit per pixel unpacked (16bit) Bayer formats. */
+#define MMAL_ENCODING_BAYER_SBGGR10    MMAL_FOURCC('B', 'G', '1', '0')
+#define MMAL_ENCODING_BAYER_SGRBG10    MMAL_FOURCC('B', 'A', '1', '0')
+#define MMAL_ENCODING_BAYER_SGBRG10    MMAL_FOURCC('G', 'B', '1', '0')
+#define MMAL_ENCODING_BAYER_SRGGB10    MMAL_FOURCC('R', 'G', '1', '0')
+
+/* 12 bit per pixel unpacked (16bit) Bayer formats */
+#define MMAL_ENCODING_BAYER_SBGGR12    MMAL_FOURCC('B', 'G', '1', '2')
+#define MMAL_ENCODING_BAYER_SGRBG12    MMAL_FOURCC('B', 'A', '1', '2')
+#define MMAL_ENCODING_BAYER_SGBRG12    MMAL_FOURCC('G', 'B', '1', '2')
+#define MMAL_ENCODING_BAYER_SRGGB12    MMAL_FOURCC('R', 'G', '1', '2')
+
+/* 14 bit per pixel unpacked (16bit) Bayer formats */
+#define MMAL_ENCODING_BAYER_SBGGR14    MMAL_FOURCC('B', 'G', '1', '4')
+#define MMAL_ENCODING_BAYER_SGBRG14    MMAL_FOURCC('G', 'B', '1', '4')
+#define MMAL_ENCODING_BAYER_SGRBG14    MMAL_FOURCC('G', 'R', '1', '4')
+#define MMAL_ENCODING_BAYER_SRGGB14    MMAL_FOURCC('R', 'G', '1', '4')
+
+/* MIPI packed monochrome images */
+#define MMAL_ENCODING_GREY    MMAL_FOURCC('G', 'R', 'E', 'Y')
+#define MMAL_ENCODING_Y10P    MMAL_FOURCC('Y', '1', '0', 'P')
+#define MMAL_ENCODING_Y12P    MMAL_FOURCC('Y', '1', '2', 'P')
+#define MMAL_ENCODING_Y14P    MMAL_FOURCC('Y', '1', '4', 'P')
+#define MMAL_ENCODING_Y16     MMAL_FOURCC('Y', '1', '6', ' ')
+
+/* Unpacked monochrome formats (16bit per sample, but only N LSBs used) */
+#define MMAL_ENCODING_Y10     MMAL_FOURCC('Y', '1', '0', ' ')
+#define MMAL_ENCODING_Y12     MMAL_FOURCC('Y', '1', '2', ' ')
+#define MMAL_ENCODING_Y14     MMAL_FOURCC('Y', '1', '4', ' ')
+
 /** An EGL image handle
  */
 #define MMAL_ENCODING_EGL_IMAGE        MMAL_FOURCC('E', 'G', 'L', 'I')

-- 
2.55.0

Re: [PATCH v5 05/10] platform/raspberrypi: vchiq-mmal: Support bayer and gray formats

[Paul Elder]

Quoting Jai Luthra (2026-09-17 17:23:11)
> Raw camera sensors often send data as packed or unpacked bayer and gray
> formats, which needs to be processed by the ISP.
> 
> Add macros to support bayer and gray format FOURCCs in the MMAL layer.
> 
> Tested-by: Paul Elder <paul.elder@ideasonboard.com>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> ---
> Changes in v4:
> - Drop comment about FourCC values being copied from V4L2

Ok, I've seen the comments from Dave. Sounds good to me.

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  include/linux/raspberrypi/mmal-encodings.h | 63 ++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
> 
> diff --git a/include/linux/raspberrypi/mmal-encodings.h b/include/linux/raspberrypi/mmal-encodings.h
> index eadf2e981408..fd9cd840cb7b 100644
> --- a/include/linux/raspberrypi/mmal-encodings.h
> +++ b/include/linux/raspberrypi/mmal-encodings.h
> @@ -69,6 +69,69 @@
>   */
>  #define MMAL_ENCODING_OPAQUE           MMAL_FOURCC('O', 'P', 'Q', 'V')
>  
> +/**
> + * Bayer formats
> + */
> +/* 8 bit per pixel Bayer formats. */
> +#define MMAL_ENCODING_BAYER_SBGGR8     MMAL_FOURCC('B', 'A', '8', '1')
> +#define MMAL_ENCODING_BAYER_SGBRG8     MMAL_FOURCC('G', 'B', 'R', 'G')
> +#define MMAL_ENCODING_BAYER_SGRBG8     MMAL_FOURCC('G', 'R', 'B', 'G')
> +#define MMAL_ENCODING_BAYER_SRGGB8     MMAL_FOURCC('R', 'G', 'G', 'B')
> +
> +/* 10 bit per pixel packed Bayer formats. */
> +#define MMAL_ENCODING_BAYER_SBGGR10P   MMAL_FOURCC('p', 'B', 'A', 'A')
> +#define MMAL_ENCODING_BAYER_SGRBG10P   MMAL_FOURCC('p', 'g', 'A', 'A')
> +#define MMAL_ENCODING_BAYER_SGBRG10P   MMAL_FOURCC('p', 'G', 'A', 'A')
> +#define MMAL_ENCODING_BAYER_SRGGB10P   MMAL_FOURCC('p', 'R', 'A', 'A')
> +
> +/* 12 bit per pixel packed Bayer formats. */
> +#define MMAL_ENCODING_BAYER_SBGGR12P   MMAL_FOURCC('p', 'B', '1', '2')
> +#define MMAL_ENCODING_BAYER_SGRBG12P   MMAL_FOURCC('p', 'g', '1', '2')
> +#define MMAL_ENCODING_BAYER_SGBRG12P   MMAL_FOURCC('p', 'G', '1', '2')
> +#define MMAL_ENCODING_BAYER_SRGGB12P   MMAL_FOURCC('p', 'R', '1', '2')
> +
> +/* 14 bit per pixel packed Bayer formats. */
> +#define MMAL_ENCODING_BAYER_SBGGR14P   MMAL_FOURCC('p', 'B', 'E', 'E')
> +#define MMAL_ENCODING_BAYER_SGBRG14P   MMAL_FOURCC('p', 'G', 'E', 'E')
> +#define MMAL_ENCODING_BAYER_SGRBG14P   MMAL_FOURCC('p', 'g', 'E', 'E')
> +#define MMAL_ENCODING_BAYER_SRGGB14P   MMAL_FOURCC('p', 'R', 'E', 'E')
> +
> +/* 16 bit per pixel Bayer formats. */
> +#define MMAL_ENCODING_BAYER_SBGGR16    MMAL_FOURCC('B', 'G', '1', '6')
> +#define MMAL_ENCODING_BAYER_SGBRG16    MMAL_FOURCC('G', 'B', '1', '6')
> +#define MMAL_ENCODING_BAYER_SGRBG16    MMAL_FOURCC('G', 'R', '1', '6')
> +#define MMAL_ENCODING_BAYER_SRGGB16    MMAL_FOURCC('R', 'G', '1', '6')
> +
> +/* 10 bit per pixel unpacked (16bit) Bayer formats. */
> +#define MMAL_ENCODING_BAYER_SBGGR10    MMAL_FOURCC('B', 'G', '1', '0')
> +#define MMAL_ENCODING_BAYER_SGRBG10    MMAL_FOURCC('B', 'A', '1', '0')
> +#define MMAL_ENCODING_BAYER_SGBRG10    MMAL_FOURCC('G', 'B', '1', '0')
> +#define MMAL_ENCODING_BAYER_SRGGB10    MMAL_FOURCC('R', 'G', '1', '0')
> +
> +/* 12 bit per pixel unpacked (16bit) Bayer formats */
> +#define MMAL_ENCODING_BAYER_SBGGR12    MMAL_FOURCC('B', 'G', '1', '2')
> +#define MMAL_ENCODING_BAYER_SGRBG12    MMAL_FOURCC('B', 'A', '1', '2')
> +#define MMAL_ENCODING_BAYER_SGBRG12    MMAL_FOURCC('G', 'B', '1', '2')
> +#define MMAL_ENCODING_BAYER_SRGGB12    MMAL_FOURCC('R', 'G', '1', '2')
> +
> +/* 14 bit per pixel unpacked (16bit) Bayer formats */
> +#define MMAL_ENCODING_BAYER_SBGGR14    MMAL_FOURCC('B', 'G', '1', '4')
> +#define MMAL_ENCODING_BAYER_SGBRG14    MMAL_FOURCC('G', 'B', '1', '4')
> +#define MMAL_ENCODING_BAYER_SGRBG14    MMAL_FOURCC('G', 'R', '1', '4')
> +#define MMAL_ENCODING_BAYER_SRGGB14    MMAL_FOURCC('R', 'G', '1', '4')
> +
> +/* MIPI packed monochrome images */
> +#define MMAL_ENCODING_GREY    MMAL_FOURCC('G', 'R', 'E', 'Y')
> +#define MMAL_ENCODING_Y10P    MMAL_FOURCC('Y', '1', '0', 'P')
> +#define MMAL_ENCODING_Y12P    MMAL_FOURCC('Y', '1', '2', 'P')
> +#define MMAL_ENCODING_Y14P    MMAL_FOURCC('Y', '1', '4', 'P')
> +#define MMAL_ENCODING_Y16     MMAL_FOURCC('Y', '1', '6', ' ')
> +
> +/* Unpacked monochrome formats (16bit per sample, but only N LSBs used) */
> +#define MMAL_ENCODING_Y10     MMAL_FOURCC('Y', '1', '0', ' ')
> +#define MMAL_ENCODING_Y12     MMAL_FOURCC('Y', '1', '2', ' ')
> +#define MMAL_ENCODING_Y14     MMAL_FOURCC('Y', '1', '4', ' ')
> +
>  /** An EGL image handle
>   */
>  #define MMAL_ENCODING_EGL_IMAGE        MMAL_FOURCC('E', 'G', 'L', 'I')
> 
> -- 
> 2.55.0
>

[PATCH v5 06/10] platform/raspberrypi: vchiq: Add helpers for vchiq driver data

[Jai Luthra]

Add helpers to set and get vchiq driver data. vchiq_set_drvdata() and
vchiq_get_drvdata() wraps dev_set_drvdata() and dev_get_drvdata()
respectively.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 include/linux/raspberrypi/vchiq_bus.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/linux/raspberrypi/vchiq_bus.h b/include/linux/raspberrypi/vchiq_bus.h
index e52291a3b247..513a144bfbe9 100644
--- a/include/linux/raspberrypi/vchiq_bus.h
+++ b/include/linux/raspberrypi/vchiq_bus.h
@@ -37,6 +37,16 @@ static inline struct vchiq_driver *to_vchiq_driver(struct device_driver *d)
 	return container_of(d, struct vchiq_driver, driver);
 }
 
+static inline void *vchiq_get_drvdata(const struct vchiq_device *device)
+{
+	return dev_get_drvdata(&device->dev);
+}
+
+static inline void vchiq_set_drvdata(struct vchiq_device *device, void *data)
+{
+	dev_set_drvdata(&device->dev, data);
+}
+
 extern const struct bus_type vchiq_bus_type;
 
 struct vchiq_device *

-- 
2.55.0

[PATCH v5 07/10] media: videobuf2: Allow exporting of a struct dmabuf

[Jai Luthra]

From: Dave Stevenson <dave.stevenson@raspberrypi.com>

videobuf2 only allowed exporting a dmabuf as a file descriptor,
but there are instances where having the struct dma_buf is
useful within the kernel.

Split the current implementation into two, one step which
exports a struct dma_buf, and the second which converts that
into an fd.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
Changes in v5:
- Update documentation of return type to only ERR_PTR and not NULL
Changes in v4:
- Return a pointer to struct dmabuf instead of passing it as a double
  pointer argument and returning an int for errors (Laurent)
- Document the return type (Paul)
---
 drivers/media/common/videobuf2/videobuf2-core.c | 45 ++++++++++++++++---------
 include/media/videobuf2-core.h                  | 16 +++++++++
 2 files changed, 45 insertions(+), 16 deletions(-)

diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
index 5e318165659f..7b99d39d7cb1 100644
--- a/drivers/media/common/videobuf2/videobuf2-core.c
+++ b/drivers/media/common/videobuf2/videobuf2-core.c
@@ -2419,50 +2419,63 @@ static int __find_plane_by_offset(struct vb2_queue *q, unsigned long offset,
 	return 0;
 }
 
-int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
-		    unsigned int plane, unsigned int flags)
+struct dma_buf *vb2_core_expbuf_dmabuf(struct vb2_queue *q,
+				       struct vb2_buffer *vb,
+				       unsigned int plane, unsigned int flags)
 {
 	struct vb2_plane *vb_plane;
-	int ret;
-	struct dma_buf *dbuf;
+	struct dma_buf *dmabuf;
 
 	if (q->memory != VB2_MEMORY_MMAP) {
 		dprintk(q, 1, "queue is not currently set up for mmap\n");
-		return -EINVAL;
+		return ERR_PTR(-EINVAL);
 	}
 
 	if (!q->mem_ops->get_dmabuf) {
 		dprintk(q, 1, "queue does not support DMA buffer exporting\n");
-		return -EINVAL;
+		return ERR_PTR(-EINVAL);
 	}
 
 	if (flags & ~(O_CLOEXEC | O_ACCMODE)) {
-		dprintk(q, 1, "queue does support only O_CLOEXEC and access mode flags\n");
-		return -EINVAL;
+		dprintk(q, 1, "queue supports only O_CLOEXEC and access mode flags\n");
+		return ERR_PTR(-EINVAL);
 	}
 
 	if (plane >= vb->num_planes) {
 		dprintk(q, 1, "buffer plane out of range\n");
-		return -EINVAL;
+		return ERR_PTR(-EINVAL);
 	}
 
 	if (vb2_fileio_is_active(q)) {
 		dprintk(q, 1, "expbuf: file io in progress\n");
-		return -EBUSY;
+		return ERR_PTR(-EBUSY);
 	}
 
 	vb_plane = &vb->planes[plane];
 
-	dbuf = call_ptr_memop(get_dmabuf,
-			      vb,
-			      vb_plane->mem_priv,
-			      flags & O_ACCMODE);
-	if (IS_ERR_OR_NULL(dbuf)) {
+	dmabuf = call_ptr_memop(get_dmabuf, vb, vb_plane->mem_priv,
+				flags & O_ACCMODE);
+	if (IS_ERR_OR_NULL(dmabuf)) {
 		dprintk(q, 1, "failed to export buffer %d, plane %d\n",
 			vb->index, plane);
-		return -EINVAL;
+		if (!dmabuf)
+			dmabuf = ERR_PTR(-EINVAL);
 	}
 
+	return dmabuf;
+}
+EXPORT_SYMBOL_GPL(vb2_core_expbuf_dmabuf);
+
+int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
+		    unsigned int plane, unsigned int flags)
+{
+	struct dma_buf *dbuf;
+	int ret;
+
+	dbuf = vb2_core_expbuf_dmabuf(q, vb, plane, flags);
+	if (IS_ERR(dbuf))
+		return PTR_ERR(dbuf);
+
 	ret = dma_buf_fd(dbuf, flags & ~O_ACCMODE);
 	if (ret < 0) {
 		dprintk(q, 3, "buffer %d, plane %d failed to export (%d)\n",
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index feda638d0064..45bfe8a2a12a 100644
--- a/include/media/videobuf2-core.h
+++ b/include/media/videobuf2-core.h
@@ -954,6 +954,22 @@ int vb2_core_streamon(struct vb2_queue *q, unsigned int type);
  */
 int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
 
+/**
+ * vb2_core_expbuf_dmabuf() - Export a buffer as a dma_buf structure
+ * @q:		pointer to &struct vb2_queue with videobuf2 queue
+ * @vb:		pointer to &struct vb2_buffer
+ * @plane:	index of the plane to be exported, 0 for single plane queues
+ * @flags:	file flags for newly created file, as defined at
+ *		include/uapi/asm-generic/fcntl.h.
+ *		Currently, the only used flag is %O_CLOEXEC.
+ *		is supported, refer to manual of open syscall for more details.
+ *
+ * Return: returns a pointer to &struct dma_buf on success; an ERR_PTR otherwise.
+ */
+struct dma_buf *vb2_core_expbuf_dmabuf(struct vb2_queue *q,
+				       struct vb2_buffer *vb,
+				       unsigned int plane, unsigned int flags);
+
 /**
  * vb2_core_expbuf() - Export a buffer as a file descriptor.
  * @q:		pointer to &struct vb2_queue with videobuf2 queue.

-- 
2.55.0

Re: [PATCH v5 07/10] media: videobuf2: Allow exporting of a struct dmabuf

[Hans Verkuil]

On 9/17/26 10:23, Jai Luthra wrote:
> From: Dave Stevenson <dave.stevenson@raspberrypi.com>
> 
> videobuf2 only allowed exporting a dmabuf as a file descriptor,
> but there are instances where having the struct dma_buf is
> useful within the kernel.
> 
> Split the current implementation into two, one step which
> exports a struct dma_buf, and the second which converts that
> into an fd.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> Tested-by: Paul Elder <paul.elder@ideasonboard.com>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>

Reviewed-by: Hans Verkuil <hverkuil+cisco@kernel.org>

Regards,

	Hans

> ---
> Changes in v5:
> - Update documentation of return type to only ERR_PTR and not NULL
> Changes in v4:
> - Return a pointer to struct dmabuf instead of passing it as a double
>   pointer argument and returning an int for errors (Laurent)
> - Document the return type (Paul)
> ---
>  drivers/media/common/videobuf2/videobuf2-core.c | 45 ++++++++++++++++---------
>  include/media/videobuf2-core.h                  | 16 +++++++++
>  2 files changed, 45 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index 5e318165659f..7b99d39d7cb1 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -2419,50 +2419,63 @@ static int __find_plane_by_offset(struct vb2_queue *q, unsigned long offset,
>  	return 0;
>  }
>  
> -int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
> -		    unsigned int plane, unsigned int flags)
> +struct dma_buf *vb2_core_expbuf_dmabuf(struct vb2_queue *q,
> +				       struct vb2_buffer *vb,
> +				       unsigned int plane, unsigned int flags)
>  {
>  	struct vb2_plane *vb_plane;
> -	int ret;
> -	struct dma_buf *dbuf;
> +	struct dma_buf *dmabuf;
>  
>  	if (q->memory != VB2_MEMORY_MMAP) {
>  		dprintk(q, 1, "queue is not currently set up for mmap\n");
> -		return -EINVAL;
> +		return ERR_PTR(-EINVAL);
>  	}
>  
>  	if (!q->mem_ops->get_dmabuf) {
>  		dprintk(q, 1, "queue does not support DMA buffer exporting\n");
> -		return -EINVAL;
> +		return ERR_PTR(-EINVAL);
>  	}
>  
>  	if (flags & ~(O_CLOEXEC | O_ACCMODE)) {
> -		dprintk(q, 1, "queue does support only O_CLOEXEC and access mode flags\n");
> -		return -EINVAL;
> +		dprintk(q, 1, "queue supports only O_CLOEXEC and access mode flags\n");
> +		return ERR_PTR(-EINVAL);
>  	}
>  
>  	if (plane >= vb->num_planes) {
>  		dprintk(q, 1, "buffer plane out of range\n");
> -		return -EINVAL;
> +		return ERR_PTR(-EINVAL);
>  	}
>  
>  	if (vb2_fileio_is_active(q)) {
>  		dprintk(q, 1, "expbuf: file io in progress\n");
> -		return -EBUSY;
> +		return ERR_PTR(-EBUSY);
>  	}
>  
>  	vb_plane = &vb->planes[plane];
>  
> -	dbuf = call_ptr_memop(get_dmabuf,
> -			      vb,
> -			      vb_plane->mem_priv,
> -			      flags & O_ACCMODE);
> -	if (IS_ERR_OR_NULL(dbuf)) {
> +	dmabuf = call_ptr_memop(get_dmabuf, vb, vb_plane->mem_priv,
> +				flags & O_ACCMODE);
> +	if (IS_ERR_OR_NULL(dmabuf)) {
>  		dprintk(q, 1, "failed to export buffer %d, plane %d\n",
>  			vb->index, plane);
> -		return -EINVAL;
> +		if (!dmabuf)
> +			dmabuf = ERR_PTR(-EINVAL);
>  	}
>  
> +	return dmabuf;
> +}
> +EXPORT_SYMBOL_GPL(vb2_core_expbuf_dmabuf);
> +
> +int vb2_core_expbuf(struct vb2_queue *q, int *fd, struct vb2_buffer *vb,
> +		    unsigned int plane, unsigned int flags)
> +{
> +	struct dma_buf *dbuf;
> +	int ret;
> +
> +	dbuf = vb2_core_expbuf_dmabuf(q, vb, plane, flags);
> +	if (IS_ERR(dbuf))
> +		return PTR_ERR(dbuf);
> +
>  	ret = dma_buf_fd(dbuf, flags & ~O_ACCMODE);
>  	if (ret < 0) {
>  		dprintk(q, 3, "buffer %d, plane %d failed to export (%d)\n",
> diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
> index feda638d0064..45bfe8a2a12a 100644
> --- a/include/media/videobuf2-core.h
> +++ b/include/media/videobuf2-core.h
> @@ -954,6 +954,22 @@ int vb2_core_streamon(struct vb2_queue *q, unsigned int type);
>   */
>  int vb2_core_streamoff(struct vb2_queue *q, unsigned int type);
>  
> +/**
> + * vb2_core_expbuf_dmabuf() - Export a buffer as a dma_buf structure
> + * @q:		pointer to &struct vb2_queue with videobuf2 queue
> + * @vb:		pointer to &struct vb2_buffer
> + * @plane:	index of the plane to be exported, 0 for single plane queues
> + * @flags:	file flags for newly created file, as defined at
> + *		include/uapi/asm-generic/fcntl.h.
> + *		Currently, the only used flag is %O_CLOEXEC.
> + *		is supported, refer to manual of open syscall for more details.
> + *
> + * Return: returns a pointer to &struct dma_buf on success; an ERR_PTR otherwise.
> + */
> +struct dma_buf *vb2_core_expbuf_dmabuf(struct vb2_queue *q,
> +				       struct vb2_buffer *vb,
> +				       unsigned int plane, unsigned int flags);
> +
>  /**
>   * vb2_core_expbuf() - Export a buffer as a file descriptor.
>   * @q:		pointer to &struct vb2_queue with videobuf2 queue.
> 

[PATCH v5 08/10] media: platform: broadcom: Move unicam driver to subdir

[Jai Luthra]

The BCM283x/BCM2711x SoCs capture camera frames using CSI-2, and
optionally process the raw frames using a VC4 firmware-based ISP block.

As the ISP driver will be added subsequently, move the files related to
the unicam driver to a separate subdirectory to ease distinction between
the two drivers' files.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
Changes in v4:
- Drop old paragraph in Kconfig that got copied from previous revision
---
 MAINTAINERS                                            |  2 +-
 drivers/media/platform/broadcom/Kconfig                | 17 ++---------------
 drivers/media/platform/broadcom/Makefile               |  2 +-
 drivers/media/platform/broadcom/bcm2835-unicam/Kconfig | 18 ++++++++++++++++++
 .../media/platform/broadcom/bcm2835-unicam/Makefile    |  3 +++
 .../{ => bcm2835-unicam}/bcm2835-unicam-regs.h         |  0
 .../broadcom/{ => bcm2835-unicam}/bcm2835-unicam.c     |  0
 7 files changed, 25 insertions(+), 17 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0ac9a9d7b215..68ef4b2f9db6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5185,7 +5185,7 @@ M:	Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml
-F:	drivers/media/platform/broadcom/bcm2835-unicam*
+F:	drivers/media/platform/broadcom/bcm2835-unicam/*
 
 BROADCOM BCM47XX MIPS ARCHITECTURE
 M:	Hauke Mehrtens <hauke@hauke-m.de>
diff --git a/drivers/media/platform/broadcom/Kconfig b/drivers/media/platform/broadcom/Kconfig
index 93ba565d9a02..cab44885182c 100644
--- a/drivers/media/platform/broadcom/Kconfig
+++ b/drivers/media/platform/broadcom/Kconfig
@@ -1,18 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
 
-config VIDEO_BCM2835_UNICAM
-	tristate "Broadcom BCM283x/BCM271x Unicam video capture driver"
-	depends on ARCH_BCM2835 || COMPILE_TEST
-	depends on COMMON_CLK && PM
-	depends on VIDEO_DEV
-	select MEDIA_CONTROLLER
-	select V4L2_FWNODE
-	select VIDEO_V4L2_SUBDEV_API
-	select VIDEOBUF2_DMA_CONTIG
-	help
-	  Say Y here to enable support for the BCM283x/BCM271x CSI-2 receiver.
-	  This is a V4L2 driver that controls the CSI-2 receiver directly,
-	  independently from the VC4 firmware.
+comment "Broadcom BCM283x/BCM271x media platform drivers"
 
-	  To compile this driver as a module, choose M here. The module will be
-	  called bcm2835-unicam.
+source "drivers/media/platform/broadcom/bcm2835-unicam/Kconfig"
diff --git a/drivers/media/platform/broadcom/Makefile b/drivers/media/platform/broadcom/Makefile
index 03d2045aba2e..33a89bdb0029 100644
--- a/drivers/media/platform/broadcom/Makefile
+++ b/drivers/media/platform/broadcom/Makefile
@@ -1,3 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
 
-obj-$(CONFIG_VIDEO_BCM2835_UNICAM) += bcm2835-unicam.o
+obj-y += bcm2835-unicam/
diff --git a/drivers/media/platform/broadcom/bcm2835-unicam/Kconfig b/drivers/media/platform/broadcom/bcm2835-unicam/Kconfig
new file mode 100644
index 000000000000..93ba565d9a02
--- /dev/null
+++ b/drivers/media/platform/broadcom/bcm2835-unicam/Kconfig
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: GPL-2.0
+
+config VIDEO_BCM2835_UNICAM
+	tristate "Broadcom BCM283x/BCM271x Unicam video capture driver"
+	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on COMMON_CLK && PM
+	depends on VIDEO_DEV
+	select MEDIA_CONTROLLER
+	select V4L2_FWNODE
+	select VIDEO_V4L2_SUBDEV_API
+	select VIDEOBUF2_DMA_CONTIG
+	help
+	  Say Y here to enable support for the BCM283x/BCM271x CSI-2 receiver.
+	  This is a V4L2 driver that controls the CSI-2 receiver directly,
+	  independently from the VC4 firmware.
+
+	  To compile this driver as a module, choose M here. The module will be
+	  called bcm2835-unicam.
diff --git a/drivers/media/platform/broadcom/bcm2835-unicam/Makefile b/drivers/media/platform/broadcom/bcm2835-unicam/Makefile
new file mode 100644
index 000000000000..03d2045aba2e
--- /dev/null
+++ b/drivers/media/platform/broadcom/bcm2835-unicam/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+
+obj-$(CONFIG_VIDEO_BCM2835_UNICAM) += bcm2835-unicam.o
diff --git a/drivers/media/platform/broadcom/bcm2835-unicam-regs.h b/drivers/media/platform/broadcom/bcm2835-unicam/bcm2835-unicam-regs.h
similarity index 100%
rename from drivers/media/platform/broadcom/bcm2835-unicam-regs.h
rename to drivers/media/platform/broadcom/bcm2835-unicam/bcm2835-unicam-regs.h
diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam/bcm2835-unicam.c
similarity index 100%
rename from drivers/media/platform/broadcom/bcm2835-unicam.c
rename to drivers/media/platform/broadcom/bcm2835-unicam/bcm2835-unicam.c

-- 
2.55.0

[PATCH v5 09/10] media: platform: broadcom: Add bcm2835-isp driver

[Jai Luthra]

From: Naushir Patuck <naush@raspberrypi.com>

The BCM2835 ISP is a fixed-function hardware block that performs image
processing on Bayer, RGB, and YUV frames. It produces two processed
video outputs at different resolutions and can generate statistics for
Bayer inputs. The hardware is not accessible directly, so this driver
programs it through the VCHIQ MMAL interface.

As the topology cannot be represented as a simple V4L2 M2M device, we
register a media device with 5 video nodes: one output (sink), two
capture (processed frames), one metadata capture (statistics), and one
metadata output (config parameters). The VCHIQ firmware supports two
concurrent users, so instantiate two identical media graphs.

ISP configuration uses the V4L2 extensible parameters framework through
the dedicated params node, allowing userspace to batch multiple
parameter blocks (black level, gamma, CCM, lens shading, etc.) in a
single buffer that is applied on the next frame boundary.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Co-developed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Co-developed-by: Jai Luthra <jai.luthra@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
---
Changes in v5:
- Fix warnings reported by media-ci (coccinelle, smatch etc.)
  - Use struct_group() around the fields we want to memcpy from UAPI param
    struct to the anonymous structs inside mmal_parameter_isp_parameters
  - Don't use complicated pointer arithmetic and instead write
    mmal_param->_mmal_substruct.update = 1 explicitly
  - Only check for IS_ERR and not IS_ERR_OR_NULL for output of
    vb2_core_expbuf_dmabuf()
  - Check node->id against array bounds
Changes in v4:
- Set ISP_NUM_INSTANCES to 1 until we have proper support for
  multiplexing ISP instances (Laurent)
- Add a new struct mmal_parameter_isp_parameters {} in mmal-parameters.h
  to send combined updates the firmware (Dave)
- Rework bcm2835-isp-params.c to use the above and save expensive
  messages over IPC boundary (Dave)
- Test if the firmware supports the single struct, and fail with an
  error message asking the user to update their firmware if not (Dave)
- Check for retval of isp_set_param() and print error messages if it
  fails
- Various cleanups and suggestions (Paul)
---
 Documentation/admin-guide/media/bcm2835-isp.dot    |   14 +
 Documentation/admin-guide/media/bcm2835-isp.rst    |   78 +
 Documentation/admin-guide/media/v4l-drivers.rst    |    1 +
 .../userspace-api/media/v4l/meta-formats.rst       |    1 +
 .../media/v4l/metafmt-bcm2835-isp.rst              |  101 ++
 MAINTAINERS                                        |    9 +
 drivers/media/platform/broadcom/Kconfig            |    1 +
 drivers/media/platform/broadcom/Makefile           |    1 +
 .../media/platform/broadcom/bcm2835-isp/Kconfig    |   15 +
 .../media/platform/broadcom/bcm2835-isp/Makefile   |    4 +
 .../broadcom/bcm2835-isp/bcm2835-isp-common.h      |   50 +
 .../broadcom/bcm2835-isp/bcm2835-isp-fmts.h        |  558 +++++++
 .../broadcom/bcm2835-isp/bcm2835-isp-params.c      |  510 +++++++
 .../broadcom/bcm2835-isp/bcm2835-v4l2-isp.c        | 1516 ++++++++++++++++++++
 drivers/media/v4l2-core/v4l2-ioctl.c               |    2 +
 include/linux/raspberrypi/mmal-parameters.h        |  155 +-
 include/uapi/linux/bcm2835-isp.h                   |  530 +++++++
 include/uapi/linux/videodev2.h                     |    2 +
 18 files changed, 3536 insertions(+), 12 deletions(-)

diff --git a/Documentation/admin-guide/media/bcm2835-isp.dot b/Documentation/admin-guide/media/bcm2835-isp.dot
new file mode 100644
index 000000000000..cda3defe2d99
--- /dev/null
+++ b/Documentation/admin-guide/media/bcm2835-isp.dot
@@ -0,0 +1,14 @@
+digraph board {
+	rankdir=TB
+	n00000001 [label="bcm2835-isp-output0\n/dev/video13", shape=box, style=filled, fillcolor=yellow]
+	n00000001 -> n00000015 [style=bold]
+	n00000005 [label="bcm2835-isp-capture0\n/dev/video14", shape=box, style=filled, fillcolor=yellow]
+	n00000009 [label="bcm2835-isp-capture1\n/dev/video15", shape=box, style=filled, fillcolor=yellow]
+	n0000000d [label="bcm2835-isp-stats2\n/dev/video16", shape=box, style=filled, fillcolor=yellow]
+	n00000011 [label="bcm2835-isp-params\n/dev/video17", shape=box, style=filled, fillcolor=yellow]
+	n00000011 -> n00000015 [style=bold]
+	n00000015 [label="bcm2835-isp\n", shape=box, style=filled, fillcolor=yellow]
+	n00000015 -> n00000005 [style=bold]
+	n00000015 -> n00000009 [style=bold]
+	n00000015 -> n0000000d [style=bold]
+}
diff --git a/Documentation/admin-guide/media/bcm2835-isp.rst b/Documentation/admin-guide/media/bcm2835-isp.rst
new file mode 100644
index 000000000000..6384cc7b3eb0
--- /dev/null
+++ b/Documentation/admin-guide/media/bcm2835-isp.rst
@@ -0,0 +1,78 @@
+.. SPDX-License-Identifier: GPL-2.0
+
+=============================================
+Broadcom BCM2835 Image Signal Processor (ISP)
+=============================================
+
+The BCM2835 ISP
+===============
+
+The BCM2835 Image Signal Processor (ISP) is a fixed function hardware pipeline
+that performs image processing on frames stored in memory. Frames can be Bayer,
+RGB, or YUV and are submitted to the ISP through a V4L2 output node. The ISP
+produces two processed image outputs at different resolutions and can generate
+statistics for Bayer inputs.
+
+The bcm2835-isp driver
+======================
+
+The bcm2835-isp driver lives under
+`drivers/media/platform/broadcom/bcm2835-isp` and registers a set of V4L2 video
+nodes connected through a media graph. The pipeline is configured through the
+V4L2 extensible parameters framework using a dedicated params node.
+
+The media topology registered by the driver is represented below:
+
+.. _bcm2835-isp-topology:
+
+.. kernel-figure:: bcm2835-isp.dot
+    :alt:   Diagram of the default media pipeline topology
+    :align: center
+
+The media graph registers the following video device nodes:
+
+- bcm2835-isp-output0: output device that queues frames to the ISP input.
+- bcm2835-isp-capture0: capture device for the main processed output.
+- bcm2835-isp-capture1: capture device for the secondary processed output.
+- bcm2835-isp-stats2: metadata capture device for ISP statistics.
+- bcm2835-isp-params: metadata output device for ISP configuration parameters.
+
+bcm2835-isp-output0
+-------------------
+
+Frames to be processed by the ISP are queued to `bcm2835-isp-output0`. Supported
+input formats include Bayer, RGB, and YUV.
+
+bcm2835-isp-capture0, bcm2835-isp-capture1
+------------------------------------------
+
+The two capture devices return processed images in YUV or RGB formats. The
+secondary output is typically used for a lower-resolution stream.
+
+bcm2835-isp-stats2
+------------------
+
+The `bcm2835-isp-stats2` node provides per-frame statistics for Bayer inputs as
+metadata buffers. The metadata format is described at
+:ref:`v4l2-meta-fmt-bcm2835-isp-stats`.
+
+bcm2835-isp-params
+------------------
+
+The `bcm2835-isp-params` node accepts configuration buffers that define the ISP
+processing parameters to apply on the next frame boundary. The metadata format
+is described at :ref:`v4l2-meta-fmt-bcm2835-isp-params`.
+
+ISP configuration
+=================
+
+The ISP configuration is described solely by the contents of the parameters
+buffer queued to `bcm2835-isp-params`. Each buffer uses the V4L2 extensible
+parameters format described in :ref:`v4l2-isp`, with block types defined in
+``include/uapi/linux/bcm2835-isp.h``.
+
+Userspace must populate a :c:type:`v4l2_isp_params_buffer` and append one or
+more block structs, each of which embeds a
+:c:type:`v4l2_isp_params_block_header` as its first member. The driver applies
+those parameters on a frame boundary once the buffer is queued. Parameter
+structure is defined at :ref:`v4l2-meta-fmt-bcm2835-isp-params`.
diff --git a/Documentation/admin-guide/media/v4l-drivers.rst b/Documentation/admin-guide/media/v4l-drivers.rst
index 4621eae9fa1e..cfbd9a64557d 100644
--- a/Documentation/admin-guide/media/v4l-drivers.rst
+++ b/Documentation/admin-guide/media/v4l-drivers.rst
@@ -10,6 +10,7 @@ Video4Linux (V4L) driver-specific documentation
 	:maxdepth: 2
 
 	amdisp4-1
+	bcm2835-isp
 	bttv
 	c3-isp
 	cafe_ccic
diff --git a/Documentation/userspace-api/media/v4l/meta-formats.rst b/Documentation/userspace-api/media/v4l/meta-formats.rst
index b5455229837e..02f0b6524472 100644
--- a/Documentation/userspace-api/media/v4l/meta-formats.rst
+++ b/Documentation/userspace-api/media/v4l/meta-formats.rst
@@ -14,6 +14,7 @@ These formats are used for the :ref:`metadata` interface only.
     :maxdepth: 1
 
     metafmt-arm-mali-c55
+    metafmt-bcm2835-isp
     metafmt-c3-isp
     metafmt-d4xx
     metafmt-generic
diff --git a/Documentation/userspace-api/media/v4l/metafmt-bcm2835-isp.rst b/Documentation/userspace-api/media/v4l/metafmt-bcm2835-isp.rst
new file mode 100644
index 000000000000..6ed1d1e7890f
--- /dev/null
+++ b/Documentation/userspace-api/media/v4l/metafmt-bcm2835-isp.rst
@@ -0,0 +1,101 @@
+.. SPDX-License-Identifier: GPL-2.0
+.. c:namespace:: V4L
+
+***********************************************************************************
+V4L2_META_FMT_BCM2835_ISP_STATS ('BSTA'), V4L2_META_FMT_BCM2835_ISP_PARAMS ('BCMP')
+***********************************************************************************
+
+.. _v4l2-meta-fmt-bcm2835-isp-stats:
+
+BCM2835 ISP Statistics
+======================
+
+The BCM2835 ISP hardware calculate image statistics for an input Bayer frame.
+These statistics are obtained from the "bcm2835-isp0-capture3" device node
+using the :c:type:`v4l2_meta_format` interface. They are formatted as described
+by the :c:type:`bcm2835_isp_stats` structure below.
+
+.. code-block:: c
+
+	#define DEFAULT_AWB_REGIONS_X 16
+	#define DEFAULT_AWB_REGIONS_Y 12
+
+	#define NUM_HISTOGRAMS 2
+	#define NUM_HISTOGRAM_BINS 128
+	#define AWB_REGIONS (DEFAULT_AWB_REGIONS_X * DEFAULT_AWB_REGIONS_Y)
+	#define FLOATING_REGIONS 16
+	#define AGC_REGIONS 16
+	#define FOCUS_REGIONS 12
+
+.. kernel-doc:: include/uapi/linux/bcm2835-isp.h
+   :functions: bcm2835_isp_stats_hist bcm2835_isp_stats_region
+	             bcm2835_isp_stats_focus bcm2835_isp_stats
+
+.. _v4l2-meta-fmt-bcm2835-isp-params:
+
+BCM2835 ISP parameters
+======================
+
+The ISP parameters are configured by queuing buffers to the "bcm2835-isp-params"
+metadata output node. Parameter buffers use the V4L2 extensible parameters
+format described in :ref:`v4l2-isp`. Userspace assembles one or more parameter
+blocks in the data area of :c:type:`v4l2_isp_params_buffer` and submits the
+buffer to the driver.
+
+Each block begins with a :c:type:`v4l2_isp_params_block_header` and embeds the
+block-specific payload. The header ``type`` must be set to a value from
+:c:type:`bcm2835_isp_param_block_type`, ``size`` must match the block size, and
+``flags`` can be used to enable or disable the block.
+
+Example: enqueue two parameter blocks (black level and gamma)
+-------------------------------------------------------------
+
+.. code-block:: c
+
+	struct v4l2_isp_params_buffer *params =
+		(struct v4l2_isp_params_buffer *)buffer;
+
+	params->version = BCM2835_ISP_PARAM_BUFFER_V1;
+	params->data_size = 0;
+
+	void *data = (void *)params->data;
+
+	struct bcm2835_isp_params_black_level *black =
+		(struct bcm2835_isp_params_black_level *)data;
+
+	black->header.type = BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL;
+	black->header.flags |= V4L2_ISP_PARAMS_FL_BLOCK_ENABLE;
+	black->header.size = sizeof(*black);
+
+	black->black_level.enabled = 1;
+	black->black_level.black_level_r = 64;
+	black->black_level.black_level_g = 64;
+	black->black_level.black_level_b = 64;
+
+	data += sizeof(*black);
+	params->data_size += sizeof(*black);
+
+	struct bcm2835_isp_params_gamma *gamma =
+		(struct bcm2835_isp_params_gamma *)data;
+
+	gamma->header.type = BCM2835_ISP_PARAM_BLOCK_GAMMA;
+	gamma->header.flags |= V4L2_ISP_PARAMS_FL_BLOCK_ENABLE;
+	gamma->header.size = sizeof(*gamma);
+
+	gamma->gamma.enabled = 1;
+	/* Fill gamma->gamma.x[] and gamma->gamma.y[] here */
+
+	params->data_size += sizeof(*gamma);
+
+The total payload size must not exceed :c:macro:`BCM2835_ISP_PARAMS_MAX_SIZE`.
+The driver applies parameter buffers on the next frame boundary.
+
+BCM2835 ISP uAPI data types
+===========================
+
+.. kernel-doc:: include/uapi/linux/bcm2835-isp.h
+   :functions: bcm2835_isp_awb_gains bcm2835_isp_ccm bcm2835_isp_gain_format
+                bcm2835_isp_digital_gain bcm2835_isp_lens_shading
+                bcm2835_isp_black_level bcm2835_isp_geq bcm2835_isp_gamma
+                bcm2835_isp_denoise bcm2835_isp_sharpen bcm2835_isp_dpc_mode
+                bcm2835_isp_dpc bcm2835_isp_rational bcm2835_isp_cdn
diff --git a/MAINTAINERS b/MAINTAINERS
index 68ef4b2f9db6..7417cb31244b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5187,6 +5187,15 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml
 F:	drivers/media/platform/broadcom/bcm2835-unicam/*
 
+BROADCOM BCM2835 ISP DRIVER
+M:	Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
+L:	linux-media@vger.kernel.org
+S:	Maintained
+F:	Documentation/admin-guide/media/bcm2835-isp.rst
+F:	Documentation/userspace-api/media/v4l/metafmt-bcm2835-isp.rst
+F:	drivers/media/platform/broadcom/bcm2835-isp/*
+F:	include/uapi/linux/bcm2835-isp.h
+
 BROADCOM BCM47XX MIPS ARCHITECTURE
 M:	Hauke Mehrtens <hauke@hauke-m.de>
 M:	Rafał Miłecki <zajec5@gmail.com>
diff --git a/drivers/media/platform/broadcom/Kconfig b/drivers/media/platform/broadcom/Kconfig
index cab44885182c..0da6c83e97ed 100644
--- a/drivers/media/platform/broadcom/Kconfig
+++ b/drivers/media/platform/broadcom/Kconfig
@@ -3,3 +3,4 @@
 comment "Broadcom BCM283x/BCM271x media platform drivers"
 
 source "drivers/media/platform/broadcom/bcm2835-unicam/Kconfig"
+source "drivers/media/platform/broadcom/bcm2835-isp/Kconfig"
diff --git a/drivers/media/platform/broadcom/Makefile b/drivers/media/platform/broadcom/Makefile
index 33a89bdb0029..1d49e586f492 100644
--- a/drivers/media/platform/broadcom/Makefile
+++ b/drivers/media/platform/broadcom/Makefile
@@ -1,3 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0
 
 obj-y += bcm2835-unicam/
+obj-y += bcm2835-isp/
diff --git a/drivers/media/platform/broadcom/bcm2835-isp/Kconfig b/drivers/media/platform/broadcom/bcm2835-isp/Kconfig
new file mode 100644
index 000000000000..3a4db5bf61a1
--- /dev/null
+++ b/drivers/media/platform/broadcom/bcm2835-isp/Kconfig
@@ -0,0 +1,15 @@
+config VIDEO_ISP_BCM2835
+	tristate "BCM2835 ISP support"
+	depends on MEDIA_SUPPORT
+	depends on VIDEO_DEV && (ARCH_BCM2835 || COMPILE_TEST)
+	depends on MEDIA_CONTROLLER
+	select BCM2835_VCHIQ_MMAL
+	select V4L2_ISP
+	select VIDEOBUF2_DMA_CONTIG
+	help
+	  This is the V4L2 driver for the Broadcom BCM2835 ISP hardware.
+	  This operates over the VCHIQ interface to a service running on
+	  VideoCore.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called bcm2835-isp.
diff --git a/drivers/media/platform/broadcom/bcm2835-isp/Makefile b/drivers/media/platform/broadcom/bcm2835-isp/Makefile
new file mode 100644
index 000000000000..21224cb85d5f
--- /dev/null
+++ b/drivers/media/platform/broadcom/bcm2835-isp/Makefile
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
+bcm2835-isp-objs := bcm2835-v4l2-isp.o bcm2835-isp-params.o
+
+obj-$(CONFIG_VIDEO_ISP_BCM2835) += bcm2835-isp.o
diff --git a/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-common.h b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-common.h
new file mode 100644
index 000000000000..60be0607b1ab
--- /dev/null
+++ b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-common.h
@@ -0,0 +1,50 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Broadcom BCM2835 ISP driver - common header
+ *
+ * Copyright (c) 2026 Raspberry Pi (Trading) Ltd.
+ * Copyright (c) 2026 Ideas On Board Oy
+ */
+
+#ifndef BCM2835_ISP_COMMON_H
+#define BCM2835_ISP_COMMON_H
+
+#include <linux/mutex.h>
+#include <linux/spinlock.h>
+#include <linux/raspberrypi/mmal-parameters.h>
+#include <linux/raspberrypi/mmal-vchiq.h>
+
+#include <media/media-entity.h>
+#include <media/v4l2-device.h>
+#include <media/videobuf2-core.h>
+
+struct dma_buf;
+
+struct bcm2835_isp_params {
+	struct device *dev;
+	struct v4l2_device *v4l2_dev;
+	struct vchiq_mmal_instance *mmal_instance;
+	struct vchiq_mmal_port *port;
+
+	struct video_device vdev;
+	struct media_pad pad;
+	struct vb2_queue queue;
+	struct mutex lock; /* params node vdev lock */
+
+	/* Lens shading state */
+	struct dma_buf *last_ls_dmabuf;
+};
+
+struct bcm2835_isp_params *
+bcm2835_isp_params_register(struct v4l2_device *v4l2_dev, struct device *dev,
+			    struct vchiq_mmal_instance *mmal_instance,
+			    struct vchiq_mmal_port *port, int video_nr);
+
+void bcm2835_isp_params_unregister(struct bcm2835_isp_params *params);
+
+int bcm2835_isp_params_drop_ls_ref(struct bcm2835_isp_params *params);
+
+int bcm2835_isp_node_querycap(struct file *file, void *priv,
+			      struct v4l2_capability *cap);
+
+#endif /* BCM2835_ISP_COMMON_H */
diff --git a/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-fmts.h b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-fmts.h
new file mode 100644
index 000000000000..6f3333d33c4f
--- /dev/null
+++ b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-fmts.h
@@ -0,0 +1,558 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Broadcom BCM2835 ISP driver
+ *
+ * Copyright © 2019-2026 Raspberry Pi (Trading) Ltd.
+ *
+ * Author: Naushir Patuck (naush@raspberrypi.com)
+ *
+ */
+
+#ifndef BCM2835_ISP_FMTS
+#define BCM2835_ISP_FMTS
+
+#include <linux/videodev2.h>
+#include <linux/raspberrypi/mmal-encodings.h>
+
+struct bcm2835_isp_fmt {
+	u32 fourcc;
+	int depth;
+	int bytesperline_align;
+	u32 mmal_fmt;
+	int size_multiplier_x2;
+	u32 colorspace_mask;
+	enum v4l2_colorspace colorspace_default;
+	unsigned int step_size;
+};
+
+#define V4L2_COLORSPACE_MASK(colorspace) BIT(colorspace)
+
+#define V4L2_COLORSPACE_MASK_JPEG V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_JPEG)
+#define V4L2_COLORSPACE_MASK_SMPTE170M V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SMPTE170M)
+#define V4L2_COLORSPACE_MASK_REC709 V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_REC709)
+#define V4L2_COLORSPACE_MASK_SRGB V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SRGB)
+#define V4L2_COLORSPACE_MASK_RAW V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_RAW)
+
+/*
+ * All three colour spaces JPEG, SMPTE170M and REC709 are fundamentally sRGB
+ * underneath (as near as makes no difference to us), just with different YCbCr
+ * encodings. Therefore the ISP can generate sRGB on its main output and any of
+ * the others on its low resolution output. Applications should, when using both
+ * outputs, program the colour spaces on them to be the same, matching whatever
+ * is requested for the low resolution output, even if the main output is
+ * producing an RGB format. In turn this requires us to allow all these colour
+ * spaces for every YUV/RGB output format.
+ */
+#define V4L2_COLORSPACE_MASK_ALL_SRGB (V4L2_COLORSPACE_MASK_JPEG |	\
+				       V4L2_COLORSPACE_MASK_SRGB |	\
+				       V4L2_COLORSPACE_MASK_SMPTE170M |	\
+				       V4L2_COLORSPACE_MASK_REC709)
+
+static const struct bcm2835_isp_fmt supported_formats[] = {
+	{
+		/* YUV formats */
+		.fourcc		    = V4L2_PIX_FMT_YUV420,
+		.depth		    = 8,
+		.bytesperline_align = 64,
+		.mmal_fmt	    = MMAL_ENCODING_I420,
+		.size_multiplier_x2 = 3,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_JPEG,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_YVU420,
+		.depth		    = 8,
+		.bytesperline_align = 64,
+		.mmal_fmt	    = MMAL_ENCODING_YV12,
+		.size_multiplier_x2 = 3,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SMPTE170M,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_NV12,
+		.depth		    = 8,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_NV12,
+		.size_multiplier_x2 = 3,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SMPTE170M,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_NV21,
+		.depth		    = 8,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_NV21,
+		.size_multiplier_x2 = 3,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SMPTE170M,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_YUYV,
+		.depth		    = 16,
+		.bytesperline_align = 64,
+		.mmal_fmt	    = MMAL_ENCODING_YUYV,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SMPTE170M,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_UYVY,
+		.depth		    = 16,
+		.bytesperline_align = 64,
+		.mmal_fmt	    = MMAL_ENCODING_UYVY,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SMPTE170M,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_YVYU,
+		.depth		    = 16,
+		.bytesperline_align = 64,
+		.mmal_fmt	    = MMAL_ENCODING_YVYU,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SMPTE170M,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_VYUY,
+		.depth		    = 16,
+		.bytesperline_align = 64,
+		.mmal_fmt	    = MMAL_ENCODING_VYUY,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SMPTE170M,
+		.step_size	    = 2,
+	}, {
+		/* RGB formats */
+		.fourcc		    = V4L2_PIX_FMT_RGB24,
+		.depth		    = 24,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_RGB24,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SRGB,
+		.step_size	    = 1,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_RGB565,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_RGB16,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SRGB,
+		.step_size	    = 1,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_BGR24,
+		.depth		    = 24,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BGR24,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SRGB,
+		.step_size	    = 1,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_XBGR32,
+		.depth		    = 32,
+		.bytesperline_align = 64,
+		.mmal_fmt	    = MMAL_ENCODING_BGRA,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SRGB,
+		.step_size	    = 1,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_RGBX32,
+		.depth		    = 32,
+		.bytesperline_align = 64,
+		.mmal_fmt	    = MMAL_ENCODING_RGBA,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
+		.colorspace_default = V4L2_COLORSPACE_SRGB,
+		.step_size	    = 1,
+	}, {
+		/* Bayer formats */
+		/* 8 bit */
+		.fourcc		    = V4L2_PIX_FMT_SRGGB8,
+		.depth		    = 8,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SRGGB8,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SBGGR8,
+		.depth		    = 8,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SBGGR8,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGRBG8,
+		.depth		    = 8,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGRBG8,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGBRG8,
+		.depth		    = 8,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGBRG8,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 10 bit */
+		.fourcc		    = V4L2_PIX_FMT_SRGGB10P,
+		.depth		    = 10,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SRGGB10P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SBGGR10P,
+		.depth		    = 10,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SBGGR10P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGRBG10P,
+		.depth		    = 10,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGRBG10P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGBRG10P,
+		.depth		    = 10,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGBRG10P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 12 bit */
+		.fourcc		    = V4L2_PIX_FMT_SRGGB12P,
+		.depth		    = 12,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SRGGB12P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SBGGR12P,
+		.depth		    = 12,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SBGGR12P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGRBG12P,
+		.depth		    = 12,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGRBG12P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGBRG12P,
+		.depth		    = 12,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGBRG12P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 14 bit */
+		.fourcc		    = V4L2_PIX_FMT_SRGGB14P,
+		.depth		    = 14,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SRGGB14P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SBGGR14P,
+		.depth		    = 14,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SBGGR14P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGRBG14P,
+		.depth		    = 14,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGRBG14P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGBRG14P,
+		.depth		    = 14,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGBRG14P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 16 bit */
+		.fourcc		    = V4L2_PIX_FMT_SRGGB16,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SRGGB16,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SBGGR16,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SBGGR16,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGRBG16,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGRBG16,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGBRG16,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGBRG16,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* Bayer formats unpacked to 16bpp */
+		/* 10 bit */
+		.fourcc		    = V4L2_PIX_FMT_SRGGB10,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SRGGB10,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SBGGR10,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SBGGR10,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGRBG10,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGRBG10,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGBRG10,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGBRG10,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 12 bit */
+		.fourcc		    = V4L2_PIX_FMT_SRGGB12,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SRGGB12,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SBGGR12,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SBGGR12,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGRBG12,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGRBG12,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGBRG12,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGBRG12,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 14 bit */
+		.fourcc		    = V4L2_PIX_FMT_SRGGB14,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SRGGB14,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SBGGR14,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SBGGR14,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGRBG14,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGRBG14,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_PIX_FMT_SGBRG14,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_BAYER_SGBRG14,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* Monochrome MIPI formats */
+		/* 8 bit */
+		.fourcc		    = V4L2_PIX_FMT_GREY,
+		.depth		    = 8,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_GREY,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 10 bit */
+		.fourcc		    = V4L2_PIX_FMT_Y10P,
+		.depth		    = 10,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_Y10P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 12 bit */
+		.fourcc		    = V4L2_PIX_FMT_Y12P,
+		.depth		    = 12,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_Y12P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 14 bit */
+		.fourcc		    = V4L2_PIX_FMT_Y14P,
+		.depth		    = 14,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_Y14P,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 16 bit */
+		.fourcc		    = V4L2_PIX_FMT_Y16,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_Y16,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 10 bit as 16bpp */
+		.fourcc		    = V4L2_PIX_FMT_Y10,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_Y10,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 12 bit as 16bpp */
+		.fourcc		    = V4L2_PIX_FMT_Y12,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_Y12,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		/* 14 bit as 16bpp */
+		.fourcc		    = V4L2_PIX_FMT_Y14,
+		.depth		    = 16,
+		.bytesperline_align = 32,
+		.mmal_fmt	    = MMAL_ENCODING_Y14,
+		.size_multiplier_x2 = 2,
+		.colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
+		.colorspace_default = V4L2_COLORSPACE_RAW,
+		.step_size	    = 2,
+	}, {
+		.fourcc		    = V4L2_META_FMT_BCM2835_ISP_STATS,
+		.depth		    = 8,
+		.mmal_fmt	    = MMAL_ENCODING_BRCM_STATS,
+		/* The rest are not valid fields for stats. */
+	}
+};
+
+#endif
diff --git a/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-params.c b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-params.c
new file mode 100644
index 000000000000..b133ad5c586f
--- /dev/null
+++ b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-params.c
@@ -0,0 +1,510 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Broadcom BCM2835 ISP driver - extensible parameters node
+ *
+ * Copyright (c) 2026 Raspberry Pi Ltd.
+ * Copyright (c) 2026 Ideas On Board Oy
+ *
+ * Author: Jai Luthra <jai.luthra@ideasonboard.com>
+ */
+
+#include <linux/dma-buf.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/raspberrypi/mmal-parameters.h>
+#include <linux/raspberrypi/vc_sm_knl.h>
+
+#include <media/v4l2-ioctl.h>
+#include <media/v4l2-isp.h>
+#include <media/videobuf2-dma-contig.h>
+
+#include <uapi/linux/bcm2835-isp.h>
+
+#include "bcm2835-isp-common.h"
+
+MODULE_IMPORT_NS("DMA_BUF");
+
+#define BCM2835_ISP_PARAMS_NAME "bcm2835-isp-params"
+
+#define BCM2835_ISP_PARAMS_BUF_SIZE \
+	v4l2_isp_buffer_size(BCM2835_ISP_PARAMS_MAX_SIZE)
+
+/**
+ * union bcm2835_isp_params_block - Generalisation of a parameter block
+ *
+ * @header:	Block header pointer for type checking
+ * @black_level: Black level configuration block
+ * @geq:	Green equalisation configuration block
+ * @gamma:	Gamma curve configuration block
+ * @denoise:	Denoise configuration block
+ * @sharpen:	Sharpen configuration block
+ * @dpc:	Defective pixel correction configuration block
+ * @cdn:	Colour denoise configuration block
+ * @ccm:	Colour correction matrix configuration block
+ * @ls:		Lens shading configuration block
+ * @awb_gains:	AWB gains configuration block
+ * @digital_gain: Digital gain configuration block
+ * @data:	Raw pointer for block iteration
+ */
+union bcm2835_isp_params_block {
+	const struct v4l2_isp_params_block_header *header;
+	const struct bcm2835_isp_params_black_level *black_level;
+	const struct bcm2835_isp_params_geq *geq;
+	const struct bcm2835_isp_params_gamma *gamma;
+	const struct bcm2835_isp_params_denoise *denoise;
+	const struct bcm2835_isp_params_sharpen *sharpen;
+	const struct bcm2835_isp_params_dpc *dpc;
+	const struct bcm2835_isp_params_cdn *cdn;
+	const struct bcm2835_isp_params_cc_matrix *ccm;
+	const struct bcm2835_isp_params_lens_shading *ls;
+	const struct bcm2835_isp_params_awb_gains *awb_gains;
+	const struct bcm2835_isp_params_digital_gain *digital_gain;
+	const __u8 *data;
+};
+
+typedef void (*bcm2835_isp_params_handler)(struct mmal_parameter_isp_parameters *mmal_param,
+					   struct bcm2835_isp_params *params,
+					   union bcm2835_isp_params_block block);
+
+struct bcm2835_isp_params_buffer {
+	struct vb2_v4l2_buffer vb;
+	struct list_head list;
+	void *config;
+};
+
+#define to_bcm2835_isp_params_buf(vbuf) \
+	container_of(vbuf, struct bcm2835_isp_params_buffer, vb)
+
+static int isp_set_param(struct bcm2835_isp_params *params, u32 parameter,
+			 void *value, u32 value_size)
+{
+	return vchiq_mmal_port_parameter_set(params->mmal_instance, params->port,
+					     parameter, value, value_size);
+}
+
+static int map_ls_table(struct bcm2835_isp_params *params,
+			struct dma_buf *dmabuf, u32 *mem_handle_table)
+{
+	void *vcsm_handle;
+	int ret;
+
+	if (IS_ERR_OR_NULL(dmabuf))
+		return -EINVAL;
+
+	ret = vc_sm_cma_import_dmabuf(dmabuf, &vcsm_handle);
+	if (ret)
+		return ret;
+
+	*mem_handle_table = vc_sm_cma_int_handle(vcsm_handle);
+
+	vc_sm_cma_free(vcsm_handle);
+
+	params->last_ls_dmabuf = dmabuf;
+
+	return 0;
+}
+
+/* Block handlers */
+
+#define BCM2835_ISP_PARAMS_HANDLER(_name, _param_field, _mmal_substruct)	\
+static void bcm2835_isp_params_##_name(struct mmal_parameter_isp_parameters *mmal_param, \
+				       struct bcm2835_isp_params *params,	\
+				       union bcm2835_isp_params_block block)	\
+{										\
+	memcpy(&mmal_param->_mmal_substruct.payload,				\
+		      (void *)&block._param_field->_param_field,		\
+		      sizeof(block._param_field->_param_field));		\
+	mmal_param->_mmal_substruct.update = 1;					\
+}
+
+BCM2835_ISP_PARAMS_HANDLER(black_level, black_level, black_level)
+BCM2835_ISP_PARAMS_HANDLER(geq, geq, green_eq)
+BCM2835_ISP_PARAMS_HANDLER(gamma, gamma, gamma)
+BCM2835_ISP_PARAMS_HANDLER(denoise, denoise, denoise)
+BCM2835_ISP_PARAMS_HANDLER(sharpen, sharpen, sharpen)
+BCM2835_ISP_PARAMS_HANDLER(dpc, dpc, dpc)
+BCM2835_ISP_PARAMS_HANDLER(cdn, cdn, colour_denoise)
+BCM2835_ISP_PARAMS_HANDLER(cc_matrix, ccm, ccm)
+BCM2835_ISP_PARAMS_HANDLER(awb_gains, awb_gains, awb_gains)
+BCM2835_ISP_PARAMS_HANDLER(digital_gain, digital_gain, digital_gain)
+
+static void bcm2835_isp_params_lens_shading(struct mmal_parameter_isp_parameters *mmal_param,
+					    struct bcm2835_isp_params *params,
+					    union bcm2835_isp_params_block block)
+{
+	struct dma_buf *dmabuf = dma_buf_get(block.ls->ls.dmabuf);
+	u32 prev_handle;
+	int ret = 0;
+
+	/*
+	 * struct bcm2835_isp_lens_shading layout matches with what MMAL
+	 * expects, so we can do a simple memcpy here. The descriptor for
+	 * the table needs special handling though.
+	 */
+	prev_handle = mmal_param->lens_shading.mem_handle_table;
+	memcpy(&mmal_param->lens_shading.enabled, &block.ls->ls,
+	       sizeof(block.ls->ls));
+
+	/*
+	 * Map the DMABUF from userspace to a VCSM CMA handle that the firmware
+	 * can import, reusing the old handle if DMABUF was unchanged.
+	 */
+	if (dmabuf != params->last_ls_dmabuf)
+		ret = map_ls_table(params, dmabuf,
+				   &mmal_param->lens_shading.mem_handle_table);
+	else
+		mmal_param->lens_shading.mem_handle_table = prev_handle;
+
+	if (!ret && mmal_param->lens_shading.mem_handle_table)
+		mmal_param->lens_shading.update = 1;
+
+	dma_buf_put(dmabuf);
+}
+
+static const bcm2835_isp_params_handler bcm2835_isp_params_handlers[] = {
+	[BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL] = bcm2835_isp_params_black_level,
+	[BCM2835_ISP_PARAM_BLOCK_GEQ] = bcm2835_isp_params_geq,
+	[BCM2835_ISP_PARAM_BLOCK_GAMMA] = bcm2835_isp_params_gamma,
+	[BCM2835_ISP_PARAM_BLOCK_DENOISE] = bcm2835_isp_params_denoise,
+	[BCM2835_ISP_PARAM_BLOCK_SHARPEN] = bcm2835_isp_params_sharpen,
+	[BCM2835_ISP_PARAM_BLOCK_DPC] = bcm2835_isp_params_dpc,
+	[BCM2835_ISP_PARAM_BLOCK_CDN] = bcm2835_isp_params_cdn,
+	[BCM2835_ISP_PARAM_BLOCK_CC_MATRIX] = bcm2835_isp_params_cc_matrix,
+	[BCM2835_ISP_PARAM_BLOCK_LENS_SHADING] = bcm2835_isp_params_lens_shading,
+	[BCM2835_ISP_PARAM_BLOCK_AWB_GAINS] = bcm2835_isp_params_awb_gains,
+	[BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN] = bcm2835_isp_params_digital_gain,
+};
+
+static const struct v4l2_isp_params_block_type_info
+bcm2835_isp_params_block_types_info[] = {
+	[BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL] = {
+		.size = sizeof(struct bcm2835_isp_params_black_level),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_GEQ] = {
+		.size = sizeof(struct bcm2835_isp_params_geq),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_GAMMA] = {
+		.size = sizeof(struct bcm2835_isp_params_gamma),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_DENOISE] = {
+		.size = sizeof(struct bcm2835_isp_params_denoise),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_SHARPEN] = {
+		.size = sizeof(struct bcm2835_isp_params_sharpen),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_DPC] = {
+		.size = sizeof(struct bcm2835_isp_params_dpc),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_CDN] = {
+		.size = sizeof(struct bcm2835_isp_params_cdn),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_CC_MATRIX] = {
+		.size = sizeof(struct bcm2835_isp_params_cc_matrix),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_LENS_SHADING] = {
+		.size = sizeof(struct bcm2835_isp_params_lens_shading),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_AWB_GAINS] = {
+		.size = sizeof(struct bcm2835_isp_params_awb_gains),
+	},
+	[BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN] = {
+		.size = sizeof(struct bcm2835_isp_params_digital_gain),
+	},
+};
+
+static_assert(ARRAY_SIZE(bcm2835_isp_params_handlers) ==
+	      ARRAY_SIZE(bcm2835_isp_params_block_types_info));
+
+static void bcm2835_isp_params_apply(struct bcm2835_isp_params *params,
+				     struct bcm2835_isp_params_buffer *buf)
+{
+	const struct v4l2_isp_params_buffer *config = buf->config;
+	size_t block_offset = 0;
+	size_t max_offset = config->data_size;
+	struct mmal_parameter_isp_parameters mmal_param = { 0 };
+	int ret;
+
+	while (block_offset < max_offset) {
+		union bcm2835_isp_params_block block;
+		bcm2835_isp_params_handler handler;
+
+		block.data = &config->data[block_offset];
+		handler = bcm2835_isp_params_handlers[block.header->type];
+		handler(&mmal_param, params, block);
+
+		block_offset += block.header->size;
+	}
+
+	ret = isp_set_param(params, MMAL_PARAMETER_ISP_SETTINGS, &mmal_param,
+			    sizeof(mmal_param));
+
+	if (ret) {
+		dev_err(params->dev,
+			"%s: MMAL_PARAMETER_ISP_SETTINGS failed with err %d\n",
+			__func__, ret);
+		vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
+		return;
+	}
+
+	vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_DONE);
+}
+
+/* vb2 operations */
+
+static int bcm2835_isp_params_queue_setup(struct vb2_queue *q,
+					  unsigned int *num_buffers,
+					  unsigned int *num_planes,
+					  unsigned int sizes[],
+					  struct device *alloc_devs[])
+{
+	if (*num_planes && *num_planes > 1)
+		return -EINVAL;
+
+	if (sizes[0] && sizes[0] < BCM2835_ISP_PARAMS_BUF_SIZE)
+		return -EINVAL;
+
+	*num_planes = 1;
+
+	if (!sizes[0])
+		sizes[0] = BCM2835_ISP_PARAMS_BUF_SIZE;
+
+	return 0;
+}
+
+static int bcm2835_isp_params_buf_init(struct vb2_buffer *vb)
+{
+	struct bcm2835_isp_params_buffer *buf =
+		to_bcm2835_isp_params_buf(to_vb2_v4l2_buffer(vb));
+
+	buf->config = kvmalloc(BCM2835_ISP_PARAMS_BUF_SIZE, GFP_KERNEL);
+	if (!buf->config)
+		return -ENOMEM;
+
+	return 0;
+}
+
+static void bcm2835_isp_params_buf_cleanup(struct vb2_buffer *vb)
+{
+	struct bcm2835_isp_params_buffer *buf =
+		to_bcm2835_isp_params_buf(to_vb2_v4l2_buffer(vb));
+
+	kvfree(buf->config);
+	buf->config = NULL;
+}
+
+static int bcm2835_isp_params_buf_prepare(struct vb2_buffer *vb)
+{
+	struct bcm2835_isp_params *params = vb2_get_drv_priv(vb->vb2_queue);
+	struct bcm2835_isp_params_buffer *buf =
+		to_bcm2835_isp_params_buf(to_vb2_v4l2_buffer(vb));
+	const struct v4l2_isp_params_buffer *config;
+	int ret;
+
+	ret = v4l2_isp_params_validate_buffer_size(params->dev, vb,
+						   BCM2835_ISP_PARAMS_BUF_SIZE);
+	if (ret)
+		return ret;
+
+	config = vb2_plane_vaddr(vb, 0);
+	if (config->version != BCM2835_ISP_PARAM_BUFFER_V1)
+		return -EINVAL;
+
+	/* Copy into scratch buffer */
+	memcpy(buf->config, config, BCM2835_ISP_PARAMS_BUF_SIZE);
+
+	return v4l2_isp_params_validate_buffer(params->dev, vb, buf->config,
+					       bcm2835_isp_params_block_types_info,
+					       ARRAY_SIZE(bcm2835_isp_params_block_types_info));
+}
+
+static void bcm2835_isp_params_buf_queue(struct vb2_buffer *vb)
+{
+	struct bcm2835_isp_params *params = vb2_get_drv_priv(vb->vb2_queue);
+	struct bcm2835_isp_params_buffer *buf =
+		to_bcm2835_isp_params_buf(to_vb2_v4l2_buffer(vb));
+
+	/*
+	 * Apply params immediately - the firmware will apply them on the
+	 * next frame boundary.
+	 */
+	bcm2835_isp_params_apply(params, buf);
+}
+
+static const struct vb2_ops bcm2835_isp_params_vb2_ops = {
+	.queue_setup = bcm2835_isp_params_queue_setup,
+	.buf_init = bcm2835_isp_params_buf_init,
+	.buf_cleanup = bcm2835_isp_params_buf_cleanup,
+	.buf_prepare = bcm2835_isp_params_buf_prepare,
+	.buf_queue = bcm2835_isp_params_buf_queue,
+};
+
+/* V4L2 ioctls */
+
+static int bcm2835_isp_params_enum_fmt(struct file *file, void *fh,
+				       struct v4l2_fmtdesc *f)
+{
+	if (f->index)
+		return -EINVAL;
+
+	f->pixelformat = V4L2_META_FMT_BCM2835_ISP_PARAMS;
+
+	return 0;
+}
+
+static int bcm2835_isp_params_g_fmt(struct file *file, void *fh,
+				    struct v4l2_format *f)
+{
+	f->fmt.meta.dataformat = V4L2_META_FMT_BCM2835_ISP_PARAMS;
+	f->fmt.meta.buffersize = BCM2835_ISP_PARAMS_BUF_SIZE;
+
+	return 0;
+}
+
+static const struct v4l2_ioctl_ops bcm2835_isp_params_ioctl_ops = {
+	.vidioc_querycap = bcm2835_isp_node_querycap,
+	.vidioc_enum_fmt_meta_out = bcm2835_isp_params_enum_fmt,
+	.vidioc_g_fmt_meta_out = bcm2835_isp_params_g_fmt,
+	.vidioc_s_fmt_meta_out = bcm2835_isp_params_g_fmt,
+	.vidioc_try_fmt_meta_out = bcm2835_isp_params_g_fmt,
+
+	.vidioc_reqbufs = vb2_ioctl_reqbufs,
+	.vidioc_querybuf = vb2_ioctl_querybuf,
+	.vidioc_qbuf = vb2_ioctl_qbuf,
+	.vidioc_dqbuf = vb2_ioctl_dqbuf,
+	.vidioc_expbuf = vb2_ioctl_expbuf,
+	.vidioc_create_bufs = vb2_ioctl_create_bufs,
+	.vidioc_prepare_buf = vb2_ioctl_prepare_buf,
+
+	.vidioc_streamon = vb2_ioctl_streamon,
+	.vidioc_streamoff = vb2_ioctl_streamoff,
+};
+
+static const struct v4l2_file_operations bcm2835_isp_params_fops = {
+	.owner = THIS_MODULE,
+	.open = v4l2_fh_open,
+	.release = vb2_fop_release,
+	.poll = vb2_fop_poll,
+	.unlocked_ioctl = video_ioctl2,
+	.mmap = vb2_fop_mmap,
+};
+
+struct bcm2835_isp_params *
+bcm2835_isp_params_register(struct v4l2_device *v4l2_dev, struct device *dev,
+			    struct vchiq_mmal_instance *mmal_instance,
+			    struct vchiq_mmal_port *port, int video_nr)
+{
+	struct mmal_parameter_isp_parameters mmal_param = { 0 };
+	struct bcm2835_isp_params *params;
+	struct video_device *vdev;
+	struct vb2_queue *q;
+	int ret;
+
+	params = devm_kzalloc(dev, sizeof(*params), GFP_KERNEL);
+	if (!params)
+		return ERR_PTR(-ENOMEM);
+
+	params->dev = dev;
+	params->v4l2_dev = v4l2_dev;
+	params->mmal_instance = mmal_instance;
+	params->port = port;
+
+	/* Test if the firmware supports a combined parameter buffer */
+	ret = vchiq_mmal_port_parameter_set(params->mmal_instance,
+					    params->port,
+					    MMAL_PARAMETER_ISP_SETTINGS,
+					    &mmal_param, sizeof(mmal_param));
+	if (ret) {
+		dev_err(dev, "Please update to the latest firmware\n"
+			"\tMMAL_PARAMETER_ISP_SETTINGS failed with err %d\n",
+			ret);
+		return ERR_PTR(-EINVAL);
+	}
+
+	mutex_init(&params->lock);
+
+	/* Initialize vb2 queue */
+	q = &params->queue;
+	q->type = V4L2_BUF_TYPE_META_OUTPUT;
+	q->io_modes = VB2_MMAP | VB2_DMABUF;
+	q->drv_priv = params;
+	q->ops = &bcm2835_isp_params_vb2_ops;
+	q->mem_ops = &vb2_dma_contig_memops;
+	q->buf_struct_size = sizeof(struct bcm2835_isp_params_buffer);
+	q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
+	q->dev = dev;
+	q->lock = &params->lock;
+
+	ret = vb2_queue_init(q);
+	if (ret) {
+		dev_err(dev, "Failed to init params vb2 queue\n");
+		mutex_destroy(&params->lock);
+		return ERR_PTR(ret);
+	}
+
+	/* Initialize video device */
+	vdev = &params->vdev;
+	vdev->device_caps = V4L2_CAP_META_OUTPUT | V4L2_CAP_STREAMING;
+	vdev->fops = &bcm2835_isp_params_fops;
+	vdev->ioctl_ops = &bcm2835_isp_params_ioctl_ops;
+	vdev->minor = -1;
+	vdev->release = video_device_release_empty;
+	vdev->queue = q;
+	vdev->lock = &params->lock;
+	vdev->v4l2_dev = v4l2_dev;
+	vdev->vfl_dir = VFL_DIR_TX;
+	snprintf(vdev->name, sizeof(vdev->name), "%s", BCM2835_ISP_PARAMS_NAME);
+
+	params->pad.flags = MEDIA_PAD_FL_SOURCE;
+	ret = media_entity_pads_init(&vdev->entity, 1, &params->pad);
+	if (ret) {
+		vb2_queue_release(q);
+		mutex_destroy(&params->lock);
+		return ERR_PTR(ret);
+	}
+
+	video_set_drvdata(vdev, params);
+
+	ret = video_register_device(vdev, VFL_TYPE_VIDEO, video_nr);
+	if (ret) {
+		dev_err(dev, "Failed to register params device node\n");
+		media_entity_cleanup(&vdev->entity);
+		vb2_queue_release(q);
+		mutex_destroy(&params->lock);
+		return ERR_PTR(ret);
+	}
+
+	v4l2_info(v4l2_dev, "Params device node registered as /dev/video%d\n",
+		  vdev->num);
+
+	return params;
+}
+
+void bcm2835_isp_params_unregister(struct bcm2835_isp_params *params)
+{
+	if (!video_is_registered(&params->vdev))
+		return;
+
+	v4l2_info(params->v4l2_dev, "Unregistering params device node\n");
+
+	vb2_video_unregister_device(&params->vdev);
+	media_entity_cleanup(&params->vdev.entity);
+	mutex_destroy(&params->lock);
+}
+
+/*
+ * The ISP component on the firmware has a reference to the dmabuf handle for
+ * the lens shading table.
+ * Pass a null handle to remove that reference.
+ */
+int bcm2835_isp_params_drop_ls_ref(struct bcm2835_isp_params *params)
+{
+	struct bcm2835_isp_lens_shading ls = {
+		/* Must set a valid grid size for the FW */
+		.grid_cell_size = 16,
+	};
+
+	params->last_ls_dmabuf = NULL;
+
+	return isp_set_param(params, MMAL_PARAMETER_LENS_SHADING_OVERRIDE, &ls,
+			     sizeof(ls));
+}
diff --git a/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-v4l2-isp.c b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-v4l2-isp.c
new file mode 100644
index 000000000000..729ab05d8154
--- /dev/null
+++ b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-v4l2-isp.c
@@ -0,0 +1,1516 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Broadcom BCM2835 ISP driver
+ *
+ * Copyright (c) 2019-2026 Raspberry Pi (Trading) Ltd.
+ * Copyright (c) 2026 Ideas On Board Oy
+ *
+ * Author: Naushir Patuck (naush@raspberrypi.com)
+ *
+ */
+
+#include <linux/err.h>
+#include <linux/module.h>
+#include <linux/raspberrypi/mmal-msg.h>
+#include <linux/raspberrypi/mmal-parameters.h>
+#include <linux/raspberrypi/mmal-vchiq.h>
+#include <linux/raspberrypi/vchiq_bus.h>
+
+#include <media/v4l2-device.h>
+#include <media/v4l2-ioctl.h>
+#include <media/videobuf2-dma-contig.h>
+
+#include "bcm2835-isp-fmts.h"
+#include "bcm2835-isp-common.h"
+
+/*
+ * There is no standard API today for multiplexing ISP instances, so we hardcode
+ * the number of instances to 1 here. The firmware backend can work with more.
+ */
+#define BCM2835_ISP_NUM_INSTANCES 1
+
+MODULE_IMPORT_NS("DMA_BUF");
+
+static unsigned int debug;
+module_param(debug, uint, 0644);
+MODULE_PARM_DESC(debug, "activates debug info");
+
+static unsigned int video_nr[BCM2835_ISP_NUM_INSTANCES] = { 13 };
+module_param_array(video_nr, uint, NULL, 0644);
+MODULE_PARM_DESC(video_nr, "base video device numbers");
+
+#define BCM2835_ISP_NAME "bcm2835-isp"
+#define BCM2835_ISP_ENTITY_NAME_LEN 32
+
+#define BCM2835_ISP_NUM_OUTPUTS 1
+#define BCM2835_ISP_NUM_CAPTURES 2
+#define BCM2835_ISP_NUM_METADATA 1
+#define BCM2835_ISP_NUM_PARAMS 1
+
+#define BCM2835_ISP_NUM_NODES						\
+		(BCM2835_ISP_NUM_OUTPUTS + BCM2835_ISP_NUM_CAPTURES +	\
+		 BCM2835_ISP_NUM_METADATA)
+#define BCM2835_ISP_PARAMS_PAD BCM2835_ISP_NUM_NODES
+#define BCM2835_ISP_NUM_ENTITY_PADS					\
+		(BCM2835_ISP_NUM_NODES + BCM2835_ISP_NUM_PARAMS)
+
+/* Default frame dimension of 1280 pixels. */
+#define DEFAULT_DIM 1280U
+/*
+ * Maximum frame dimension of 16384 pixels.  Even though the ISP runs in tiles,
+ * have a sensible limit so that we do not create an excessive number of tiles
+ * to process.
+ */
+#define MAX_DIM 16384U
+/*
+ * Minimum frame dimension of 64 pixels.  Anything lower, and the tiling
+ * algorithm may not be able to cope when applying filter context.
+ */
+#define MIN_DIM 64U
+
+/* Timeout for stop_streaming to allow all buffers to return */
+#define COMPLETE_TIMEOUT (2 * HZ)
+
+/* Per-queue, driver-specific private data */
+struct bcm2835_isp_q_data {
+	/*
+	 * These parameters should be treated as gospel, with everything else
+	 * being determined from them.
+	 */
+	unsigned int bytesperline;
+	unsigned int width;
+	unsigned int height;
+	unsigned int sizeimage;
+	enum v4l2_colorspace colorspace;
+	enum v4l2_ycbcr_encoding ycbcr_enc;
+	enum v4l2_xfer_func xfer_func;
+	enum v4l2_quantization quantization;
+	const struct bcm2835_isp_fmt *fmt;
+};
+
+/*
+ * Structure to describe a single node /dev/video<N> which represents a single
+ * input or output queue to the ISP device.
+ */
+struct bcm2835_isp_node {
+	int vfl_dir;
+	unsigned int id;
+	const char *name;
+	struct vchiq_mmal_port *port;
+	struct video_device vfd;
+	struct media_pad pad;
+	struct mutex lock; /* top level device node lock */
+	struct mutex queue_lock;
+
+	struct vb2_queue queue;
+	unsigned int sequence;
+
+	/* The list of formats supported on the node. */
+	struct bcm2835_isp_fmt const **supported_fmts;
+	unsigned int num_supported_fmts;
+
+	struct bcm2835_isp_q_data q_data;
+
+	/* Parent device structure */
+	struct bcm2835_isp_dev *dev;
+
+	bool registered;
+};
+
+/*
+ * Structure representing the entire ISP device, comprising several input and
+ * output nodes /dev/video<N>.
+ */
+struct bcm2835_isp_dev {
+	struct v4l2_device v4l2_dev;
+	struct device *dev;
+	struct media_device mdev;
+	struct media_entity entity;
+	bool media_device_registered;
+	bool media_entity_registered;
+	struct vchiq_mmal_instance *mmal_instance;
+	struct vchiq_mmal_component *component;
+	struct completion frame_cmplt;
+
+	struct bcm2835_isp_node node[BCM2835_ISP_NUM_NODES];
+	struct media_pad pad[BCM2835_ISP_NUM_ENTITY_PADS];
+	atomic_t num_streaming;
+
+	/* Extensible params node */
+	struct bcm2835_isp_params *params;
+};
+
+struct bcm2835_isp_buffer {
+	struct vb2_v4l2_buffer vb;
+	struct mmal_buffer mmal;
+};
+
+#define to_bcm2835_isp_buffer(vbuf) \
+	container_of(vbuf, struct bcm2835_isp_buffer, vb)
+
+static
+inline struct bcm2835_isp_dev *node_get_dev(struct bcm2835_isp_node *node)
+{
+	return node->dev;
+}
+
+static inline bool node_is_output(struct bcm2835_isp_node *node)
+{
+	return node->queue.type == V4L2_BUF_TYPE_VIDEO_OUTPUT;
+}
+
+static inline bool node_is_capture(struct bcm2835_isp_node *node)
+{
+	return node->queue.type == V4L2_BUF_TYPE_VIDEO_CAPTURE;
+}
+
+static inline bool node_is_stats(struct bcm2835_isp_node *node)
+{
+	return node->queue.type == V4L2_BUF_TYPE_META_CAPTURE;
+}
+
+static inline enum v4l2_buf_type index_to_queue_type(int index)
+{
+	if (index < BCM2835_ISP_NUM_OUTPUTS)
+		return V4L2_BUF_TYPE_VIDEO_OUTPUT;
+	else if (index < BCM2835_ISP_NUM_OUTPUTS + BCM2835_ISP_NUM_CAPTURES)
+		return V4L2_BUF_TYPE_VIDEO_CAPTURE;
+	else
+		return V4L2_BUF_TYPE_META_CAPTURE;
+}
+
+static const struct bcm2835_isp_fmt *get_fmt(u32 mmal_fmt)
+{
+	unsigned int i;
+
+	for (i = 0; i < ARRAY_SIZE(supported_formats); i++) {
+		if (supported_formats[i].mmal_fmt == mmal_fmt)
+			return &supported_formats[i];
+	}
+	return NULL;
+}
+
+static const
+struct bcm2835_isp_fmt *find_format_by_fourcc(unsigned int fourcc,
+					      struct bcm2835_isp_node *node)
+{
+	const struct bcm2835_isp_fmt *fmt;
+	unsigned int i;
+
+	for (i = 0; i < node->num_supported_fmts; i++) {
+		fmt = node->supported_fmts[i];
+		if (fmt->fourcc == fourcc)
+			return fmt;
+	}
+
+	return NULL;
+}
+
+static const
+struct bcm2835_isp_fmt *find_format(struct v4l2_format *f,
+				    struct bcm2835_isp_node *node)
+{
+	return find_format_by_fourcc(node_is_stats(node) ?
+				     f->fmt.meta.dataformat :
+				     f->fmt.pix.pixelformat,
+				     node);
+}
+
+/* vb2_to_mmal_buffer() - converts vb2 buffer header to MMAL
+ *
+ * Copies all the required fields from a VB2 buffer to the MMAL buffer header,
+ * ready for sending to the VPU.
+ */
+static void vb2_to_mmal_buffer(struct mmal_buffer *buf,
+			       struct vb2_v4l2_buffer *vb2)
+{
+	u64 pts;
+
+	buf->mmal_flags = 0;
+	if (vb2->flags & V4L2_BUF_FLAG_KEYFRAME)
+		buf->mmal_flags |= MMAL_BUFFER_HEADER_FLAG_KEYFRAME;
+
+	/* Data must be framed correctly as one frame per buffer. */
+	buf->mmal_flags |= MMAL_BUFFER_HEADER_FLAG_FRAME_END;
+
+	buf->length = vb2->vb2_buf.planes[0].bytesused;
+	/*
+	 * Minor ambiguity in the V4L2 spec as to whether passing in a 0 length
+	 * buffer, or one with V4L2_BUF_FLAG_LAST set denotes end of stream.
+	 * Handle either.
+	 */
+	if (!buf->length || (vb2->flags & V4L2_BUF_FLAG_LAST))
+		buf->mmal_flags |= MMAL_BUFFER_HEADER_FLAG_EOS;
+
+	/* vb2 timestamps in nsecs, mmal in usecs */
+	pts = vb2->vb2_buf.timestamp;
+	do_div(pts, 1000);
+	buf->pts = pts;
+	buf->dts = MMAL_TIME_UNKNOWN;
+}
+
+static void mmal_buffer_cb(struct vchiq_mmal_instance *instance,
+			   struct vchiq_mmal_port *port, int status,
+			   struct mmal_buffer *mmal_buf)
+{
+	struct bcm2835_isp_buffer *q_buf;
+	struct bcm2835_isp_node *node = port->cb_ctx;
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	struct vb2_v4l2_buffer *vb2;
+
+	q_buf = container_of(mmal_buf, struct bcm2835_isp_buffer, mmal);
+	vb2 = &q_buf->vb;
+	v4l2_dbg(2, debug, &dev->v4l2_dev,
+		 "%s: port:%s[%d], status:%d, buf:%p, dmabuf:%p, length:%lu, flags %u, pts %lld\n",
+		 __func__, node_is_output(node) ? "input" : "output", node->id,
+		 status, mmal_buf, mmal_buf->dma_buf, mmal_buf->length,
+		 mmal_buf->mmal_flags, mmal_buf->pts);
+
+	if (status) {
+		/* error in transfer */
+		if (vb2) {
+			/* there was a buffer with the error so return it */
+			vb2_buffer_done(&vb2->vb2_buf, VB2_BUF_STATE_ERROR);
+		}
+		return;
+	}
+
+	/* vb2 timestamps in nsecs, mmal in usecs */
+	vb2->vb2_buf.timestamp = mmal_buf->pts * 1000;
+	vb2->sequence = node->sequence++;
+	vb2_set_plane_payload(&vb2->vb2_buf, 0, mmal_buf->length);
+	vb2_buffer_done(&vb2->vb2_buf, VB2_BUF_STATE_DONE);
+
+	if (!port->enabled)
+		complete(&dev->frame_cmplt);
+}
+
+struct colorspace_translation {
+	enum v4l2_colorspace v4l2_value;
+	u32 mmal_value;
+};
+
+static u32 translate_color_space(enum v4l2_colorspace color_space)
+{
+	static const struct colorspace_translation translations[] = {
+		{ V4L2_COLORSPACE_DEFAULT, MMAL_COLOR_SPACE_UNKNOWN },
+		{ V4L2_COLORSPACE_SMPTE170M, MMAL_COLOR_SPACE_ITUR_BT601 },
+		{ V4L2_COLORSPACE_SMPTE240M, MMAL_COLOR_SPACE_SMPTE240M },
+		{ V4L2_COLORSPACE_REC709, MMAL_COLOR_SPACE_ITUR_BT709 },
+		/* V4L2_COLORSPACE_BT878 unavailable */
+		{ V4L2_COLORSPACE_470_SYSTEM_M, MMAL_COLOR_SPACE_BT470_2_M },
+		{ V4L2_COLORSPACE_470_SYSTEM_BG, MMAL_COLOR_SPACE_BT470_2_BG },
+		{ V4L2_COLORSPACE_JPEG, MMAL_COLOR_SPACE_JPEG_JFIF },
+		/*
+		 * We don't have an encoding for SRGB as such, but VideoCore
+		 * will do the right thing if it gets "unknown".
+		 */
+		{ V4L2_COLORSPACE_SRGB, MMAL_COLOR_SPACE_UNKNOWN },
+		/* V4L2_COLORSPACE_OPRGB unavailable */
+		/* V4L2_COLORSPACE_BT2020 unavailable */
+		/* V4L2_COLORSPACE_RAW unavailable */
+		/* V4L2_COLORSPACE_DCI_P3 unavailable */
+	};
+
+	unsigned int i;
+
+	for (i = 0; i < ARRAY_SIZE(translations); i++) {
+		if (color_space == translations[i].v4l2_value)
+			return translations[i].mmal_value;
+	}
+
+	return MMAL_COLOR_SPACE_UNKNOWN;
+}
+
+static void setup_mmal_port_format(struct bcm2835_isp_node *node,
+				   struct vchiq_mmal_port *port)
+{
+	struct bcm2835_isp_q_data *q_data = &node->q_data;
+
+	port->format.encoding = q_data->fmt->mmal_fmt;
+	/* Raw image format - set width/height */
+	port->es.video.width = (q_data->bytesperline << 3) / q_data->fmt->depth;
+	port->es.video.height = q_data->height;
+	port->es.video.crop.width = q_data->width;
+	port->es.video.crop.height = q_data->height;
+	port->es.video.crop.x = 0;
+	port->es.video.crop.y = 0;
+	port->es.video.color_space = translate_color_space(q_data->colorspace);
+};
+
+static int setup_mmal_port(struct bcm2835_isp_node *node)
+{
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	unsigned int enable = 1;
+	int ret;
+
+	v4l2_dbg(2, debug, &dev->v4l2_dev, "%s: setup %s[%d]\n", __func__,
+		 node->name, node->id);
+
+	vchiq_mmal_port_parameter_set(dev->mmal_instance, node->port,
+				      MMAL_PARAMETER_ZERO_COPY, &enable,
+				      sizeof(enable));
+	setup_mmal_port_format(node, node->port);
+	ret = vchiq_mmal_port_set_format(dev->mmal_instance, node->port);
+	if (ret < 0) {
+		v4l2_dbg(1, debug, &dev->v4l2_dev,
+			 "%s: vchiq_mmal_port_set_format failed\n",
+			 __func__);
+		return ret;
+	}
+
+	if (node->q_data.sizeimage < node->port->minimum_buffer.size) {
+		v4l2_err(&dev->v4l2_dev,
+			 "buffer size mismatch sizeimage %u < min size %u\n",
+			 node->q_data.sizeimage,
+			 node->port->minimum_buffer.size);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int bcm2835_isp_mmal_buf_cleanup(struct mmal_buffer *mmal_buf)
+{
+	mmal_vchi_buffer_cleanup(mmal_buf);
+
+	if (mmal_buf->dma_buf) {
+		dma_buf_put(mmal_buf->dma_buf);
+		mmal_buf->dma_buf = NULL;
+	}
+
+	return 0;
+}
+
+static int bcm2835_isp_node_queue_setup(struct vb2_queue *q,
+					unsigned int *nbuffers,
+					unsigned int *nplanes,
+					unsigned int sizes[],
+					struct device *alloc_devs[])
+{
+	struct bcm2835_isp_node *node = vb2_get_drv_priv(q);
+	unsigned int size;
+
+	if (setup_mmal_port(node))
+		return -EINVAL;
+
+	size = node->q_data.sizeimage;
+	if (size == 0) {
+		v4l2_info(&node_get_dev(node)->v4l2_dev,
+			  "%s: Image size unset in queue_setup for node %s[%d]\n",
+			  __func__, node->name, node->id);
+		return -EINVAL;
+	}
+
+	if (*nplanes)
+		return sizes[0] < size ? -EINVAL : 0;
+
+	*nplanes = 1;
+	sizes[0] = size;
+
+	node->port->current_buffer.size = size;
+
+	if (*nbuffers < node->port->minimum_buffer.num)
+		*nbuffers = node->port->minimum_buffer.num;
+
+	node->port->current_buffer.num = *nbuffers;
+
+	v4l2_dbg(2, debug, &node_get_dev(node)->v4l2_dev,
+		 "%s: Image size %u, nbuffers %u for node %s[%d]\n",
+		 __func__, sizes[0], *nbuffers, node->name, node->id);
+	return 0;
+}
+
+static int bcm2835_isp_buf_init(struct vb2_buffer *vb)
+{
+	struct bcm2835_isp_node *node = vb2_get_drv_priv(vb->vb2_queue);
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	struct bcm2835_isp_buffer *buf =
+		to_bcm2835_isp_buffer(to_vb2_v4l2_buffer(vb));
+
+	v4l2_dbg(3, debug, &dev->v4l2_dev, "%s: vb %p\n", __func__, vb);
+
+	buf->mmal.buffer = vb2_plane_vaddr(&buf->vb.vb2_buf, 0);
+	buf->mmal.buffer_size = vb2_plane_size(&buf->vb.vb2_buf, 0);
+	mmal_vchi_buffer_init(dev->mmal_instance, &buf->mmal);
+	return 0;
+}
+
+static int bcm2835_isp_buf_prepare(struct vb2_buffer *vb)
+{
+	struct bcm2835_isp_node *node = vb2_get_drv_priv(vb->vb2_queue);
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	struct vb2_v4l2_buffer *vb2 = to_vb2_v4l2_buffer(vb);
+	struct bcm2835_isp_buffer *buf = to_bcm2835_isp_buffer(vb2);
+	struct dma_buf *dma_buf;
+	int ret = 0;
+
+	v4l2_dbg(3, debug, &dev->v4l2_dev, "%s: type: %d ptr %p\n",
+		 __func__, vb->vb2_queue->type, vb);
+
+	if (V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type)) {
+		if (vb2->field == V4L2_FIELD_ANY)
+			vb2->field = V4L2_FIELD_NONE;
+		if (vb2->field != V4L2_FIELD_NONE) {
+			v4l2_err(&dev->v4l2_dev,
+				 "%s field isn't supported\n", __func__);
+			return -EINVAL;
+		}
+	}
+
+	if (vb2_plane_size(vb, 0) < node->q_data.sizeimage) {
+		v4l2_err(&dev->v4l2_dev,
+			 "%s data will not fit into plane (%lu < %u)\n",
+			 __func__, vb2_plane_size(vb, 0),
+			 node->q_data.sizeimage);
+		return -EINVAL;
+	}
+
+	if (!V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type))
+		vb2_set_plane_payload(vb, 0, node->q_data.sizeimage);
+
+	switch (vb->memory) {
+	case VB2_MEMORY_DMABUF:
+		dma_buf = dma_buf_get(vb->planes[0].m.fd);
+
+		if (dma_buf != buf->mmal.dma_buf) {
+			/*
+			 * dmabuf either hasn't already been mapped, or it has
+			 * changed.
+			 */
+			if (buf->mmal.dma_buf) {
+				v4l2_err(&dev->v4l2_dev,
+					 "%s Buffer changed - why did the core not call cleanup?\n",
+					 __func__);
+				bcm2835_isp_mmal_buf_cleanup(&buf->mmal);
+			}
+
+			buf->mmal.dma_buf = dma_buf;
+		} else {
+			/*
+			 * Already have a reference to the buffer, so release it
+			 * here.
+			 */
+			dma_buf_put(dma_buf);
+		}
+		break;
+	case VB2_MEMORY_MMAP:
+		/*
+		 * We want to do this at init, but vb2_core_expbuf checks that
+		 * the index < q->num_buffers, and q->num_buffers only gets
+		 * updated once all the buffers are allocated.
+		 */
+		if (!buf->mmal.dma_buf) {
+			buf->mmal.dma_buf =
+				vb2_core_expbuf_dmabuf(vb->vb2_queue, vb, 0,
+						       O_CLOEXEC);
+			v4l2_dbg(3, debug, &dev->v4l2_dev,
+				 "%s: exporting ptr %p to dmabuf %p\n",
+				 __func__, vb, buf->mmal.dma_buf);
+
+			if (IS_ERR(buf->mmal.dma_buf)) {
+				ret = PTR_ERR(buf->mmal.dma_buf);
+				v4l2_err(&dev->v4l2_dev,
+					 "%s: Failed to expbuf idx %d, ret %d\n",
+					 __func__, vb->index, ret);
+				buf->mmal.dma_buf = NULL;
+			}
+		}
+		break;
+	default:
+		ret = -EINVAL;
+		break;
+	}
+
+	return ret;
+}
+
+static void bcm2835_isp_node_buffer_queue(struct vb2_buffer *buf)
+{
+	struct bcm2835_isp_node *node = vb2_get_drv_priv(buf->vb2_queue);
+	struct bcm2835_isp_buffer *buffer =
+		to_bcm2835_isp_buffer(to_vb2_v4l2_buffer(buf));
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+
+	v4l2_dbg(3, debug, &dev->v4l2_dev, "%s: node %s[%d], buffer %p\n",
+		 __func__, node->name, node->id, buffer);
+
+	vb2_to_mmal_buffer(&buffer->mmal, &buffer->vb);
+	v4l2_dbg(3, debug, &dev->v4l2_dev,
+		 "%s: node %s[%d] - submitting  mmal dmabuf %p\n", __func__,
+		 node->name, node->id, buffer->mmal.dma_buf);
+	vchiq_mmal_submit_buffer(dev->mmal_instance, node->port, &buffer->mmal);
+}
+
+static void bcm2835_isp_buffer_cleanup(struct vb2_buffer *vb)
+{
+	struct bcm2835_isp_buffer *buffer =
+		to_bcm2835_isp_buffer(to_vb2_v4l2_buffer(vb));
+
+	bcm2835_isp_mmal_buf_cleanup(&buffer->mmal);
+}
+
+static int bcm2835_isp_node_start_streaming(struct vb2_queue *q,
+					    unsigned int count)
+{
+	struct bcm2835_isp_node *node = vb2_get_drv_priv(q);
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	int ret;
+
+	v4l2_dbg(1, debug, &dev->v4l2_dev, "%s: node %s[%d] (count %u)\n",
+		 __func__, node->name, node->id, count);
+
+	ret = vchiq_mmal_component_enable(dev->mmal_instance, dev->component);
+	if (ret) {
+		v4l2_err(&dev->v4l2_dev, "%s: Failed enabling component, ret %d\n",
+			 __func__, ret);
+		return -EIO;
+	}
+
+	node->sequence = 0;
+	node->port->cb_ctx = node;
+	ret = vchiq_mmal_port_enable(dev->mmal_instance, node->port,
+				     mmal_buffer_cb);
+	if (!ret)
+		atomic_inc(&dev->num_streaming);
+	else
+		v4l2_err(&dev->v4l2_dev,
+			 "%s: Failed enabling port, ret %d\n", __func__, ret);
+
+	return ret;
+}
+
+static void bcm2835_isp_node_stop_streaming(struct vb2_queue *q)
+{
+	struct bcm2835_isp_node *node = vb2_get_drv_priv(q);
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	int ret;
+
+	v4l2_dbg(1, debug, &dev->v4l2_dev, "%s: node %s[%d], mmal port %p\n",
+		 __func__, node->name, node->id, node->port);
+
+	init_completion(&dev->frame_cmplt);
+
+	/* Disable MMAL port - this will flush buffers back */
+	ret = vchiq_mmal_port_disable(dev->mmal_instance, node->port);
+	if (ret)
+		v4l2_err(&dev->v4l2_dev,
+			 "%s: Failed disabling %s port, ret %d\n", __func__,
+			 node_is_output(node) ? "i/p" : "o/p",
+			 ret);
+
+	while (atomic_read(&node->port->buffers_with_vpu)) {
+		v4l2_dbg(1, debug, &dev->v4l2_dev,
+			 "%s: Waiting for buffers to be returned - %d outstanding\n",
+			 __func__, atomic_read(&node->port->buffers_with_vpu));
+		ret = wait_for_completion_timeout(&dev->frame_cmplt,
+						  COMPLETE_TIMEOUT);
+		if (ret <= 0) {
+			v4l2_err(&dev->v4l2_dev,
+				 "%s: Timeout waiting for buffers to be returned - %d outstanding\n",
+				 __func__,
+				 atomic_read(&node->port->buffers_with_vpu));
+			break;
+		}
+	}
+
+	atomic_dec(&dev->num_streaming);
+	/* If all ports disabled, then disable the component */
+	if (atomic_read(&dev->num_streaming) == 0) {
+		ret = bcm2835_isp_params_drop_ls_ref(dev->params);
+		if (ret) {
+			v4l2_err(&dev->v4l2_dev,
+				 "%s: Failed dropping LS buffer, ret %d\n",
+				 __func__, ret);
+		}
+
+		ret = vchiq_mmal_component_disable(dev->mmal_instance,
+						   dev->component);
+		if (ret) {
+			v4l2_err(&dev->v4l2_dev,
+				 "%s: Failed disabling component, ret %d\n",
+				 __func__, ret);
+		}
+	}
+
+	/*
+	 * Simply wait for any vb2 buffers to finish. We could take steps to
+	 * make them complete more quickly if we care, or even return them
+	 * ourselves.
+	 */
+	vb2_wait_for_all_buffers(&node->queue);
+}
+
+static const struct vb2_ops bcm2835_isp_node_queue_ops = {
+	.queue_setup		= bcm2835_isp_node_queue_setup,
+	.buf_init		= bcm2835_isp_buf_init,
+	.buf_prepare		= bcm2835_isp_buf_prepare,
+	.buf_queue		= bcm2835_isp_node_buffer_queue,
+	.buf_cleanup		= bcm2835_isp_buffer_cleanup,
+	.start_streaming	= bcm2835_isp_node_start_streaming,
+	.stop_streaming		= bcm2835_isp_node_stop_streaming,
+};
+
+static const
+struct bcm2835_isp_fmt *get_default_format(struct bcm2835_isp_node *node)
+{
+	return node->supported_fmts[0];
+}
+
+static inline unsigned int get_bytesperline(int width,
+					    const struct bcm2835_isp_fmt *fmt)
+{
+	/* GPU aligns 24bpp images to a multiple of 32 pixels (not bytes). */
+	if (fmt->depth == 24)
+		return ALIGN(width, 32) * 3;
+	else
+		return ALIGN((width * fmt->depth) >> 3, fmt->bytesperline_align);
+}
+
+static inline unsigned int get_sizeimage(int bpl, int width, int height,
+					 const struct bcm2835_isp_fmt *fmt)
+{
+	return (bpl * height * fmt->size_multiplier_x2) >> 1;
+}
+
+static const struct v4l2_file_operations bcm2835_isp_fops = {
+	.owner		= THIS_MODULE,
+	.open		= v4l2_fh_open,
+	.release	= vb2_fop_release,
+	.poll		= vb2_fop_poll,
+	.unlocked_ioctl = video_ioctl2,
+	.mmap		= vb2_fop_mmap
+};
+
+static int populate_qdata_fmt(struct v4l2_format *f,
+			      struct bcm2835_isp_node *node)
+{
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	struct bcm2835_isp_q_data *q_data = &node->q_data;
+	int ret;
+
+	if (!node_is_stats(node)) {
+		v4l2_dbg(1, debug, &dev->v4l2_dev,
+			 "%s: Setting pix format for type %d, wxh: %ux%u, fmt: %08x, size %u\n",
+			 __func__, f->type, f->fmt.pix.width, f->fmt.pix.height,
+			 f->fmt.pix.pixelformat, f->fmt.pix.sizeimage);
+
+		q_data->fmt = find_format(f, node);
+		q_data->width = f->fmt.pix.width;
+		q_data->height = f->fmt.pix.height;
+
+		/* All parameters should have been set correctly by try_fmt */
+		q_data->bytesperline = f->fmt.pix.bytesperline;
+		q_data->sizeimage = f->fmt.pix.sizeimage;
+		q_data->ycbcr_enc = f->fmt.pix.ycbcr_enc;
+		q_data->xfer_func = f->fmt.pix.xfer_func;
+		q_data->quantization = f->fmt.pix.quantization;
+
+		/* We must indicate which of the allowed colour spaces we have. */
+		q_data->colorspace = f->fmt.pix.colorspace;
+	} else {
+		v4l2_dbg(1, debug, &dev->v4l2_dev,
+			 "%s: Setting meta format for fmt: %08x, size %u\n",
+			 __func__, f->fmt.meta.dataformat,
+			 f->fmt.meta.buffersize);
+
+		q_data->fmt = find_format(f, node);
+		q_data->width = 0;
+		q_data->height = 0;
+		q_data->bytesperline = 0;
+		q_data->sizeimage = f->fmt.meta.buffersize;
+
+		/* This won't mean anything for metadata, but may as well fill it in. */
+		q_data->colorspace = V4L2_COLORSPACE_DEFAULT;
+	}
+
+	v4l2_dbg(1, debug, &dev->v4l2_dev,
+		 "%s: Calculated bpl as %u, size %u\n", __func__,
+		 q_data->bytesperline, q_data->sizeimage);
+
+	setup_mmal_port_format(node, node->port);
+	ret = vchiq_mmal_port_set_format(dev->mmal_instance, node->port);
+	if (ret) {
+		v4l2_err(&dev->v4l2_dev,
+			 "%s: Failed vchiq_mmal_port_set_format on port, ret %d\n",
+			 __func__, ret);
+		ret = -EINVAL;
+	}
+
+	if (q_data->sizeimage < node->port->minimum_buffer.size) {
+		v4l2_err(&dev->v4l2_dev,
+			 "%s: Current buffer size of %u < min buf size %u - driver mismatch to MMAL\n",
+			 __func__,
+			 q_data->sizeimage,
+			 node->port->minimum_buffer.size);
+		ret = -EINVAL;
+	}
+
+	v4l2_dbg(1, debug, &dev->v4l2_dev,
+		 "%s: Set format for type %d, wxh: %dx%d, fmt: %08x, size %u\n",
+		 __func__, f->type, q_data->width, q_data->height,
+		 q_data->fmt->fourcc, q_data->sizeimage);
+
+	return ret;
+}
+
+int bcm2835_isp_node_querycap(struct file *file, void *priv,
+			      struct v4l2_capability *cap)
+{
+	strscpy(cap->driver, BCM2835_ISP_NAME, sizeof(cap->driver));
+	strscpy(cap->card, BCM2835_ISP_NAME, sizeof(cap->card));
+	snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
+		 BCM2835_ISP_NAME);
+
+	return 0;
+}
+
+static int bcm2835_isp_node_g_fmt(struct file *file, void *priv,
+				  struct v4l2_format *f)
+{
+	struct bcm2835_isp_node *node = video_drvdata(file);
+
+	if (f->type != node->queue.type)
+		return -EINVAL;
+
+	if (node_is_stats(node)) {
+		f->fmt.meta.dataformat = V4L2_META_FMT_BCM2835_ISP_STATS;
+		f->fmt.meta.buffersize =
+			node->port->minimum_buffer.size;
+	} else {
+		struct bcm2835_isp_q_data *q_data = &node->q_data;
+
+		f->fmt.pix.width = q_data->width;
+		f->fmt.pix.height = q_data->height;
+		f->fmt.pix.field = V4L2_FIELD_NONE;
+		f->fmt.pix.pixelformat = q_data->fmt->fourcc;
+		f->fmt.pix.bytesperline = q_data->bytesperline;
+		f->fmt.pix.sizeimage = q_data->sizeimage;
+		f->fmt.pix.colorspace = q_data->colorspace;
+		f->fmt.pix.ycbcr_enc = q_data->ycbcr_enc;
+		f->fmt.pix.xfer_func = q_data->xfer_func;
+		f->fmt.pix.quantization = q_data->quantization;
+	}
+
+	return 0;
+}
+
+static int bcm2835_isp_node_enum_fmt(struct file *file, void *priv,
+				     struct v4l2_fmtdesc *f)
+{
+	struct bcm2835_isp_node *node = video_drvdata(file);
+
+	if (f->type != node->queue.type)
+		return -EINVAL;
+
+	if (f->index < node->num_supported_fmts) {
+		/* Format found */
+		f->pixelformat = node->supported_fmts[f->index]->fourcc;
+		f->flags = 0;
+		return 0;
+	}
+
+	return -EINVAL;
+}
+
+static int bcm2835_isp_enum_framesizes(struct file *file, void *priv,
+				       struct v4l2_frmsizeenum *fsize)
+{
+	struct bcm2835_isp_node *node = video_drvdata(file);
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	const struct bcm2835_isp_fmt *fmt;
+
+	if (node_is_stats(node) || fsize->index)
+		return -EINVAL;
+
+	fmt = find_format_by_fourcc(fsize->pixel_format, node);
+	if (!fmt) {
+		v4l2_err(&dev->v4l2_dev, "Invalid pixel code: %x\n",
+			 fsize->pixel_format);
+		return -EINVAL;
+	}
+
+	fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
+	fsize->stepwise.min_width = MIN_DIM;
+	fsize->stepwise.max_width = MAX_DIM;
+	fsize->stepwise.step_width = fmt->step_size;
+
+	fsize->stepwise.min_height = MIN_DIM;
+	fsize->stepwise.max_height = MAX_DIM;
+	fsize->stepwise.step_height = fmt->step_size;
+
+	return 0;
+}
+
+static int bcm2835_isp_node_try_fmt(struct file *file, void *priv,
+				    struct v4l2_format *f)
+{
+	struct bcm2835_isp_node *node = video_drvdata(file);
+	const struct bcm2835_isp_fmt *fmt;
+
+	if (f->type != node->queue.type)
+		return -EINVAL;
+
+	fmt = find_format(f, node);
+	if (!fmt)
+		fmt = get_default_format(node);
+
+	if (!node_is_stats(node)) {
+		bool is_rgb;
+
+		f->fmt.pix.width = clamp_t(u32, f->fmt.pix.width, MIN_DIM,
+					   MAX_DIM);
+		f->fmt.pix.height = clamp_t(u32, f->fmt.pix.height, MIN_DIM,
+					    MAX_DIM);
+		f->fmt.pix.pixelformat = fmt->fourcc;
+
+		/*
+		 * Fill in the actual colour space when the requested one was
+		 * not supported. This also catches the case when the "default"
+		 * colour space was requested (as that's never in the mask).
+		 */
+		if (!(V4L2_COLORSPACE_MASK(f->fmt.pix.colorspace) & fmt->colorspace_mask))
+			f->fmt.pix.colorspace = fmt->colorspace_default;
+		/* In all cases, we only support the defaults for these: */
+		f->fmt.pix.ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(f->fmt.pix.colorspace);
+		f->fmt.pix.xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(f->fmt.pix.colorspace);
+		/* RAW counts as sRGB here so that we get full range. */
+		is_rgb = f->fmt.pix.colorspace == V4L2_COLORSPACE_SRGB ||
+			f->fmt.pix.colorspace == V4L2_COLORSPACE_RAW;
+		f->fmt.pix.quantization = V4L2_MAP_QUANTIZATION_DEFAULT(is_rgb,
+									f->fmt.pix.colorspace,
+									f->fmt.pix.ycbcr_enc);
+
+		/* Respect any stride value (suitably aligned) that was requested. */
+		f->fmt.pix.bytesperline = max(get_bytesperline(f->fmt.pix.width, fmt),
+					      ALIGN(f->fmt.pix.bytesperline,
+						    fmt->bytesperline_align));
+		f->fmt.pix.field = V4L2_FIELD_NONE;
+		f->fmt.pix.sizeimage =
+			get_sizeimage(f->fmt.pix.bytesperline, f->fmt.pix.width,
+				      f->fmt.pix.height, fmt);
+	} else {
+		f->fmt.meta.dataformat = fmt->fourcc;
+		f->fmt.meta.buffersize = node->port->minimum_buffer.size;
+	}
+
+	return 0;
+}
+
+static int bcm2835_isp_node_s_fmt(struct file *file, void *priv,
+				  struct v4l2_format *f)
+{
+	struct bcm2835_isp_node *node = video_drvdata(file);
+	int ret;
+
+	if (f->type != node->queue.type)
+		return -EINVAL;
+
+	ret = bcm2835_isp_node_try_fmt(file, priv, f);
+	if (ret)
+		return ret;
+
+	v4l2_dbg(1, debug, &node_get_dev(node)->v4l2_dev,
+		 "%s: Set format for node %s[%d]\n",
+		 __func__, node->name, node->id);
+
+	return populate_qdata_fmt(f, node);
+}
+
+static int bcm2835_isp_node_s_selection(struct file *file, void *fh,
+					struct v4l2_selection *s)
+{
+	struct mmal_parameter_crop crop;
+	struct bcm2835_isp_node *node = video_drvdata(file);
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+
+	if (!node_is_output(node))
+		return -EINVAL;
+
+	if (!s->r.width || !s->r.height)
+		return -EINVAL;
+
+	/* We can only set crop on the input. */
+	switch (s->target) {
+	case V4L2_SEL_TGT_CROP:
+		/*
+		 * Adjust the crop window if it goes outside of the frame
+		 * dimensions.
+		 */
+		s->r.left = clamp_t(unsigned int, s->r.left, 0,
+				    node->q_data.width - MIN_DIM);
+		s->r.top = clamp_t(unsigned int, s->r.top, 0,
+				   node->q_data.height - MIN_DIM);
+		s->r.width = clamp_t(unsigned int, s->r.width, MIN_DIM,
+				     node->q_data.width - s->r.left);
+		s->r.height = clamp_t(unsigned int, s->r.height, MIN_DIM,
+				      node->q_data.height - s->r.top);
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	crop.rect.x = s->r.left;
+	crop.rect.y = s->r.top;
+	crop.rect.width = s->r.width;
+	crop.rect.height = s->r.height;
+
+	return vchiq_mmal_port_parameter_set(dev->mmal_instance, node->port,
+					     MMAL_PARAMETER_CROP,
+					     &crop, sizeof(crop));
+}
+
+static int bcm2835_isp_node_g_selection(struct file *file, void *fh,
+					struct v4l2_selection *s)
+{
+	struct mmal_parameter_crop crop;
+	struct bcm2835_isp_node *node = video_drvdata(file);
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	u32 crop_size = sizeof(crop);
+	int ret;
+
+	if (!node_is_output(node))
+		return -EINVAL;
+
+	/* We can only return out an input crop. */
+	switch (s->target) {
+	case V4L2_SEL_TGT_CROP:
+		ret = vchiq_mmal_port_parameter_get(dev->mmal_instance,
+						    node->port,
+						    MMAL_PARAMETER_CROP,
+						    &crop, &crop_size);
+		if (!ret) {
+			s->r.left = crop.rect.x;
+			s->r.top = crop.rect.y;
+			s->r.width = crop.rect.width;
+			s->r.height = crop.rect.height;
+		}
+		break;
+	case V4L2_SEL_TGT_CROP_DEFAULT:
+	case V4L2_SEL_TGT_CROP_BOUNDS:
+		/* Default (i.e. no) crop window. */
+		s->r.left = 0;
+		s->r.top = 0;
+		s->r.width = node->q_data.width;
+		s->r.height = node->q_data.height;
+		ret = 0;
+		break;
+	default:
+		ret =  -EINVAL;
+	}
+
+	return ret;
+}
+
+static const struct v4l2_ioctl_ops bcm2835_isp_node_ioctl_ops = {
+	.vidioc_querycap		= bcm2835_isp_node_querycap,
+	.vidioc_g_fmt_vid_cap		= bcm2835_isp_node_g_fmt,
+	.vidioc_g_fmt_vid_out		= bcm2835_isp_node_g_fmt,
+	.vidioc_g_fmt_meta_cap		= bcm2835_isp_node_g_fmt,
+	.vidioc_s_fmt_vid_cap		= bcm2835_isp_node_s_fmt,
+	.vidioc_s_fmt_vid_out		= bcm2835_isp_node_s_fmt,
+	.vidioc_s_fmt_meta_cap		= bcm2835_isp_node_s_fmt,
+	.vidioc_try_fmt_vid_cap		= bcm2835_isp_node_try_fmt,
+	.vidioc_try_fmt_vid_out		= bcm2835_isp_node_try_fmt,
+	.vidioc_try_fmt_meta_cap	= bcm2835_isp_node_try_fmt,
+	.vidioc_s_selection		= bcm2835_isp_node_s_selection,
+	.vidioc_g_selection		= bcm2835_isp_node_g_selection,
+
+	.vidioc_enum_fmt_vid_cap	= bcm2835_isp_node_enum_fmt,
+	.vidioc_enum_fmt_vid_out	= bcm2835_isp_node_enum_fmt,
+	.vidioc_enum_fmt_meta_cap	= bcm2835_isp_node_enum_fmt,
+	.vidioc_enum_framesizes		= bcm2835_isp_enum_framesizes,
+
+	.vidioc_reqbufs			= vb2_ioctl_reqbufs,
+	.vidioc_querybuf		= vb2_ioctl_querybuf,
+	.vidioc_qbuf			= vb2_ioctl_qbuf,
+	.vidioc_dqbuf			= vb2_ioctl_dqbuf,
+	.vidioc_expbuf			= vb2_ioctl_expbuf,
+	.vidioc_create_bufs		= vb2_ioctl_create_bufs,
+	.vidioc_prepare_buf		= vb2_ioctl_prepare_buf,
+
+	.vidioc_streamon		= vb2_ioctl_streamon,
+	.vidioc_streamoff		= vb2_ioctl_streamoff,
+};
+
+/*
+ * Size of the array to provide to the VPU when asking for the list of supported
+ * formats.
+ *
+ * The ISP component currently advertises 62 input formats, so add a small
+ * overhead on that. Should the component advertise more formats then the excess
+ * will be dropped and a warning logged.
+ */
+#define MAX_SUPPORTED_ENCODINGS 70
+
+/* Populate node->supported_fmts with the formats supported by those ports. */
+static int bcm2835_isp_get_supported_fmts(struct bcm2835_isp_node *node)
+{
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+	struct bcm2835_isp_fmt const **list;
+	unsigned int i, j, num_encodings;
+	u32 fourccs[MAX_SUPPORTED_ENCODINGS];
+	u32 param_size = sizeof(fourccs);
+	int ret;
+
+	ret = vchiq_mmal_port_parameter_get(dev->mmal_instance, node->port,
+					    MMAL_PARAMETER_SUPPORTED_ENCODINGS,
+					    &fourccs, &param_size);
+
+	if (ret) {
+		if (ret == MMAL_MSG_STATUS_ENOSPC) {
+			v4l2_err(&dev->v4l2_dev,
+				 "%s: port has more encodings than we provided space for. Some are dropped (%zu vs %u).\n",
+				 __func__, param_size / sizeof(u32),
+				 MAX_SUPPORTED_ENCODINGS);
+			num_encodings = MAX_SUPPORTED_ENCODINGS;
+		} else {
+			v4l2_err(&dev->v4l2_dev, "%s: get_param ret %u.\n",
+				 __func__, ret);
+			return -EINVAL;
+		}
+	} else {
+		num_encodings = param_size / sizeof(u32);
+	}
+
+	/*
+	 * Assume at this stage that all encodings will be supported in V4L2.
+	 * Any that aren't supported will waste a very small amount of memory.
+	 */
+	list = devm_kzalloc(dev->dev,
+			    sizeof(struct bcm2835_isp_fmt *) * num_encodings,
+			    GFP_KERNEL);
+	if (!list)
+		return -ENOMEM;
+	node->supported_fmts = list;
+
+	for (i = 0, j = 0; i < num_encodings; i++) {
+		const struct bcm2835_isp_fmt *fmt = get_fmt(fourccs[i]);
+
+		if (fmt) {
+			list[j] = fmt;
+			j++;
+		}
+	}
+	node->num_supported_fmts = j;
+
+	return 0;
+}
+
+/*
+ * Register a device node /dev/video<N> to go along with one of the ISP's input
+ * or output nodes.
+ */
+static int bcm2835_isp_register_node(struct bcm2835_isp_dev *dev,
+				     unsigned int instance,
+				     struct bcm2835_isp_node *node, int index)
+{
+	struct video_device *vfd;
+	struct vb2_queue *queue;
+	bool is_rgb;
+	int ret;
+
+	mutex_init(&node->lock);
+	mutex_init(&node->queue_lock);
+
+	node->dev = dev;
+	vfd = &node->vfd;
+	queue = &node->queue;
+	queue->type = index_to_queue_type(index);
+	/*
+	 * Setup the node type-specific params.
+	 */
+	switch (queue->type) {
+	case V4L2_BUF_TYPE_VIDEO_OUTPUT:
+		vfd->device_caps = V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING;
+		node->id = index;
+		node->vfl_dir = VFL_DIR_TX;
+		node->name = "output";
+		if (node->id >= ARRAY_SIZE(dev->component->input))
+			return -EINVAL;
+		node->port = &dev->component->input[node->id];
+		break;
+	case V4L2_BUF_TYPE_VIDEO_CAPTURE:
+		vfd->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
+		/* First Capture node starts at id 0, etc. */
+		node->id = index - BCM2835_ISP_NUM_OUTPUTS;
+		node->vfl_dir = VFL_DIR_RX;
+		node->name = "capture";
+		if (node->id >= ARRAY_SIZE(dev->component->output))
+			return -EINVAL;
+		node->port = &dev->component->output[node->id];
+		break;
+	case V4L2_BUF_TYPE_META_CAPTURE:
+		vfd->device_caps = V4L2_CAP_META_CAPTURE | V4L2_CAP_STREAMING;
+		node->id = index - BCM2835_ISP_NUM_OUTPUTS;
+		node->vfl_dir = VFL_DIR_RX;
+		node->name = "stats";
+		if (node->id >= ARRAY_SIZE(dev->component->output))
+			return -EINVAL;
+		node->port = &dev->component->output[node->id];
+		break;
+	}
+
+	ret = bcm2835_isp_get_supported_fmts(node);
+	if (ret)
+		return ret;
+
+	/* Initialise the video node. */
+	vfd->vfl_type	= VFL_TYPE_VIDEO;
+	vfd->fops	= &bcm2835_isp_fops;
+	vfd->ioctl_ops	= &bcm2835_isp_node_ioctl_ops;
+	vfd->minor	= -1;
+	vfd->release	= video_device_release_empty;
+	vfd->queue	= &node->queue;
+	vfd->lock	= &node->lock;
+	vfd->v4l2_dev	= &dev->v4l2_dev;
+	vfd->vfl_dir	= node->vfl_dir;
+
+	node->q_data.fmt = get_default_format(node);
+	node->q_data.width = DEFAULT_DIM;
+	node->q_data.height = DEFAULT_DIM;
+	node->q_data.bytesperline =
+		get_bytesperline(DEFAULT_DIM, node->q_data.fmt);
+	node->q_data.sizeimage = node_is_stats(node) ?
+				 node->port->recommended_buffer.size :
+				 get_sizeimage(node->q_data.bytesperline,
+					       node->q_data.width,
+					       node->q_data.height,
+					       node->q_data.fmt);
+	node->q_data.colorspace = node->q_data.fmt->colorspace_default;
+	node->q_data.ycbcr_enc =
+		V4L2_MAP_YCBCR_ENC_DEFAULT(node->q_data.colorspace);
+	node->q_data.xfer_func =
+		V4L2_MAP_XFER_FUNC_DEFAULT(node->q_data.colorspace);
+	is_rgb = node->q_data.colorspace == V4L2_COLORSPACE_SRGB ||
+		node->q_data.colorspace == V4L2_COLORSPACE_RAW;
+	node->q_data.quantization = V4L2_MAP_QUANTIZATION_DEFAULT(is_rgb,
+								  node->q_data.colorspace,
+								  node->q_data.ycbcr_enc);
+
+	queue->io_modes = VB2_MMAP | VB2_DMABUF;
+	queue->drv_priv = node;
+	queue->ops = &bcm2835_isp_node_queue_ops;
+	queue->mem_ops = &vb2_dma_contig_memops;
+	queue->buf_struct_size = sizeof(struct bcm2835_isp_buffer);
+	queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
+	queue->dev = dev->dev;
+	queue->lock = &node->queue_lock;
+
+	ret = vb2_queue_init(queue);
+	if (ret < 0) {
+		v4l2_info(&dev->v4l2_dev, "vb2_queue_init failed\n");
+		return ret;
+	}
+
+	/* Define the device names */
+	snprintf(vfd->name, sizeof(node->vfd.name), "%s-%s%d", BCM2835_ISP_NAME,
+		 node->name, node->id);
+
+	node->pad.flags = node_is_output(node) ? MEDIA_PAD_FL_SOURCE : MEDIA_PAD_FL_SINK;
+	ret = media_entity_pads_init(&node->vfd.entity, 1, &node->pad);
+	if (ret)
+		goto queue_cleanup;
+
+	ret = video_register_device(vfd, VFL_TYPE_VIDEO, video_nr[instance]);
+	if (ret) {
+		v4l2_err(&dev->v4l2_dev,
+			 "Failed to register video %s[%d] device node\n",
+			 node->name, node->id);
+		goto queue_cleanup;
+	}
+
+	node->registered = true;
+	video_set_drvdata(vfd, node);
+
+	v4l2_info(&dev->v4l2_dev,
+		  "Device node %s[%d] registered as /dev/video%d\n",
+		  node->name, node->id, vfd->num);
+
+	return 0;
+
+queue_cleanup:
+	vb2_queue_release(&node->queue);
+	return ret;
+}
+
+/* Unregister one of the /dev/video<N> nodes associated with the ISP. */
+static void bcm2835_unregister_node(struct bcm2835_isp_node *node)
+{
+	struct bcm2835_isp_dev *dev = node_get_dev(node);
+
+	v4l2_info(&dev->v4l2_dev,
+		  "Unregistering node %s[%d] device node /dev/video%d\n",
+		  node->name, node->id, node->vfd.num);
+
+	if (node->registered) {
+		video_unregister_device(&node->vfd);
+		vb2_queue_release(&node->queue);
+	}
+
+	/*
+	 * node->supported_fmts.list is free'd automatically
+	 * as a managed resource.
+	 */
+	node->supported_fmts = NULL;
+	node->num_supported_fmts = 0;
+	node->registered = false;
+}
+
+static void media_controller_unregister(struct bcm2835_isp_dev *dev)
+{
+	v4l2_info(&dev->v4l2_dev, "Unregister from media controller\n");
+
+	if (dev->media_device_registered) {
+		media_device_unregister(&dev->mdev);
+		media_device_cleanup(&dev->mdev);
+		dev->media_device_registered = false;
+	}
+
+	kfree(dev->entity.name);
+	dev->entity.name = NULL;
+
+	if (dev->media_entity_registered) {
+		media_device_unregister_entity(&dev->entity);
+		dev->media_entity_registered = false;
+	}
+
+	dev->v4l2_dev.mdev = NULL;
+}
+
+static int media_controller_register(struct bcm2835_isp_dev *dev)
+{
+	struct media_entity *entity;
+	char *name;
+	unsigned int i;
+	int ret;
+
+	v4l2_dbg(2, debug, &dev->v4l2_dev, "Registering with media controller\n");
+
+	name = kmalloc(BCM2835_ISP_ENTITY_NAME_LEN, GFP_KERNEL);
+	if (!name) {
+		ret = -ENOMEM;
+		goto done;
+	}
+	snprintf(name, BCM2835_ISP_ENTITY_NAME_LEN, "bcm2835-isp");
+	dev->entity.name = name;
+	dev->entity.obj_type = MEDIA_ENTITY_TYPE_BASE;
+	dev->entity.function = MEDIA_ENT_F_PROC_VIDEO_ISP;
+
+	for (i = 0; i < BCM2835_ISP_NUM_NODES; i++) {
+		dev->pad[i].flags = node_is_output(&dev->node[i]) ?
+					MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE;
+	}
+	dev->pad[BCM2835_ISP_PARAMS_PAD].flags = MEDIA_PAD_FL_SINK;
+
+	ret = media_entity_pads_init(&dev->entity, BCM2835_ISP_NUM_ENTITY_PADS,
+				     dev->pad);
+	if (ret)
+		goto done;
+
+	ret = media_device_register_entity(&dev->mdev, &dev->entity);
+	if (ret)
+		goto done;
+
+	dev->media_entity_registered = true;
+
+	for (i = 0; i < BCM2835_ISP_NUM_NODES; i++) {
+		entity = &dev->node[i].vfd.entity;
+		int output = node_is_output(&dev->node[i]);
+
+		if (output)
+			ret = media_create_pad_link(entity, 0,
+						    &dev->entity, i,
+						    MEDIA_LNK_FL_IMMUTABLE |
+						    MEDIA_LNK_FL_ENABLED);
+		else
+			ret = media_create_pad_link(&dev->entity, i,
+						    entity, 0,
+						    MEDIA_LNK_FL_IMMUTABLE |
+						    MEDIA_LNK_FL_ENABLED);
+		if (ret)
+			goto done;
+	}
+
+	entity = &dev->params->vdev.entity;
+	ret = media_create_pad_link(entity, 0, &dev->entity, BCM2835_ISP_PARAMS_PAD,
+				    MEDIA_LNK_FL_IMMUTABLE |
+				    MEDIA_LNK_FL_ENABLED);
+	if (ret)
+		goto done;
+
+	ret = media_device_register(&dev->mdev);
+	if (!ret)
+		dev->media_device_registered = true;
+done:
+	return ret;
+}
+
+static void bcm2835_isp_remove_instance(struct bcm2835_isp_dev *dev)
+{
+	unsigned int i;
+
+	if (!IS_ERR_OR_NULL(dev->params))
+		bcm2835_isp_params_unregister(dev->params);
+
+	for (i = 0; i < BCM2835_ISP_NUM_NODES; i++)
+		bcm2835_unregister_node(&dev->node[i]);
+
+	v4l2_device_unregister(&dev->v4l2_dev);
+	media_controller_unregister(dev);
+
+	if (dev->component)
+		vchiq_mmal_component_finalise(dev->mmal_instance,
+					      dev->component);
+
+	vchiq_mmal_finalise(dev->mmal_instance);
+}
+
+static int bcm2835_isp_probe_instance(struct vchiq_device *device,
+				      struct bcm2835_isp_dev **dev_int,
+				      unsigned int instance)
+{
+	struct bcm2835_isp_dev *dev;
+	unsigned int i;
+	int ret;
+
+	dev = devm_kzalloc(&device->dev, sizeof(*dev), GFP_KERNEL);
+	if (!dev)
+		return -ENOMEM;
+
+	*dev_int = dev;
+	dev->dev = &device->dev;
+	dev->mdev.dev = &device->dev;
+
+	strscpy(dev->mdev.model, BCM2835_ISP_NAME, sizeof(dev->mdev.model));
+	snprintf(dev->mdev.bus_info, sizeof(dev->mdev.bus_info), "platform:%s",
+		 BCM2835_ISP_NAME);
+	media_device_init(&dev->mdev);
+
+	dev->v4l2_dev.mdev = &dev->mdev;
+
+	ret = v4l2_device_register(&device->dev, &dev->v4l2_dev);
+	if (ret)
+		return ret;
+
+	ret = vchiq_mmal_init(&device->dev, &dev->mmal_instance);
+	if (ret) {
+		v4l2_device_unregister(&dev->v4l2_dev);
+		return ret;
+	}
+
+	ret = vchiq_mmal_component_init(dev->mmal_instance, "ril.isp",
+					&dev->component);
+	if (ret) {
+		v4l2_err(&dev->v4l2_dev,
+			 "%s: failed to create ril.isp component\n", __func__);
+		return ret;
+	}
+
+	if (dev->component->inputs < BCM2835_ISP_NUM_OUTPUTS ||
+	    dev->component->outputs < BCM2835_ISP_NUM_CAPTURES +
+					BCM2835_ISP_NUM_METADATA) {
+		v4l2_err(&dev->v4l2_dev,
+			 "%s: ril.isp returned %d i/p (%d expected), %d o/p (%d expected) ports\n",
+			  __func__, dev->component->inputs,
+			  BCM2835_ISP_NUM_OUTPUTS,
+			  dev->component->outputs,
+			  BCM2835_ISP_NUM_CAPTURES + BCM2835_ISP_NUM_METADATA);
+		return -EINVAL;
+	}
+
+	atomic_set(&dev->num_streaming, 0);
+
+	for (i = 0; i < BCM2835_ISP_NUM_NODES; i++) {
+		struct bcm2835_isp_node *node = &dev->node[i];
+
+		ret = bcm2835_isp_register_node(dev, instance, node, i);
+		if (ret)
+			return ret;
+	}
+
+	/* Register extensible params node */
+	dev->params = bcm2835_isp_params_register(&dev->v4l2_dev, dev->dev,
+						  dev->mmal_instance,
+						  &dev->component->input[0],
+						  video_nr[instance] + BCM2835_ISP_NUM_NODES);
+	if (IS_ERR(dev->params))
+		return PTR_ERR(dev->params);
+
+	ret = media_controller_register(dev);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static void bcm2835_isp_remove(struct vchiq_device *device)
+{
+	struct bcm2835_isp_dev **bcm2835_isp_instances;
+	unsigned int i;
+
+	bcm2835_isp_instances = vchiq_get_drvdata(device);
+	for (i = 0; i < BCM2835_ISP_NUM_INSTANCES; i++) {
+		if (bcm2835_isp_instances[i])
+			bcm2835_isp_remove_instance(bcm2835_isp_instances[i]);
+	}
+}
+
+static int bcm2835_isp_probe(struct vchiq_device *device)
+{
+	struct bcm2835_isp_dev **bcm2835_isp_instances;
+	unsigned int i;
+	int ret;
+
+	ret = dma_set_mask_and_coherent(&device->dev, DMA_BIT_MASK(32));
+	if (ret) {
+		dev_err(&device->dev, "dma_set_mask_and_coherent failed: %d\n",
+			ret);
+		return ret;
+	}
+
+	bcm2835_isp_instances = devm_kzalloc(&device->dev,
+					     sizeof(*bcm2835_isp_instances) *
+						      BCM2835_ISP_NUM_INSTANCES,
+					     GFP_KERNEL);
+	if (!bcm2835_isp_instances)
+		return -ENOMEM;
+
+	vchiq_set_drvdata(device, bcm2835_isp_instances);
+
+	for (i = 0; i < BCM2835_ISP_NUM_INSTANCES; i++) {
+		ret = bcm2835_isp_probe_instance(device,
+						 &bcm2835_isp_instances[i], i);
+		if (ret)
+			goto error;
+	}
+
+	dev_info(&device->dev, "Loaded V4L2 %s\n", BCM2835_ISP_NAME);
+	return 0;
+
+error:
+	bcm2835_isp_remove(device);
+
+	return ret;
+}
+
+static struct vchiq_device_id device_id_table[] = {
+	{ .name = "bcm2835-isp" },
+	{}
+};
+MODULE_DEVICE_TABLE(vchiq, device_id_table);
+
+static struct vchiq_driver bcm2835_isp_drv = {
+	.probe = bcm2835_isp_probe,
+	.remove = bcm2835_isp_remove,
+	.id_table = device_id_table,
+	.driver = {
+		.name = BCM2835_ISP_NAME,
+	},
+};
+
+module_vchiq_driver(bcm2835_isp_drv);
+
+MODULE_DESCRIPTION("BCM2835 ISP driver");
+MODULE_AUTHOR("Naushir Patuck <naush@raspberrypi.com>");
+MODULE_LICENSE("GPL");
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index 17ba1ae70735..1449de2b64b5 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1490,6 +1490,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
 	case V4L2_META_FMT_GENERIC_CSI2_16:	descr = "8-bit Generic Meta, 16b CSI-2"; break;
 	case V4L2_META_FMT_GENERIC_CSI2_20:	descr = "8-bit Generic Meta, 20b CSI-2"; break;
 	case V4L2_META_FMT_GENERIC_CSI2_24:	descr = "8-bit Generic Meta, 24b CSI-2"; break;
+	case V4L2_META_FMT_BCM2835_ISP_STATS: descr = "BCM2835 ISP Image Statistics"; break;
+	case V4L2_META_FMT_BCM2835_ISP_PARAMS: descr = "BCM2835 ISP Config Parameters"; break;
 
 	default:
 		/* Compressed formats */
diff --git a/include/linux/raspberrypi/mmal-parameters.h b/include/linux/raspberrypi/mmal-parameters.h
index 6ae5a7a1932c..f0e2ec025b70 100644
--- a/include/linux/raspberrypi/mmal-parameters.h
+++ b/include/linux/raspberrypi/mmal-parameters.h
@@ -23,6 +23,8 @@
 #define MMAL_PARAMETERS_H
 
 #include <linux/math.h>
+#include <linux/stddef.h>
+#include <uapi/linux/bcm2835-isp.h>
 
 /** Common parameter ID group, used with many types of component. */
 #define MMAL_PARAMETER_GROUP_COMMON		(0 << 16)
@@ -279,8 +281,14 @@ enum mmal_parameter_camera_type {
 	MMAL_PARAMETER_DPC,
 		/**< Tales a @ref MMAP_PARAMETER_GAMMA_T */
 	MMAL_PARAMETER_GAMMA,
+
+	/* 0x60 */
 		/**< Takes a @ref MMAL_PARAMETER_CDN_T */
 	MMAL_PARAMETER_CDN,
+		/**< Takes a @ref MMAL_PARAMETER_BOOLEAN_T */
+	MMAL_PARAMETER_JPEG_IJG_SCALING,
+		/**< Takes a @ref MMAL_PARAMETER_ISP_SETTINGS_T */
+	MMAL_PARAMETER_ISP_SETTINGS,
 };
 
 enum mmal_parameter_camera_config_timestamp_mode {
@@ -819,20 +827,143 @@ enum mmal_parameter_ls_gain_format_type {
 	MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_DUMMY  = 0x7FFFFFFF
 };
 
-struct mmal_parameter_lens_shading_v2 {
-	u32 enabled;
-	u32 grid_cell_size;
-	u32 grid_width;
-	u32 grid_stride;
-	u32 grid_height;
-	u32 mem_handle_table;
-	u32 ref_transform;
-	u32 corner_sampled;
-	enum mmal_parameter_ls_gain_format_type gain_format;
-};
-
 struct mmal_parameter_crop {
 	struct vchiq_mmal_rect rect;
 };
 
+struct mmal_parameter_isp_parameters {
+	struct {
+		/* Black level */
+		u32 update;
+
+		struct_group(payload,
+			u32 enable;
+			u16 black_level_r;
+			u16 black_level_g;
+			u16 black_level_b;
+			u8 padding[2];
+		);
+	} black_level;
+
+	struct {
+		/* GEQ */
+		u32 update;
+
+		struct_group(payload,
+			u32 enable;
+			u32 offset;
+			struct bcm2835_isp_rational slope;
+			u8 padding[4];
+		);
+	} green_eq;
+
+	struct {
+		/* Gamma */
+		u32 update;
+
+		struct_group(payload,
+			u32 enable;
+			u16 X[BCM2835_NUM_GAMMA_PTS];
+			u16 Y[BCM2835_NUM_GAMMA_PTS];
+		);
+	} gamma;
+
+	struct {
+		/* Denoise */
+		u32 update;
+
+		struct_group(payload,
+			u32 enable;
+			u32 constant;
+			struct bcm2835_isp_rational slope;
+			struct bcm2835_isp_rational strength;
+			u8 padding[4];
+		);
+	} denoise;
+
+	struct {
+		/* Sharpen */
+		u32 update;
+
+		struct_group(payload,
+			u32 enable;
+			struct bcm2835_isp_rational threshold;
+			struct bcm2835_isp_rational strength;
+			struct bcm2835_isp_rational limit;
+		);
+	} sharpen;
+
+	struct {
+		/* Defective Pixel Correction */
+		u32 update;
+
+		struct_group(payload,
+			u32 enable;
+			u32 strength;
+			u8 padding[4];
+		);
+	} dpc;
+
+	struct {
+		/* Colour denoise */
+		u32 update;
+
+		struct_group(payload,
+			u32 enable;
+			u32 mode;
+			u8 padding[4];
+		);
+	} colour_denoise;
+
+	struct {
+		/* CCM */
+		u32 update;
+
+		struct_group(payload,
+			u32 enable;
+			struct bcm2835_isp_ccm ccm;
+			u8 padding[4];
+		);
+	} ccm;
+
+	struct {
+		/* Lens shading */
+		u32 update;
+
+		struct_group(payload,
+			u32 enabled;
+			u32 grid_cell_size;
+			u32 grid_width;
+			u32 grid_stride;
+			u32 grid_height;
+			u32 mem_handle_table;
+			u32 ref_transform;
+			u32 corner_sampled;
+			enum mmal_parameter_ls_gain_format_type gain_format;
+			u8 padding[4];
+		);
+	} lens_shading;
+
+	struct {
+		/* AWB Gains */
+		u32 update;
+
+		struct_group(payload,
+			struct bcm2835_isp_rational r_gain;
+			struct bcm2835_isp_rational b_gain;
+			u8 padding[4];
+		);
+	} awb_gains;
+
+	struct {
+		/* Digital Gain */
+		u32 update;
+
+		struct_group(payload,
+			struct bcm2835_isp_rational value;
+			u8 padding[4];
+		);
+	} digital_gain;
+};
+
 #endif
diff --git a/include/uapi/linux/bcm2835-isp.h b/include/uapi/linux/bcm2835-isp.h
new file mode 100644
index 000000000000..d15a4ed18404
--- /dev/null
+++ b/include/uapi/linux/bcm2835-isp.h
@@ -0,0 +1,530 @@
+/* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) */
+/*
+ * bcm2835-isp.h
+ *
+ * BCM2835 ISP driver - user space header file.
+ *
+ * Copyright © 2019-2026 Raspberry Pi (Trading) Ltd.
+ *
+ * Author: Naushir Patuck (naush@raspberrypi.com)
+ *
+ */
+
+#ifndef __BCM2835_ISP_H_
+#define __BCM2835_ISP_H_
+
+#include <linux/media/v4l2-isp.h>
+
+/*
+ * All structs below are directly mapped from struct
+ * mmal_parameter_isp_parameters in include/linux/raspberrypi/mmal-parameters.h
+ * for convenience.
+ */
+
+/**
+ * struct bcm2835_isp_rational - Rational value type.
+ *
+ * @num:	Numerator.
+ * @den:	Denominator.
+ */
+struct bcm2835_isp_rational {
+	__s32 num;
+	__u32 den;
+};
+
+/**
+ * struct bcm2835_isp_ccm - Colour correction matrix.
+ *
+ * @ccm:	3x3 correction matrix coefficients.
+ * @offsets:	1x3 correction offsets.
+ */
+struct bcm2835_isp_ccm {
+	struct bcm2835_isp_rational ccm[3][3];
+	__s32 offsets[3];
+};
+
+/**
+ * struct bcm2835_isp_custom_ccm - Custom CCM configuration.
+ *
+ * @enabled:	Enable custom CCM.
+ * @ccm:	Custom CCM coefficients and offsets.
+ */
+struct bcm2835_isp_custom_ccm {
+	__u32 enabled;
+	struct bcm2835_isp_ccm ccm;
+};
+
+/**
+ * enum bcm2835_isp_gain_format - format of the gains in the lens shading
+ *				  tables.
+ *
+ * @GAIN_FORMAT_U0P8_1:		Gains are u0.8 format, starting at 1.0
+ * @GAIN_FORMAT_U1P7_0:		Gains are u1.7 format, starting at 0.0
+ * @GAIN_FORMAT_U1P7_1:		Gains are u1.7 format, starting at 1.0
+ * @GAIN_FORMAT_U2P6_0:		Gains are u2.6 format, starting at 0.0
+ * @GAIN_FORMAT_U2P6_1:		Gains are u2.6 format, starting at 1.0
+ * @GAIN_FORMAT_U3P5_0:		Gains are u3.5 format, starting at 0.0
+ * @GAIN_FORMAT_U3P5_1:		Gains are u3.5 format, starting at 1.0
+ * @GAIN_FORMAT_U4P10:		Gains are u4.10 format, starting at 0.0
+ */
+enum bcm2835_isp_gain_format {
+	GAIN_FORMAT_U0P8_1 = 0,
+	GAIN_FORMAT_U1P7_0 = 1,
+	GAIN_FORMAT_U1P7_1 = 2,
+	GAIN_FORMAT_U2P6_0 = 3,
+	GAIN_FORMAT_U2P6_1 = 4,
+	GAIN_FORMAT_U3P5_0 = 5,
+	GAIN_FORMAT_U3P5_1 = 6,
+	GAIN_FORMAT_U4P10  = 7,
+};
+
+/**
+ * struct bcm2835_isp_lens_shading - Lens shading tables.
+ *
+ * @enabled:		Enable lens shading.
+ * @grid_cell_size:	Size of grid cells in samples (16, 32, 64, 128 or 256).
+ * @grid_width:		Width of lens shading tables in grid cells.
+ * @grid_stride:	Row to row distance (in grid cells) between grid cells
+ *			in the same horizontal location.
+ * @grid_height:	Height of lens shading tables in grid cells.
+ * @dmabuf:		dmabuf file handle containing the table.
+ * @ref_transform:	Reference transform - unsupported, please pass zero.
+ * @corner_sampled:	Whether the gains are sampled at the corner points
+ *			of the grid cells or in the cell centres.
+ * @gain_format:	Format of the gains (see enum &bcm2835_isp_gain_format).
+ */
+struct bcm2835_isp_lens_shading {
+	__u32 enabled;
+	__u32 grid_cell_size;
+	__u32 grid_width;
+	__u32 grid_stride;
+	__u32 grid_height;
+	__s32 dmabuf;
+	__u32 ref_transform;
+	__u32 corner_sampled;
+	__u32 gain_format;
+};
+
+/**
+ * struct bcm2835_isp_black_level - Sensor black level configuration.
+ *
+ * @enabled:		Enable black level.
+ * @black_level_r:	Black level for red channel.
+ * @black_level_g:	Black level for green channels.
+ * @black_level_b:	Black level for blue channel.
+ * @padding:		Unused padding.
+ */
+struct bcm2835_isp_black_level {
+	__u32 enabled;
+	__u16 black_level_r;
+	__u16 black_level_g;
+	__u16 black_level_b;
+	__u8 padding[2]; /* Unused */
+};
+
+/**
+ * struct bcm2835_isp_geq - Green equalisation parameters.
+ *
+ * @enabled:	Enable green equalisation.
+ * @offset:	Fixed offset of the green equalisation threshold.
+ * @slope:	Slope of the green equalisation threshold.
+ */
+struct bcm2835_isp_geq {
+	__u32 enabled;
+	__u32 offset;
+	struct bcm2835_isp_rational slope;
+};
+
+#define BCM2835_NUM_GAMMA_PTS 33
+
+/**
+ * struct bcm2835_isp_gamma - Gamma parameters.
+ *
+ * @enabled:	Enable gamma adjustment.
+ * @x:		X values of the points defining the gamma curve.
+ *		Values should be scaled to 16 bits.
+ * @y:		Y values of the points defining the gamma curve.
+ *		Values should be scaled to 16 bits.
+ */
+struct bcm2835_isp_gamma {
+	__u32 enabled;
+	__u16 x[BCM2835_NUM_GAMMA_PTS];
+	__u16 y[BCM2835_NUM_GAMMA_PTS];
+};
+
+/**
+ * enum bcm2835_isp_cdn_mode - Mode of operation for colour denoise.
+ *
+ * @CDN_MODE_FAST:		Fast (but lower quality) colour denoise
+ *				algorithm, typically used for video recording.
+ * @CDN_MODE_HIGH_QUALITY:	High quality (but slower) colour denoise
+ *				algorithm, typically used for stills capture.
+ */
+enum bcm2835_isp_cdn_mode {
+	CDN_MODE_FAST = 0,
+	CDN_MODE_HIGH_QUALITY = 1,
+};
+
+/**
+ * struct bcm2835_isp_cdn - Colour denoise parameters.
+ *
+ * @enabled:	Enable colour denoise.
+ * @mode:	Colour denoise operating mode (see enum &bcm2835_isp_cdn_mode)
+ */
+struct bcm2835_isp_cdn {
+	__u32 enabled;
+	__u32 mode;
+};
+
+/**
+ * struct bcm2835_isp_denoise - Denoise parameters.
+ *
+ * @enabled:	Enable denoise.
+ * @constant:	Fixed offset of the noise threshold.
+ * @slope:	Slope of the noise threshold.
+ * @strength:	Denoise strength between 0.0 (off) and 1.0 (maximum).
+ */
+struct bcm2835_isp_denoise {
+	__u32 enabled;
+	__u32 constant;
+	struct bcm2835_isp_rational slope;
+	struct bcm2835_isp_rational strength;
+};
+
+/**
+ * struct bcm2835_isp_sharpen - Sharpen parameters.
+ *
+ * @enabled:	Enable sharpening.
+ * @threshold:	Threshold at which to start sharpening pixels.
+ * @strength:	Strength with which pixel sharpening increases.
+ * @limit:	Limit to the amount of sharpening applied.
+ */
+struct bcm2835_isp_sharpen {
+	__u32 enabled;
+	struct bcm2835_isp_rational threshold;
+	struct bcm2835_isp_rational strength;
+	struct bcm2835_isp_rational limit;
+};
+
+/**
+ * enum bcm2835_isp_dpc_mode - defective pixel correction (DPC) strength.
+ *
+ * @DPC_MODE_OFF:		No DPC.
+ * @DPC_MODE_NORMAL:		Normal DPC.
+ * @DPC_MODE_STRONG:		Strong DPC.
+ */
+enum bcm2835_isp_dpc_mode {
+	DPC_MODE_OFF = 0,
+	DPC_MODE_NORMAL = 1,
+	DPC_MODE_STRONG = 2,
+};
+
+/**
+ * struct bcm2835_isp_dpc - Defective pixel correction (DPC) parameters.
+ *
+ * @enabled:	Enable DPC.
+ * @strength:	DPC strength (see enum &bcm2835_isp_dpc_mode).
+ */
+struct bcm2835_isp_dpc {
+	__u32 enabled;
+	__u32 strength;
+};
+
+/**
+ * struct bcm2835_isp_awb_gains - AWB gains configuration.
+ *
+ * @r_gain:	Red channel AWB gain.
+ * @b_gain:	Blue channel AWB gain.
+ */
+struct bcm2835_isp_awb_gains {
+	struct bcm2835_isp_rational r_gain;
+	struct bcm2835_isp_rational b_gain;
+};
+
+/**
+ * struct bcm2835_isp_digital_gain - Digital gain configuration.
+ *
+ * @gain:	Digital gain value.
+ */
+struct bcm2835_isp_digital_gain {
+	struct bcm2835_isp_rational gain;
+};
+
+/*
+ * BCM2835 ISP extensible parameters buffer definitions.
+ *
+ * The extensible parameters mechanism allows userspace to submit ISP
+ * configuration parameters as a buffer containing a series of tagged
+ * blocks rather than individual V4L2 controls. This enables atomic
+ * application of multiple parameters in a single operation.
+ */
+
+/**
+ * enum bcm2835_isp_param_buffer_version - BCM2835 ISP parameters buffer version
+ *
+ * @BCM2835_ISP_PARAM_BUFFER_V1: First version of parameters buffer format
+ */
+enum bcm2835_isp_param_buffer_version {
+	BCM2835_ISP_PARAM_BUFFER_V1 = V4L2_ISP_PARAMS_VERSION_V1,
+};
+
+/**
+ * enum bcm2835_isp_param_block_type - BCM2835 ISP parameter block types
+ *
+ * This enumeration defines the types of parameters blocks that can be
+ * included in the extensible parameters buffer. Each block type corresponds
+ * to a specific ISP processing block configuration.
+ *
+ * @BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL: Black level configuration
+ * @BCM2835_ISP_PARAM_BLOCK_GEQ: Green equalisation configuration
+ * @BCM2835_ISP_PARAM_BLOCK_GAMMA: Gamma curve configuration
+ * @BCM2835_ISP_PARAM_BLOCK_DENOISE: Denoise configuration
+ * @BCM2835_ISP_PARAM_BLOCK_SHARPEN: Sharpening configuration
+ * @BCM2835_ISP_PARAM_BLOCK_DPC: Defective pixel correction configuration
+ * @BCM2835_ISP_PARAM_BLOCK_CDN: Colour denoise configuration
+ * @BCM2835_ISP_PARAM_BLOCK_CC_MATRIX: Colour correction matrix configuration
+ * @BCM2835_ISP_PARAM_BLOCK_LENS_SHADING: Lens shading table configuration
+ * @BCM2835_ISP_PARAM_BLOCK_AWB_GAINS: AWB gains configuration
+ * @BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN: Digital gain configuration
+ */
+enum bcm2835_isp_param_block_type {
+	BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL,
+	BCM2835_ISP_PARAM_BLOCK_GEQ,
+	BCM2835_ISP_PARAM_BLOCK_GAMMA,
+	BCM2835_ISP_PARAM_BLOCK_DENOISE,
+	BCM2835_ISP_PARAM_BLOCK_SHARPEN,
+	BCM2835_ISP_PARAM_BLOCK_DPC,
+	BCM2835_ISP_PARAM_BLOCK_CDN,
+	BCM2835_ISP_PARAM_BLOCK_CC_MATRIX,
+	BCM2835_ISP_PARAM_BLOCK_LENS_SHADING,
+	BCM2835_ISP_PARAM_BLOCK_AWB_GAINS,
+	BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN,
+};
+
+/**
+ * struct bcm2835_isp_params_black_level - Black level parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL)
+ * @black_level: Black level configuration
+ */
+struct bcm2835_isp_params_black_level {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_black_level black_level;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_geq - Green equalisation parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_GEQ)
+ * @geq: Green equalisation configuration
+ */
+struct bcm2835_isp_params_geq {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_geq geq;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_gamma - Gamma parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_GAMMA)
+ * @gamma: Gamma curve configuration
+ */
+struct bcm2835_isp_params_gamma {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_gamma gamma;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_denoise - Denoise parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_DENOISE)
+ * @denoise: Denoise configuration
+ */
+struct bcm2835_isp_params_denoise {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_denoise denoise;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_sharpen - Sharpen parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_SHARPEN)
+ * @sharpen: Sharpening configuration
+ */
+struct bcm2835_isp_params_sharpen {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_sharpen sharpen;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_dpc - Defective pixel correction parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_DPC)
+ * @dpc: DPC configuration
+ */
+struct bcm2835_isp_params_dpc {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_dpc dpc;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_cdn - Colour denoise parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_CDN)
+ * @cdn: Colour denoise configuration
+ */
+struct bcm2835_isp_params_cdn {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_cdn cdn;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_cc_matrix - Colour correction matrix parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_CC_MATRIX)
+ * @ccm: Colour correction matrix configuration
+ */
+struct bcm2835_isp_params_cc_matrix {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_custom_ccm ccm;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_lens_shading - Lens shading parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_LENS_SHADING)
+ * @ls: Lens shading configuration (includes dmabuf fd for table data)
+ */
+struct bcm2835_isp_params_lens_shading {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_lens_shading ls;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_awb_gains - AWB gains parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_AWB_GAINS)
+ * @awb_gains: AWB gains configuration
+ */
+struct bcm2835_isp_params_awb_gains {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_awb_gains awb_gains;
+} __attribute__((aligned(8)));
+
+/**
+ * struct bcm2835_isp_params_digital_gain - Digital gain parameters block
+ *
+ * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN)
+ * @digital_gain: Digital gain configuration
+ */
+struct bcm2835_isp_params_digital_gain {
+	struct v4l2_isp_params_block_header header;
+	struct bcm2835_isp_digital_gain digital_gain;
+} __attribute__((aligned(8)));
+
+/**
+ * define BCM2835_ISP_PARAMS_MAX_SIZE - Maximum size of all ISP parameters
+ *
+ * This defines the maximum size needed to accommodate all possible parameter
+ * blocks in a single buffer. Drivers use this to allocate appropriately
+ * sized buffers.
+ */
+#define BCM2835_ISP_PARAMS_MAX_SIZE					\
+	(sizeof(struct bcm2835_isp_params_black_level) +		\
+	 sizeof(struct bcm2835_isp_params_geq) +			\
+	 sizeof(struct bcm2835_isp_params_gamma) +			\
+	 sizeof(struct bcm2835_isp_params_denoise) +			\
+	 sizeof(struct bcm2835_isp_params_sharpen) +			\
+	 sizeof(struct bcm2835_isp_params_dpc) +			\
+	 sizeof(struct bcm2835_isp_params_cdn) +			\
+	 sizeof(struct bcm2835_isp_params_cc_matrix) +			\
+	 sizeof(struct bcm2835_isp_params_lens_shading) +		\
+	 sizeof(struct bcm2835_isp_params_awb_gains) +			\
+	 sizeof(struct bcm2835_isp_params_digital_gain))
+
+/*
+ * ISP statistics structures.
+ *
+ * The bcm2835_isp_stats structure is generated at the output of the
+ * statistics node.  Note that this does not directly map onto the statistics
+ * output of the ISP HW.  Instead, the MMAL firmware code maps the HW statistics
+ * to the bcm2835_isp_stats structure.
+ */
+#define DEFAULT_AWB_REGIONS_X 16
+#define DEFAULT_AWB_REGIONS_Y 12
+
+#define NUM_HISTOGRAMS 2
+#define NUM_HISTOGRAM_BINS 128
+#define AWB_REGIONS (DEFAULT_AWB_REGIONS_X * DEFAULT_AWB_REGIONS_Y)
+#define FLOATING_REGIONS 16
+#define AGC_REGIONS 16
+#define FOCUS_REGIONS 12
+
+/**
+ * struct bcm2835_isp_stats_hist - Histogram statistics
+ *
+ * @r_hist:	Red channel histogram.
+ * @g_hist:	Combined green channel histogram.
+ * @b_hist:	Blue channel histogram.
+ */
+struct bcm2835_isp_stats_hist {
+	__u32 r_hist[NUM_HISTOGRAM_BINS];
+	__u32 g_hist[NUM_HISTOGRAM_BINS];
+	__u32 b_hist[NUM_HISTOGRAM_BINS];
+};
+
+/**
+ * struct bcm2835_isp_stats_region - Region sums.
+ *
+ * @counted:	The number of 2x2 bayer tiles accumulated.
+ * @notcounted:	The number of 2x2 bayer tiles not accumulated.
+ * @r_sum:	Total sum of counted pixels in the red channel for a region.
+ * @g_sum:	Total sum of counted pixels in the green channel for a region.
+ * @b_sum:	Total sum of counted pixels in the blue channel for a region.
+ */
+struct bcm2835_isp_stats_region {
+	__u32 counted;
+	__u32 notcounted;
+	__u64 r_sum;
+	__u64 g_sum;
+	__u64 b_sum;
+};
+
+/**
+ * struct bcm2835_isp_stats_focus - Focus statistics.
+ *
+ * @contrast_val:	Focus measure - accumulated output of the focus filter.
+ *			In the first dimension, index [0] counts pixels below a
+ *			preset threshold, and index [1] counts pixels above the
+ *			threshold.  In the second dimension, index [0] uses the
+ *			first predefined filter, and index [1] uses the second
+ *			predefined filter.
+ * @contrast_val_num:	The number of counted pixels in the above accumulation.
+ */
+struct bcm2835_isp_stats_focus {
+	__u64 contrast_val[2][2];
+	__u32 contrast_val_num[2][2];
+};
+
+/**
+ * struct bcm2835_isp_stats - ISP statistics.
+ *
+ * @version:		Version of the bcm2835_isp_stats structure.
+ * @size:		Size of the bcm2835_isp_stats structure.
+ * @hist:		Histogram statistics for the entire image.
+ * @awb_stats:		Statistics for the regions defined for AWB calculations.
+ * @floating_stats:	Statistics for arbitrarily placed (floating) regions.
+ * @agc_stats:		Statistics for the regions defined for AGC calculations.
+ * @focus_stats:	Focus filter statistics for the focus regions.
+ */
+struct bcm2835_isp_stats {
+	__u32 version;
+	__u32 size;
+	struct bcm2835_isp_stats_hist hist[NUM_HISTOGRAMS];
+	struct bcm2835_isp_stats_region awb_stats[AWB_REGIONS];
+	struct bcm2835_isp_stats_region floating_stats[FLOATING_REGIONS];
+	struct bcm2835_isp_stats_region agc_stats[AGC_REGIONS];
+	struct bcm2835_isp_stats_focus focus_stats[FOCUS_REGIONS];
+};
+
+#endif /* __BCM2835_ISP_H_ */
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 5373dba640fa..f98977138d9c 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -870,6 +870,8 @@ struct v4l2_pix_format {
 #define V4L2_META_FMT_D4XX        v4l2_fourcc('D', '4', 'X', 'X') /* D4XX Payload Header metadata */
 #define V4L2_META_FMT_UVC_MSXU_1_5  v4l2_fourcc('U', 'V', 'C', 'M') /* UVC MSXU metadata */
 #define V4L2_META_FMT_VIVID	  v4l2_fourcc('V', 'I', 'V', 'D') /* Vivid Metadata */
+#define V4L2_META_FMT_BCM2835_ISP_STATS v4l2_fourcc('B', 'S', 'T', 'A') /* BCM2835 ISP stats */
+#define V4L2_META_FMT_BCM2835_ISP_PARAMS v4l2_fourcc('B', 'C', 'M', 'P') /* BCM2835 ISP params */
 
 /* Vendor specific - used for RK_ISP1 camera sub-system */
 #define V4L2_META_FMT_RK_ISP1_PARAMS	v4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 3A Parameters */

-- 
2.55.0

Re: [PATCH v5 09/10] media: platform: broadcom: Add bcm2835-isp driver

[Paul Elder]

Quoting Jai Luthra (2026-09-17 17:23:15)
> From: Naushir Patuck <naush@raspberrypi.com>
> 
> The BCM2835 ISP is a fixed-function hardware block that performs image
> processing on Bayer, RGB, and YUV frames. It produces two processed
> video outputs at different resolutions and can generate statistics for
> Bayer inputs. The hardware is not accessible directly, so this driver
> programs it through the VCHIQ MMAL interface.
> 
> As the topology cannot be represented as a simple V4L2 M2M device, we
> register a media device with 5 video nodes: one output (sink), two
> capture (processed frames), one metadata capture (statistics), and one
> metadata output (config parameters). The VCHIQ firmware supports two
> concurrent users, so instantiate two identical media graphs.
> 
> ISP configuration uses the V4L2 extensible parameters framework through
> the dedicated params node, allowing userspace to batch multiple
> parameter blocks (black level, gamma, CCM, lens shading, etc.) in a
> single buffer that is applied on the next frame boundary.
> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> Co-developed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Co-developed-by: Jai Luthra <jai.luthra@ideasonboard.com>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> Tested-by: Paul Elder <paul.elder@ideasonboard.com>

Looks good to me.

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
> Changes in v5:
> - Fix warnings reported by media-ci (coccinelle, smatch etc.)
>   - Use struct_group() around the fields we want to memcpy from UAPI param
>     struct to the anonymous structs inside mmal_parameter_isp_parameters
>   - Don't use complicated pointer arithmetic and instead write
>     mmal_param->_mmal_substruct.update = 1 explicitly
>   - Only check for IS_ERR and not IS_ERR_OR_NULL for output of
>     vb2_core_expbuf_dmabuf()
>   - Check node->id against array bounds
> Changes in v4:
> - Set ISP_NUM_INSTANCES to 1 until we have proper support for
>   multiplexing ISP instances (Laurent)
> - Add a new struct mmal_parameter_isp_parameters {} in mmal-parameters.h
>   to send combined updates the firmware (Dave)
> - Rework bcm2835-isp-params.c to use the above and save expensive
>   messages over IPC boundary (Dave)
> - Test if the firmware supports the single struct, and fail with an
>   error message asking the user to update their firmware if not (Dave)
> - Check for retval of isp_set_param() and print error messages if it
>   fails
> - Various cleanups and suggestions (Paul)
> ---
>  Documentation/admin-guide/media/bcm2835-isp.dot    |   14 +
>  Documentation/admin-guide/media/bcm2835-isp.rst    |   78 +
>  Documentation/admin-guide/media/v4l-drivers.rst    |    1 +
>  .../userspace-api/media/v4l/meta-formats.rst       |    1 +
>  .../media/v4l/metafmt-bcm2835-isp.rst              |  101 ++
>  MAINTAINERS                                        |    9 +
>  drivers/media/platform/broadcom/Kconfig            |    1 +
>  drivers/media/platform/broadcom/Makefile           |    1 +
>  .../media/platform/broadcom/bcm2835-isp/Kconfig    |   15 +
>  .../media/platform/broadcom/bcm2835-isp/Makefile   |    4 +
>  .../broadcom/bcm2835-isp/bcm2835-isp-common.h      |   50 +
>  .../broadcom/bcm2835-isp/bcm2835-isp-fmts.h        |  558 +++++++
>  .../broadcom/bcm2835-isp/bcm2835-isp-params.c      |  510 +++++++
>  .../broadcom/bcm2835-isp/bcm2835-v4l2-isp.c        | 1516 ++++++++++++++++++++
>  drivers/media/v4l2-core/v4l2-ioctl.c               |    2 +
>  include/linux/raspberrypi/mmal-parameters.h        |  155 +-
>  include/uapi/linux/bcm2835-isp.h                   |  530 +++++++
>  include/uapi/linux/videodev2.h                     |    2 +
>  18 files changed, 3536 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/admin-guide/media/bcm2835-isp.dot b/Documentation/admin-guide/media/bcm2835-isp.dot
> new file mode 100644
> index 000000000000..cda3defe2d99
> --- /dev/null
> +++ b/Documentation/admin-guide/media/bcm2835-isp.dot
> @@ -0,0 +1,14 @@
> +digraph board {
> +       rankdir=TB
> +       n00000001 [label="bcm2835-isp-output0\n/dev/video13", shape=box, style=filled, fillcolor=yellow]
> +       n00000001 -> n00000015 [style=bold]
> +       n00000005 [label="bcm2835-isp-capture0\n/dev/video14", shape=box, style=filled, fillcolor=yellow]
> +       n00000009 [label="bcm2835-isp-capture1\n/dev/video15", shape=box, style=filled, fillcolor=yellow]
> +       n0000000d [label="bcm2835-isp-stats2\n/dev/video16", shape=box, style=filled, fillcolor=yellow]
> +       n00000011 [label="bcm2835-isp-params\n/dev/video17", shape=box, style=filled, fillcolor=yellow]
> +       n00000011 -> n00000015 [style=bold]
> +       n00000015 [label="bcm2835-isp\n", shape=box, style=filled, fillcolor=yellow]
> +       n00000015 -> n00000005 [style=bold]
> +       n00000015 -> n00000009 [style=bold]
> +       n00000015 -> n0000000d [style=bold]
> +}
> diff --git a/Documentation/admin-guide/media/bcm2835-isp.rst b/Documentation/admin-guide/media/bcm2835-isp.rst
> new file mode 100644
> index 000000000000..6384cc7b3eb0
> --- /dev/null
> +++ b/Documentation/admin-guide/media/bcm2835-isp.rst
> @@ -0,0 +1,78 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +=============================================
> +Broadcom BCM2835 Image Signal Processor (ISP)
> +=============================================
> +
> +The BCM2835 ISP
> +===============
> +
> +The BCM2835 Image Signal Processor (ISP) is a fixed function hardware pipeline
> +that performs image processing on frames stored in memory. Frames can be Bayer,
> +RGB, or YUV and are submitted to the ISP through a V4L2 output node. The ISP
> +produces two processed image outputs at different resolutions and can generate
> +statistics for Bayer inputs.
> +
> +The bcm2835-isp driver
> +======================
> +
> +The bcm2835-isp driver lives under
> +`drivers/media/platform/broadcom/bcm2835-isp` and registers a set of V4L2 video
> +nodes connected through a media graph. The pipeline is configured through the
> +V4L2 extensible parameters framework using a dedicated params node.
> +
> +The media topology registered by the driver is represented below:
> +
> +.. _bcm2835-isp-topology:
> +
> +.. kernel-figure:: bcm2835-isp.dot
> +    :alt:   Diagram of the default media pipeline topology
> +    :align: center
> +
> +The media graph registers the following video device nodes:
> +
> +- bcm2835-isp-output0: output device that queues frames to the ISP input.
> +- bcm2835-isp-capture0: capture device for the main processed output.
> +- bcm2835-isp-capture1: capture device for the secondary processed output.
> +- bcm2835-isp-stats2: metadata capture device for ISP statistics.
> +- bcm2835-isp-params: metadata output device for ISP configuration parameters.
> +
> +bcm2835-isp-output0
> +-------------------
> +
> +Frames to be processed by the ISP are queued to `bcm2835-isp-output0`. Supported
> +input formats include Bayer, RGB, and YUV.
> +
> +bcm2835-isp-capture0, bcm2835-isp-capture1
> +------------------------------------------
> +
> +The two capture devices return processed images in YUV or RGB formats. The
> +secondary output is typically used for a lower-resolution stream.
> +
> +bcm2835-isp-stats2
> +------------------
> +
> +The `bcm2835-isp-stats2` node provides per-frame statistics for Bayer inputs as
> +metadata buffers. The metadata format is described at
> +:ref:`v4l2-meta-fmt-bcm2835-isp-stats`.
> +
> +bcm2835-isp-params
> +------------------
> +
> +The `bcm2835-isp-params` node accepts configuration buffers that define the ISP
> +processing parameters to apply on the next frame boundary. The metadata format
> +is described at :ref:`v4l2-meta-fmt-bcm2835-isp-params`.
> +
> +ISP configuration
> +=================
> +
> +The ISP configuration is described solely by the contents of the parameters
> +buffer queued to `bcm2835-isp-params`. Each buffer uses the V4L2 extensible
> +parameters format described in :ref:`v4l2-isp`, with block types defined in
> +``include/uapi/linux/bcm2835-isp.h``.
> +
> +Userspace must populate a :c:type:`v4l2_isp_params_buffer` and append one or
> +more block structs, each of which embeds a
> +:c:type:`v4l2_isp_params_block_header` as its first member. The driver applies
> +those parameters on a frame boundary once the buffer is queued. Parameter
> +structure is defined at :ref:`v4l2-meta-fmt-bcm2835-isp-params`.
> diff --git a/Documentation/admin-guide/media/v4l-drivers.rst b/Documentation/admin-guide/media/v4l-drivers.rst
> index 4621eae9fa1e..cfbd9a64557d 100644
> --- a/Documentation/admin-guide/media/v4l-drivers.rst
> +++ b/Documentation/admin-guide/media/v4l-drivers.rst
> @@ -10,6 +10,7 @@ Video4Linux (V4L) driver-specific documentation
>         :maxdepth: 2
>  
>         amdisp4-1
> +       bcm2835-isp
>         bttv
>         c3-isp
>         cafe_ccic
> diff --git a/Documentation/userspace-api/media/v4l/meta-formats.rst b/Documentation/userspace-api/media/v4l/meta-formats.rst
> index b5455229837e..02f0b6524472 100644
> --- a/Documentation/userspace-api/media/v4l/meta-formats.rst
> +++ b/Documentation/userspace-api/media/v4l/meta-formats.rst
> @@ -14,6 +14,7 @@ These formats are used for the :ref:`metadata` interface only.
>      :maxdepth: 1
>  
>      metafmt-arm-mali-c55
> +    metafmt-bcm2835-isp
>      metafmt-c3-isp
>      metafmt-d4xx
>      metafmt-generic
> diff --git a/Documentation/userspace-api/media/v4l/metafmt-bcm2835-isp.rst b/Documentation/userspace-api/media/v4l/metafmt-bcm2835-isp.rst
> new file mode 100644
> index 000000000000..6ed1d1e7890f
> --- /dev/null
> +++ b/Documentation/userspace-api/media/v4l/metafmt-bcm2835-isp.rst
> @@ -0,0 +1,101 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +.. c:namespace:: V4L
> +
> +***********************************************************************************
> +V4L2_META_FMT_BCM2835_ISP_STATS ('BSTA'), V4L2_META_FMT_BCM2835_ISP_PARAMS ('BCMP')
> +***********************************************************************************
> +
> +.. _v4l2-meta-fmt-bcm2835-isp-stats:
> +
> +BCM2835 ISP Statistics
> +======================
> +
> +The BCM2835 ISP hardware calculate image statistics for an input Bayer frame.
> +These statistics are obtained from the "bcm2835-isp0-capture3" device node
> +using the :c:type:`v4l2_meta_format` interface. They are formatted as described
> +by the :c:type:`bcm2835_isp_stats` structure below.
> +
> +.. code-block:: c
> +
> +       #define DEFAULT_AWB_REGIONS_X 16
> +       #define DEFAULT_AWB_REGIONS_Y 12
> +
> +       #define NUM_HISTOGRAMS 2
> +       #define NUM_HISTOGRAM_BINS 128
> +       #define AWB_REGIONS (DEFAULT_AWB_REGIONS_X * DEFAULT_AWB_REGIONS_Y)
> +       #define FLOATING_REGIONS 16
> +       #define AGC_REGIONS 16
> +       #define FOCUS_REGIONS 12
> +
> +.. kernel-doc:: include/uapi/linux/bcm2835-isp.h
> +   :functions: bcm2835_isp_stats_hist bcm2835_isp_stats_region
> +                    bcm2835_isp_stats_focus bcm2835_isp_stats
> +
> +.. _v4l2-meta-fmt-bcm2835-isp-params:
> +
> +BCM2835 ISP parameters
> +======================
> +
> +The ISP parameters are configured by queuing buffers to the "bcm2835-isp-params"
> +metadata output node. Parameter buffers use the V4L2 extensible parameters
> +format described in :ref:`v4l2-isp`. Userspace assembles one or more parameter
> +blocks in the data area of :c:type:`v4l2_isp_params_buffer` and submits the
> +buffer to the driver.
> +
> +Each block begins with a :c:type:`v4l2_isp_params_block_header` and embeds the
> +block-specific payload. The header ``type`` must be set to a value from
> +:c:type:`bcm2835_isp_param_block_type`, ``size`` must match the block size, and
> +``flags`` can be used to enable or disable the block.
> +
> +Example: enqueue two parameter blocks (black level and gamma)
> +-------------------------------------------------------------
> +
> +.. code-block:: c
> +
> +       struct v4l2_isp_params_buffer *params =
> +               (struct v4l2_isp_params_buffer *)buffer;
> +
> +       params->version = BCM2835_ISP_PARAM_BUFFER_V1;
> +       params->data_size = 0;
> +
> +       void *data = (void *)params->data;
> +
> +       struct bcm2835_isp_params_black_level *black =
> +               (struct bcm2835_isp_params_black_level *)data;
> +
> +       black->header.type = BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL;
> +       black->header.flags |= V4L2_ISP_PARAMS_FL_BLOCK_ENABLE;
> +       black->header.size = sizeof(*black);
> +
> +       black->black_level.enabled = 1;
> +       black->black_level.black_level_r = 64;
> +       black->black_level.black_level_g = 64;
> +       black->black_level.black_level_b = 64;
> +
> +       data += sizeof(*black);
> +       params->data_size += sizeof(*black);
> +
> +       struct bcm2835_isp_params_gamma *gamma =
> +               (struct bcm2835_isp_params_gamma *)data;
> +
> +       gamma->header.type = BCM2835_ISP_PARAM_BLOCK_GAMMA;
> +       gamma->header.flags |= V4L2_ISP_PARAMS_FL_BLOCK_ENABLE;
> +       gamma->header.size = sizeof(*gamma);
> +
> +       gamma->gamma.enabled = 1;
> +       /* Fill gamma->gamma.x[] and gamma->gamma.y[] here */
> +
> +       params->data_size += sizeof(*gamma);
> +
> +The total payload size must not exceed :c:macro:`BCM2835_ISP_PARAMS_MAX_SIZE`.
> +The driver applies parameter buffers on the next frame boundary.
> +
> +BCM2835 ISP uAPI data types
> +===========================
> +
> +.. kernel-doc:: include/uapi/linux/bcm2835-isp.h
> +   :functions: bcm2835_isp_awb_gains bcm2835_isp_ccm bcm2835_isp_gain_format
> +                bcm2835_isp_digital_gain bcm2835_isp_lens_shading
> +                bcm2835_isp_black_level bcm2835_isp_geq bcm2835_isp_gamma
> +                bcm2835_isp_denoise bcm2835_isp_sharpen bcm2835_isp_dpc_mode
> +                bcm2835_isp_dpc bcm2835_isp_rational bcm2835_isp_cdn
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 68ef4b2f9db6..7417cb31244b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5187,6 +5187,15 @@ S:       Maintained
>  F:     Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml
>  F:     drivers/media/platform/broadcom/bcm2835-unicam/*
>  
> +BROADCOM BCM2835 ISP DRIVER
> +M:     Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
> +L:     linux-media@vger.kernel.org
> +S:     Maintained
> +F:     Documentation/admin-guide/media/bcm2835-isp.rst
> +F:     Documentation/userspace-api/media/v4l/metafmt-bcm2835-isp.rst
> +F:     drivers/media/platform/broadcom/bcm2835-isp/*
> +F:     include/uapi/linux/bcm2835-isp.h
> +
>  BROADCOM BCM47XX MIPS ARCHITECTURE
>  M:     Hauke Mehrtens <hauke@hauke-m.de>
>  M:     Rafał Miłecki <zajec5@gmail.com>
> diff --git a/drivers/media/platform/broadcom/Kconfig b/drivers/media/platform/broadcom/Kconfig
> index cab44885182c..0da6c83e97ed 100644
> --- a/drivers/media/platform/broadcom/Kconfig
> +++ b/drivers/media/platform/broadcom/Kconfig
> @@ -3,3 +3,4 @@
>  comment "Broadcom BCM283x/BCM271x media platform drivers"
>  
>  source "drivers/media/platform/broadcom/bcm2835-unicam/Kconfig"
> +source "drivers/media/platform/broadcom/bcm2835-isp/Kconfig"
> diff --git a/drivers/media/platform/broadcom/Makefile b/drivers/media/platform/broadcom/Makefile
> index 33a89bdb0029..1d49e586f492 100644
> --- a/drivers/media/platform/broadcom/Makefile
> +++ b/drivers/media/platform/broadcom/Makefile
> @@ -1,3 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
>  obj-y += bcm2835-unicam/
> +obj-y += bcm2835-isp/
> diff --git a/drivers/media/platform/broadcom/bcm2835-isp/Kconfig b/drivers/media/platform/broadcom/bcm2835-isp/Kconfig
> new file mode 100644
> index 000000000000..3a4db5bf61a1
> --- /dev/null
> +++ b/drivers/media/platform/broadcom/bcm2835-isp/Kconfig
> @@ -0,0 +1,15 @@
> +config VIDEO_ISP_BCM2835
> +       tristate "BCM2835 ISP support"
> +       depends on MEDIA_SUPPORT
> +       depends on VIDEO_DEV && (ARCH_BCM2835 || COMPILE_TEST)
> +       depends on MEDIA_CONTROLLER
> +       select BCM2835_VCHIQ_MMAL
> +       select V4L2_ISP
> +       select VIDEOBUF2_DMA_CONTIG
> +       help
> +         This is the V4L2 driver for the Broadcom BCM2835 ISP hardware.
> +         This operates over the VCHIQ interface to a service running on
> +         VideoCore.
> +
> +         To compile this driver as a module, choose M here: the module
> +         will be called bcm2835-isp.
> diff --git a/drivers/media/platform/broadcom/bcm2835-isp/Makefile b/drivers/media/platform/broadcom/bcm2835-isp/Makefile
> new file mode 100644
> index 000000000000..21224cb85d5f
> --- /dev/null
> +++ b/drivers/media/platform/broadcom/bcm2835-isp/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0
> +bcm2835-isp-objs := bcm2835-v4l2-isp.o bcm2835-isp-params.o
> +
> +obj-$(CONFIG_VIDEO_ISP_BCM2835) += bcm2835-isp.o
> diff --git a/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-common.h b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-common.h
> new file mode 100644
> index 000000000000..60be0607b1ab
> --- /dev/null
> +++ b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-common.h
> @@ -0,0 +1,50 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Broadcom BCM2835 ISP driver - common header
> + *
> + * Copyright (c) 2026 Raspberry Pi (Trading) Ltd.
> + * Copyright (c) 2026 Ideas On Board Oy
> + */
> +
> +#ifndef BCM2835_ISP_COMMON_H
> +#define BCM2835_ISP_COMMON_H
> +
> +#include <linux/mutex.h>
> +#include <linux/spinlock.h>
> +#include <linux/raspberrypi/mmal-parameters.h>
> +#include <linux/raspberrypi/mmal-vchiq.h>
> +
> +#include <media/media-entity.h>
> +#include <media/v4l2-device.h>
> +#include <media/videobuf2-core.h>
> +
> +struct dma_buf;
> +
> +struct bcm2835_isp_params {
> +       struct device *dev;
> +       struct v4l2_device *v4l2_dev;
> +       struct vchiq_mmal_instance *mmal_instance;
> +       struct vchiq_mmal_port *port;
> +
> +       struct video_device vdev;
> +       struct media_pad pad;
> +       struct vb2_queue queue;
> +       struct mutex lock; /* params node vdev lock */
> +
> +       /* Lens shading state */
> +       struct dma_buf *last_ls_dmabuf;
> +};
> +
> +struct bcm2835_isp_params *
> +bcm2835_isp_params_register(struct v4l2_device *v4l2_dev, struct device *dev,
> +                           struct vchiq_mmal_instance *mmal_instance,
> +                           struct vchiq_mmal_port *port, int video_nr);
> +
> +void bcm2835_isp_params_unregister(struct bcm2835_isp_params *params);
> +
> +int bcm2835_isp_params_drop_ls_ref(struct bcm2835_isp_params *params);
> +
> +int bcm2835_isp_node_querycap(struct file *file, void *priv,
> +                             struct v4l2_capability *cap);
> +
> +#endif /* BCM2835_ISP_COMMON_H */
> diff --git a/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-fmts.h b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-fmts.h
> new file mode 100644
> index 000000000000..6f3333d33c4f
> --- /dev/null
> +++ b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-fmts.h
> @@ -0,0 +1,558 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Broadcom BCM2835 ISP driver
> + *
> + * Copyright © 2019-2026 Raspberry Pi (Trading) Ltd.
> + *
> + * Author: Naushir Patuck (naush@raspberrypi.com)
> + *
> + */
> +
> +#ifndef BCM2835_ISP_FMTS
> +#define BCM2835_ISP_FMTS
> +
> +#include <linux/videodev2.h>
> +#include <linux/raspberrypi/mmal-encodings.h>
> +
> +struct bcm2835_isp_fmt {
> +       u32 fourcc;
> +       int depth;
> +       int bytesperline_align;
> +       u32 mmal_fmt;
> +       int size_multiplier_x2;
> +       u32 colorspace_mask;
> +       enum v4l2_colorspace colorspace_default;
> +       unsigned int step_size;
> +};
> +
> +#define V4L2_COLORSPACE_MASK(colorspace) BIT(colorspace)
> +
> +#define V4L2_COLORSPACE_MASK_JPEG V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_JPEG)
> +#define V4L2_COLORSPACE_MASK_SMPTE170M V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SMPTE170M)
> +#define V4L2_COLORSPACE_MASK_REC709 V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_REC709)
> +#define V4L2_COLORSPACE_MASK_SRGB V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SRGB)
> +#define V4L2_COLORSPACE_MASK_RAW V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_RAW)
> +
> +/*
> + * All three colour spaces JPEG, SMPTE170M and REC709 are fundamentally sRGB
> + * underneath (as near as makes no difference to us), just with different YCbCr
> + * encodings. Therefore the ISP can generate sRGB on its main output and any of
> + * the others on its low resolution output. Applications should, when using both
> + * outputs, program the colour spaces on them to be the same, matching whatever
> + * is requested for the low resolution output, even if the main output is
> + * producing an RGB format. In turn this requires us to allow all these colour
> + * spaces for every YUV/RGB output format.
> + */
> +#define V4L2_COLORSPACE_MASK_ALL_SRGB (V4L2_COLORSPACE_MASK_JPEG |     \
> +                                      V4L2_COLORSPACE_MASK_SRGB |      \
> +                                      V4L2_COLORSPACE_MASK_SMPTE170M | \
> +                                      V4L2_COLORSPACE_MASK_REC709)
> +
> +static const struct bcm2835_isp_fmt supported_formats[] = {
> +       {
> +               /* YUV formats */
> +               .fourcc             = V4L2_PIX_FMT_YUV420,
> +               .depth              = 8,
> +               .bytesperline_align = 64,
> +               .mmal_fmt           = MMAL_ENCODING_I420,
> +               .size_multiplier_x2 = 3,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_JPEG,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_YVU420,
> +               .depth              = 8,
> +               .bytesperline_align = 64,
> +               .mmal_fmt           = MMAL_ENCODING_YV12,
> +               .size_multiplier_x2 = 3,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SMPTE170M,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_NV12,
> +               .depth              = 8,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_NV12,
> +               .size_multiplier_x2 = 3,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SMPTE170M,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_NV21,
> +               .depth              = 8,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_NV21,
> +               .size_multiplier_x2 = 3,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SMPTE170M,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_YUYV,
> +               .depth              = 16,
> +               .bytesperline_align = 64,
> +               .mmal_fmt           = MMAL_ENCODING_YUYV,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SMPTE170M,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_UYVY,
> +               .depth              = 16,
> +               .bytesperline_align = 64,
> +               .mmal_fmt           = MMAL_ENCODING_UYVY,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SMPTE170M,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_YVYU,
> +               .depth              = 16,
> +               .bytesperline_align = 64,
> +               .mmal_fmt           = MMAL_ENCODING_YVYU,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SMPTE170M,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_VYUY,
> +               .depth              = 16,
> +               .bytesperline_align = 64,
> +               .mmal_fmt           = MMAL_ENCODING_VYUY,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SMPTE170M,
> +               .step_size          = 2,
> +       }, {
> +               /* RGB formats */
> +               .fourcc             = V4L2_PIX_FMT_RGB24,
> +               .depth              = 24,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_RGB24,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SRGB,
> +               .step_size          = 1,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_RGB565,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_RGB16,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SRGB,
> +               .step_size          = 1,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_BGR24,
> +               .depth              = 24,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BGR24,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SRGB,
> +               .step_size          = 1,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_XBGR32,
> +               .depth              = 32,
> +               .bytesperline_align = 64,
> +               .mmal_fmt           = MMAL_ENCODING_BGRA,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SRGB,
> +               .step_size          = 1,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_RGBX32,
> +               .depth              = 32,
> +               .bytesperline_align = 64,
> +               .mmal_fmt           = MMAL_ENCODING_RGBA,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_ALL_SRGB,
> +               .colorspace_default = V4L2_COLORSPACE_SRGB,
> +               .step_size          = 1,
> +       }, {
> +               /* Bayer formats */
> +               /* 8 bit */
> +               .fourcc             = V4L2_PIX_FMT_SRGGB8,
> +               .depth              = 8,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SRGGB8,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SBGGR8,
> +               .depth              = 8,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SBGGR8,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGRBG8,
> +               .depth              = 8,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGRBG8,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGBRG8,
> +               .depth              = 8,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGBRG8,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 10 bit */
> +               .fourcc             = V4L2_PIX_FMT_SRGGB10P,
> +               .depth              = 10,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SRGGB10P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SBGGR10P,
> +               .depth              = 10,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SBGGR10P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGRBG10P,
> +               .depth              = 10,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGRBG10P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGBRG10P,
> +               .depth              = 10,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGBRG10P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 12 bit */
> +               .fourcc             = V4L2_PIX_FMT_SRGGB12P,
> +               .depth              = 12,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SRGGB12P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SBGGR12P,
> +               .depth              = 12,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SBGGR12P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGRBG12P,
> +               .depth              = 12,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGRBG12P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGBRG12P,
> +               .depth              = 12,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGBRG12P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 14 bit */
> +               .fourcc             = V4L2_PIX_FMT_SRGGB14P,
> +               .depth              = 14,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SRGGB14P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SBGGR14P,
> +               .depth              = 14,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SBGGR14P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGRBG14P,
> +               .depth              = 14,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGRBG14P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGBRG14P,
> +               .depth              = 14,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGBRG14P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 16 bit */
> +               .fourcc             = V4L2_PIX_FMT_SRGGB16,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SRGGB16,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SBGGR16,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SBGGR16,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGRBG16,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGRBG16,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGBRG16,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGBRG16,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* Bayer formats unpacked to 16bpp */
> +               /* 10 bit */
> +               .fourcc             = V4L2_PIX_FMT_SRGGB10,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SRGGB10,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SBGGR10,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SBGGR10,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGRBG10,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGRBG10,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGBRG10,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGBRG10,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 12 bit */
> +               .fourcc             = V4L2_PIX_FMT_SRGGB12,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SRGGB12,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SBGGR12,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SBGGR12,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGRBG12,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGRBG12,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGBRG12,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGBRG12,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 14 bit */
> +               .fourcc             = V4L2_PIX_FMT_SRGGB14,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SRGGB14,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SBGGR14,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SBGGR14,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGRBG14,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGRBG14,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_PIX_FMT_SGBRG14,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_BAYER_SGBRG14,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* Monochrome MIPI formats */
> +               /* 8 bit */
> +               .fourcc             = V4L2_PIX_FMT_GREY,
> +               .depth              = 8,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_GREY,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 10 bit */
> +               .fourcc             = V4L2_PIX_FMT_Y10P,
> +               .depth              = 10,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_Y10P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 12 bit */
> +               .fourcc             = V4L2_PIX_FMT_Y12P,
> +               .depth              = 12,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_Y12P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 14 bit */
> +               .fourcc             = V4L2_PIX_FMT_Y14P,
> +               .depth              = 14,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_Y14P,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 16 bit */
> +               .fourcc             = V4L2_PIX_FMT_Y16,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_Y16,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 10 bit as 16bpp */
> +               .fourcc             = V4L2_PIX_FMT_Y10,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_Y10,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 12 bit as 16bpp */
> +               .fourcc             = V4L2_PIX_FMT_Y12,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_Y12,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               /* 14 bit as 16bpp */
> +               .fourcc             = V4L2_PIX_FMT_Y14,
> +               .depth              = 16,
> +               .bytesperline_align = 32,
> +               .mmal_fmt           = MMAL_ENCODING_Y14,
> +               .size_multiplier_x2 = 2,
> +               .colorspace_mask    = V4L2_COLORSPACE_MASK_RAW,
> +               .colorspace_default = V4L2_COLORSPACE_RAW,
> +               .step_size          = 2,
> +       }, {
> +               .fourcc             = V4L2_META_FMT_BCM2835_ISP_STATS,
> +               .depth              = 8,
> +               .mmal_fmt           = MMAL_ENCODING_BRCM_STATS,
> +               /* The rest are not valid fields for stats. */
> +       }
> +};
> +
> +#endif
> diff --git a/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-params.c b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-params.c
> new file mode 100644
> index 000000000000..b133ad5c586f
> --- /dev/null
> +++ b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-isp-params.c
> @@ -0,0 +1,510 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Broadcom BCM2835 ISP driver - extensible parameters node
> + *
> + * Copyright (c) 2026 Raspberry Pi Ltd.
> + * Copyright (c) 2026 Ideas On Board Oy
> + *
> + * Author: Jai Luthra <jai.luthra@ideasonboard.com>
> + */
> +
> +#include <linux/dma-buf.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/raspberrypi/mmal-parameters.h>
> +#include <linux/raspberrypi/vc_sm_knl.h>
> +
> +#include <media/v4l2-ioctl.h>
> +#include <media/v4l2-isp.h>
> +#include <media/videobuf2-dma-contig.h>
> +
> +#include <uapi/linux/bcm2835-isp.h>
> +
> +#include "bcm2835-isp-common.h"
> +
> +MODULE_IMPORT_NS("DMA_BUF");
> +
> +#define BCM2835_ISP_PARAMS_NAME "bcm2835-isp-params"
> +
> +#define BCM2835_ISP_PARAMS_BUF_SIZE \
> +       v4l2_isp_buffer_size(BCM2835_ISP_PARAMS_MAX_SIZE)
> +
> +/**
> + * union bcm2835_isp_params_block - Generalisation of a parameter block
> + *
> + * @header:    Block header pointer for type checking
> + * @black_level: Black level configuration block
> + * @geq:       Green equalisation configuration block
> + * @gamma:     Gamma curve configuration block
> + * @denoise:   Denoise configuration block
> + * @sharpen:   Sharpen configuration block
> + * @dpc:       Defective pixel correction configuration block
> + * @cdn:       Colour denoise configuration block
> + * @ccm:       Colour correction matrix configuration block
> + * @ls:                Lens shading configuration block
> + * @awb_gains: AWB gains configuration block
> + * @digital_gain: Digital gain configuration block
> + * @data:      Raw pointer for block iteration
> + */
> +union bcm2835_isp_params_block {
> +       const struct v4l2_isp_params_block_header *header;
> +       const struct bcm2835_isp_params_black_level *black_level;
> +       const struct bcm2835_isp_params_geq *geq;
> +       const struct bcm2835_isp_params_gamma *gamma;
> +       const struct bcm2835_isp_params_denoise *denoise;
> +       const struct bcm2835_isp_params_sharpen *sharpen;
> +       const struct bcm2835_isp_params_dpc *dpc;
> +       const struct bcm2835_isp_params_cdn *cdn;
> +       const struct bcm2835_isp_params_cc_matrix *ccm;
> +       const struct bcm2835_isp_params_lens_shading *ls;
> +       const struct bcm2835_isp_params_awb_gains *awb_gains;
> +       const struct bcm2835_isp_params_digital_gain *digital_gain;
> +       const __u8 *data;
> +};
> +
> +typedef void (*bcm2835_isp_params_handler)(struct mmal_parameter_isp_parameters *mmal_param,
> +                                          struct bcm2835_isp_params *params,
> +                                          union bcm2835_isp_params_block block);
> +
> +struct bcm2835_isp_params_buffer {
> +       struct vb2_v4l2_buffer vb;
> +       struct list_head list;
> +       void *config;
> +};
> +
> +#define to_bcm2835_isp_params_buf(vbuf) \
> +       container_of(vbuf, struct bcm2835_isp_params_buffer, vb)
> +
> +static int isp_set_param(struct bcm2835_isp_params *params, u32 parameter,
> +                        void *value, u32 value_size)
> +{
> +       return vchiq_mmal_port_parameter_set(params->mmal_instance, params->port,
> +                                            parameter, value, value_size);
> +}
> +
> +static int map_ls_table(struct bcm2835_isp_params *params,
> +                       struct dma_buf *dmabuf, u32 *mem_handle_table)
> +{
> +       void *vcsm_handle;
> +       int ret;
> +
> +       if (IS_ERR_OR_NULL(dmabuf))
> +               return -EINVAL;
> +
> +       ret = vc_sm_cma_import_dmabuf(dmabuf, &vcsm_handle);
> +       if (ret)
> +               return ret;
> +
> +       *mem_handle_table = vc_sm_cma_int_handle(vcsm_handle);
> +
> +       vc_sm_cma_free(vcsm_handle);
> +
> +       params->last_ls_dmabuf = dmabuf;
> +
> +       return 0;
> +}
> +
> +/* Block handlers */
> +
> +#define BCM2835_ISP_PARAMS_HANDLER(_name, _param_field, _mmal_substruct)       \
> +static void bcm2835_isp_params_##_name(struct mmal_parameter_isp_parameters *mmal_param, \
> +                                      struct bcm2835_isp_params *params,       \
> +                                      union bcm2835_isp_params_block block)    \
> +{                                                                              \
> +       memcpy(&mmal_param->_mmal_substruct.payload,                            \
> +                     (void *)&block._param_field->_param_field,                \
> +                     sizeof(block._param_field->_param_field));                \
> +       mmal_param->_mmal_substruct.update = 1;                                 \
> +}
> +
> +BCM2835_ISP_PARAMS_HANDLER(black_level, black_level, black_level)
> +BCM2835_ISP_PARAMS_HANDLER(geq, geq, green_eq)
> +BCM2835_ISP_PARAMS_HANDLER(gamma, gamma, gamma)
> +BCM2835_ISP_PARAMS_HANDLER(denoise, denoise, denoise)
> +BCM2835_ISP_PARAMS_HANDLER(sharpen, sharpen, sharpen)
> +BCM2835_ISP_PARAMS_HANDLER(dpc, dpc, dpc)
> +BCM2835_ISP_PARAMS_HANDLER(cdn, cdn, colour_denoise)
> +BCM2835_ISP_PARAMS_HANDLER(cc_matrix, ccm, ccm)
> +BCM2835_ISP_PARAMS_HANDLER(awb_gains, awb_gains, awb_gains)
> +BCM2835_ISP_PARAMS_HANDLER(digital_gain, digital_gain, digital_gain)
> +
> +static void bcm2835_isp_params_lens_shading(struct mmal_parameter_isp_parameters *mmal_param,
> +                                           struct bcm2835_isp_params *params,
> +                                           union bcm2835_isp_params_block block)
> +{
> +       struct dma_buf *dmabuf = dma_buf_get(block.ls->ls.dmabuf);
> +       u32 prev_handle;
> +       int ret = 0;
> +
> +       /*
> +        * struct bcm2835_isp_lens_shading layout matches with what MMAL
> +        * expects, so we can do a simple memcpy here. The descriptor for
> +        * the table needs special handling though.
> +        */
> +       prev_handle = mmal_param->lens_shading.mem_handle_table;
> +       memcpy(&mmal_param->lens_shading.enabled, &block.ls->ls,
> +              sizeof(block.ls->ls));
> +
> +       /*
> +        * Map the DMABUF from userspace to a VCSM CMA handle that the firmware
> +        * can import, reusing the old handle if DMABUF was unchanged.
> +        */
> +       if (dmabuf != params->last_ls_dmabuf)
> +               ret = map_ls_table(params, dmabuf,
> +                                  &mmal_param->lens_shading.mem_handle_table);
> +       else
> +               mmal_param->lens_shading.mem_handle_table = prev_handle;
> +
> +       if (!ret && mmal_param->lens_shading.mem_handle_table)
> +               mmal_param->lens_shading.update = 1;
> +
> +       dma_buf_put(dmabuf);
> +}
> +
> +static const bcm2835_isp_params_handler bcm2835_isp_params_handlers[] = {
> +       [BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL] = bcm2835_isp_params_black_level,
> +       [BCM2835_ISP_PARAM_BLOCK_GEQ] = bcm2835_isp_params_geq,
> +       [BCM2835_ISP_PARAM_BLOCK_GAMMA] = bcm2835_isp_params_gamma,
> +       [BCM2835_ISP_PARAM_BLOCK_DENOISE] = bcm2835_isp_params_denoise,
> +       [BCM2835_ISP_PARAM_BLOCK_SHARPEN] = bcm2835_isp_params_sharpen,
> +       [BCM2835_ISP_PARAM_BLOCK_DPC] = bcm2835_isp_params_dpc,
> +       [BCM2835_ISP_PARAM_BLOCK_CDN] = bcm2835_isp_params_cdn,
> +       [BCM2835_ISP_PARAM_BLOCK_CC_MATRIX] = bcm2835_isp_params_cc_matrix,
> +       [BCM2835_ISP_PARAM_BLOCK_LENS_SHADING] = bcm2835_isp_params_lens_shading,
> +       [BCM2835_ISP_PARAM_BLOCK_AWB_GAINS] = bcm2835_isp_params_awb_gains,
> +       [BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN] = bcm2835_isp_params_digital_gain,
> +};
> +
> +static const struct v4l2_isp_params_block_type_info
> +bcm2835_isp_params_block_types_info[] = {
> +       [BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL] = {
> +               .size = sizeof(struct bcm2835_isp_params_black_level),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_GEQ] = {
> +               .size = sizeof(struct bcm2835_isp_params_geq),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_GAMMA] = {
> +               .size = sizeof(struct bcm2835_isp_params_gamma),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_DENOISE] = {
> +               .size = sizeof(struct bcm2835_isp_params_denoise),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_SHARPEN] = {
> +               .size = sizeof(struct bcm2835_isp_params_sharpen),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_DPC] = {
> +               .size = sizeof(struct bcm2835_isp_params_dpc),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_CDN] = {
> +               .size = sizeof(struct bcm2835_isp_params_cdn),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_CC_MATRIX] = {
> +               .size = sizeof(struct bcm2835_isp_params_cc_matrix),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_LENS_SHADING] = {
> +               .size = sizeof(struct bcm2835_isp_params_lens_shading),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_AWB_GAINS] = {
> +               .size = sizeof(struct bcm2835_isp_params_awb_gains),
> +       },
> +       [BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN] = {
> +               .size = sizeof(struct bcm2835_isp_params_digital_gain),
> +       },
> +};
> +
> +static_assert(ARRAY_SIZE(bcm2835_isp_params_handlers) ==
> +             ARRAY_SIZE(bcm2835_isp_params_block_types_info));
> +
> +static void bcm2835_isp_params_apply(struct bcm2835_isp_params *params,
> +                                    struct bcm2835_isp_params_buffer *buf)
> +{
> +       const struct v4l2_isp_params_buffer *config = buf->config;
> +       size_t block_offset = 0;
> +       size_t max_offset = config->data_size;
> +       struct mmal_parameter_isp_parameters mmal_param = { 0 };
> +       int ret;
> +
> +       while (block_offset < max_offset) {
> +               union bcm2835_isp_params_block block;
> +               bcm2835_isp_params_handler handler;
> +
> +               block.data = &config->data[block_offset];
> +               handler = bcm2835_isp_params_handlers[block.header->type];
> +               handler(&mmal_param, params, block);
> +
> +               block_offset += block.header->size;
> +       }
> +
> +       ret = isp_set_param(params, MMAL_PARAMETER_ISP_SETTINGS, &mmal_param,
> +                           sizeof(mmal_param));
> +
> +       if (ret) {
> +               dev_err(params->dev,
> +                       "%s: MMAL_PARAMETER_ISP_SETTINGS failed with err %d\n",
> +                       __func__, ret);
> +               vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
> +               return;
> +       }
> +
> +       vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_DONE);
> +}
> +
> +/* vb2 operations */
> +
> +static int bcm2835_isp_params_queue_setup(struct vb2_queue *q,
> +                                         unsigned int *num_buffers,
> +                                         unsigned int *num_planes,
> +                                         unsigned int sizes[],
> +                                         struct device *alloc_devs[])
> +{
> +       if (*num_planes && *num_planes > 1)
> +               return -EINVAL;
> +
> +       if (sizes[0] && sizes[0] < BCM2835_ISP_PARAMS_BUF_SIZE)
> +               return -EINVAL;
> +
> +       *num_planes = 1;
> +
> +       if (!sizes[0])
> +               sizes[0] = BCM2835_ISP_PARAMS_BUF_SIZE;
> +
> +       return 0;
> +}
> +
> +static int bcm2835_isp_params_buf_init(struct vb2_buffer *vb)
> +{
> +       struct bcm2835_isp_params_buffer *buf =
> +               to_bcm2835_isp_params_buf(to_vb2_v4l2_buffer(vb));
> +
> +       buf->config = kvmalloc(BCM2835_ISP_PARAMS_BUF_SIZE, GFP_KERNEL);
> +       if (!buf->config)
> +               return -ENOMEM;
> +
> +       return 0;
> +}
> +
> +static void bcm2835_isp_params_buf_cleanup(struct vb2_buffer *vb)
> +{
> +       struct bcm2835_isp_params_buffer *buf =
> +               to_bcm2835_isp_params_buf(to_vb2_v4l2_buffer(vb));
> +
> +       kvfree(buf->config);
> +       buf->config = NULL;
> +}
> +
> +static int bcm2835_isp_params_buf_prepare(struct vb2_buffer *vb)
> +{
> +       struct bcm2835_isp_params *params = vb2_get_drv_priv(vb->vb2_queue);
> +       struct bcm2835_isp_params_buffer *buf =
> +               to_bcm2835_isp_params_buf(to_vb2_v4l2_buffer(vb));
> +       const struct v4l2_isp_params_buffer *config;
> +       int ret;
> +
> +       ret = v4l2_isp_params_validate_buffer_size(params->dev, vb,
> +                                                  BCM2835_ISP_PARAMS_BUF_SIZE);
> +       if (ret)
> +               return ret;
> +
> +       config = vb2_plane_vaddr(vb, 0);
> +       if (config->version != BCM2835_ISP_PARAM_BUFFER_V1)
> +               return -EINVAL;
> +
> +       /* Copy into scratch buffer */
> +       memcpy(buf->config, config, BCM2835_ISP_PARAMS_BUF_SIZE);
> +
> +       return v4l2_isp_params_validate_buffer(params->dev, vb, buf->config,
> +                                              bcm2835_isp_params_block_types_info,
> +                                              ARRAY_SIZE(bcm2835_isp_params_block_types_info));
> +}
> +
> +static void bcm2835_isp_params_buf_queue(struct vb2_buffer *vb)
> +{
> +       struct bcm2835_isp_params *params = vb2_get_drv_priv(vb->vb2_queue);
> +       struct bcm2835_isp_params_buffer *buf =
> +               to_bcm2835_isp_params_buf(to_vb2_v4l2_buffer(vb));
> +
> +       /*
> +        * Apply params immediately - the firmware will apply them on the
> +        * next frame boundary.
> +        */
> +       bcm2835_isp_params_apply(params, buf);
> +}
> +
> +static const struct vb2_ops bcm2835_isp_params_vb2_ops = {
> +       .queue_setup = bcm2835_isp_params_queue_setup,
> +       .buf_init = bcm2835_isp_params_buf_init,
> +       .buf_cleanup = bcm2835_isp_params_buf_cleanup,
> +       .buf_prepare = bcm2835_isp_params_buf_prepare,
> +       .buf_queue = bcm2835_isp_params_buf_queue,
> +};
> +
> +/* V4L2 ioctls */
> +
> +static int bcm2835_isp_params_enum_fmt(struct file *file, void *fh,
> +                                      struct v4l2_fmtdesc *f)
> +{
> +       if (f->index)
> +               return -EINVAL;
> +
> +       f->pixelformat = V4L2_META_FMT_BCM2835_ISP_PARAMS;
> +
> +       return 0;
> +}
> +
> +static int bcm2835_isp_params_g_fmt(struct file *file, void *fh,
> +                                   struct v4l2_format *f)
> +{
> +       f->fmt.meta.dataformat = V4L2_META_FMT_BCM2835_ISP_PARAMS;
> +       f->fmt.meta.buffersize = BCM2835_ISP_PARAMS_BUF_SIZE;
> +
> +       return 0;
> +}
> +
> +static const struct v4l2_ioctl_ops bcm2835_isp_params_ioctl_ops = {
> +       .vidioc_querycap = bcm2835_isp_node_querycap,
> +       .vidioc_enum_fmt_meta_out = bcm2835_isp_params_enum_fmt,
> +       .vidioc_g_fmt_meta_out = bcm2835_isp_params_g_fmt,
> +       .vidioc_s_fmt_meta_out = bcm2835_isp_params_g_fmt,
> +       .vidioc_try_fmt_meta_out = bcm2835_isp_params_g_fmt,
> +
> +       .vidioc_reqbufs = vb2_ioctl_reqbufs,
> +       .vidioc_querybuf = vb2_ioctl_querybuf,
> +       .vidioc_qbuf = vb2_ioctl_qbuf,
> +       .vidioc_dqbuf = vb2_ioctl_dqbuf,
> +       .vidioc_expbuf = vb2_ioctl_expbuf,
> +       .vidioc_create_bufs = vb2_ioctl_create_bufs,
> +       .vidioc_prepare_buf = vb2_ioctl_prepare_buf,
> +
> +       .vidioc_streamon = vb2_ioctl_streamon,
> +       .vidioc_streamoff = vb2_ioctl_streamoff,
> +};
> +
> +static const struct v4l2_file_operations bcm2835_isp_params_fops = {
> +       .owner = THIS_MODULE,
> +       .open = v4l2_fh_open,
> +       .release = vb2_fop_release,
> +       .poll = vb2_fop_poll,
> +       .unlocked_ioctl = video_ioctl2,
> +       .mmap = vb2_fop_mmap,
> +};
> +
> +struct bcm2835_isp_params *
> +bcm2835_isp_params_register(struct v4l2_device *v4l2_dev, struct device *dev,
> +                           struct vchiq_mmal_instance *mmal_instance,
> +                           struct vchiq_mmal_port *port, int video_nr)
> +{
> +       struct mmal_parameter_isp_parameters mmal_param = { 0 };
> +       struct bcm2835_isp_params *params;
> +       struct video_device *vdev;
> +       struct vb2_queue *q;
> +       int ret;
> +
> +       params = devm_kzalloc(dev, sizeof(*params), GFP_KERNEL);
> +       if (!params)
> +               return ERR_PTR(-ENOMEM);
> +
> +       params->dev = dev;
> +       params->v4l2_dev = v4l2_dev;
> +       params->mmal_instance = mmal_instance;
> +       params->port = port;
> +
> +       /* Test if the firmware supports a combined parameter buffer */
> +       ret = vchiq_mmal_port_parameter_set(params->mmal_instance,
> +                                           params->port,
> +                                           MMAL_PARAMETER_ISP_SETTINGS,
> +                                           &mmal_param, sizeof(mmal_param));
> +       if (ret) {
> +               dev_err(dev, "Please update to the latest firmware\n"
> +                       "\tMMAL_PARAMETER_ISP_SETTINGS failed with err %d\n",
> +                       ret);
> +               return ERR_PTR(-EINVAL);
> +       }
> +
> +       mutex_init(&params->lock);
> +
> +       /* Initialize vb2 queue */
> +       q = &params->queue;
> +       q->type = V4L2_BUF_TYPE_META_OUTPUT;
> +       q->io_modes = VB2_MMAP | VB2_DMABUF;
> +       q->drv_priv = params;
> +       q->ops = &bcm2835_isp_params_vb2_ops;
> +       q->mem_ops = &vb2_dma_contig_memops;
> +       q->buf_struct_size = sizeof(struct bcm2835_isp_params_buffer);
> +       q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
> +       q->dev = dev;
> +       q->lock = &params->lock;
> +
> +       ret = vb2_queue_init(q);
> +       if (ret) {
> +               dev_err(dev, "Failed to init params vb2 queue\n");
> +               mutex_destroy(&params->lock);
> +               return ERR_PTR(ret);
> +       }
> +
> +       /* Initialize video device */
> +       vdev = &params->vdev;
> +       vdev->device_caps = V4L2_CAP_META_OUTPUT | V4L2_CAP_STREAMING;
> +       vdev->fops = &bcm2835_isp_params_fops;
> +       vdev->ioctl_ops = &bcm2835_isp_params_ioctl_ops;
> +       vdev->minor = -1;
> +       vdev->release = video_device_release_empty;
> +       vdev->queue = q;
> +       vdev->lock = &params->lock;
> +       vdev->v4l2_dev = v4l2_dev;
> +       vdev->vfl_dir = VFL_DIR_TX;
> +       snprintf(vdev->name, sizeof(vdev->name), "%s", BCM2835_ISP_PARAMS_NAME);
> +
> +       params->pad.flags = MEDIA_PAD_FL_SOURCE;
> +       ret = media_entity_pads_init(&vdev->entity, 1, &params->pad);
> +       if (ret) {
> +               vb2_queue_release(q);
> +               mutex_destroy(&params->lock);
> +               return ERR_PTR(ret);
> +       }
> +
> +       video_set_drvdata(vdev, params);
> +
> +       ret = video_register_device(vdev, VFL_TYPE_VIDEO, video_nr);
> +       if (ret) {
> +               dev_err(dev, "Failed to register params device node\n");
> +               media_entity_cleanup(&vdev->entity);
> +               vb2_queue_release(q);
> +               mutex_destroy(&params->lock);
> +               return ERR_PTR(ret);
> +       }
> +
> +       v4l2_info(v4l2_dev, "Params device node registered as /dev/video%d\n",
> +                 vdev->num);
> +
> +       return params;
> +}
> +
> +void bcm2835_isp_params_unregister(struct bcm2835_isp_params *params)
> +{
> +       if (!video_is_registered(&params->vdev))
> +               return;
> +
> +       v4l2_info(params->v4l2_dev, "Unregistering params device node\n");
> +
> +       vb2_video_unregister_device(&params->vdev);
> +       media_entity_cleanup(&params->vdev.entity);
> +       mutex_destroy(&params->lock);
> +}
> +
> +/*
> + * The ISP component on the firmware has a reference to the dmabuf handle for
> + * the lens shading table.
> + * Pass a null handle to remove that reference.
> + */
> +int bcm2835_isp_params_drop_ls_ref(struct bcm2835_isp_params *params)
> +{
> +       struct bcm2835_isp_lens_shading ls = {
> +               /* Must set a valid grid size for the FW */
> +               .grid_cell_size = 16,
> +       };
> +
> +       params->last_ls_dmabuf = NULL;
> +
> +       return isp_set_param(params, MMAL_PARAMETER_LENS_SHADING_OVERRIDE, &ls,
> +                            sizeof(ls));
> +}
> diff --git a/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-v4l2-isp.c b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-v4l2-isp.c
> new file mode 100644
> index 000000000000..729ab05d8154
> --- /dev/null
> +++ b/drivers/media/platform/broadcom/bcm2835-isp/bcm2835-v4l2-isp.c
> @@ -0,0 +1,1516 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Broadcom BCM2835 ISP driver
> + *
> + * Copyright (c) 2019-2026 Raspberry Pi (Trading) Ltd.
> + * Copyright (c) 2026 Ideas On Board Oy
> + *
> + * Author: Naushir Patuck (naush@raspberrypi.com)
> + *
> + */
> +
> +#include <linux/err.h>
> +#include <linux/module.h>
> +#include <linux/raspberrypi/mmal-msg.h>
> +#include <linux/raspberrypi/mmal-parameters.h>
> +#include <linux/raspberrypi/mmal-vchiq.h>
> +#include <linux/raspberrypi/vchiq_bus.h>
> +
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-ioctl.h>
> +#include <media/videobuf2-dma-contig.h>
> +
> +#include "bcm2835-isp-fmts.h"
> +#include "bcm2835-isp-common.h"
> +
> +/*
> + * There is no standard API today for multiplexing ISP instances, so we hardcode
> + * the number of instances to 1 here. The firmware backend can work with more.
> + */
> +#define BCM2835_ISP_NUM_INSTANCES 1
> +
> +MODULE_IMPORT_NS("DMA_BUF");
> +
> +static unsigned int debug;
> +module_param(debug, uint, 0644);
> +MODULE_PARM_DESC(debug, "activates debug info");
> +
> +static unsigned int video_nr[BCM2835_ISP_NUM_INSTANCES] = { 13 };
> +module_param_array(video_nr, uint, NULL, 0644);
> +MODULE_PARM_DESC(video_nr, "base video device numbers");
> +
> +#define BCM2835_ISP_NAME "bcm2835-isp"
> +#define BCM2835_ISP_ENTITY_NAME_LEN 32
> +
> +#define BCM2835_ISP_NUM_OUTPUTS 1
> +#define BCM2835_ISP_NUM_CAPTURES 2
> +#define BCM2835_ISP_NUM_METADATA 1
> +#define BCM2835_ISP_NUM_PARAMS 1
> +
> +#define BCM2835_ISP_NUM_NODES                                          \
> +               (BCM2835_ISP_NUM_OUTPUTS + BCM2835_ISP_NUM_CAPTURES +   \
> +                BCM2835_ISP_NUM_METADATA)
> +#define BCM2835_ISP_PARAMS_PAD BCM2835_ISP_NUM_NODES
> +#define BCM2835_ISP_NUM_ENTITY_PADS                                    \
> +               (BCM2835_ISP_NUM_NODES + BCM2835_ISP_NUM_PARAMS)
> +
> +/* Default frame dimension of 1280 pixels. */
> +#define DEFAULT_DIM 1280U
> +/*
> + * Maximum frame dimension of 16384 pixels.  Even though the ISP runs in tiles,
> + * have a sensible limit so that we do not create an excessive number of tiles
> + * to process.
> + */
> +#define MAX_DIM 16384U
> +/*
> + * Minimum frame dimension of 64 pixels.  Anything lower, and the tiling
> + * algorithm may not be able to cope when applying filter context.
> + */
> +#define MIN_DIM 64U
> +
> +/* Timeout for stop_streaming to allow all buffers to return */
> +#define COMPLETE_TIMEOUT (2 * HZ)
> +
> +/* Per-queue, driver-specific private data */
> +struct bcm2835_isp_q_data {
> +       /*
> +        * These parameters should be treated as gospel, with everything else
> +        * being determined from them.
> +        */
> +       unsigned int bytesperline;
> +       unsigned int width;
> +       unsigned int height;
> +       unsigned int sizeimage;
> +       enum v4l2_colorspace colorspace;
> +       enum v4l2_ycbcr_encoding ycbcr_enc;
> +       enum v4l2_xfer_func xfer_func;
> +       enum v4l2_quantization quantization;
> +       const struct bcm2835_isp_fmt *fmt;
> +};
> +
> +/*
> + * Structure to describe a single node /dev/video<N> which represents a single
> + * input or output queue to the ISP device.
> + */
> +struct bcm2835_isp_node {
> +       int vfl_dir;
> +       unsigned int id;
> +       const char *name;
> +       struct vchiq_mmal_port *port;
> +       struct video_device vfd;
> +       struct media_pad pad;
> +       struct mutex lock; /* top level device node lock */
> +       struct mutex queue_lock;
> +
> +       struct vb2_queue queue;
> +       unsigned int sequence;
> +
> +       /* The list of formats supported on the node. */
> +       struct bcm2835_isp_fmt const **supported_fmts;
> +       unsigned int num_supported_fmts;
> +
> +       struct bcm2835_isp_q_data q_data;
> +
> +       /* Parent device structure */
> +       struct bcm2835_isp_dev *dev;
> +
> +       bool registered;
> +};
> +
> +/*
> + * Structure representing the entire ISP device, comprising several input and
> + * output nodes /dev/video<N>.
> + */
> +struct bcm2835_isp_dev {
> +       struct v4l2_device v4l2_dev;
> +       struct device *dev;
> +       struct media_device mdev;
> +       struct media_entity entity;
> +       bool media_device_registered;
> +       bool media_entity_registered;
> +       struct vchiq_mmal_instance *mmal_instance;
> +       struct vchiq_mmal_component *component;
> +       struct completion frame_cmplt;
> +
> +       struct bcm2835_isp_node node[BCM2835_ISP_NUM_NODES];
> +       struct media_pad pad[BCM2835_ISP_NUM_ENTITY_PADS];
> +       atomic_t num_streaming;
> +
> +       /* Extensible params node */
> +       struct bcm2835_isp_params *params;
> +};
> +
> +struct bcm2835_isp_buffer {
> +       struct vb2_v4l2_buffer vb;
> +       struct mmal_buffer mmal;
> +};
> +
> +#define to_bcm2835_isp_buffer(vbuf) \
> +       container_of(vbuf, struct bcm2835_isp_buffer, vb)
> +
> +static
> +inline struct bcm2835_isp_dev *node_get_dev(struct bcm2835_isp_node *node)
> +{
> +       return node->dev;
> +}
> +
> +static inline bool node_is_output(struct bcm2835_isp_node *node)
> +{
> +       return node->queue.type == V4L2_BUF_TYPE_VIDEO_OUTPUT;
> +}
> +
> +static inline bool node_is_capture(struct bcm2835_isp_node *node)
> +{
> +       return node->queue.type == V4L2_BUF_TYPE_VIDEO_CAPTURE;
> +}
> +
> +static inline bool node_is_stats(struct bcm2835_isp_node *node)
> +{
> +       return node->queue.type == V4L2_BUF_TYPE_META_CAPTURE;
> +}
> +
> +static inline enum v4l2_buf_type index_to_queue_type(int index)
> +{
> +       if (index < BCM2835_ISP_NUM_OUTPUTS)
> +               return V4L2_BUF_TYPE_VIDEO_OUTPUT;
> +       else if (index < BCM2835_ISP_NUM_OUTPUTS + BCM2835_ISP_NUM_CAPTURES)
> +               return V4L2_BUF_TYPE_VIDEO_CAPTURE;
> +       else
> +               return V4L2_BUF_TYPE_META_CAPTURE;
> +}
> +
> +static const struct bcm2835_isp_fmt *get_fmt(u32 mmal_fmt)
> +{
> +       unsigned int i;
> +
> +       for (i = 0; i < ARRAY_SIZE(supported_formats); i++) {
> +               if (supported_formats[i].mmal_fmt == mmal_fmt)
> +                       return &supported_formats[i];
> +       }
> +       return NULL;
> +}
> +
> +static const
> +struct bcm2835_isp_fmt *find_format_by_fourcc(unsigned int fourcc,
> +                                             struct bcm2835_isp_node *node)
> +{
> +       const struct bcm2835_isp_fmt *fmt;
> +       unsigned int i;
> +
> +       for (i = 0; i < node->num_supported_fmts; i++) {
> +               fmt = node->supported_fmts[i];
> +               if (fmt->fourcc == fourcc)
> +                       return fmt;
> +       }
> +
> +       return NULL;
> +}
> +
> +static const
> +struct bcm2835_isp_fmt *find_format(struct v4l2_format *f,
> +                                   struct bcm2835_isp_node *node)
> +{
> +       return find_format_by_fourcc(node_is_stats(node) ?
> +                                    f->fmt.meta.dataformat :
> +                                    f->fmt.pix.pixelformat,
> +                                    node);
> +}
> +
> +/* vb2_to_mmal_buffer() - converts vb2 buffer header to MMAL
> + *
> + * Copies all the required fields from a VB2 buffer to the MMAL buffer header,
> + * ready for sending to the VPU.
> + */
> +static void vb2_to_mmal_buffer(struct mmal_buffer *buf,
> +                              struct vb2_v4l2_buffer *vb2)
> +{
> +       u64 pts;
> +
> +       buf->mmal_flags = 0;
> +       if (vb2->flags & V4L2_BUF_FLAG_KEYFRAME)
> +               buf->mmal_flags |= MMAL_BUFFER_HEADER_FLAG_KEYFRAME;
> +
> +       /* Data must be framed correctly as one frame per buffer. */
> +       buf->mmal_flags |= MMAL_BUFFER_HEADER_FLAG_FRAME_END;
> +
> +       buf->length = vb2->vb2_buf.planes[0].bytesused;
> +       /*
> +        * Minor ambiguity in the V4L2 spec as to whether passing in a 0 length
> +        * buffer, or one with V4L2_BUF_FLAG_LAST set denotes end of stream.
> +        * Handle either.
> +        */
> +       if (!buf->length || (vb2->flags & V4L2_BUF_FLAG_LAST))
> +               buf->mmal_flags |= MMAL_BUFFER_HEADER_FLAG_EOS;
> +
> +       /* vb2 timestamps in nsecs, mmal in usecs */
> +       pts = vb2->vb2_buf.timestamp;
> +       do_div(pts, 1000);
> +       buf->pts = pts;
> +       buf->dts = MMAL_TIME_UNKNOWN;
> +}
> +
> +static void mmal_buffer_cb(struct vchiq_mmal_instance *instance,
> +                          struct vchiq_mmal_port *port, int status,
> +                          struct mmal_buffer *mmal_buf)
> +{
> +       struct bcm2835_isp_buffer *q_buf;
> +       struct bcm2835_isp_node *node = port->cb_ctx;
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       struct vb2_v4l2_buffer *vb2;
> +
> +       q_buf = container_of(mmal_buf, struct bcm2835_isp_buffer, mmal);
> +       vb2 = &q_buf->vb;
> +       v4l2_dbg(2, debug, &dev->v4l2_dev,
> +                "%s: port:%s[%d], status:%d, buf:%p, dmabuf:%p, length:%lu, flags %u, pts %lld\n",
> +                __func__, node_is_output(node) ? "input" : "output", node->id,
> +                status, mmal_buf, mmal_buf->dma_buf, mmal_buf->length,
> +                mmal_buf->mmal_flags, mmal_buf->pts);
> +
> +       if (status) {
> +               /* error in transfer */
> +               if (vb2) {
> +                       /* there was a buffer with the error so return it */
> +                       vb2_buffer_done(&vb2->vb2_buf, VB2_BUF_STATE_ERROR);
> +               }
> +               return;
> +       }
> +
> +       /* vb2 timestamps in nsecs, mmal in usecs */
> +       vb2->vb2_buf.timestamp = mmal_buf->pts * 1000;
> +       vb2->sequence = node->sequence++;
> +       vb2_set_plane_payload(&vb2->vb2_buf, 0, mmal_buf->length);
> +       vb2_buffer_done(&vb2->vb2_buf, VB2_BUF_STATE_DONE);
> +
> +       if (!port->enabled)
> +               complete(&dev->frame_cmplt);
> +}
> +
> +struct colorspace_translation {
> +       enum v4l2_colorspace v4l2_value;
> +       u32 mmal_value;
> +};
> +
> +static u32 translate_color_space(enum v4l2_colorspace color_space)
> +{
> +       static const struct colorspace_translation translations[] = {
> +               { V4L2_COLORSPACE_DEFAULT, MMAL_COLOR_SPACE_UNKNOWN },
> +               { V4L2_COLORSPACE_SMPTE170M, MMAL_COLOR_SPACE_ITUR_BT601 },
> +               { V4L2_COLORSPACE_SMPTE240M, MMAL_COLOR_SPACE_SMPTE240M },
> +               { V4L2_COLORSPACE_REC709, MMAL_COLOR_SPACE_ITUR_BT709 },
> +               /* V4L2_COLORSPACE_BT878 unavailable */
> +               { V4L2_COLORSPACE_470_SYSTEM_M, MMAL_COLOR_SPACE_BT470_2_M },
> +               { V4L2_COLORSPACE_470_SYSTEM_BG, MMAL_COLOR_SPACE_BT470_2_BG },
> +               { V4L2_COLORSPACE_JPEG, MMAL_COLOR_SPACE_JPEG_JFIF },
> +               /*
> +                * We don't have an encoding for SRGB as such, but VideoCore
> +                * will do the right thing if it gets "unknown".
> +                */
> +               { V4L2_COLORSPACE_SRGB, MMAL_COLOR_SPACE_UNKNOWN },
> +               /* V4L2_COLORSPACE_OPRGB unavailable */
> +               /* V4L2_COLORSPACE_BT2020 unavailable */
> +               /* V4L2_COLORSPACE_RAW unavailable */
> +               /* V4L2_COLORSPACE_DCI_P3 unavailable */
> +       };
> +
> +       unsigned int i;
> +
> +       for (i = 0; i < ARRAY_SIZE(translations); i++) {
> +               if (color_space == translations[i].v4l2_value)
> +                       return translations[i].mmal_value;
> +       }
> +
> +       return MMAL_COLOR_SPACE_UNKNOWN;
> +}
> +
> +static void setup_mmal_port_format(struct bcm2835_isp_node *node,
> +                                  struct vchiq_mmal_port *port)
> +{
> +       struct bcm2835_isp_q_data *q_data = &node->q_data;
> +
> +       port->format.encoding = q_data->fmt->mmal_fmt;
> +       /* Raw image format - set width/height */
> +       port->es.video.width = (q_data->bytesperline << 3) / q_data->fmt->depth;
> +       port->es.video.height = q_data->height;
> +       port->es.video.crop.width = q_data->width;
> +       port->es.video.crop.height = q_data->height;
> +       port->es.video.crop.x = 0;
> +       port->es.video.crop.y = 0;
> +       port->es.video.color_space = translate_color_space(q_data->colorspace);
> +};
> +
> +static int setup_mmal_port(struct bcm2835_isp_node *node)
> +{
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       unsigned int enable = 1;
> +       int ret;
> +
> +       v4l2_dbg(2, debug, &dev->v4l2_dev, "%s: setup %s[%d]\n", __func__,
> +                node->name, node->id);
> +
> +       vchiq_mmal_port_parameter_set(dev->mmal_instance, node->port,
> +                                     MMAL_PARAMETER_ZERO_COPY, &enable,
> +                                     sizeof(enable));
> +       setup_mmal_port_format(node, node->port);
> +       ret = vchiq_mmal_port_set_format(dev->mmal_instance, node->port);
> +       if (ret < 0) {
> +               v4l2_dbg(1, debug, &dev->v4l2_dev,
> +                        "%s: vchiq_mmal_port_set_format failed\n",
> +                        __func__);
> +               return ret;
> +       }
> +
> +       if (node->q_data.sizeimage < node->port->minimum_buffer.size) {
> +               v4l2_err(&dev->v4l2_dev,
> +                        "buffer size mismatch sizeimage %u < min size %u\n",
> +                        node->q_data.sizeimage,
> +                        node->port->minimum_buffer.size);
> +               return -EINVAL;
> +       }
> +
> +       return 0;
> +}
> +
> +static int bcm2835_isp_mmal_buf_cleanup(struct mmal_buffer *mmal_buf)
> +{
> +       mmal_vchi_buffer_cleanup(mmal_buf);
> +
> +       if (mmal_buf->dma_buf) {
> +               dma_buf_put(mmal_buf->dma_buf);
> +               mmal_buf->dma_buf = NULL;
> +       }
> +
> +       return 0;
> +}
> +
> +static int bcm2835_isp_node_queue_setup(struct vb2_queue *q,
> +                                       unsigned int *nbuffers,
> +                                       unsigned int *nplanes,
> +                                       unsigned int sizes[],
> +                                       struct device *alloc_devs[])
> +{
> +       struct bcm2835_isp_node *node = vb2_get_drv_priv(q);
> +       unsigned int size;
> +
> +       if (setup_mmal_port(node))
> +               return -EINVAL;
> +
> +       size = node->q_data.sizeimage;
> +       if (size == 0) {
> +               v4l2_info(&node_get_dev(node)->v4l2_dev,
> +                         "%s: Image size unset in queue_setup for node %s[%d]\n",
> +                         __func__, node->name, node->id);
> +               return -EINVAL;
> +       }
> +
> +       if (*nplanes)
> +               return sizes[0] < size ? -EINVAL : 0;
> +
> +       *nplanes = 1;
> +       sizes[0] = size;
> +
> +       node->port->current_buffer.size = size;
> +
> +       if (*nbuffers < node->port->minimum_buffer.num)
> +               *nbuffers = node->port->minimum_buffer.num;
> +
> +       node->port->current_buffer.num = *nbuffers;
> +
> +       v4l2_dbg(2, debug, &node_get_dev(node)->v4l2_dev,
> +                "%s: Image size %u, nbuffers %u for node %s[%d]\n",
> +                __func__, sizes[0], *nbuffers, node->name, node->id);
> +       return 0;
> +}
> +
> +static int bcm2835_isp_buf_init(struct vb2_buffer *vb)
> +{
> +       struct bcm2835_isp_node *node = vb2_get_drv_priv(vb->vb2_queue);
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       struct bcm2835_isp_buffer *buf =
> +               to_bcm2835_isp_buffer(to_vb2_v4l2_buffer(vb));
> +
> +       v4l2_dbg(3, debug, &dev->v4l2_dev, "%s: vb %p\n", __func__, vb);
> +
> +       buf->mmal.buffer = vb2_plane_vaddr(&buf->vb.vb2_buf, 0);
> +       buf->mmal.buffer_size = vb2_plane_size(&buf->vb.vb2_buf, 0);
> +       mmal_vchi_buffer_init(dev->mmal_instance, &buf->mmal);
> +       return 0;
> +}
> +
> +static int bcm2835_isp_buf_prepare(struct vb2_buffer *vb)
> +{
> +       struct bcm2835_isp_node *node = vb2_get_drv_priv(vb->vb2_queue);
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       struct vb2_v4l2_buffer *vb2 = to_vb2_v4l2_buffer(vb);
> +       struct bcm2835_isp_buffer *buf = to_bcm2835_isp_buffer(vb2);
> +       struct dma_buf *dma_buf;
> +       int ret = 0;
> +
> +       v4l2_dbg(3, debug, &dev->v4l2_dev, "%s: type: %d ptr %p\n",
> +                __func__, vb->vb2_queue->type, vb);
> +
> +       if (V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type)) {
> +               if (vb2->field == V4L2_FIELD_ANY)
> +                       vb2->field = V4L2_FIELD_NONE;
> +               if (vb2->field != V4L2_FIELD_NONE) {
> +                       v4l2_err(&dev->v4l2_dev,
> +                                "%s field isn't supported\n", __func__);
> +                       return -EINVAL;
> +               }
> +       }
> +
> +       if (vb2_plane_size(vb, 0) < node->q_data.sizeimage) {
> +               v4l2_err(&dev->v4l2_dev,
> +                        "%s data will not fit into plane (%lu < %u)\n",
> +                        __func__, vb2_plane_size(vb, 0),
> +                        node->q_data.sizeimage);
> +               return -EINVAL;
> +       }
> +
> +       if (!V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type))
> +               vb2_set_plane_payload(vb, 0, node->q_data.sizeimage);
> +
> +       switch (vb->memory) {
> +       case VB2_MEMORY_DMABUF:
> +               dma_buf = dma_buf_get(vb->planes[0].m.fd);
> +
> +               if (dma_buf != buf->mmal.dma_buf) {
> +                       /*
> +                        * dmabuf either hasn't already been mapped, or it has
> +                        * changed.
> +                        */
> +                       if (buf->mmal.dma_buf) {
> +                               v4l2_err(&dev->v4l2_dev,
> +                                        "%s Buffer changed - why did the core not call cleanup?\n",
> +                                        __func__);
> +                               bcm2835_isp_mmal_buf_cleanup(&buf->mmal);
> +                       }
> +
> +                       buf->mmal.dma_buf = dma_buf;
> +               } else {
> +                       /*
> +                        * Already have a reference to the buffer, so release it
> +                        * here.
> +                        */
> +                       dma_buf_put(dma_buf);
> +               }
> +               break;
> +       case VB2_MEMORY_MMAP:
> +               /*
> +                * We want to do this at init, but vb2_core_expbuf checks that
> +                * the index < q->num_buffers, and q->num_buffers only gets
> +                * updated once all the buffers are allocated.
> +                */
> +               if (!buf->mmal.dma_buf) {
> +                       buf->mmal.dma_buf =
> +                               vb2_core_expbuf_dmabuf(vb->vb2_queue, vb, 0,
> +                                                      O_CLOEXEC);
> +                       v4l2_dbg(3, debug, &dev->v4l2_dev,
> +                                "%s: exporting ptr %p to dmabuf %p\n",
> +                                __func__, vb, buf->mmal.dma_buf);
> +
> +                       if (IS_ERR(buf->mmal.dma_buf)) {
> +                               ret = PTR_ERR(buf->mmal.dma_buf);
> +                               v4l2_err(&dev->v4l2_dev,
> +                                        "%s: Failed to expbuf idx %d, ret %d\n",
> +                                        __func__, vb->index, ret);
> +                               buf->mmal.dma_buf = NULL;
> +                       }
> +               }
> +               break;
> +       default:
> +               ret = -EINVAL;
> +               break;
> +       }
> +
> +       return ret;
> +}
> +
> +static void bcm2835_isp_node_buffer_queue(struct vb2_buffer *buf)
> +{
> +       struct bcm2835_isp_node *node = vb2_get_drv_priv(buf->vb2_queue);
> +       struct bcm2835_isp_buffer *buffer =
> +               to_bcm2835_isp_buffer(to_vb2_v4l2_buffer(buf));
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +
> +       v4l2_dbg(3, debug, &dev->v4l2_dev, "%s: node %s[%d], buffer %p\n",
> +                __func__, node->name, node->id, buffer);
> +
> +       vb2_to_mmal_buffer(&buffer->mmal, &buffer->vb);
> +       v4l2_dbg(3, debug, &dev->v4l2_dev,
> +                "%s: node %s[%d] - submitting  mmal dmabuf %p\n", __func__,
> +                node->name, node->id, buffer->mmal.dma_buf);
> +       vchiq_mmal_submit_buffer(dev->mmal_instance, node->port, &buffer->mmal);
> +}
> +
> +static void bcm2835_isp_buffer_cleanup(struct vb2_buffer *vb)
> +{
> +       struct bcm2835_isp_buffer *buffer =
> +               to_bcm2835_isp_buffer(to_vb2_v4l2_buffer(vb));
> +
> +       bcm2835_isp_mmal_buf_cleanup(&buffer->mmal);
> +}
> +
> +static int bcm2835_isp_node_start_streaming(struct vb2_queue *q,
> +                                           unsigned int count)
> +{
> +       struct bcm2835_isp_node *node = vb2_get_drv_priv(q);
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       int ret;
> +
> +       v4l2_dbg(1, debug, &dev->v4l2_dev, "%s: node %s[%d] (count %u)\n",
> +                __func__, node->name, node->id, count);
> +
> +       ret = vchiq_mmal_component_enable(dev->mmal_instance, dev->component);
> +       if (ret) {
> +               v4l2_err(&dev->v4l2_dev, "%s: Failed enabling component, ret %d\n",
> +                        __func__, ret);
> +               return -EIO;
> +       }
> +
> +       node->sequence = 0;
> +       node->port->cb_ctx = node;
> +       ret = vchiq_mmal_port_enable(dev->mmal_instance, node->port,
> +                                    mmal_buffer_cb);
> +       if (!ret)
> +               atomic_inc(&dev->num_streaming);
> +       else
> +               v4l2_err(&dev->v4l2_dev,
> +                        "%s: Failed enabling port, ret %d\n", __func__, ret);
> +
> +       return ret;
> +}
> +
> +static void bcm2835_isp_node_stop_streaming(struct vb2_queue *q)
> +{
> +       struct bcm2835_isp_node *node = vb2_get_drv_priv(q);
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       int ret;
> +
> +       v4l2_dbg(1, debug, &dev->v4l2_dev, "%s: node %s[%d], mmal port %p\n",
> +                __func__, node->name, node->id, node->port);
> +
> +       init_completion(&dev->frame_cmplt);
> +
> +       /* Disable MMAL port - this will flush buffers back */
> +       ret = vchiq_mmal_port_disable(dev->mmal_instance, node->port);
> +       if (ret)
> +               v4l2_err(&dev->v4l2_dev,
> +                        "%s: Failed disabling %s port, ret %d\n", __func__,
> +                        node_is_output(node) ? "i/p" : "o/p",
> +                        ret);
> +
> +       while (atomic_read(&node->port->buffers_with_vpu)) {
> +               v4l2_dbg(1, debug, &dev->v4l2_dev,
> +                        "%s: Waiting for buffers to be returned - %d outstanding\n",
> +                        __func__, atomic_read(&node->port->buffers_with_vpu));
> +               ret = wait_for_completion_timeout(&dev->frame_cmplt,
> +                                                 COMPLETE_TIMEOUT);
> +               if (ret <= 0) {
> +                       v4l2_err(&dev->v4l2_dev,
> +                                "%s: Timeout waiting for buffers to be returned - %d outstanding\n",
> +                                __func__,
> +                                atomic_read(&node->port->buffers_with_vpu));
> +                       break;
> +               }
> +       }
> +
> +       atomic_dec(&dev->num_streaming);
> +       /* If all ports disabled, then disable the component */
> +       if (atomic_read(&dev->num_streaming) == 0) {
> +               ret = bcm2835_isp_params_drop_ls_ref(dev->params);
> +               if (ret) {
> +                       v4l2_err(&dev->v4l2_dev,
> +                                "%s: Failed dropping LS buffer, ret %d\n",
> +                                __func__, ret);
> +               }
> +
> +               ret = vchiq_mmal_component_disable(dev->mmal_instance,
> +                                                  dev->component);
> +               if (ret) {
> +                       v4l2_err(&dev->v4l2_dev,
> +                                "%s: Failed disabling component, ret %d\n",
> +                                __func__, ret);
> +               }
> +       }
> +
> +       /*
> +        * Simply wait for any vb2 buffers to finish. We could take steps to
> +        * make them complete more quickly if we care, or even return them
> +        * ourselves.
> +        */
> +       vb2_wait_for_all_buffers(&node->queue);
> +}
> +
> +static const struct vb2_ops bcm2835_isp_node_queue_ops = {
> +       .queue_setup            = bcm2835_isp_node_queue_setup,
> +       .buf_init               = bcm2835_isp_buf_init,
> +       .buf_prepare            = bcm2835_isp_buf_prepare,
> +       .buf_queue              = bcm2835_isp_node_buffer_queue,
> +       .buf_cleanup            = bcm2835_isp_buffer_cleanup,
> +       .start_streaming        = bcm2835_isp_node_start_streaming,
> +       .stop_streaming         = bcm2835_isp_node_stop_streaming,
> +};
> +
> +static const
> +struct bcm2835_isp_fmt *get_default_format(struct bcm2835_isp_node *node)
> +{
> +       return node->supported_fmts[0];
> +}
> +
> +static inline unsigned int get_bytesperline(int width,
> +                                           const struct bcm2835_isp_fmt *fmt)
> +{
> +       /* GPU aligns 24bpp images to a multiple of 32 pixels (not bytes). */
> +       if (fmt->depth == 24)
> +               return ALIGN(width, 32) * 3;
> +       else
> +               return ALIGN((width * fmt->depth) >> 3, fmt->bytesperline_align);
> +}
> +
> +static inline unsigned int get_sizeimage(int bpl, int width, int height,
> +                                        const struct bcm2835_isp_fmt *fmt)
> +{
> +       return (bpl * height * fmt->size_multiplier_x2) >> 1;
> +}
> +
> +static const struct v4l2_file_operations bcm2835_isp_fops = {
> +       .owner          = THIS_MODULE,
> +       .open           = v4l2_fh_open,
> +       .release        = vb2_fop_release,
> +       .poll           = vb2_fop_poll,
> +       .unlocked_ioctl = video_ioctl2,
> +       .mmap           = vb2_fop_mmap
> +};
> +
> +static int populate_qdata_fmt(struct v4l2_format *f,
> +                             struct bcm2835_isp_node *node)
> +{
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       struct bcm2835_isp_q_data *q_data = &node->q_data;
> +       int ret;
> +
> +       if (!node_is_stats(node)) {
> +               v4l2_dbg(1, debug, &dev->v4l2_dev,
> +                        "%s: Setting pix format for type %d, wxh: %ux%u, fmt: %08x, size %u\n",
> +                        __func__, f->type, f->fmt.pix.width, f->fmt.pix.height,
> +                        f->fmt.pix.pixelformat, f->fmt.pix.sizeimage);
> +
> +               q_data->fmt = find_format(f, node);
> +               q_data->width = f->fmt.pix.width;
> +               q_data->height = f->fmt.pix.height;
> +
> +               /* All parameters should have been set correctly by try_fmt */
> +               q_data->bytesperline = f->fmt.pix.bytesperline;
> +               q_data->sizeimage = f->fmt.pix.sizeimage;
> +               q_data->ycbcr_enc = f->fmt.pix.ycbcr_enc;
> +               q_data->xfer_func = f->fmt.pix.xfer_func;
> +               q_data->quantization = f->fmt.pix.quantization;
> +
> +               /* We must indicate which of the allowed colour spaces we have. */
> +               q_data->colorspace = f->fmt.pix.colorspace;
> +       } else {
> +               v4l2_dbg(1, debug, &dev->v4l2_dev,
> +                        "%s: Setting meta format for fmt: %08x, size %u\n",
> +                        __func__, f->fmt.meta.dataformat,
> +                        f->fmt.meta.buffersize);
> +
> +               q_data->fmt = find_format(f, node);
> +               q_data->width = 0;
> +               q_data->height = 0;
> +               q_data->bytesperline = 0;
> +               q_data->sizeimage = f->fmt.meta.buffersize;
> +
> +               /* This won't mean anything for metadata, but may as well fill it in. */
> +               q_data->colorspace = V4L2_COLORSPACE_DEFAULT;
> +       }
> +
> +       v4l2_dbg(1, debug, &dev->v4l2_dev,
> +                "%s: Calculated bpl as %u, size %u\n", __func__,
> +                q_data->bytesperline, q_data->sizeimage);
> +
> +       setup_mmal_port_format(node, node->port);
> +       ret = vchiq_mmal_port_set_format(dev->mmal_instance, node->port);
> +       if (ret) {
> +               v4l2_err(&dev->v4l2_dev,
> +                        "%s: Failed vchiq_mmal_port_set_format on port, ret %d\n",
> +                        __func__, ret);
> +               ret = -EINVAL;
> +       }
> +
> +       if (q_data->sizeimage < node->port->minimum_buffer.size) {
> +               v4l2_err(&dev->v4l2_dev,
> +                        "%s: Current buffer size of %u < min buf size %u - driver mismatch to MMAL\n",
> +                        __func__,
> +                        q_data->sizeimage,
> +                        node->port->minimum_buffer.size);
> +               ret = -EINVAL;
> +       }
> +
> +       v4l2_dbg(1, debug, &dev->v4l2_dev,
> +                "%s: Set format for type %d, wxh: %dx%d, fmt: %08x, size %u\n",
> +                __func__, f->type, q_data->width, q_data->height,
> +                q_data->fmt->fourcc, q_data->sizeimage);
> +
> +       return ret;
> +}
> +
> +int bcm2835_isp_node_querycap(struct file *file, void *priv,
> +                             struct v4l2_capability *cap)
> +{
> +       strscpy(cap->driver, BCM2835_ISP_NAME, sizeof(cap->driver));
> +       strscpy(cap->card, BCM2835_ISP_NAME, sizeof(cap->card));
> +       snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s",
> +                BCM2835_ISP_NAME);
> +
> +       return 0;
> +}
> +
> +static int bcm2835_isp_node_g_fmt(struct file *file, void *priv,
> +                                 struct v4l2_format *f)
> +{
> +       struct bcm2835_isp_node *node = video_drvdata(file);
> +
> +       if (f->type != node->queue.type)
> +               return -EINVAL;
> +
> +       if (node_is_stats(node)) {
> +               f->fmt.meta.dataformat = V4L2_META_FMT_BCM2835_ISP_STATS;
> +               f->fmt.meta.buffersize =
> +                       node->port->minimum_buffer.size;
> +       } else {
> +               struct bcm2835_isp_q_data *q_data = &node->q_data;
> +
> +               f->fmt.pix.width = q_data->width;
> +               f->fmt.pix.height = q_data->height;
> +               f->fmt.pix.field = V4L2_FIELD_NONE;
> +               f->fmt.pix.pixelformat = q_data->fmt->fourcc;
> +               f->fmt.pix.bytesperline = q_data->bytesperline;
> +               f->fmt.pix.sizeimage = q_data->sizeimage;
> +               f->fmt.pix.colorspace = q_data->colorspace;
> +               f->fmt.pix.ycbcr_enc = q_data->ycbcr_enc;
> +               f->fmt.pix.xfer_func = q_data->xfer_func;
> +               f->fmt.pix.quantization = q_data->quantization;
> +       }
> +
> +       return 0;
> +}
> +
> +static int bcm2835_isp_node_enum_fmt(struct file *file, void *priv,
> +                                    struct v4l2_fmtdesc *f)
> +{
> +       struct bcm2835_isp_node *node = video_drvdata(file);
> +
> +       if (f->type != node->queue.type)
> +               return -EINVAL;
> +
> +       if (f->index < node->num_supported_fmts) {
> +               /* Format found */
> +               f->pixelformat = node->supported_fmts[f->index]->fourcc;
> +               f->flags = 0;
> +               return 0;
> +       }
> +
> +       return -EINVAL;
> +}
> +
> +static int bcm2835_isp_enum_framesizes(struct file *file, void *priv,
> +                                      struct v4l2_frmsizeenum *fsize)
> +{
> +       struct bcm2835_isp_node *node = video_drvdata(file);
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       const struct bcm2835_isp_fmt *fmt;
> +
> +       if (node_is_stats(node) || fsize->index)
> +               return -EINVAL;
> +
> +       fmt = find_format_by_fourcc(fsize->pixel_format, node);
> +       if (!fmt) {
> +               v4l2_err(&dev->v4l2_dev, "Invalid pixel code: %x\n",
> +                        fsize->pixel_format);
> +               return -EINVAL;
> +       }
> +
> +       fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
> +       fsize->stepwise.min_width = MIN_DIM;
> +       fsize->stepwise.max_width = MAX_DIM;
> +       fsize->stepwise.step_width = fmt->step_size;
> +
> +       fsize->stepwise.min_height = MIN_DIM;
> +       fsize->stepwise.max_height = MAX_DIM;
> +       fsize->stepwise.step_height = fmt->step_size;
> +
> +       return 0;
> +}
> +
> +static int bcm2835_isp_node_try_fmt(struct file *file, void *priv,
> +                                   struct v4l2_format *f)
> +{
> +       struct bcm2835_isp_node *node = video_drvdata(file);
> +       const struct bcm2835_isp_fmt *fmt;
> +
> +       if (f->type != node->queue.type)
> +               return -EINVAL;
> +
> +       fmt = find_format(f, node);
> +       if (!fmt)
> +               fmt = get_default_format(node);
> +
> +       if (!node_is_stats(node)) {
> +               bool is_rgb;
> +
> +               f->fmt.pix.width = clamp_t(u32, f->fmt.pix.width, MIN_DIM,
> +                                          MAX_DIM);
> +               f->fmt.pix.height = clamp_t(u32, f->fmt.pix.height, MIN_DIM,
> +                                           MAX_DIM);
> +               f->fmt.pix.pixelformat = fmt->fourcc;
> +
> +               /*
> +                * Fill in the actual colour space when the requested one was
> +                * not supported. This also catches the case when the "default"
> +                * colour space was requested (as that's never in the mask).
> +                */
> +               if (!(V4L2_COLORSPACE_MASK(f->fmt.pix.colorspace) & fmt->colorspace_mask))
> +                       f->fmt.pix.colorspace = fmt->colorspace_default;
> +               /* In all cases, we only support the defaults for these: */
> +               f->fmt.pix.ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(f->fmt.pix.colorspace);
> +               f->fmt.pix.xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(f->fmt.pix.colorspace);
> +               /* RAW counts as sRGB here so that we get full range. */
> +               is_rgb = f->fmt.pix.colorspace == V4L2_COLORSPACE_SRGB ||
> +                       f->fmt.pix.colorspace == V4L2_COLORSPACE_RAW;
> +               f->fmt.pix.quantization = V4L2_MAP_QUANTIZATION_DEFAULT(is_rgb,
> +                                                                       f->fmt.pix.colorspace,
> +                                                                       f->fmt.pix.ycbcr_enc);
> +
> +               /* Respect any stride value (suitably aligned) that was requested. */
> +               f->fmt.pix.bytesperline = max(get_bytesperline(f->fmt.pix.width, fmt),
> +                                             ALIGN(f->fmt.pix.bytesperline,
> +                                                   fmt->bytesperline_align));
> +               f->fmt.pix.field = V4L2_FIELD_NONE;
> +               f->fmt.pix.sizeimage =
> +                       get_sizeimage(f->fmt.pix.bytesperline, f->fmt.pix.width,
> +                                     f->fmt.pix.height, fmt);
> +       } else {
> +               f->fmt.meta.dataformat = fmt->fourcc;
> +               f->fmt.meta.buffersize = node->port->minimum_buffer.size;
> +       }
> +
> +       return 0;
> +}
> +
> +static int bcm2835_isp_node_s_fmt(struct file *file, void *priv,
> +                                 struct v4l2_format *f)
> +{
> +       struct bcm2835_isp_node *node = video_drvdata(file);
> +       int ret;
> +
> +       if (f->type != node->queue.type)
> +               return -EINVAL;
> +
> +       ret = bcm2835_isp_node_try_fmt(file, priv, f);
> +       if (ret)
> +               return ret;
> +
> +       v4l2_dbg(1, debug, &node_get_dev(node)->v4l2_dev,
> +                "%s: Set format for node %s[%d]\n",
> +                __func__, node->name, node->id);
> +
> +       return populate_qdata_fmt(f, node);
> +}
> +
> +static int bcm2835_isp_node_s_selection(struct file *file, void *fh,
> +                                       struct v4l2_selection *s)
> +{
> +       struct mmal_parameter_crop crop;
> +       struct bcm2835_isp_node *node = video_drvdata(file);
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +
> +       if (!node_is_output(node))
> +               return -EINVAL;
> +
> +       if (!s->r.width || !s->r.height)
> +               return -EINVAL;
> +
> +       /* We can only set crop on the input. */
> +       switch (s->target) {
> +       case V4L2_SEL_TGT_CROP:
> +               /*
> +                * Adjust the crop window if it goes outside of the frame
> +                * dimensions.
> +                */
> +               s->r.left = clamp_t(unsigned int, s->r.left, 0,
> +                                   node->q_data.width - MIN_DIM);
> +               s->r.top = clamp_t(unsigned int, s->r.top, 0,
> +                                  node->q_data.height - MIN_DIM);
> +               s->r.width = clamp_t(unsigned int, s->r.width, MIN_DIM,
> +                                    node->q_data.width - s->r.left);
> +               s->r.height = clamp_t(unsigned int, s->r.height, MIN_DIM,
> +                                     node->q_data.height - s->r.top);
> +               break;
> +       default:
> +               return -EINVAL;
> +       }
> +
> +       crop.rect.x = s->r.left;
> +       crop.rect.y = s->r.top;
> +       crop.rect.width = s->r.width;
> +       crop.rect.height = s->r.height;
> +
> +       return vchiq_mmal_port_parameter_set(dev->mmal_instance, node->port,
> +                                            MMAL_PARAMETER_CROP,
> +                                            &crop, sizeof(crop));
> +}
> +
> +static int bcm2835_isp_node_g_selection(struct file *file, void *fh,
> +                                       struct v4l2_selection *s)
> +{
> +       struct mmal_parameter_crop crop;
> +       struct bcm2835_isp_node *node = video_drvdata(file);
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       u32 crop_size = sizeof(crop);
> +       int ret;
> +
> +       if (!node_is_output(node))
> +               return -EINVAL;
> +
> +       /* We can only return out an input crop. */
> +       switch (s->target) {
> +       case V4L2_SEL_TGT_CROP:
> +               ret = vchiq_mmal_port_parameter_get(dev->mmal_instance,
> +                                                   node->port,
> +                                                   MMAL_PARAMETER_CROP,
> +                                                   &crop, &crop_size);
> +               if (!ret) {
> +                       s->r.left = crop.rect.x;
> +                       s->r.top = crop.rect.y;
> +                       s->r.width = crop.rect.width;
> +                       s->r.height = crop.rect.height;
> +               }
> +               break;
> +       case V4L2_SEL_TGT_CROP_DEFAULT:
> +       case V4L2_SEL_TGT_CROP_BOUNDS:
> +               /* Default (i.e. no) crop window. */
> +               s->r.left = 0;
> +               s->r.top = 0;
> +               s->r.width = node->q_data.width;
> +               s->r.height = node->q_data.height;
> +               ret = 0;
> +               break;
> +       default:
> +               ret =  -EINVAL;
> +       }
> +
> +       return ret;
> +}
> +
> +static const struct v4l2_ioctl_ops bcm2835_isp_node_ioctl_ops = {
> +       .vidioc_querycap                = bcm2835_isp_node_querycap,
> +       .vidioc_g_fmt_vid_cap           = bcm2835_isp_node_g_fmt,
> +       .vidioc_g_fmt_vid_out           = bcm2835_isp_node_g_fmt,
> +       .vidioc_g_fmt_meta_cap          = bcm2835_isp_node_g_fmt,
> +       .vidioc_s_fmt_vid_cap           = bcm2835_isp_node_s_fmt,
> +       .vidioc_s_fmt_vid_out           = bcm2835_isp_node_s_fmt,
> +       .vidioc_s_fmt_meta_cap          = bcm2835_isp_node_s_fmt,
> +       .vidioc_try_fmt_vid_cap         = bcm2835_isp_node_try_fmt,
> +       .vidioc_try_fmt_vid_out         = bcm2835_isp_node_try_fmt,
> +       .vidioc_try_fmt_meta_cap        = bcm2835_isp_node_try_fmt,
> +       .vidioc_s_selection             = bcm2835_isp_node_s_selection,
> +       .vidioc_g_selection             = bcm2835_isp_node_g_selection,
> +
> +       .vidioc_enum_fmt_vid_cap        = bcm2835_isp_node_enum_fmt,
> +       .vidioc_enum_fmt_vid_out        = bcm2835_isp_node_enum_fmt,
> +       .vidioc_enum_fmt_meta_cap       = bcm2835_isp_node_enum_fmt,
> +       .vidioc_enum_framesizes         = bcm2835_isp_enum_framesizes,
> +
> +       .vidioc_reqbufs                 = vb2_ioctl_reqbufs,
> +       .vidioc_querybuf                = vb2_ioctl_querybuf,
> +       .vidioc_qbuf                    = vb2_ioctl_qbuf,
> +       .vidioc_dqbuf                   = vb2_ioctl_dqbuf,
> +       .vidioc_expbuf                  = vb2_ioctl_expbuf,
> +       .vidioc_create_bufs             = vb2_ioctl_create_bufs,
> +       .vidioc_prepare_buf             = vb2_ioctl_prepare_buf,
> +
> +       .vidioc_streamon                = vb2_ioctl_streamon,
> +       .vidioc_streamoff               = vb2_ioctl_streamoff,
> +};
> +
> +/*
> + * Size of the array to provide to the VPU when asking for the list of supported
> + * formats.
> + *
> + * The ISP component currently advertises 62 input formats, so add a small
> + * overhead on that. Should the component advertise more formats then the excess
> + * will be dropped and a warning logged.
> + */
> +#define MAX_SUPPORTED_ENCODINGS 70
> +
> +/* Populate node->supported_fmts with the formats supported by those ports. */
> +static int bcm2835_isp_get_supported_fmts(struct bcm2835_isp_node *node)
> +{
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +       struct bcm2835_isp_fmt const **list;
> +       unsigned int i, j, num_encodings;
> +       u32 fourccs[MAX_SUPPORTED_ENCODINGS];
> +       u32 param_size = sizeof(fourccs);
> +       int ret;
> +
> +       ret = vchiq_mmal_port_parameter_get(dev->mmal_instance, node->port,
> +                                           MMAL_PARAMETER_SUPPORTED_ENCODINGS,
> +                                           &fourccs, &param_size);
> +
> +       if (ret) {
> +               if (ret == MMAL_MSG_STATUS_ENOSPC) {
> +                       v4l2_err(&dev->v4l2_dev,
> +                                "%s: port has more encodings than we provided space for. Some are dropped (%zu vs %u).\n",
> +                                __func__, param_size / sizeof(u32),
> +                                MAX_SUPPORTED_ENCODINGS);
> +                       num_encodings = MAX_SUPPORTED_ENCODINGS;
> +               } else {
> +                       v4l2_err(&dev->v4l2_dev, "%s: get_param ret %u.\n",
> +                                __func__, ret);
> +                       return -EINVAL;
> +               }
> +       } else {
> +               num_encodings = param_size / sizeof(u32);
> +       }
> +
> +       /*
> +        * Assume at this stage that all encodings will be supported in V4L2.
> +        * Any that aren't supported will waste a very small amount of memory.
> +        */
> +       list = devm_kzalloc(dev->dev,
> +                           sizeof(struct bcm2835_isp_fmt *) * num_encodings,
> +                           GFP_KERNEL);
> +       if (!list)
> +               return -ENOMEM;
> +       node->supported_fmts = list;
> +
> +       for (i = 0, j = 0; i < num_encodings; i++) {
> +               const struct bcm2835_isp_fmt *fmt = get_fmt(fourccs[i]);
> +
> +               if (fmt) {
> +                       list[j] = fmt;
> +                       j++;
> +               }
> +       }
> +       node->num_supported_fmts = j;
> +
> +       return 0;
> +}
> +
> +/*
> + * Register a device node /dev/video<N> to go along with one of the ISP's input
> + * or output nodes.
> + */
> +static int bcm2835_isp_register_node(struct bcm2835_isp_dev *dev,
> +                                    unsigned int instance,
> +                                    struct bcm2835_isp_node *node, int index)
> +{
> +       struct video_device *vfd;
> +       struct vb2_queue *queue;
> +       bool is_rgb;
> +       int ret;
> +
> +       mutex_init(&node->lock);
> +       mutex_init(&node->queue_lock);
> +
> +       node->dev = dev;
> +       vfd = &node->vfd;
> +       queue = &node->queue;
> +       queue->type = index_to_queue_type(index);
> +       /*
> +        * Setup the node type-specific params.
> +        */
> +       switch (queue->type) {
> +       case V4L2_BUF_TYPE_VIDEO_OUTPUT:
> +               vfd->device_caps = V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING;
> +               node->id = index;
> +               node->vfl_dir = VFL_DIR_TX;
> +               node->name = "output";
> +               if (node->id >= ARRAY_SIZE(dev->component->input))
> +                       return -EINVAL;
> +               node->port = &dev->component->input[node->id];
> +               break;
> +       case V4L2_BUF_TYPE_VIDEO_CAPTURE:
> +               vfd->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
> +               /* First Capture node starts at id 0, etc. */
> +               node->id = index - BCM2835_ISP_NUM_OUTPUTS;
> +               node->vfl_dir = VFL_DIR_RX;
> +               node->name = "capture";
> +               if (node->id >= ARRAY_SIZE(dev->component->output))
> +                       return -EINVAL;
> +               node->port = &dev->component->output[node->id];
> +               break;
> +       case V4L2_BUF_TYPE_META_CAPTURE:
> +               vfd->device_caps = V4L2_CAP_META_CAPTURE | V4L2_CAP_STREAMING;
> +               node->id = index - BCM2835_ISP_NUM_OUTPUTS;
> +               node->vfl_dir = VFL_DIR_RX;
> +               node->name = "stats";
> +               if (node->id >= ARRAY_SIZE(dev->component->output))
> +                       return -EINVAL;
> +               node->port = &dev->component->output[node->id];
> +               break;
> +       }
> +
> +       ret = bcm2835_isp_get_supported_fmts(node);
> +       if (ret)
> +               return ret;
> +
> +       /* Initialise the video node. */
> +       vfd->vfl_type   = VFL_TYPE_VIDEO;
> +       vfd->fops       = &bcm2835_isp_fops;
> +       vfd->ioctl_ops  = &bcm2835_isp_node_ioctl_ops;
> +       vfd->minor      = -1;
> +       vfd->release    = video_device_release_empty;
> +       vfd->queue      = &node->queue;
> +       vfd->lock       = &node->lock;
> +       vfd->v4l2_dev   = &dev->v4l2_dev;
> +       vfd->vfl_dir    = node->vfl_dir;
> +
> +       node->q_data.fmt = get_default_format(node);
> +       node->q_data.width = DEFAULT_DIM;
> +       node->q_data.height = DEFAULT_DIM;
> +       node->q_data.bytesperline =
> +               get_bytesperline(DEFAULT_DIM, node->q_data.fmt);
> +       node->q_data.sizeimage = node_is_stats(node) ?
> +                                node->port->recommended_buffer.size :
> +                                get_sizeimage(node->q_data.bytesperline,
> +                                              node->q_data.width,
> +                                              node->q_data.height,
> +                                              node->q_data.fmt);
> +       node->q_data.colorspace = node->q_data.fmt->colorspace_default;
> +       node->q_data.ycbcr_enc =
> +               V4L2_MAP_YCBCR_ENC_DEFAULT(node->q_data.colorspace);
> +       node->q_data.xfer_func =
> +               V4L2_MAP_XFER_FUNC_DEFAULT(node->q_data.colorspace);
> +       is_rgb = node->q_data.colorspace == V4L2_COLORSPACE_SRGB ||
> +               node->q_data.colorspace == V4L2_COLORSPACE_RAW;
> +       node->q_data.quantization = V4L2_MAP_QUANTIZATION_DEFAULT(is_rgb,
> +                                                                 node->q_data.colorspace,
> +                                                                 node->q_data.ycbcr_enc);
> +
> +       queue->io_modes = VB2_MMAP | VB2_DMABUF;
> +       queue->drv_priv = node;
> +       queue->ops = &bcm2835_isp_node_queue_ops;
> +       queue->mem_ops = &vb2_dma_contig_memops;
> +       queue->buf_struct_size = sizeof(struct bcm2835_isp_buffer);
> +       queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY;
> +       queue->dev = dev->dev;
> +       queue->lock = &node->queue_lock;
> +
> +       ret = vb2_queue_init(queue);
> +       if (ret < 0) {
> +               v4l2_info(&dev->v4l2_dev, "vb2_queue_init failed\n");
> +               return ret;
> +       }
> +
> +       /* Define the device names */
> +       snprintf(vfd->name, sizeof(node->vfd.name), "%s-%s%d", BCM2835_ISP_NAME,
> +                node->name, node->id);
> +
> +       node->pad.flags = node_is_output(node) ? MEDIA_PAD_FL_SOURCE : MEDIA_PAD_FL_SINK;
> +       ret = media_entity_pads_init(&node->vfd.entity, 1, &node->pad);
> +       if (ret)
> +               goto queue_cleanup;
> +
> +       ret = video_register_device(vfd, VFL_TYPE_VIDEO, video_nr[instance]);
> +       if (ret) {
> +               v4l2_err(&dev->v4l2_dev,
> +                        "Failed to register video %s[%d] device node\n",
> +                        node->name, node->id);
> +               goto queue_cleanup;
> +       }
> +
> +       node->registered = true;
> +       video_set_drvdata(vfd, node);
> +
> +       v4l2_info(&dev->v4l2_dev,
> +                 "Device node %s[%d] registered as /dev/video%d\n",
> +                 node->name, node->id, vfd->num);
> +
> +       return 0;
> +
> +queue_cleanup:
> +       vb2_queue_release(&node->queue);
> +       return ret;
> +}
> +
> +/* Unregister one of the /dev/video<N> nodes associated with the ISP. */
> +static void bcm2835_unregister_node(struct bcm2835_isp_node *node)
> +{
> +       struct bcm2835_isp_dev *dev = node_get_dev(node);
> +
> +       v4l2_info(&dev->v4l2_dev,
> +                 "Unregistering node %s[%d] device node /dev/video%d\n",
> +                 node->name, node->id, node->vfd.num);
> +
> +       if (node->registered) {
> +               video_unregister_device(&node->vfd);
> +               vb2_queue_release(&node->queue);
> +       }
> +
> +       /*
> +        * node->supported_fmts.list is free'd automatically
> +        * as a managed resource.
> +        */
> +       node->supported_fmts = NULL;
> +       node->num_supported_fmts = 0;
> +       node->registered = false;
> +}
> +
> +static void media_controller_unregister(struct bcm2835_isp_dev *dev)
> +{
> +       v4l2_info(&dev->v4l2_dev, "Unregister from media controller\n");
> +
> +       if (dev->media_device_registered) {
> +               media_device_unregister(&dev->mdev);
> +               media_device_cleanup(&dev->mdev);
> +               dev->media_device_registered = false;
> +       }
> +
> +       kfree(dev->entity.name);
> +       dev->entity.name = NULL;
> +
> +       if (dev->media_entity_registered) {
> +               media_device_unregister_entity(&dev->entity);
> +               dev->media_entity_registered = false;
> +       }
> +
> +       dev->v4l2_dev.mdev = NULL;
> +}
> +
> +static int media_controller_register(struct bcm2835_isp_dev *dev)
> +{
> +       struct media_entity *entity;
> +       char *name;
> +       unsigned int i;
> +       int ret;
> +
> +       v4l2_dbg(2, debug, &dev->v4l2_dev, "Registering with media controller\n");
> +
> +       name = kmalloc(BCM2835_ISP_ENTITY_NAME_LEN, GFP_KERNEL);
> +       if (!name) {
> +               ret = -ENOMEM;
> +               goto done;
> +       }
> +       snprintf(name, BCM2835_ISP_ENTITY_NAME_LEN, "bcm2835-isp");
> +       dev->entity.name = name;
> +       dev->entity.obj_type = MEDIA_ENTITY_TYPE_BASE;
> +       dev->entity.function = MEDIA_ENT_F_PROC_VIDEO_ISP;
> +
> +       for (i = 0; i < BCM2835_ISP_NUM_NODES; i++) {
> +               dev->pad[i].flags = node_is_output(&dev->node[i]) ?
> +                                       MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE;
> +       }
> +       dev->pad[BCM2835_ISP_PARAMS_PAD].flags = MEDIA_PAD_FL_SINK;
> +
> +       ret = media_entity_pads_init(&dev->entity, BCM2835_ISP_NUM_ENTITY_PADS,
> +                                    dev->pad);
> +       if (ret)
> +               goto done;
> +
> +       ret = media_device_register_entity(&dev->mdev, &dev->entity);
> +       if (ret)
> +               goto done;
> +
> +       dev->media_entity_registered = true;
> +
> +       for (i = 0; i < BCM2835_ISP_NUM_NODES; i++) {
> +               entity = &dev->node[i].vfd.entity;
> +               int output = node_is_output(&dev->node[i]);
> +
> +               if (output)
> +                       ret = media_create_pad_link(entity, 0,
> +                                                   &dev->entity, i,
> +                                                   MEDIA_LNK_FL_IMMUTABLE |
> +                                                   MEDIA_LNK_FL_ENABLED);
> +               else
> +                       ret = media_create_pad_link(&dev->entity, i,
> +                                                   entity, 0,
> +                                                   MEDIA_LNK_FL_IMMUTABLE |
> +                                                   MEDIA_LNK_FL_ENABLED);
> +               if (ret)
> +                       goto done;
> +       }
> +
> +       entity = &dev->params->vdev.entity;
> +       ret = media_create_pad_link(entity, 0, &dev->entity, BCM2835_ISP_PARAMS_PAD,
> +                                   MEDIA_LNK_FL_IMMUTABLE |
> +                                   MEDIA_LNK_FL_ENABLED);
> +       if (ret)
> +               goto done;
> +
> +       ret = media_device_register(&dev->mdev);
> +       if (!ret)
> +               dev->media_device_registered = true;
> +done:
> +       return ret;
> +}
> +
> +static void bcm2835_isp_remove_instance(struct bcm2835_isp_dev *dev)
> +{
> +       unsigned int i;
> +
> +       if (!IS_ERR_OR_NULL(dev->params))
> +               bcm2835_isp_params_unregister(dev->params);
> +
> +       for (i = 0; i < BCM2835_ISP_NUM_NODES; i++)
> +               bcm2835_unregister_node(&dev->node[i]);
> +
> +       v4l2_device_unregister(&dev->v4l2_dev);
> +       media_controller_unregister(dev);
> +
> +       if (dev->component)
> +               vchiq_mmal_component_finalise(dev->mmal_instance,
> +                                             dev->component);
> +
> +       vchiq_mmal_finalise(dev->mmal_instance);
> +}
> +
> +static int bcm2835_isp_probe_instance(struct vchiq_device *device,
> +                                     struct bcm2835_isp_dev **dev_int,
> +                                     unsigned int instance)
> +{
> +       struct bcm2835_isp_dev *dev;
> +       unsigned int i;
> +       int ret;
> +
> +       dev = devm_kzalloc(&device->dev, sizeof(*dev), GFP_KERNEL);
> +       if (!dev)
> +               return -ENOMEM;
> +
> +       *dev_int = dev;
> +       dev->dev = &device->dev;
> +       dev->mdev.dev = &device->dev;
> +
> +       strscpy(dev->mdev.model, BCM2835_ISP_NAME, sizeof(dev->mdev.model));
> +       snprintf(dev->mdev.bus_info, sizeof(dev->mdev.bus_info), "platform:%s",
> +                BCM2835_ISP_NAME);
> +       media_device_init(&dev->mdev);
> +
> +       dev->v4l2_dev.mdev = &dev->mdev;
> +
> +       ret = v4l2_device_register(&device->dev, &dev->v4l2_dev);
> +       if (ret)
> +               return ret;
> +
> +       ret = vchiq_mmal_init(&device->dev, &dev->mmal_instance);
> +       if (ret) {
> +               v4l2_device_unregister(&dev->v4l2_dev);
> +               return ret;
> +       }
> +
> +       ret = vchiq_mmal_component_init(dev->mmal_instance, "ril.isp",
> +                                       &dev->component);
> +       if (ret) {
> +               v4l2_err(&dev->v4l2_dev,
> +                        "%s: failed to create ril.isp component\n", __func__);
> +               return ret;
> +       }
> +
> +       if (dev->component->inputs < BCM2835_ISP_NUM_OUTPUTS ||
> +           dev->component->outputs < BCM2835_ISP_NUM_CAPTURES +
> +                                       BCM2835_ISP_NUM_METADATA) {
> +               v4l2_err(&dev->v4l2_dev,
> +                        "%s: ril.isp returned %d i/p (%d expected), %d o/p (%d expected) ports\n",
> +                         __func__, dev->component->inputs,
> +                         BCM2835_ISP_NUM_OUTPUTS,
> +                         dev->component->outputs,
> +                         BCM2835_ISP_NUM_CAPTURES + BCM2835_ISP_NUM_METADATA);
> +               return -EINVAL;
> +       }
> +
> +       atomic_set(&dev->num_streaming, 0);
> +
> +       for (i = 0; i < BCM2835_ISP_NUM_NODES; i++) {
> +               struct bcm2835_isp_node *node = &dev->node[i];
> +
> +               ret = bcm2835_isp_register_node(dev, instance, node, i);
> +               if (ret)
> +                       return ret;
> +       }
> +
> +       /* Register extensible params node */
> +       dev->params = bcm2835_isp_params_register(&dev->v4l2_dev, dev->dev,
> +                                                 dev->mmal_instance,
> +                                                 &dev->component->input[0],
> +                                                 video_nr[instance] + BCM2835_ISP_NUM_NODES);
> +       if (IS_ERR(dev->params))
> +               return PTR_ERR(dev->params);
> +
> +       ret = media_controller_register(dev);
> +       if (ret)
> +               return ret;
> +
> +       return 0;
> +}
> +
> +static void bcm2835_isp_remove(struct vchiq_device *device)
> +{
> +       struct bcm2835_isp_dev **bcm2835_isp_instances;
> +       unsigned int i;
> +
> +       bcm2835_isp_instances = vchiq_get_drvdata(device);
> +       for (i = 0; i < BCM2835_ISP_NUM_INSTANCES; i++) {
> +               if (bcm2835_isp_instances[i])
> +                       bcm2835_isp_remove_instance(bcm2835_isp_instances[i]);
> +       }
> +}
> +
> +static int bcm2835_isp_probe(struct vchiq_device *device)
> +{
> +       struct bcm2835_isp_dev **bcm2835_isp_instances;
> +       unsigned int i;
> +       int ret;
> +
> +       ret = dma_set_mask_and_coherent(&device->dev, DMA_BIT_MASK(32));
> +       if (ret) {
> +               dev_err(&device->dev, "dma_set_mask_and_coherent failed: %d\n",
> +                       ret);
> +               return ret;
> +       }
> +
> +       bcm2835_isp_instances = devm_kzalloc(&device->dev,
> +                                            sizeof(*bcm2835_isp_instances) *
> +                                                     BCM2835_ISP_NUM_INSTANCES,
> +                                            GFP_KERNEL);
> +       if (!bcm2835_isp_instances)
> +               return -ENOMEM;
> +
> +       vchiq_set_drvdata(device, bcm2835_isp_instances);
> +
> +       for (i = 0; i < BCM2835_ISP_NUM_INSTANCES; i++) {
> +               ret = bcm2835_isp_probe_instance(device,
> +                                                &bcm2835_isp_instances[i], i);
> +               if (ret)
> +                       goto error;
> +       }
> +
> +       dev_info(&device->dev, "Loaded V4L2 %s\n", BCM2835_ISP_NAME);
> +       return 0;
> +
> +error:
> +       bcm2835_isp_remove(device);
> +
> +       return ret;
> +}
> +
> +static struct vchiq_device_id device_id_table[] = {
> +       { .name = "bcm2835-isp" },
> +       {}
> +};
> +MODULE_DEVICE_TABLE(vchiq, device_id_table);
> +
> +static struct vchiq_driver bcm2835_isp_drv = {
> +       .probe = bcm2835_isp_probe,
> +       .remove = bcm2835_isp_remove,
> +       .id_table = device_id_table,
> +       .driver = {
> +               .name = BCM2835_ISP_NAME,
> +       },
> +};
> +
> +module_vchiq_driver(bcm2835_isp_drv);
> +
> +MODULE_DESCRIPTION("BCM2835 ISP driver");
> +MODULE_AUTHOR("Naushir Patuck <naush@raspberrypi.com>");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index 17ba1ae70735..1449de2b64b5 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1490,6 +1490,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>         case V4L2_META_FMT_GENERIC_CSI2_16:     descr = "8-bit Generic Meta, 16b CSI-2"; break;
>         case V4L2_META_FMT_GENERIC_CSI2_20:     descr = "8-bit Generic Meta, 20b CSI-2"; break;
>         case V4L2_META_FMT_GENERIC_CSI2_24:     descr = "8-bit Generic Meta, 24b CSI-2"; break;
> +       case V4L2_META_FMT_BCM2835_ISP_STATS: descr = "BCM2835 ISP Image Statistics"; break;
> +       case V4L2_META_FMT_BCM2835_ISP_PARAMS: descr = "BCM2835 ISP Config Parameters"; break;
>  
>         default:
>                 /* Compressed formats */
> diff --git a/include/linux/raspberrypi/mmal-parameters.h b/include/linux/raspberrypi/mmal-parameters.h
> index 6ae5a7a1932c..f0e2ec025b70 100644
> --- a/include/linux/raspberrypi/mmal-parameters.h
> +++ b/include/linux/raspberrypi/mmal-parameters.h
> @@ -23,6 +23,8 @@
>  #define MMAL_PARAMETERS_H
>  
>  #include <linux/math.h>
> +#include <linux/stddef.h>
> +#include <uapi/linux/bcm2835-isp.h>
>  
>  /** Common parameter ID group, used with many types of component. */
>  #define MMAL_PARAMETER_GROUP_COMMON            (0 << 16)
> @@ -279,8 +281,14 @@ enum mmal_parameter_camera_type {
>         MMAL_PARAMETER_DPC,
>                 /**< Tales a @ref MMAP_PARAMETER_GAMMA_T */
>         MMAL_PARAMETER_GAMMA,
> +
> +       /* 0x60 */
>                 /**< Takes a @ref MMAL_PARAMETER_CDN_T */
>         MMAL_PARAMETER_CDN,
> +               /**< Takes a @ref MMAL_PARAMETER_BOOLEAN_T */
> +       MMAL_PARAMETER_JPEG_IJG_SCALING,
> +               /**< Takes a @ref MMAL_PARAMETER_ISP_SETTINGS_T */
> +       MMAL_PARAMETER_ISP_SETTINGS,
>  };
>  
>  enum mmal_parameter_camera_config_timestamp_mode {
> @@ -819,20 +827,143 @@ enum mmal_parameter_ls_gain_format_type {
>         MMAL_PARAMETER_LS_GAIN_FORMAT_TYPE_DUMMY  = 0x7FFFFFFF
>  };
>  
> -struct mmal_parameter_lens_shading_v2 {
> -       u32 enabled;
> -       u32 grid_cell_size;
> -       u32 grid_width;
> -       u32 grid_stride;
> -       u32 grid_height;
> -       u32 mem_handle_table;
> -       u32 ref_transform;
> -       u32 corner_sampled;
> -       enum mmal_parameter_ls_gain_format_type gain_format;
> -};
> -
>  struct mmal_parameter_crop {
>         struct vchiq_mmal_rect rect;
>  };
>  
> +struct mmal_parameter_isp_parameters {
> +       struct {
> +               /* Black level */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enable;
> +                       u16 black_level_r;
> +                       u16 black_level_g;
> +                       u16 black_level_b;
> +                       u8 padding[2];
> +               );
> +       } black_level;
> +
> +       struct {
> +               /* GEQ */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enable;
> +                       u32 offset;
> +                       struct bcm2835_isp_rational slope;
> +                       u8 padding[4];
> +               );
> +       } green_eq;
> +
> +       struct {
> +               /* Gamma */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enable;
> +                       u16 X[BCM2835_NUM_GAMMA_PTS];
> +                       u16 Y[BCM2835_NUM_GAMMA_PTS];
> +               );
> +       } gamma;
> +
> +       struct {
> +               /* Denoise */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enable;
> +                       u32 constant;
> +                       struct bcm2835_isp_rational slope;
> +                       struct bcm2835_isp_rational strength;
> +                       u8 padding[4];
> +               );
> +       } denoise;
> +
> +       struct {
> +               /* Sharpen */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enable;
> +                       struct bcm2835_isp_rational threshold;
> +                       struct bcm2835_isp_rational strength;
> +                       struct bcm2835_isp_rational limit;
> +               );
> +       } sharpen;
> +
> +       struct {
> +               /* Defective Pixel Correction */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enable;
> +                       u32 strength;
> +                       u8 padding[4];
> +               );
> +       } dpc;
> +
> +       struct {
> +               /* Colour denoise */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enable;
> +                       u32 mode;
> +                       u8 padding[4];
> +               );
> +       } colour_denoise;
> +
> +       struct {
> +               /* CCM */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enable;
> +                       struct bcm2835_isp_ccm ccm;
> +                       u8 padding[4];
> +               );
> +       } ccm;
> +
> +       struct {
> +               /* Lens shading */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       u32 enabled;
> +                       u32 grid_cell_size;
> +                       u32 grid_width;
> +                       u32 grid_stride;
> +                       u32 grid_height;
> +                       u32 mem_handle_table;
> +                       u32 ref_transform;
> +                       u32 corner_sampled;
> +                       enum mmal_parameter_ls_gain_format_type gain_format;
> +                       u8 padding[4];
> +               );
> +       } lens_shading;
> +
> +       struct {
> +               /* AWB Gains */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       struct bcm2835_isp_rational r_gain;
> +                       struct bcm2835_isp_rational b_gain;
> +                       u8 padding[4];
> +               );
> +       } awb_gains;
> +
> +       struct {
> +               /* Digital Gain */
> +               u32 update;
> +
> +               struct_group(payload,
> +                       struct bcm2835_isp_rational value;
> +                       u8 padding[4];
> +               );
> +       } digital_gain;
> +};
> +
>  #endif
> diff --git a/include/uapi/linux/bcm2835-isp.h b/include/uapi/linux/bcm2835-isp.h
> new file mode 100644
> index 000000000000..d15a4ed18404
> --- /dev/null
> +++ b/include/uapi/linux/bcm2835-isp.h
> @@ -0,0 +1,530 @@
> +/* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) */
> +/*
> + * bcm2835-isp.h
> + *
> + * BCM2835 ISP driver - user space header file.
> + *
> + * Copyright © 2019-2026 Raspberry Pi (Trading) Ltd.
> + *
> + * Author: Naushir Patuck (naush@raspberrypi.com)
> + *
> + */
> +
> +#ifndef __BCM2835_ISP_H_
> +#define __BCM2835_ISP_H_
> +
> +#include <linux/media/v4l2-isp.h>
> +
> +/*
> + * All structs below are directly mapped from struct
> + * mmal_parameter_isp_parameters in include/linux/raspberrypi/mmal-parameters.h
> + * for convenience.
> + */
> +
> +/**
> + * struct bcm2835_isp_rational - Rational value type.
> + *
> + * @num:       Numerator.
> + * @den:       Denominator.
> + */
> +struct bcm2835_isp_rational {
> +       __s32 num;
> +       __u32 den;
> +};
> +
> +/**
> + * struct bcm2835_isp_ccm - Colour correction matrix.
> + *
> + * @ccm:       3x3 correction matrix coefficients.
> + * @offsets:   1x3 correction offsets.
> + */
> +struct bcm2835_isp_ccm {
> +       struct bcm2835_isp_rational ccm[3][3];
> +       __s32 offsets[3];
> +};
> +
> +/**
> + * struct bcm2835_isp_custom_ccm - Custom CCM configuration.
> + *
> + * @enabled:   Enable custom CCM.
> + * @ccm:       Custom CCM coefficients and offsets.
> + */
> +struct bcm2835_isp_custom_ccm {
> +       __u32 enabled;
> +       struct bcm2835_isp_ccm ccm;
> +};
> +
> +/**
> + * enum bcm2835_isp_gain_format - format of the gains in the lens shading
> + *                               tables.
> + *
> + * @GAIN_FORMAT_U0P8_1:                Gains are u0.8 format, starting at 1.0
> + * @GAIN_FORMAT_U1P7_0:                Gains are u1.7 format, starting at 0.0
> + * @GAIN_FORMAT_U1P7_1:                Gains are u1.7 format, starting at 1.0
> + * @GAIN_FORMAT_U2P6_0:                Gains are u2.6 format, starting at 0.0
> + * @GAIN_FORMAT_U2P6_1:                Gains are u2.6 format, starting at 1.0
> + * @GAIN_FORMAT_U3P5_0:                Gains are u3.5 format, starting at 0.0
> + * @GAIN_FORMAT_U3P5_1:                Gains are u3.5 format, starting at 1.0
> + * @GAIN_FORMAT_U4P10:         Gains are u4.10 format, starting at 0.0
> + */
> +enum bcm2835_isp_gain_format {
> +       GAIN_FORMAT_U0P8_1 = 0,
> +       GAIN_FORMAT_U1P7_0 = 1,
> +       GAIN_FORMAT_U1P7_1 = 2,
> +       GAIN_FORMAT_U2P6_0 = 3,
> +       GAIN_FORMAT_U2P6_1 = 4,
> +       GAIN_FORMAT_U3P5_0 = 5,
> +       GAIN_FORMAT_U3P5_1 = 6,
> +       GAIN_FORMAT_U4P10  = 7,
> +};
> +
> +/**
> + * struct bcm2835_isp_lens_shading - Lens shading tables.
> + *
> + * @enabled:           Enable lens shading.
> + * @grid_cell_size:    Size of grid cells in samples (16, 32, 64, 128 or 256).
> + * @grid_width:                Width of lens shading tables in grid cells.
> + * @grid_stride:       Row to row distance (in grid cells) between grid cells
> + *                     in the same horizontal location.
> + * @grid_height:       Height of lens shading tables in grid cells.
> + * @dmabuf:            dmabuf file handle containing the table.
> + * @ref_transform:     Reference transform - unsupported, please pass zero.
> + * @corner_sampled:    Whether the gains are sampled at the corner points
> + *                     of the grid cells or in the cell centres.
> + * @gain_format:       Format of the gains (see enum &bcm2835_isp_gain_format).
> + */
> +struct bcm2835_isp_lens_shading {
> +       __u32 enabled;
> +       __u32 grid_cell_size;
> +       __u32 grid_width;
> +       __u32 grid_stride;
> +       __u32 grid_height;
> +       __s32 dmabuf;
> +       __u32 ref_transform;
> +       __u32 corner_sampled;
> +       __u32 gain_format;
> +};
> +
> +/**
> + * struct bcm2835_isp_black_level - Sensor black level configuration.
> + *
> + * @enabled:           Enable black level.
> + * @black_level_r:     Black level for red channel.
> + * @black_level_g:     Black level for green channels.
> + * @black_level_b:     Black level for blue channel.
> + * @padding:           Unused padding.
> + */
> +struct bcm2835_isp_black_level {
> +       __u32 enabled;
> +       __u16 black_level_r;
> +       __u16 black_level_g;
> +       __u16 black_level_b;
> +       __u8 padding[2]; /* Unused */
> +};
> +
> +/**
> + * struct bcm2835_isp_geq - Green equalisation parameters.
> + *
> + * @enabled:   Enable green equalisation.
> + * @offset:    Fixed offset of the green equalisation threshold.
> + * @slope:     Slope of the green equalisation threshold.
> + */
> +struct bcm2835_isp_geq {
> +       __u32 enabled;
> +       __u32 offset;
> +       struct bcm2835_isp_rational slope;
> +};
> +
> +#define BCM2835_NUM_GAMMA_PTS 33
> +
> +/**
> + * struct bcm2835_isp_gamma - Gamma parameters.
> + *
> + * @enabled:   Enable gamma adjustment.
> + * @x:         X values of the points defining the gamma curve.
> + *             Values should be scaled to 16 bits.
> + * @y:         Y values of the points defining the gamma curve.
> + *             Values should be scaled to 16 bits.
> + */
> +struct bcm2835_isp_gamma {
> +       __u32 enabled;
> +       __u16 x[BCM2835_NUM_GAMMA_PTS];
> +       __u16 y[BCM2835_NUM_GAMMA_PTS];
> +};
> +
> +/**
> + * enum bcm2835_isp_cdn_mode - Mode of operation for colour denoise.
> + *
> + * @CDN_MODE_FAST:             Fast (but lower quality) colour denoise
> + *                             algorithm, typically used for video recording.
> + * @CDN_MODE_HIGH_QUALITY:     High quality (but slower) colour denoise
> + *                             algorithm, typically used for stills capture.
> + */
> +enum bcm2835_isp_cdn_mode {
> +       CDN_MODE_FAST = 0,
> +       CDN_MODE_HIGH_QUALITY = 1,
> +};
> +
> +/**
> + * struct bcm2835_isp_cdn - Colour denoise parameters.
> + *
> + * @enabled:   Enable colour denoise.
> + * @mode:      Colour denoise operating mode (see enum &bcm2835_isp_cdn_mode)
> + */
> +struct bcm2835_isp_cdn {
> +       __u32 enabled;
> +       __u32 mode;
> +};
> +
> +/**
> + * struct bcm2835_isp_denoise - Denoise parameters.
> + *
> + * @enabled:   Enable denoise.
> + * @constant:  Fixed offset of the noise threshold.
> + * @slope:     Slope of the noise threshold.
> + * @strength:  Denoise strength between 0.0 (off) and 1.0 (maximum).
> + */
> +struct bcm2835_isp_denoise {
> +       __u32 enabled;
> +       __u32 constant;
> +       struct bcm2835_isp_rational slope;
> +       struct bcm2835_isp_rational strength;
> +};
> +
> +/**
> + * struct bcm2835_isp_sharpen - Sharpen parameters.
> + *
> + * @enabled:   Enable sharpening.
> + * @threshold: Threshold at which to start sharpening pixels.
> + * @strength:  Strength with which pixel sharpening increases.
> + * @limit:     Limit to the amount of sharpening applied.
> + */
> +struct bcm2835_isp_sharpen {
> +       __u32 enabled;
> +       struct bcm2835_isp_rational threshold;
> +       struct bcm2835_isp_rational strength;
> +       struct bcm2835_isp_rational limit;
> +};
> +
> +/**
> + * enum bcm2835_isp_dpc_mode - defective pixel correction (DPC) strength.
> + *
> + * @DPC_MODE_OFF:              No DPC.
> + * @DPC_MODE_NORMAL:           Normal DPC.
> + * @DPC_MODE_STRONG:           Strong DPC.
> + */
> +enum bcm2835_isp_dpc_mode {
> +       DPC_MODE_OFF = 0,
> +       DPC_MODE_NORMAL = 1,
> +       DPC_MODE_STRONG = 2,
> +};
> +
> +/**
> + * struct bcm2835_isp_dpc - Defective pixel correction (DPC) parameters.
> + *
> + * @enabled:   Enable DPC.
> + * @strength:  DPC strength (see enum &bcm2835_isp_dpc_mode).
> + */
> +struct bcm2835_isp_dpc {
> +       __u32 enabled;
> +       __u32 strength;
> +};
> +
> +/**
> + * struct bcm2835_isp_awb_gains - AWB gains configuration.
> + *
> + * @r_gain:    Red channel AWB gain.
> + * @b_gain:    Blue channel AWB gain.
> + */
> +struct bcm2835_isp_awb_gains {
> +       struct bcm2835_isp_rational r_gain;
> +       struct bcm2835_isp_rational b_gain;
> +};
> +
> +/**
> + * struct bcm2835_isp_digital_gain - Digital gain configuration.
> + *
> + * @gain:      Digital gain value.
> + */
> +struct bcm2835_isp_digital_gain {
> +       struct bcm2835_isp_rational gain;
> +};
> +
> +/*
> + * BCM2835 ISP extensible parameters buffer definitions.
> + *
> + * The extensible parameters mechanism allows userspace to submit ISP
> + * configuration parameters as a buffer containing a series of tagged
> + * blocks rather than individual V4L2 controls. This enables atomic
> + * application of multiple parameters in a single operation.
> + */
> +
> +/**
> + * enum bcm2835_isp_param_buffer_version - BCM2835 ISP parameters buffer version
> + *
> + * @BCM2835_ISP_PARAM_BUFFER_V1: First version of parameters buffer format
> + */
> +enum bcm2835_isp_param_buffer_version {
> +       BCM2835_ISP_PARAM_BUFFER_V1 = V4L2_ISP_PARAMS_VERSION_V1,
> +};
> +
> +/**
> + * enum bcm2835_isp_param_block_type - BCM2835 ISP parameter block types
> + *
> + * This enumeration defines the types of parameters blocks that can be
> + * included in the extensible parameters buffer. Each block type corresponds
> + * to a specific ISP processing block configuration.
> + *
> + * @BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL: Black level configuration
> + * @BCM2835_ISP_PARAM_BLOCK_GEQ: Green equalisation configuration
> + * @BCM2835_ISP_PARAM_BLOCK_GAMMA: Gamma curve configuration
> + * @BCM2835_ISP_PARAM_BLOCK_DENOISE: Denoise configuration
> + * @BCM2835_ISP_PARAM_BLOCK_SHARPEN: Sharpening configuration
> + * @BCM2835_ISP_PARAM_BLOCK_DPC: Defective pixel correction configuration
> + * @BCM2835_ISP_PARAM_BLOCK_CDN: Colour denoise configuration
> + * @BCM2835_ISP_PARAM_BLOCK_CC_MATRIX: Colour correction matrix configuration
> + * @BCM2835_ISP_PARAM_BLOCK_LENS_SHADING: Lens shading table configuration
> + * @BCM2835_ISP_PARAM_BLOCK_AWB_GAINS: AWB gains configuration
> + * @BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN: Digital gain configuration
> + */
> +enum bcm2835_isp_param_block_type {
> +       BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL,
> +       BCM2835_ISP_PARAM_BLOCK_GEQ,
> +       BCM2835_ISP_PARAM_BLOCK_GAMMA,
> +       BCM2835_ISP_PARAM_BLOCK_DENOISE,
> +       BCM2835_ISP_PARAM_BLOCK_SHARPEN,
> +       BCM2835_ISP_PARAM_BLOCK_DPC,
> +       BCM2835_ISP_PARAM_BLOCK_CDN,
> +       BCM2835_ISP_PARAM_BLOCK_CC_MATRIX,
> +       BCM2835_ISP_PARAM_BLOCK_LENS_SHADING,
> +       BCM2835_ISP_PARAM_BLOCK_AWB_GAINS,
> +       BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN,
> +};
> +
> +/**
> + * struct bcm2835_isp_params_black_level - Black level parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_BLACK_LEVEL)
> + * @black_level: Black level configuration
> + */
> +struct bcm2835_isp_params_black_level {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_black_level black_level;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_geq - Green equalisation parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_GEQ)
> + * @geq: Green equalisation configuration
> + */
> +struct bcm2835_isp_params_geq {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_geq geq;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_gamma - Gamma parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_GAMMA)
> + * @gamma: Gamma curve configuration
> + */
> +struct bcm2835_isp_params_gamma {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_gamma gamma;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_denoise - Denoise parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_DENOISE)
> + * @denoise: Denoise configuration
> + */
> +struct bcm2835_isp_params_denoise {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_denoise denoise;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_sharpen - Sharpen parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_SHARPEN)
> + * @sharpen: Sharpening configuration
> + */
> +struct bcm2835_isp_params_sharpen {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_sharpen sharpen;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_dpc - Defective pixel correction parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_DPC)
> + * @dpc: DPC configuration
> + */
> +struct bcm2835_isp_params_dpc {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_dpc dpc;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_cdn - Colour denoise parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_CDN)
> + * @cdn: Colour denoise configuration
> + */
> +struct bcm2835_isp_params_cdn {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_cdn cdn;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_cc_matrix - Colour correction matrix parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_CC_MATRIX)
> + * @ccm: Colour correction matrix configuration
> + */
> +struct bcm2835_isp_params_cc_matrix {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_custom_ccm ccm;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_lens_shading - Lens shading parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_LENS_SHADING)
> + * @ls: Lens shading configuration (includes dmabuf fd for table data)
> + */
> +struct bcm2835_isp_params_lens_shading {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_lens_shading ls;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_awb_gains - AWB gains parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_AWB_GAINS)
> + * @awb_gains: AWB gains configuration
> + */
> +struct bcm2835_isp_params_awb_gains {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_awb_gains awb_gains;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * struct bcm2835_isp_params_digital_gain - Digital gain parameters block
> + *
> + * @header: Block header (type = BCM2835_ISP_PARAM_BLOCK_DIGITAL_GAIN)
> + * @digital_gain: Digital gain configuration
> + */
> +struct bcm2835_isp_params_digital_gain {
> +       struct v4l2_isp_params_block_header header;
> +       struct bcm2835_isp_digital_gain digital_gain;
> +} __attribute__((aligned(8)));
> +
> +/**
> + * define BCM2835_ISP_PARAMS_MAX_SIZE - Maximum size of all ISP parameters
> + *
> + * This defines the maximum size needed to accommodate all possible parameter
> + * blocks in a single buffer. Drivers use this to allocate appropriately
> + * sized buffers.
> + */
> +#define BCM2835_ISP_PARAMS_MAX_SIZE                                    \
> +       (sizeof(struct bcm2835_isp_params_black_level) +                \
> +        sizeof(struct bcm2835_isp_params_geq) +                        \
> +        sizeof(struct bcm2835_isp_params_gamma) +                      \
> +        sizeof(struct bcm2835_isp_params_denoise) +                    \
> +        sizeof(struct bcm2835_isp_params_sharpen) +                    \
> +        sizeof(struct bcm2835_isp_params_dpc) +                        \
> +        sizeof(struct bcm2835_isp_params_cdn) +                        \
> +        sizeof(struct bcm2835_isp_params_cc_matrix) +                  \
> +        sizeof(struct bcm2835_isp_params_lens_shading) +               \
> +        sizeof(struct bcm2835_isp_params_awb_gains) +                  \
> +        sizeof(struct bcm2835_isp_params_digital_gain))
> +
> +/*
> + * ISP statistics structures.
> + *
> + * The bcm2835_isp_stats structure is generated at the output of the
> + * statistics node.  Note that this does not directly map onto the statistics
> + * output of the ISP HW.  Instead, the MMAL firmware code maps the HW statistics
> + * to the bcm2835_isp_stats structure.
> + */
> +#define DEFAULT_AWB_REGIONS_X 16
> +#define DEFAULT_AWB_REGIONS_Y 12
> +
> +#define NUM_HISTOGRAMS 2
> +#define NUM_HISTOGRAM_BINS 128
> +#define AWB_REGIONS (DEFAULT_AWB_REGIONS_X * DEFAULT_AWB_REGIONS_Y)
> +#define FLOATING_REGIONS 16
> +#define AGC_REGIONS 16
> +#define FOCUS_REGIONS 12
> +
> +/**
> + * struct bcm2835_isp_stats_hist - Histogram statistics
> + *
> + * @r_hist:    Red channel histogram.
> + * @g_hist:    Combined green channel histogram.
> + * @b_hist:    Blue channel histogram.
> + */
> +struct bcm2835_isp_stats_hist {
> +       __u32 r_hist[NUM_HISTOGRAM_BINS];
> +       __u32 g_hist[NUM_HISTOGRAM_BINS];
> +       __u32 b_hist[NUM_HISTOGRAM_BINS];
> +};
> +
> +/**
> + * struct bcm2835_isp_stats_region - Region sums.
> + *
> + * @counted:   The number of 2x2 bayer tiles accumulated.
> + * @notcounted:        The number of 2x2 bayer tiles not accumulated.
> + * @r_sum:     Total sum of counted pixels in the red channel for a region.
> + * @g_sum:     Total sum of counted pixels in the green channel for a region.
> + * @b_sum:     Total sum of counted pixels in the blue channel for a region.
> + */
> +struct bcm2835_isp_stats_region {
> +       __u32 counted;
> +       __u32 notcounted;
> +       __u64 r_sum;
> +       __u64 g_sum;
> +       __u64 b_sum;
> +};
> +
> +/**
> + * struct bcm2835_isp_stats_focus - Focus statistics.
> + *
> + * @contrast_val:      Focus measure - accumulated output of the focus filter.
> + *                     In the first dimension, index [0] counts pixels below a
> + *                     preset threshold, and index [1] counts pixels above the
> + *                     threshold.  In the second dimension, index [0] uses the
> + *                     first predefined filter, and index [1] uses the second
> + *                     predefined filter.
> + * @contrast_val_num:  The number of counted pixels in the above accumulation.
> + */
> +struct bcm2835_isp_stats_focus {
> +       __u64 contrast_val[2][2];
> +       __u32 contrast_val_num[2][2];
> +};
> +
> +/**
> + * struct bcm2835_isp_stats - ISP statistics.
> + *
> + * @version:           Version of the bcm2835_isp_stats structure.
> + * @size:              Size of the bcm2835_isp_stats structure.
> + * @hist:              Histogram statistics for the entire image.
> + * @awb_stats:         Statistics for the regions defined for AWB calculations.
> + * @floating_stats:    Statistics for arbitrarily placed (floating) regions.
> + * @agc_stats:         Statistics for the regions defined for AGC calculations.
> + * @focus_stats:       Focus filter statistics for the focus regions.
> + */
> +struct bcm2835_isp_stats {
> +       __u32 version;
> +       __u32 size;
> +       struct bcm2835_isp_stats_hist hist[NUM_HISTOGRAMS];
> +       struct bcm2835_isp_stats_region awb_stats[AWB_REGIONS];
> +       struct bcm2835_isp_stats_region floating_stats[FLOATING_REGIONS];
> +       struct bcm2835_isp_stats_region agc_stats[AGC_REGIONS];
> +       struct bcm2835_isp_stats_focus focus_stats[FOCUS_REGIONS];
> +};
> +
> +#endif /* __BCM2835_ISP_H_ */
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 5373dba640fa..f98977138d9c 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -870,6 +870,8 @@ struct v4l2_pix_format {
>  #define V4L2_META_FMT_D4XX        v4l2_fourcc('D', '4', 'X', 'X') /* D4XX Payload Header metadata */
>  #define V4L2_META_FMT_UVC_MSXU_1_5  v4l2_fourcc('U', 'V', 'C', 'M') /* UVC MSXU metadata */
>  #define V4L2_META_FMT_VIVID      v4l2_fourcc('V', 'I', 'V', 'D') /* Vivid Metadata */
> +#define V4L2_META_FMT_BCM2835_ISP_STATS v4l2_fourcc('B', 'S', 'T', 'A') /* BCM2835 ISP stats */
> +#define V4L2_META_FMT_BCM2835_ISP_PARAMS v4l2_fourcc('B', 'C', 'M', 'P') /* BCM2835 ISP params */
>  
>  /* Vendor specific - used for RK_ISP1 camera sub-system */
>  #define V4L2_META_FMT_RK_ISP1_PARAMS   v4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 3A Parameters */
> 
> -- 
> 2.55.0
>

[PATCH v5 10/10] platform/raspberrypi: vchiq: Load bcm2835_isp driver from vchiq

[Jai Luthra]

From: Naushir Patuck <naush@raspberrypi.com>

Broadcom BCM2835 ISP driver is managed through the VCHIQ interface, so
register it to the VCHIQ driver, similar to the audio and shared memory
drivers.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c | 2 ++
 include/linux/raspberrypi/vchiq_arm.h                    | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
index ec951ab19d67..f35b40bdd963 100644
--- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
+++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
@@ -1415,6 +1415,7 @@ static int vchiq_probe(struct platform_device *pdev)
 
 	mgmt->audio_dev = vchiq_device_register(&pdev->dev, "bcm2835-audio");
 	mgmt->vcsm_cma_dev = vchiq_device_register(&pdev->dev, "vcsm-cma");
+	mgmt->isp_dev = vchiq_device_register(&pdev->dev, "bcm2835-isp");
 
 	return 0;
 }
@@ -1423,6 +1424,7 @@ static void vchiq_remove(struct platform_device *pdev)
 {
 	struct vchiq_drv_mgmt *mgmt = dev_get_drvdata(&pdev->dev);
 
+	vchiq_device_unregister(mgmt->isp_dev);
 	vchiq_device_unregister(mgmt->vcsm_cma_dev);
 	vchiq_device_unregister(mgmt->audio_dev);
 	vchiq_debugfs_deinit();
diff --git a/include/linux/raspberrypi/vchiq_arm.h b/include/linux/raspberrypi/vchiq_arm.h
index d59837eaaa8c..ea1bd419e471 100644
--- a/include/linux/raspberrypi/vchiq_arm.h
+++ b/include/linux/raspberrypi/vchiq_arm.h
@@ -63,6 +63,7 @@ struct vchiq_drv_mgmt {
 	 */
 	struct vchiq_device *audio_dev;
 	struct vchiq_device *vcsm_cma_dev;
+	struct vchiq_device *isp_dev;
 };
 
 struct user_service {

-- 
2.55.0

Re: [PATCH v5 00/10] media: Add support for Broadcom/RPi BCM2835 ISP

[Dave Stevenson]

Hi Jai and All.

On Thu, 17 Sept 2026 at 09:25, Jai Luthra <jai.luthra@ideasonboard.com> wrote:
>
> Hi,
>
> This series adds initial support for Broadcom/Raspberry Pi BCM2835 ISP
> present on older Raspberry Pi boards.
>
> The underlying hardware for the ISP is accessed through the VideoCore
> VPU, via the VCHIQ/MMAL interface that was recently destaged under
> platform/raspberrypi. The ISP driver, and thus this series, depends on
> VCSM CMA driver for shared memory support (for lens shading buffers):
>
> https://lore.kernel.org/all/20260916-b4-vc-sm-cma-v4-0-476d1142b5df@ideasonboard.com
>
> The baseline driver was taken from the one present in the downstream
> raspberrypi 6.12 tree (which was posted as v1 with minor cleanups).
>
> Since then the driver has been significantly modified, switching away
> from custom V4L2 controls to parameter buffers for ISP configuration,
> and many other fixes.
>
> This series along with dependencies is available for ease of testing in
> this linux branch:
> https://github.com/jailuthra/linux/tree/b4/rpi-isp
>
> You can test this series with libcamera, using the following libcamera
> branch:
> https://github.com/jailuthra/libcamera/tree/pi4-upstream
>
> This series (v4 onwards) depends on the latest raspberry pi firmware
> that is in process of being published. I'll reply with a link to this
> cover letter when it's available.

Apologies, I hadn't nudged the relevant person for it to be released.
It is now in https://github.com/raspberrypi/rpi-firmware

  Dave

> Thanks,
> Jai
>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> ---
> Changes in v5:
> - Add missing note in cover letter about dependency on latest firmware
> - Update documentation of return type of vb2_core_expbuf_dmabuf() to only
>   ERR_PTR and not NULL
> - Fix warnings reported by media-ci (coccinelle, smatch etc.)
>   - Use struct_group() around the fields we want to memcpy from UAPI param
>     struct to the anonymous structs inside mmal_parameter_isp_parameters
>   - Don't use complicated pointer arithmetic and instead write
>     mmal_param->_mmal_substruct.update = 1 explicitly
>   - Only check for IS_ERR and not IS_ERR_OR_NULL for output of
>     vb2_core_expbuf_dmabuf()
>   - Check node->id against array bounds
> - Link to v4: https://lore.kernel.org/r/20260916-b4-vchiq-isp-v4-0-f668c2017b74@ideasonboard.com
>
> Changes in v4:
> - Rebase on v7.3-rc1
> - Set ISP_NUM_INSTANCES to 1 until we have proper support for
>   multiplexing ISP instances (Laurent)
> - Add a new struct mmal_parameter_isp_parameters {} in mmal-parameters.h
>   to send combined updates the firmware (Dave)
> - Rework bcm2835-isp-params.c to use the above and save expensive
>   messages over IPC boundary (Dave)
> - Test if the firmware supports the single struct, and fail with an
>   error message asking the user to update their firmware if not (Dave)
> - Check for retval of isp_set_param() and print error messages if it
>   fails
> - Various cleanups and suggestions (Paul)
> - Add "media: videobuf2-core: Move type check out of vb2_core_expbuf()"
>   on Laurent's suggestion
> - Drop comment about FourCC values being copied from V4L2
> - Drop old paragraph in Kconfig that got copied from previous revision
> - Link to v3: https://lore.kernel.org/r/20260717-b4-vchiq-isp-v3-0-fb8235e15c68@ideasonboard.com
>
> Changes in v3:
> - Rebase on v7.2-rc1
> - Split PATCH 1 to add missing incles before moving the headers
> - Update commit messages with Laurent's suggestions
> - Drop redundant buffer list and locks for params as we send them
>   immediately to the firmware in .buf_queue
> - Drop the now empty .stop_streaming() for params node
> - Minor cleanups
> - Link to v2: https://lore.kernel.org/r/20260210-b4-vchiq-isp-v2-0-4403944152fe@ideasonboard.com
>
> Changes in v2:
> - Replace custom V4L2 controls (V4L2_CID_USER_BCM2835_ISP_*) with the
>   V4L2 extensible parameters framework via a dedicated metadata output
>   node (bcm2835-isp-params). Split params handling into new file
>   bcm2835-isp-params.c.
> - Add AWB gains and digital gain as extensible parameter block types
>   instead of standard V4L2 integer controls.
> - Use MEDIA_ENT_F_PROC_VIDEO_ISP instead of MEDIA_ENT_F_PROC_VIDEO_SCALER
>   for the media entity function.
> - Rework media controller registration: let video device nodes handle
>   their own entity registration, removing the manual entity/interface
>   creation in media_controller_register_node().
> - Propagate colorspace, ycbcr_enc, xfer_func, and quantization properly
>   through g_fmt/s_fmt.
> - Fold the stats/params FourCC additions (previously a separate commit)
>   into this patch.
> - Drop the custom CID base commit (no longer needed).
> - Update documentation.
> - Link to v1: https://lore.kernel.org/r/20260113-b4-vchiq-isp-v1-0-ea0b300bffc8@ideasonboard.com
>
> ---
> Dave Stevenson (1):
>       media: videobuf2: Allow exporting of a struct dmabuf
>
> Jai Luthra (7):
>       media: videobuf2-core: Move type check out of vb2_core_expbuf()
>       platform/raspberrypi: vchiq-mmal: Include missing headers
>       platform/raspberrypi: vchiq-mmal: Move headers to include/linux
>       platform/raspberrypi: vchiq-mmal: Support ISP parameters and stats
>       platform/raspberrypi: vchiq-mmal: Support bayer and gray formats
>       platform/raspberrypi: vchiq: Add helpers for vchiq driver data
>       media: platform: broadcom: Move unicam driver to subdir
>
> Naushir Patuck (2):
>       media: platform: broadcom: Add bcm2835-isp driver
>       platform/raspberrypi: vchiq: Load bcm2835_isp driver from vchiq
>
>  Documentation/admin-guide/media/bcm2835-isp.dot    |   14 +
>  Documentation/admin-guide/media/bcm2835-isp.rst    |   78 +
>  Documentation/admin-guide/media/v4l-drivers.rst    |    1 +
>  .../userspace-api/media/v4l/meta-formats.rst       |    1 +
>  .../media/v4l/metafmt-bcm2835-isp.rst              |  101 ++
>  MAINTAINERS                                        |   12 +-
>  drivers/media/common/videobuf2/videobuf2-core.c    |   50 +-
>  drivers/media/common/videobuf2/videobuf2-v4l2.c    |    8 +-
>  drivers/media/dvb-core/dvb_vb2.c                   |    3 +-
>  drivers/media/platform/broadcom/Kconfig            |   18 +-
>  drivers/media/platform/broadcom/Makefile           |    3 +-
>  .../media/platform/broadcom/bcm2835-isp/Kconfig    |   15 +
>  .../media/platform/broadcom/bcm2835-isp/Makefile   |    4 +
>  .../broadcom/bcm2835-isp/bcm2835-isp-common.h      |   50 +
>  .../broadcom/bcm2835-isp/bcm2835-isp-fmts.h        |  558 +++++++
>  .../broadcom/bcm2835-isp/bcm2835-isp-params.c      |  510 +++++++
>  .../broadcom/bcm2835-isp/bcm2835-v4l2-isp.c        | 1516 ++++++++++++++++++++
>  .../media/platform/broadcom/bcm2835-unicam/Kconfig |   18 +
>  .../platform/broadcom/bcm2835-unicam/Makefile      |    3 +
>  .../{ => bcm2835-unicam}/bcm2835-unicam-regs.h     |    0
>  .../broadcom/{ => bcm2835-unicam}/bcm2835-unicam.c |    0
>  drivers/media/v4l2-core/v4l2-ioctl.c               |    2 +
>  .../raspberrypi/vchiq-interface/vchiq_arm.c        |    2 +
>  .../platform/raspberrypi/vchiq-mmal/mmal-vchiq.c   |    9 +-
>  .../linux/raspberrypi}/mmal-common.h               |    4 +
>  .../linux/raspberrypi}/mmal-encodings.h            |   67 +
>  .../linux/raspberrypi}/mmal-msg-common.h           |    0
>  .../linux/raspberrypi}/mmal-msg-format.h           |    0
>  .../linux/raspberrypi}/mmal-msg-port.h             |    0
>  .../linux/raspberrypi}/mmal-msg.h                  |    0
>  .../linux/raspberrypi}/mmal-parameters.h           |  217 +++
>  .../linux/raspberrypi}/mmal-vchiq.h                |    0
>  include/linux/raspberrypi/vchiq_arm.h              |    1 +
>  include/linux/raspberrypi/vchiq_bus.h              |   10 +
>  include/media/videobuf2-core.h                     |   21 +-
>  include/uapi/linux/bcm2835-isp.h                   |  530 +++++++
>  include/uapi/linux/videodev2.h                     |    2 +
>  37 files changed, 3778 insertions(+), 50 deletions(-)
> ---
> base-commit: e5e04726cdd043e309677071ab1b65a4b18f422b
> change-id: 20250923-b4-vchiq-isp-7e8c22c2860c
> prerequisite-change-id: 20251030-b4-vc-sm-cma-f6727c39cd25:v4
> prerequisite-patch-id: 4fc8cb49edcbe9c8e699b4ab9f6863ac040a070b
> prerequisite-patch-id: 0a5fdf8fe23298fac2c6d188e1686dd292901efc
> prerequisite-patch-id: d6d9ee5b60f97112dcf1aea01212c724d9151505
> prerequisite-patch-id: 3855700b608f20e2a6857a9702838d1e54fc31cb
> prerequisite-patch-id: e2b1e84a1e94e7095b964da693129d36dda78bb0
> prerequisite-patch-id: 07e50207cc947f44e1d626b31d0ace7e12a8f3a1
> prerequisite-patch-id: 3d82a2605799686668729fdc2677c3f6b7c2aa0d
> prerequisite-patch-id: 7795536d875736f74fb4b2e77ca106b127bedbc0
> prerequisite-patch-id: ad833b78f90ce3081e470caf70e601fc573bb52d
> prerequisite-patch-id: 1898d91213e9bd75be3109180527fb0caf6d7174
> prerequisite-patch-id: d0cfc49c673c8c4a4c13d44a547104c24f57cb49
>
> Best regards,
> --
> Jai Luthra <jai.luthra@ideasonboard.com>
>