mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Scally <dan.scally@ideasonboard.com>
To: "D. Manresa" <dmanresa@gmail.com>,
	antoine.pichot@gmail.com, linux-media@vger.kernel.org
Cc: sakari.ailus@linux.intel.com, mchehab@kernel.org,
	djrscally@gmail.com, hansg@kernel.org,
	andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/7] media: i2c: ov7251: Fix link frequency index
Date: Tue, 27 Oct 2026 16:34:33 +0000	[thread overview]
Message-ID: <09579c0c-dd04-4d03-b815-c2cba53ddca1@ideasonboard.com> (raw)
In-Reply-To: <6ae07c65.e52dcaf0.293af3.e7d5@mx.google.com>

Hello

On 27/10/2026 10:26, D. Manresa wrote:

<snip>

> So either ipu-bridge's advertised link frequency is wrong for this SKU,
> or mainline's 319.2 MHz PLL entry needs more than the index fix to be
> usable. I have the machine for a few more days and can run whatever would
> help decide which.

It would be worth validating the settings for the 319.2MHz link frequency to make sure that the PLL 
is being configured correctly. The link frequency itself advertised by the ipu-bridge strictly just 
needs to be one that the sensor driver is capable of configuring, but ideally we would make sure 
that the sensor can configure one that these platforms tend to use, as the platform designers will 
generally choose it carefully to be appropriate for their device. When I made these changes I 
checked and the driver for my Surface Go 2 was setting 319.2 MHz, so I would be more suspicious of 
the driver's PLL settings than that value.

Dan

> 
> The rest of the series tests well here; I have replied to the cover letter
> with that.
> 
> D. Manresa
> 
> (Written with AI assistance, directed and reviewed by me.)


  parent reply	other threads:[~2026-10-27 16:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 11:10 [PATCH 0/7] media: i2c: ov7251: fixes and infrared strobe for Surface Book 2 Antoine Pichot
2026-10-26 11:10 ` [PATCH 1/7] media: i2c: ov7251: Fix link frequency index Antoine Pichot
2026-10-27 10:26   ` D. Manresa
2026-10-27 13:26     ` Antoine Pichot
2026-10-27 18:11       ` D. Manresa
2026-10-27 16:34     ` Dan Scally [this message]
2026-10-27 16:50     ` Dave Stevenson
2026-10-27 18:15       ` D. Manresa
2026-10-27 16:05   ` Dan Scally
2026-10-26 11:10 ` [PATCH 2/7] media: i2c: ov7251: Reset vblank when the frame interval changes Antoine Pichot
2026-10-26 11:10 ` [PATCH 3/7] media: i2c: ov7251: Add control event support Antoine Pichot
2026-10-26 11:34   ` Sakari Ailus
2026-10-26 13:03     ` Antoine Pichot
2026-10-26 11:10 ` [PATCH 4/7] media: i2c: ov7251: Add orientation and rotation controls Antoine Pichot
2026-10-26 11:10 ` [PATCH 5/7] media: i2c: ov7251: Move the strobe registers out of the mode tables Antoine Pichot
2026-10-26 11:10 ` [PATCH 6/7] media: i2c: ov7251: Add strobe output enable control Antoine Pichot
2026-10-26 15:14   ` Andy Shevchenko
2026-10-27  2:44     ` Antoine Pichot
2026-10-26 11:10 ` [PATCH 7/7] media: ipu-bridge: Add a 90 degree rotation quirk for Surface Book 2 Antoine Pichot
2026-10-27 10:26 ` [PATCH 0/7] media: i2c: ov7251: fixes and infrared strobe " D. Manresa
2026-10-27 13:26   ` Antoine Pichot
2026-10-27 18:45     ` D. Manresa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09579c0c-dd04-4d03-b815-c2cba53ddca1@ideasonboard.com \
    --to=dan.scally@ideasonboard.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=antoine.pichot@gmail.com \
    --cc=djrscally@gmail.com \
    --cc=dmanresa@gmail.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®